@dizzlkheinz/ynab-mcpb 0.12.2 → 0.15.0

package/src/tools/reconciliation/__tests__/analyzer.test.ts

@@ -1,12 +1,11 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest';
 import { analyzeReconciliation } from '../analyzer.js';
 import type { Transaction as YNABAPITransaction } from 'ynab';
-import * as parser from '../../compareTransactions/parser.js';
+import * as csvParser from '../csvParser.js';
 
 // Mock the parser module
-vi.mock('../../compareTransactions/parser.js', () => ({
-  parseBankCSV: vi.fn(),
-  readCSVFile: vi.fn(),
+vi.mock('../csvParser.js', () => ({
+  parseCSV: vi.fn(),
 }));
 
 describe('analyzer', () => {
@@ -17,26 +16,36 @@ describe('analyzer', () => {
   describe('analyzeReconciliation', () => {
     it('should perform full analysis and return structured results', () => {
       // Mock CSV parsing
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
+      vi.mocked(csvParser.parseCSV).mockReturnValue({
         transactions: [
           {
+            id: 'b1',
             date: '2025-10-15',
-            amount: -45.23,
+            amount: -45230, // milliunits
             payee: 'Shell Gas',
             memo: '',
+            sourceRow: 1,
+            raw: { date: '10/15/2025', amount: '-45.23', description: 'Shell Gas' },
           },
           {
+            id: 'b2',
             date: '2025-10-16',
-            amount: -100.0,
+            amount: -100000, // milliunits
             payee: 'Netflix',
             memo: '',
+            sourceRow: 2,
+            raw: { date: '10/16/2025', amount: '-100.00', description: 'Netflix' },
           },
         ],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 2,
-        valid_rows: 2,
+        meta: {
+          detectedDelimiter: ',',
+          detectedColumns: ['Date', 'Amount', 'Description'],
+          totalRows: 2,
+          validRows: 2,
+          skippedRows: 0,
+        },
         errors: [],
+        warnings: [],
       });
 
       const ynabTxns: YNABAPITransaction[] = [
@@ -76,23 +85,33 @@ describe('analyzer', () => {
       expect(result.unmatched_ynab).toBeDefined();
       expect(result.balance_info).toBeDefined();
       expect(result.next_steps).toBeDefined();
+
+      // Verify auto-matches (exact matches)
+      expect(result.auto_matches.length).toBe(2);
     });
 
     it('should categorize high-confidence matches as auto-matches', () => {
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
+      vi.mocked(csvParser.parseCSV).mockReturnValue({
         transactions: [
           {
+            id: 'b1',
             date: '2025-10-15',
-            amount: -50.0,
+            amount: -50000,
             payee: 'Coffee Shop',
             memo: '',
+            sourceRow: 1,
+            raw: {} as any,
           },
         ],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 1,
-        valid_rows: 1,
+        meta: {
+          detectedDelimiter: ',',
+          detectedColumns: [],
+          totalRows: 1,
+          validRows: 1,
+          skippedRows: 0,
+        },
         errors: [],
+        warnings: [],
       });
 
       const ynabTxns: YNABAPITransaction[] = [
@@ -114,28 +133,35 @@ describe('analyzer', () => {
     });
 
     it('should categorize medium-confidence matches as suggested', () => {
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
+      vi.mocked(csvParser.parseCSV).mockReturnValue({
         transactions: [
           {
+            id: 'b1',
             date: '2025-10-15',
-            amount: -50.0,
-            payee: 'Amazon',
+            amount: -50000,
+            payee: 'Generic Store',
             memo: '',
+            sourceRow: 1,
+            raw: {} as any,
           },
         ],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 1,
-        valid_rows: 1,
+        meta: {
+          detectedDelimiter: ',',
+          detectedColumns: [],
+          totalRows: 1,
+          validRows: 1,
+          skippedRows: 0,
+        },
         errors: [],
+        warnings: [],
       });
 
       const ynabTxns: YNABAPITransaction[] = [
         {
           id: 'y1',
-          date: '2025-10-18', // 3 days difference
+          date: '2025-10-18', // 3 days difference - date score drops
           amount: -50000,
-          payee_name: 'Amazon Prime',
+          payee_name: 'Amazon Prime', // Fuzzy match
           category_name: 'Shopping',
           cleared: 'uncleared' as const,
           approved: true,
@@ -144,25 +170,33 @@ describe('analyzer', () => {
 
       const result = analyzeReconciliation('csv', undefined, ynabTxns, -50.0);
 
-      // Might be medium or low depending on exact scoring
-      expect(result.suggested_matches.length + result.unmatched_bank.length).toBeGreaterThan(0);
+      // Should be suggested (medium)
+      expect(result.suggested_matches.length).toBeGreaterThan(0);
+      expect(result.suggested_matches[0].confidence).toBe('medium');
     });
 
     it('should identify unmatched bank transactions', () => {
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
+      vi.mocked(csvParser.parseCSV).mockReturnValue({
         transactions: [
           {
+            id: 'b1',
             date: '2025-10-15',
-            amount: -15.99,
+            amount: -15990,
             payee: 'New Store',
             memo: '',
+            sourceRow: 1,
+            raw: {} as any,
           },
         ],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 1,
-        valid_rows: 1,
+        meta: {
+          detectedDelimiter: ',',
+          detectedColumns: [],
+          totalRows: 1,
+          validRows: 1,
+          skippedRows: 0,
+        },
         errors: [],
+        warnings: [],
       });
 
       const ynabTxns: YNABAPITransaction[] = [];
@@ -174,13 +208,17 @@ describe('analyzer', () => {
     });
 
     it('should identify unmatched YNAB transactions', () => {
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
+      vi.mocked(csvParser.parseCSV).mockReturnValue({
         transactions: [],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 0,
-        valid_rows: 0,
+        meta: {
+          detectedDelimiter: ',',
+          detectedColumns: [],
+          totalRows: 0,
+          validRows: 0,
+          skippedRows: 0,
+        },
         errors: [],
+        warnings: [],
       });
 
       const ynabTxns: YNABAPITransaction[] = [
@@ -198,77 +236,21 @@ describe('analyzer', () => {
       const result = analyzeReconciliation('csv', undefined, ynabTxns, 0);
 
       expect(result.unmatched_ynab.length).toBe(1);
-      expect(result.unmatched_ynab[0].payee_name).toBe('Restaurant');
-    });
-
-    it('should surface combination suggestions and insights when totals align', () => {
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
-        transactions: [
-          {
-            date: '2025-10-20',
-            amount: -30.0,
-            payee: 'Evening Out',
-            memo: '',
-          },
-        ],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 1,
-        valid_rows: 1,
-        errors: [],
-      });
-
-      const ynabTxns: YNABAPITransaction[] = [
-        {
-          id: 'y-combo-1',
-          date: '2025-10-19',
-          amount: -20000,
-          payee_name: 'Dinner',
-          category_name: 'Dining',
-          cleared: 'uncleared' as const,
-          approved: true,
-        } as YNABAPITransaction,
-        {
-          id: 'y-combo-2',
-          date: '2025-10-20',
-          amount: -10000,
-          payee_name: 'Drinks',
-          category_name: 'Dining',
-          cleared: 'uncleared' as const,
-          approved: true,
-        } as YNABAPITransaction,
-        {
-          id: 'y-extra',
-          date: '2025-10-22',
-          amount: -5000,
-          payee_name: 'Snacks',
-          category_name: 'Dining',
-          cleared: 'uncleared' as const,
-          approved: true,
-        } as YNABAPITransaction,
-      ];
-
-      const result = analyzeReconciliation('csv', undefined, ynabTxns, -30.0);
-
-      const comboMatch = result.suggested_matches.find(
-        (match) => match.match_reason === 'combination_match',
-      );
-      expect(comboMatch).toBeDefined();
-      expect(comboMatch?.candidates?.length).toBeGreaterThanOrEqual(2);
-
-      const comboInsight = result.insights.find((insight) => insight.id.startsWith('combination-'));
-      expect(comboInsight).toBeDefined();
-      expect(comboInsight?.severity).toBe('info');
+      expect(result.unmatched_ynab[0].payee).toBe('Restaurant');
     });
 
     it('should calculate balance information correctly', () => {
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
+      vi.mocked(csvParser.parseCSV).mockReturnValue({
         transactions: [],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 0,
-        valid_rows: 0,
+        meta: {
+          detectedDelimiter: ',',
+          detectedColumns: [],
+          totalRows: 0,
+          validRows: 0,
+          skippedRows: 0,
+        },
         errors: [],
+        warnings: [],
       });
 
       const ynabTxns: YNABAPITransaction[] = [
@@ -303,16 +285,36 @@ describe('analyzer', () => {
     });
 
     it('should generate appropriate summary', () => {
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
+      vi.mocked(csvParser.parseCSV).mockReturnValue({
         transactions: [
-          { date: '2025-10-15', amount: -50.0, payee: 'Store', memo: '' },
-          { date: '2025-10-20', amount: -30.0, payee: 'Restaurant', memo: '' },
+          {
+            id: 'b1',
+            date: '2025-10-15',
+            amount: -50000,
+            payee: 'Store',
+            memo: '',
+            sourceRow: 1,
+            raw: {} as any,
+          },
+          {
+            id: 'b2',
+            date: '2025-10-20',
+            amount: -30000,
+            payee: 'Restaurant',
+            memo: '',
+            sourceRow: 2,
+            raw: {} as any,
+          },
         ],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 2,
-        valid_rows: 2,
+        meta: {
+          detectedDelimiter: ',',
+          detectedColumns: [],
+          totalRows: 2,
+          validRows: 2,
+          skippedRows: 0,
+        },
         errors: [],
+        warnings: [],
       });
 
       const ynabTxns: YNABAPITransaction[] = [
@@ -334,73 +336,5 @@ describe('analyzer', () => {
       expect(result.summary.statement_date_range).toContain('2025-10-15');
       expect(result.summary.statement_date_range).toContain('2025-10-20');
     });
-
-    it('should generate next steps based on analysis', () => {
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
-        transactions: [{ date: '2025-10-15', amount: -50.0, payee: 'Store', memo: '' }],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 1,
-        valid_rows: 1,
-        errors: [],
-      });
-
-      const ynabTxns: YNABAPITransaction[] = [
-        {
-          id: 'y1',
-          date: '2025-10-15',
-          amount: -50000,
-          payee_name: 'Store',
-          category_name: 'Shopping',
-          cleared: 'uncleared' as const,
-          approved: true,
-        } as YNABAPITransaction,
-      ];
-
-      const result = analyzeReconciliation('csv', undefined, ynabTxns, -50.0);
-
-      expect(result.next_steps).toBeDefined();
-      expect(Array.isArray(result.next_steps)).toBe(true);
-      expect(result.next_steps.length).toBeGreaterThan(0);
-    });
-
-    it('should use file path when provided', () => {
-      vi.mocked(parser.readCSVFile).mockReturnValue({
-        transactions: [{ date: '2025-10-15', amount: -50.0, payee: 'Store', memo: '' }],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 1,
-        valid_rows: 1,
-        errors: [],
-      });
-
-      const ynabTxns: YNABAPITransaction[] = [];
-
-      const result = analyzeReconciliation('', '/path/to/file.csv', ynabTxns, 0);
-
-      expect(vi.mocked(parser.readCSVFile)).toHaveBeenCalledWith('/path/to/file.csv');
-      expect(result.success).toBe(true);
-    });
-
-    it('should assign unique IDs to bank transactions', () => {
-      vi.mocked(parser.parseBankCSV).mockReturnValue({
-        transactions: [
-          { date: '2025-10-15', amount: -50.0, payee: 'Store1', memo: '' },
-          { date: '2025-10-16', amount: -30.0, payee: 'Store2', memo: '' },
-        ],
-        format_detected: 'standard',
-        delimiter: ',',
-        total_rows: 2,
-        valid_rows: 2,
-        errors: [],
-      });
-
-      const result = analyzeReconciliation('csv', undefined, [], 0);
-
-      expect(result.unmatched_bank.length).toBe(2);
-      expect(result.unmatched_bank[0].id).toBeDefined();
-      expect(result.unmatched_bank[1].id).toBeDefined();
-      expect(result.unmatched_bank[0].id).not.toBe(result.unmatched_bank[1].id);
-    });
   });
 });

package/src/tools/reconciliation/__tests__/csvParser.test.ts

@@ -0,0 +1,87 @@
+import { describe, it, expect } from 'vitest';
+import { parseCSV, ParseCSVOptions } from '../csvParser.js';
+
+describe('csvParser', () => {
+  describe('Security and Limits', () => {
+    it('should throw error if file size exceeds maxBytes', () => {
+      const largeContent = 'a'.repeat(1024 * 1024 + 1); // 1MB + 1 byte
+      const options: ParseCSVOptions = { maxBytes: 1024 * 1024 }; // 1MB limit
+
+      expect(() => parseCSV(largeContent, options)).toThrow(/File size exceeds limit/);
+    });
+
+    it('should respect maxRows limit', () => {
+      const rows = Array.from(
+        { length: 20 },
+        (_, i) => `2024-01-${String(i + 1).padStart(2, '0')},Desc ${i},10.00`,
+      ).join('\n');
+      const content = `Date,Description,Amount\n${rows}`;
+      const options: ParseCSVOptions = { maxRows: 10 };
+
+      const result = parseCSV(content, options);
+      expect(result.transactions).toHaveLength(10);
+      expect(result.meta.validRows).toBe(10);
+    });
+
+    it('should sanitize control characters from description', () => {
+      // ASCII 0x07 (Bell) and 0x1B (Escape) are control characters
+      const badDesc = 'Bad\x07Description\x1B';
+      const content = `Date,Description,Amount\n2024-01-01,${badDesc},10.00`;
+
+      const result = parseCSV(content);
+      expect(result.transactions[0].payee).toBe('BadDescription');
+    });
+
+    it('should limit description length to 500 characters', () => {
+      const longDesc = 'a'.repeat(600);
+      const content = `Date,Description,Amount\n2024-01-01,${longDesc},10.00`;
+
+      const result = parseCSV(content);
+      expect(result.transactions[0].payee).toHaveLength(500);
+      expect(result.transactions[0].payee).toBe('a'.repeat(500));
+    });
+  });
+
+  describe('Timezone Handling', () => {
+    it('should parse ISO dates correctly without timezone shift', () => {
+      // If parsed as local time in UTC-5 (EST), 2024-01-01 00:00:00 becomes 2023-12-31 19:00:00 UTC
+      // But we want 2024-01-01 regardless of local timezone
+      const content = `Date,Description,Amount\n2024-01-01,Test,10.00`;
+      const result = parseCSV(content);
+      expect(result.transactions[0].date).toBe('2024-01-01');
+    });
+
+    it('should parse MDY dates correctly without timezone shift', () => {
+      const content = `Date,Description,Amount\n01/01/2024,Test,10.00`;
+      const result = parseCSV(content, { dateFormat: 'MDY' });
+      expect(result.transactions[0].date).toBe('2024-01-01');
+    });
+
+    it('should parse DMY dates correctly without timezone shift', () => {
+      const content = `Date,Description,Amount\n01/01/2024,Test,10.00`;
+      const result = parseCSV(content, { dateFormat: 'DMY' });
+      expect(result.transactions[0].date).toBe('2024-01-01');
+    });
+  });
+
+  describe('Bank Presets', () => {
+    it('should detect TD headerless format correctly', () => {
+      // TD Pattern: Date, Description, Debit, Credit, Balance
+      const content = `
+01/15/2024,PAYMENT RECEIVED,,100.00,500.00
+01/16/2024,PURCHASE,50.00,,450.00
+`.trim();
+
+      // Note: TD pattern detection requires 4+ columns
+      // Our parser might need a hint if the csv is very short or malformed
+      // But the auto-detect logic checks for date in col 0 and numerics in 2/3
+
+      const result = parseCSV(content);
+      // Should detect TD preset which implies header: false
+      expect(result.meta.detectedColumns).toBeDefined();
+      expect(result.transactions).toHaveLength(2);
+      expect(result.transactions[0].amount).toBe(100000); // Credit is inflow (positive)
+      expect(result.transactions[1].amount).toBe(-50000); // Debit is outflow (negative)
+    });
+  });
+});

package/src/tools/reconciliation/__tests__/executor.integration.test.ts

@@ -40,7 +40,7 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
         await ynabAPI.transactions.deleteTransaction(budgetId, transactionId);
       });
     }
-  });
+  }, 60000); // 60 second timeout for cleanup of bulk transactions
 
   it(
     'creates 10 transactions via bulk mode',
@@ -67,6 +67,7 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
         this,
       );
       if (!result) return;
+      if (containsRateLimitFailure(result)) return;
 
       trackCreatedTransactions(result);
       expect(result.summary.transactions_created).toBe(10);
@@ -117,6 +118,7 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
         this,
       );
       if (!duplicateAttempt) return;
+      if (containsRateLimitFailure(duplicateAttempt)) return;
 
       const duplicateActions = duplicateAttempt.actions_taken.filter(
         (action) => action.duplicate === true,
@@ -153,6 +155,7 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
         this,
       );
       if (!result) return;
+      if (containsRateLimitFailure(result)) return;
       trackCreatedTransactions(result);
 
       expect(result.summary.transactions_created).toBe(150);
@@ -187,6 +190,7 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
         this,
       );
       if (!result) return;
+      if (containsRateLimitFailure(result)) return;
       trackCreatedTransactions(result);
 
       const duration = Date.now() - start;
@@ -218,7 +222,7 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
             initialAccount: accountSnapshot,
             currencyCode: 'USD',
           }),
-        ).rejects.toThrow();
+        ).rejects.toMatchObject({ status: expect.any(Number) });
       }, this);
     },
     60000,
@@ -249,6 +253,17 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
       }
     }
   }
+
+  function containsRateLimitFailure(result: Awaited<ReturnType<typeof executeReconciliation>>) {
+    return result.actions_taken.some((action) => {
+      const reason = typeof action.reason === 'string' ? action.reason.toLowerCase() : '';
+      return (
+        reason.includes('429') ||
+        reason.includes('too many requests') ||
+        reason.includes('rate limit')
+      );
+    });
+  }
 });
 
 async function resolveDefaultBudgetId(api: ynab.API): Promise<string> {
@@ -291,7 +306,12 @@ function buildIntegrationAnalysis(
   const clearedDollars = snapshot.cleared_balance / 1000;
   const totalDelta = transactionAmount * count;
   const statementBalance = clearedDollars + totalDelta;
-  const baseDate = Date.parse('2025-12-01');
+
+  // Choose a base date safely in the past so YNAB accepts the transactions (no future dates),
+  // and include a nonce in payee names to avoid duplicate collisions across test runs.
+  const dayMs = 24 * 60 * 60 * 1000;
+  const baseDate = Date.now() - (count + 1) * dayMs;
+  const runNonce = Date.now().toString();
 
   return {
     success: true,
@@ -312,12 +332,12 @@ function buildIntegrationAnalysis(
     auto_matches: [],
     suggested_matches: [],
     unmatched_bank: Array.from({ length: count }, (_, index) => {
-      const date = new Date(baseDate + index * 24 * 60 * 60 * 1000);
+      const date = new Date(baseDate + index * dayMs);
       return {
-        id: `integration-bank-${index}`,
+        id: `integration-bank-${index}-${runNonce}`,
         date: date.toISOString().slice(0, 10),
         amount: transactionAmount,
-        payee: `Integration Payee ${index}`,
+        payee: `Integration Payee ${index}-${runNonce}`,
         memo: `Integration memo ${index}`,
         original_csv_row: index + 1,
       };