@divaltor/academy 0.1.5 → 0.1.7

package/README.md

@@ -36,7 +36,11 @@ Add Academy to `opencode.jsonc`. Each agent can override its display name and co
 }
 ```
 
-Colors accept six-digit hex values or OpenCode theme colors: `primary`, `secondary`, `accent`, `success`, `warning`, `error`, and `info`. You can alternatively set a color with OpenCode's native `agents.<id>.color` configuration. Custom names also update persona references. Agent IDs are `rudolf`, `bourbon`, `agnes`, `cafe`, `dantsu`, and `bellno`. The previous `agentNames` option and `diana` plugin option remain supported for compatibility. See the [plugin docs](https://opencode.ai/v2/docs/build/plugins) to learn more.
+Colors accept six-digit hex values or OpenCode theme colors: `primary`, `secondary`, `accent`, `success`, `warning`, `error`, and `info`. You can alternatively set a color with OpenCode's native `agents.<id>.color` configuration. Custom names also become the agents' IDs and update persona and permission references. Without custom names, agent IDs are `rudolf`, `bourbon`, `agnes`, `cafe`, `dantsu`, and `bellno`.
+
+> [!WARNING] Choose custom names when first setting up Academy and avoid changing them later. OpenCode stores the selected agent ID in each session, so renaming an agent removes the ID referenced by existing sessions and can prevent those sessions from continuing.
+
+See the [plugin docs](https://opencode.ai/v2/docs/build/plugins) to learn more.
 
 ### Private GitHub repositories
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@divaltor/academy",
-  "version": "0.1.5",
+  "version": "0.1.7",
   "description": "An OpenCode plugin that trains a Tracen Academy roster of specialist coding agents to research, build, and review.",
   "homepage": "https://github.com/divaltor/academy#readme",
   "bugs": {

package/src/index.ts

@@ -9,23 +9,11 @@ const AgentOptions = Schema.Struct({
 });
 
 const AcademyOptions = Schema.Struct({
-  agentNames: Schema.optionalKey(
-    Schema.Struct({
-      agnes: Schema.optionalKey(Schema.NonEmptyString),
-      bellno: Schema.optionalKey(Schema.NonEmptyString),
-      bourbon: Schema.optionalKey(Schema.NonEmptyString),
-      cafe: Schema.optionalKey(Schema.NonEmptyString),
-      dantsu: Schema.optionalKey(Schema.NonEmptyString),
-      diana: Schema.optionalKey(Schema.NonEmptyString),
-      rudolf: Schema.optionalKey(Schema.NonEmptyString),
-    })
-  ),
   agnes: Schema.optionalKey(AgentOptions),
   bellno: Schema.optionalKey(AgentOptions),
   bourbon: Schema.optionalKey(AgentOptions),
   cafe: Schema.optionalKey(AgentOptions),
   dantsu: Schema.optionalKey(AgentOptions),
-  diana: Schema.optionalKey(AgentOptions),
   rudolf: Schema.optionalKey(AgentOptions),
 });
 
@@ -36,17 +24,18 @@ const setup = Effect.fn("Academy.setup")(function* setup(ctx: Plugin.Context) {
   const options = yield* Schema.decodeUnknownEffect(AcademyOptions, {
     onExcessProperty: "error",
   })(ctx.options).pipe(Effect.orDie);
-  const legacyNames = options.agentNames ?? {};
   const agentNames = new Map(
-    agents.map((agent) => [
-      agent.name,
-      options[agent.id]?.name ??
-        (agent.id === "rudolf" ? options.diana?.name : undefined) ??
-        legacyNames[agent.id] ??
-        (agent.id === "rudolf" ? legacyNames.diana : undefined) ??
-        agent.name,
-    ])
+    agents.map((agent) => [agent.name, options[agent.id]?.name ?? agent.name])
   );
+  const agentID = (id: (typeof agents)[number]["id"]) =>
+    Agent.ID.make(options[id]?.name ?? id);
+  const configuredAgentIDs = agents.map((agent) => agentID(agent.id));
+
+  if (new Set(configuredAgentIDs).size !== configuredAgentIDs.length) {
+    return yield* Effect.die(
+      new Error("Academy agent names must produce unique agent IDs")
+    );
+  }
 
   yield* ctx.mcp.transform((editor) => {
     if (Option.isNone(githubToken)) {
@@ -65,29 +54,41 @@ const setup = Effect.fn("Academy.setup")(function* setup(ctx: Plugin.Context) {
   });
 
   yield* ctx.agent.transform((editor) => {
-    for (const id of ["build", "plan", "explore", "general", "diana"]) {
+    for (const id of ["build", "plan", "explore", "general"]) {
       editor.remove(id);
     }
 
     for (const definition of agents) {
-      editor.update(definition.id, (agent) => {
+      if (agentID(definition.id) !== definition.id) {
+        editor.remove(definition.id);
+      }
+    }
+
+    for (const definition of agents) {
+      editor.update(agentID(definition.id), (agent) => {
         agent.name = Agent.Name.make(
           agentNames.get(definition.name) ?? definition.name
         );
         agent.description = definition.description;
         agent.mode = definition.mode;
         agent.color =
-          options[definition.id]?.color ??
-          (definition.id === "rudolf" ? options.diana?.color : undefined) ??
-          agent.color ??
-          definition.color;
+          options[definition.id]?.color ?? agent.color ?? definition.color;
         agent.system = definition.system.replaceAll(
           /\b(?:Rudolf|Agnes|Bourbon|Cafe|Dantsu|Bellno)\b/gu,
           (name) => agentNames.get(name) ?? name
         );
-        agent.permissions = definition.permissions.map((permission) => ({
-          ...permission,
-        }));
+        agent.permissions = definition.permissions.map((permission) => {
+          const referencedAgent = agents.find(
+            (candidate) => candidate.id === permission.resource
+          );
+
+          return {
+            ...permission,
+            resource: referencedAgent
+              ? agentID(referencedAgent.id)
+              : permission.resource,
+          };
+        });
         agent.model = definition.model
           ? {
               id: Model.ID.make(definition.model.id),
@@ -98,7 +99,7 @@ const setup = Effect.fn("Academy.setup")(function* setup(ctx: Plugin.Context) {
       });
     }
 
-    editor.default("rudolf");
+    editor.default(agentID("rudolf"));
   });
 });