@ditojs/server 1.2.0 → 1.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ditojs/server",
-  "version": "1.2.0",
+  "version": "1.4.0",
   "type": "module",
   "description": "Dito.js Server – Dito.js is a declarative and modern web framework, based on Objection.js, Koa.js and Vue.js",
   "repository": "https://github.com/ditojs/dito/tree/master/packages/server",
@@ -14,16 +14,16 @@
     "dito": "./src/cli/index.js"
   },
   "engines": {
-    "node": ">= 14.0.0",
+    "node": ">= 16.0.0",
     "yarn": ">= 1.0.0"
   },
   "browserslist": [
-    "node >= 14"
+    "node >= 16"
   ],
   "dependencies": {
-    "@ditojs/admin": "^1.2.0",
-    "@ditojs/router": "^1.2.0",
-    "@ditojs/utils": "^1.2.0",
+    "@ditojs/admin": "^1.4.0",
+    "@ditojs/router": "^1.4.0",
+    "@ditojs/utils": "^1.4.0",
     "@koa/cors": "^3.2.0",
     "@koa/multer": "^3.0.0",
     "@originjs/vite-plugin-commonjs": "^1.0.3",
@@ -53,7 +53,6 @@
     "koa-session": "^6.2.0",
     "koa-static": "^5.0.0",
     "mime-types": "^2.1.35",
-    "minimatch": "^5.0.1",
     "multer": "^1.4.4",
     "multer-s3": "^2.10.0",
     "nanoid": "^3.3.1",
@@ -82,5 +81,5 @@
     "pg": "^8.7.3",
     "sqlite3": "^5.0.2"
   },
-  "gitHead": "ac257e83630a7387e161116ba6fa4dd46db2985f"
+  "gitHead": "0b308cb3bd1513d78894c7ccdc0c8716339f55a1"
 }

package/src/app/Application.js

@@ -171,7 +171,7 @@ export class Application extends Koa {
         }
         if (Object.keys(data).length > 0) {
           console.info(
-            pico.yellow.bold(`\n${modelClass.name}:\n`),
+            pico.yellow(pico.bold(`\n${modelClass.name}:\n`)),
             util.inspect(data, {
               colors: true,
               depth: null,

package/src/app/Validator.js

@@ -195,12 +195,12 @@ export class Validator extends objection.Validator {
       // NOTE: As of Ajv 8, `error.dataPath` is now called `error.instancePath`,
       // but we stick to `error.dataPath` in Dito.js, and support both in errors
       // passed in here.
-      const instancePath = error.instancePath || error.dataPath
+      const instancePath = (error.instancePath ?? error.dataPath) || ''
       const dataPath = `${options?.dataPath || ''}${instancePath}`
       // Unknown properties are reported in `['propertyName']` notation,
       // so replace those with dot-notation, see:
       // https://github.com/epoberezkin/ajv/issues/671
-      const key = dataPath.replace(/\['([^']*)'\]/g, '.$1').slice(1)
+      const key = dataPath.replace(/\['([^']*)'\]/g, '/$1').slice(1)
       const { message, keyword, params } = error
       const definition = keyword === 'format'
         ? this.getFormat(params.format)

package/src/controllers/AdminController.js

@@ -13,7 +13,7 @@ import { merge } from '@ditojs/utils'
 import { Controller } from './Controller.js'
 import { handleConnectMiddleware } from '../middleware/index.js'
 import { ControllerError } from '../errors/index.js'
-import { formatJson } from '../utils/index.js'
+import { formatJson, deprecate } from '../utils/index.js'
 
 export class AdminController extends Controller {
   // @override
@@ -34,11 +34,19 @@ export class AdminController extends Controller {
   }
 
   getPath(name) {
-    const str = this.config[name]?.path
+    const { config } = this
+    let str = config[name]
+    if (config.build?.path || config.dist?.path) {
+      deprecate(`config.admin.build.path and config.admin.dist.path are deprecated. Use config.admin.root and config.admin.dist instead.`)
+
+      str = name === 'root' ? config.build?.path
+        : name === 'dist' ? config.dist?.path
+        : null
+    }
     if (!str) {
       throw new ControllerError(
         this,
-        `Missing admin.${name}.path configuration.`
+        `Missing \`config.admin.${name}\` configuration.`
       )
     }
     return path.resolve(str)
@@ -85,8 +93,8 @@ export class AdminController extends Controller {
     this.koa = new Koa()
     this.koa.use(this.middleware())
     if (this.mode === 'development') {
-      // Calling getPath() throws exception if admin.build.path is not defined:
-      if (this.getPath('build')) {
+      // Calling getPath() throws exception if config.admin.root is not defined:
+      if (this.getPath('root')) {
         this.app.once('after:start', () => this.setupViteServer())
       }
     } else {
@@ -128,14 +136,14 @@ export class AdminController extends Controller {
     const development = this.mode === 'development'
 
     const cwd = path.resolve('.')
-    const root = this.getPath('build')
+    const root = this.getPath('root')
     const base = `${this.url}/`
     const views = path.join(root, 'views')
 
     // Read `package.json` from the closest package.json, so we can emulate
     // ESM-style imports mappings in rollup / vite.
     const pkg = findUpSync('package.json', { cwd: root })
-    const { imports } = JSON.parse(fs.readFileSync(pkg, 'utf8'))
+    const { imports = {} } = JSON.parse(fs.readFileSync(pkg, 'utf8'))
 
     return defineConfig(merge({
       root,
@@ -209,7 +217,7 @@ export class AdminController extends Controller {
             replacement: '#',
             customResolver(id) {
               for (const [find, replacement] of Object.entries(imports)) {
-                picomatch.isMatch(id, find, {
+                picomatch.isMatch(id, find.replace('*', '**'), {
                   capture: true,
                   onMatch({ input, regex }) {
                     const replacementPath = path.resolve(replacement)

package/src/controllers/Controller.js

@@ -120,6 +120,15 @@ export class Controller {
         type, actions, name, action, authorize[name]
       )
     }
+    // Expose a direct reference to the controller on the action object, but
+    // also make it inherit from the controller so that all its public fields
+    // and functions (`app`, `query()`, `execute()`, etc.) can be accessed
+    // directly through `this` from actions.
+    // NOTE: Inheritance is also set up by `inheritValues()` so that from inside
+    // the handlers, `super` points to the parent controller's actions object,
+    // so that calling `super.patch()` from a patch handler magically works.
+    actions.controller = this
+    Object.setPrototypeOf(actions, this)
     return actions
   }
 
@@ -139,7 +148,9 @@ export class Controller {
     this.setupActionRoute(
       type,
       // eslint-disable-next-line new-cap
-      new actionClass(this, handler, type, name, method, path, authorize)
+      new actionClass(
+        this, actions, handler, type, name, method, path, authorize
+      )
     )
     return handler
   }
@@ -559,5 +570,5 @@ function isMethodAction(name) {
     options: true,
     trace: true,
     connect: true
-  }[name]
+  }[name] || false
 }

package/src/controllers/ControllerAction.js

@@ -1,7 +1,9 @@
 import { isString, isObject, asArray, clone } from '@ditojs/utils'
 
 export default class ControllerAction {
-  constructor(controller, handler, type, name, _method, _path, _authorize) {
+  constructor(
+    controller, actions, handler, type, name, _method, _path, _authorize
+  ) {
     const {
       core = false,
       // Allow decorators on actions to override the predetermined defaults for
@@ -20,6 +22,7 @@ export default class ControllerAction {
     } = handler
 
     this.controller = controller
+    this.actions = actions
     this.handler = handler
     this.type = type
     this.name = name
@@ -96,7 +99,7 @@ export default class ControllerAction {
   }
 
   async callHandler(ctx, ...args) {
-    return this.handler.call(this.controller, ctx, ...args)
+    return this.handler.call(this.actions, ctx, ...args)
   }
 
   createValidationError(options) {

package/src/services/Service.js

@@ -26,6 +26,7 @@ export class Service {
   }
 
   getLogger(ctx) {
-    return ctx.logger.child({ name: this.name })
+    const logger = ctx?.logger ?? this.app.logger
+    return logger.child({ name: this.name })
   }
 }