@discourse/lint-configs 2.38.0 → 2.39.0

package/eslint-rules/test-filename-suffix.mjs

@@ -0,0 +1,38 @@
+import path from "node:path";
+
+function isTestFile(filename) {
+  return /tests?\/(javascripts\/)?(acceptance|integration|unit)/.test(filename);
+}
+
+function hasTestSuffix(filename) {
+  return path.parse(filename).name.endsWith("-test");
+}
+
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Require test filenames to end with `-test`.",
+    },
+    schema: [], // no options
+  },
+
+  create(context) {
+    return {
+      Program(node) {
+        const filename = context.getFilename();
+
+        if (!isTestFile(filename)) {
+          return;
+        }
+
+        if (!hasTestSuffix(filename)) {
+          context.report({
+            node,
+            message: "Test filenames must end with `-test`.",
+          });
+        }
+      },
+    };
+  },
+};

package/eslint.mjs

@@ -29,6 +29,7 @@ import noUnusedServices from "./eslint-rules/no-unused-services.mjs";
 import pluginApiNoVersion from "./eslint-rules/plugin-api-no-version.mjs";
 import serviceInjectImport from "./eslint-rules/service-inject-import.mjs";
 import templateTagNoSelfThis from "./eslint-rules/template-tag-no-self-this.mjs";
+import testFilenameSuffix from "./eslint-rules/test-filename-suffix.mjs";
 import themeImports from "./eslint-rules/theme-imports.mjs";
 import truthHelpersImports from "./eslint-rules/truth-helpers-imports.mjs";
 
@@ -140,6 +141,7 @@ export default [
           "no-route-template": noRouteTemplate,
           "template-tag-no-self-this": templateTagNoSelfThis,
           "moved-packages-import-paths": movedPackagesImportPaths,
+          "test-filename-suffix": testFilenameSuffix,
         },
       },
     },
@@ -207,6 +209,7 @@ export default [
       "ember/no-unnecessary-index-route": "off", // the assumption made in this rule doesn't seem to be true in discourse router
       "ember/no-unnecessary-service-injection-argument": "error",
       "ember/no-replace-test-comments": "error",
+      "qunit/no-identical-names": "off", // the rule doesn't consider that tests might be in different `acceptance` modules
       "sort-class-members/sort-class-members": [
         "error",
         {
@@ -305,6 +308,7 @@ export default [
       "discourse/template-tag-no-self-this": ["error"],
       "discourse/no-route-template": ["error"],
       "discourse/moved-packages-import-paths": ["error"],
+      "discourse/test-filename-suffix": ["error"],
     },
   },
   {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discourse/lint-configs",
-  "version": "2.38.0",
+  "version": "2.39.0",
   "description": "Shareable lint configs for Discourse core, plugins, and themes",
   "author": "Discourse",
   "license": "MIT",