@discourse/lint-configs 2.37.2 → 2.39.0

package/eslint-rules/test-filename-suffix.mjs

@@ -0,0 +1,38 @@
+import path from "node:path";
+
+function isTestFile(filename) {
+  return /tests?\/(javascripts\/)?(acceptance|integration|unit)/.test(filename);
+}
+
+function hasTestSuffix(filename) {
+  return path.parse(filename).name.endsWith("-test");
+}
+
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Require test filenames to end with `-test`.",
+    },
+    schema: [], // no options
+  },
+
+  create(context) {
+    return {
+      Program(node) {
+        const filename = context.getFilename();
+
+        if (!isTestFile(filename)) {
+          return;
+        }
+
+        if (!hasTestSuffix(filename)) {
+          context.report({
+            node,
+            message: "Test filenames must end with `-test`.",
+          });
+        }
+      },
+    };
+  },
+};

package/eslint.mjs

@@ -29,6 +29,7 @@ import noUnusedServices from "./eslint-rules/no-unused-services.mjs";
 import pluginApiNoVersion from "./eslint-rules/plugin-api-no-version.mjs";
 import serviceInjectImport from "./eslint-rules/service-inject-import.mjs";
 import templateTagNoSelfThis from "./eslint-rules/template-tag-no-self-this.mjs";
+import testFilenameSuffix from "./eslint-rules/test-filename-suffix.mjs";
 import themeImports from "./eslint-rules/theme-imports.mjs";
 import truthHelpersImports from "./eslint-rules/truth-helpers-imports.mjs";
 
@@ -55,6 +56,7 @@ export default [
         useBabel: true,
         requireConfigFile: false,
         babelOptions: {
+          configFile: false,
           plugins: [[decoratorsPluginPath, { legacy: true }]],
         },
       },
@@ -139,6 +141,7 @@ export default [
           "no-route-template": noRouteTemplate,
           "template-tag-no-self-this": templateTagNoSelfThis,
           "moved-packages-import-paths": movedPackagesImportPaths,
+          "test-filename-suffix": testFilenameSuffix,
         },
       },
     },
@@ -185,41 +188,28 @@ export default [
       "import/no-duplicates": "error",
       "object-shorthand": ["error", "properties"],
       "no-dupe-class-members": "error",
-      "ember/no-classic-components": "off",
-      "ember/no-component-lifecycle-hooks": "off",
-      "ember/require-tagless-components": "off",
+      "ember/no-component-lifecycle-hooks": "off", // too much noise for now; classic components should be converted to glimmer wholesale instead
       "ember/no-assignment-of-untracked-properties-used-in-tracking-contexts":
-        "off",
-      "ember/no-computed-properties-in-native-classes": "off",
-      "ember/no-side-effects": "off",
-      "ember/require-computed-property-dependencies": "off",
-      "ember/require-return-from-computed": "off",
+        "off", // TODO? needs to understand `@trackedArray` though
+      "ember/no-computed-properties-in-native-classes": "off", // too many for now
+      "ember/require-computed-property-dependencies": "off", // we no longer recommend using @computed
+      "ember/require-return-from-computed": "off", // we no longer recommend using @computed
       "ember/use-brace-expansion": "off", // we no longer recommend using @computed
       "ember/no-deprecated-router-transition-methods": "off", // this rule is broken
-      "ember/avoid-leaking-state-in-ember-objects": "off",
-      "ember/no-get": "off",
-      "ember/no-observers": "off",
+      "ember/no-get": "off", // TODO: still too many uses, and is required when crossing `@tracked`/`EmberObject` boundary
       "ember/no-implicit-injections": "off", // this rule is broken
-      "ember/no-array-prototype-extensions": "off",
-      "ember/no-at-ember-render-modifiers": "off",
-      "ember/classic-decorator-hooks": "off",
-      "ember/classic-decorator-no-classic-methods": "off",
-      "ember/no-actions-hash": "off",
-      "ember/no-tracked-properties-from-args": "off",
-      "ember/no-jquery": "off",
-      "ember/no-runloop": "off",
-      "ember/no-capital-letters-in-routes": "off",
-      "ember/no-controller-access-in-routes": "off",
-      "ember/no-shadow-route-definition": "off",
-      "ember/no-unnecessary-index-route": "off",
+      "ember/no-array-prototype-extensions": "off", // too many false-positives
+      "ember/no-at-ember-render-modifiers": "off", // TODO: @ember/render-modifiers are considered an anti-pattern
+      "ember/classic-decorator-hooks": "off", // too much noise; doesn't consider EmberObject/Controller/EmberComponent as classic w/o the decorator
+      "ember/classic-decorator-no-classic-methods": "off", // same as ember/classic-decorator-hooks
+      "ember/no-runloop": "off", // TODO: though not in the foreseeable future
+      "ember/no-capital-letters-in-routes": "off", // TODO: too many errors for now
+      "ember/no-controller-access-in-routes": "off", // TODO: maybe?
+      "ember/no-shadow-route-definition": "off", // TODO: but there seems to be a bug in the rule (a nested route can't shadow the parent)
+      "ember/no-unnecessary-index-route": "off", // the assumption made in this rule doesn't seem to be true in discourse router
       "ember/no-unnecessary-service-injection-argument": "error",
-      "ember/route-path-style": "off",
-      "ember/routes-segments-snake-case": "off",
       "ember/no-replace-test-comments": "error",
-      "qunit/no-assert-equal": "off",
-      "qunit/no-conditional-assertions": "off",
-      "qunit/no-identical-names": "off",
-      "qunit/no-loose-assertions": "off",
+      "qunit/no-identical-names": "off", // the rule doesn't consider that tests might be in different `acceptance` modules
       "sort-class-members/sort-class-members": [
         "error",
         {
@@ -316,8 +306,9 @@ export default [
       "discourse/capital-components": ["error"],
       "discourse/no-onclick": ["error"],
       "discourse/template-tag-no-self-this": ["error"],
-      // "discourse/no-route-template": ["error"], // Enable by default once Ember 6.6 is on stable
-      // "discourse/moved-packages-import-paths": ["error"], // Enable when the package move commits are released
+      "discourse/no-route-template": ["error"],
+      "discourse/moved-packages-import-paths": ["error"],
+      "discourse/test-filename-suffix": ["error"],
     },
   },
   {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discourse/lint-configs",
-  "version": "2.37.2",
+  "version": "2.39.0",
   "description": "Shareable lint configs for Discourse core, plugins, and themes",
   "author": "Discourse",
   "license": "MIT",
@@ -29,9 +29,9 @@
     "./template-lint-rules": "./template-lint-rules/index.mjs"
   },
   "dependencies": {
-    "@babel/core": "^7.28.6",
+    "@babel/core": "^7.29.0",
     "@babel/eslint-parser": "^7.28.6",
-    "@babel/plugin-proposal-decorators": "^7.28.6",
+    "@babel/plugin-proposal-decorators": "^7.29.0",
     "@eslint/js": "^9.39.2",
     "ember-eslint-parser": "^0.5.13",
     "ember-template-lint": "^7.9.3",
@@ -42,10 +42,10 @@
     "eslint-plugin-qunit": "^8.2.5",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-sort-class-members": "^1.21.0",
-    "globals": "^17.0.0",
-    "prettier": "^3.8.0",
-    "prettier-plugin-ember-template-tag": "^2.1.2",
-    "stylelint": "^17.0.0",
+    "globals": "^17.3.0",
+    "prettier": "^3.8.1",
+    "prettier-plugin-ember-template-tag": "^2.1.3",
+    "stylelint": "^17.1.0",
     "stylelint-config-standard": "^40.0.0",
     "stylelint-config-standard-scss": "^17.0.0",
     "stylelint-scss": "^7.0.0",
@@ -54,8 +54,8 @@
   "peerDependencies": {
     "ember-template-lint": "7.9.3",
     "eslint": "9.39.2",
-    "prettier": "3.8.0",
-    "stylelint": "17.0.0"
+    "prettier": "3.8.1",
+    "stylelint": "17.1.0"
   },
   "scripts": {
     "lint": "eslint --no-error-on-unmatched-pattern \"**/*.{cjs,mjs,js}\" && pnpm prettier --check \"**/*.{cjs,mjs,js}\"",