@discourse/lint-configs 2.29.0 → 2.31.0

package/eslint-rules/deprecated-imports.mjs

@@ -0,0 +1,42 @@
+export default {
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Use the correct import paths",
+    },
+    fixable: "code",
+    schema: [], // no options
+  },
+
+  create(context) {
+    return {
+      ImportDeclaration(node) {
+        if (node.source.value === "discourse/helpers/get-url") {
+          context.report({
+            node,
+            message:
+              "Use 'discourse/lib/get-url' instead of 'discourse/helpers/get-url'",
+            fix(fixer) {
+              return fixer.replaceText(node.source, `"discourse/lib/get-url"`);
+            },
+          });
+        } else if (
+          node.source.value === "discourse/helpers/html-safe" &&
+          node.specifiers[0]?.local.name === "htmlSafe"
+        ) {
+          context.report({
+            node,
+            message:
+              "Use '@ember/template' instead of 'discourse/helpers/html-safe'",
+            fix(fixer) {
+              return fixer.replaceText(
+                node,
+                `import { htmlSafe } from "@ember/template";`
+              );
+            },
+          });
+        }
+      },
+    };
+  },
+};

package/eslint-rules/no-onclick.mjs

@@ -0,0 +1,24 @@
+export default {
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Avoid the `onclick` attribute",
+    },
+    fixable: "code",
+    schema: [], // no options
+  },
+
+  create(context) {
+    return {
+      GlimmerAttrNode(node) {
+        if (node.name === "onclick") {
+          context.report({
+            node,
+            message:
+              'Do not use `onclick` attribute. Use `{{on "click" ...}}` modifier instead.',
+          });
+        }
+      },
+    };
+  },
+};

package/eslint.mjs

@@ -13,6 +13,7 @@ import SimpleImportSort from "eslint-plugin-simple-import-sort";
 import SortClassMembers from "eslint-plugin-sort-class-members";
 import globals from "globals";
 import capitalComponents from "./eslint-rules/capital-components.mjs";
+import deprecatedImports from "./eslint-rules/deprecated-imports.mjs";
 import deprecatedLookups from "./eslint-rules/deprecated-lookups.mjs";
 import deprecatedPluginApis from "./eslint-rules/deprecated-plugin-apis.mjs";
 import discourseCommonImports from "./eslint-rules/discourse-common-imports.mjs";
@@ -22,6 +23,7 @@ import lineAfterImports from "./eslint-rules/line-after-imports.mjs";
 import lineBeforeDefaultExport from "./eslint-rules/line-before-default-export.mjs";
 import linesBetweenClassMembers from "./eslint-rules/lines-between-class-members.mjs";
 import noCurlyComponents from "./eslint-rules/no-curly-components.mjs";
+import noOnclick from "./eslint-rules/no-onclick.mjs";
 import noSimpleQuerySelector from "./eslint-rules/no-simple-query-selector.mjs";
 import pluginApiNoVersion from "./eslint-rules/plugin-api-no-version.mjs";
 import serviceInjectImport from "./eslint-rules/service-inject-import.mjs";
@@ -124,12 +126,14 @@ export default [
           "no-simple-query-selector": noSimpleQuerySelector,
           "deprecated-lookups": deprecatedLookups,
           "discourse-common-imports": discourseCommonImports,
+          "deprecated-imports": deprecatedImports,
           "lines-between-class-members": linesBetweenClassMembers,
           "deprecated-plugin-apis": deprecatedPluginApis,
           "line-after-imports": lineAfterImports,
           "line-before-default-export": lineBeforeDefaultExport,
           "no-curly-components": noCurlyComponents,
           "capital-components": capitalComponents,
+          "no-onclick": noOnclick,
         },
       },
     },
@@ -297,12 +301,14 @@ export default [
       "discourse/no-simple-query-selector": ["error"],
       "discourse/deprecated-lookups": ["error"],
       "discourse/discourse-common-imports": ["error"],
+      "discourse/deprecated-imports": ["error"],
       "discourse/lines-between-class-members": ["error"],
       "discourse/deprecated-plugin-apis": ["error"],
       "discourse/line-after-imports": ["error"],
       "discourse/line-before-default-export": ["error"],
       "discourse/no-curly-components": ["error"],
       "discourse/capital-components": ["error"],
+      "discourse/no-onclick": ["error"],
     },
   },
   {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discourse/lint-configs",
-  "version": "2.29.0",
+  "version": "2.31.0",
   "description": "Shareable lint configs for Discourse core, plugins, and themes",
   "author": "Discourse",
   "license": "MIT",