@discourse/lint-configs 2.26.0 → 2.28.0

package/eslint-rules/plugin-api-no-version.mjs

@@ -0,0 +1,40 @@
+export default {
+  meta: {
+    type: "suggestion",
+    docs: {
+      description:
+        "remove the deprecated version argument from apiInitializer/withPluginApi calls",
+    },
+    fixable: "code",
+    schema: [], // no options
+  },
+
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (
+          node.callee.name === "apiInitializer" ||
+          node.callee.name === "withPluginApi"
+        ) {
+          if (
+            node.arguments.length >= 2 &&
+            node.arguments[0].type === "Literal"
+          ) {
+            context.report({
+              node: node.arguments[0],
+              message: `Specifying plugin api version in ${node.callee.name} is no longer necessary`,
+              fix(fixer) {
+                const arg = node.arguments[0];
+                const punctuatorToken = context.sourceCode.getTokenAfter(arg);
+                const nextToken =
+                  context.sourceCode.getTokenAfter(punctuatorToken);
+
+                return fixer.removeRange([arg.range[0], nextToken.range[0]]);
+              },
+            });
+          }
+        }
+      },
+    };
+  },
+};

package/eslint.mjs

@@ -23,6 +23,7 @@ import lineBeforeDefaultExport from "./eslint-rules/line-before-default-export.m
 import linesBetweenClassMembers from "./eslint-rules/lines-between-class-members.mjs";
 import noCurlyComponents from "./eslint-rules/no-curly-components.mjs";
 import noSimpleQuerySelector from "./eslint-rules/no-simple-query-selector.mjs";
+import pluginApiNoVersion from "./eslint-rules/plugin-api-no-version.mjs";
 import serviceInjectImport from "./eslint-rules/service-inject-import.mjs";
 import themeImports from "./eslint-rules/theme-imports.mjs";
 import truthHelpersImports from "./eslint-rules/truth-helpers-imports.mjs";
@@ -118,6 +119,7 @@ export default [
           "i18n-t": i18nT,
           "service-inject-import": serviceInjectImport,
           "truth-helpers-imports": truthHelpersImports,
+          "plugin-api-no-version": pluginApiNoVersion,
           "theme-imports": themeImports,
           "no-simple-query-selector": noSimpleQuerySelector,
           "deprecated-lookups": deprecatedLookups,
@@ -153,7 +155,6 @@ export default [
       "no-iterator": "error",
       "no-loop-func": "error",
       "no-misleading-character-class": "off",
-      "no-mixed-spaces-and-tabs": "error",
       "no-multi-str": "error",
       "no-new": "error",
       "no-proto": "error",
@@ -163,7 +164,6 @@ export default [
       "no-sequences": "error",
       "no-shadow": "error",
       "no-this-before-super": "error",
-      "no-trailing-spaces": "error",
       "no-undef": "error",
       "no-unexpected-multiline": "off",
       "no-unused-vars": "error",
@@ -171,9 +171,7 @@ export default [
       "no-var": "error",
       "no-with": "error",
       radix: "error",
-      semi: "error",
       "valid-typeof": "error",
-      "wrap-iife": ["error", "inside"],
       curly: "error",
       "import/no-duplicates": "error",
       "object-shorthand": ["error", "properties"],
@@ -294,6 +292,7 @@ export default [
       "discourse/i18n-t": ["error"],
       "discourse/service-inject-import": ["error"],
       "discourse/truth-helpers-imports": ["error"],
+      "discourse/plugin-api-no-version": ["error"],
       "discourse/theme-imports": ["error"],
       "discourse/no-simple-query-selector": ["error"],
       "discourse/deprecated-lookups": ["error"],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discourse/lint-configs",
-  "version": "2.26.0",
+  "version": "2.28.0",
   "description": "Shareable lint configs for Discourse core, plugins, and themes",
   "author": "Discourse",
   "license": "MIT",