@discourse/lint-configs 2.17.2 → 2.19.0

package/eslint-rules/no-register-connector-class.mjs

@@ -0,0 +1,30 @@
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description: "disallow api.registerConnectorClass() uses",
+    },
+    fixable: "code",
+    schema: [], // no options
+  },
+
+  create(context) {
+    return {
+      CallExpression(node) {
+        const { callee, arguments: args } = node;
+
+        if (
+          callee.type === "MemberExpression" &&
+          callee.property.name === "registerConnectorClass" &&
+          args.length === 3
+        ) {
+          context.report({
+            node,
+            message:
+              "registerConnectorClass is deprecated. Create a glimmer component in a plugin connector directory or use renderInOutlet instead.",
+          });
+        }
+      },
+    };
+  },
+};

package/eslint.mjs

@@ -19,6 +19,7 @@ import i18nT from "./eslint-rules/i18n-t.mjs";
 import lineAfterImports from "./eslint-rules/line-after-imports.mjs";
 import lineBeforeDefaultExport from "./eslint-rules/line-before-default-export.mjs";
 import linesBetweenClassMembers from "./eslint-rules/lines-between-class-members.mjs";
+import noRegisterConnectorClass from "./eslint-rules/no-register-connector-class.mjs";
 import noSimpleQuerySelector from "./eslint-rules/no-simple-query-selector.mjs";
 import serviceInjectImport from "./eslint-rules/service-inject-import.mjs";
 import truthHelpersImports from "./eslint-rules/truth-helpers-imports.mjs";
@@ -118,6 +119,7 @@ export default [
           "deprecated-lookups": deprecatedLookups,
           "discourse-common-imports": discourseCommonImports,
           "lines-between-class-members": linesBetweenClassMembers,
+          "no-register-connector-class": noRegisterConnectorClass,
           "line-after-imports": lineAfterImports,
           "line-before-default-export": lineBeforeDefaultExport,
         },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discourse/lint-configs",
-  "version": "2.17.2",
+  "version": "2.19.0",
   "description": "Shareable lint configs for Discourse core, plugins, and themes",
   "author": "Discourse",
   "license": "MIT",
@@ -33,26 +33,26 @@
     "@babel/core": "^7.27.1",
     "@babel/eslint-parser": "^7.27.1",
     "@babel/plugin-proposal-decorators": "^7.27.1",
-    "ember-template-lint": "^7.6.0",
-    "eslint": "^9.26.0",
+    "ember-template-lint": "^7.7.0",
+    "eslint": "^9.27.0",
     "eslint-plugin-decorator-position": "^6.0.0",
     "eslint-plugin-ember": "^12.5.0",
     "eslint-plugin-import": "^2.31.0",
     "eslint-plugin-qunit": "^8.1.2",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-sort-class-members": "^1.21.0",
-    "globals": "^16.0.0",
+    "globals": "^16.1.0",
     "prettier": "^3.5.3",
     "prettier-plugin-ember-template-tag": "^2.0.5",
     "stylelint": "^16.19.1",
     "stylelint-config-standard": "^38.0.0",
-    "stylelint-config-standard-scss": "^14.0.0",
+    "stylelint-config-standard-scss": "^15.0.1",
     "stylelint-scss": "^6.12.0",
     "typescript": "^5.8.3"
   },
   "peerDependencies": {
-    "ember-template-lint": "7.6.0",
-    "eslint": "9.26.0",
+    "ember-template-lint": "7.7.0",
+    "eslint": "9.27.0",
     "prettier": "3.5.3",
     "stylelint": "16.19.1"
   }

package/template-lint-rules/index.mjs

@@ -1,5 +1,6 @@
 import NoAtClass from "./no-at-class.mjs";
 import NoImplicitThis from "./no-implicit-this.mjs";
+import PluginOutletLazyHash from "./plugin-outlet-lazy-hash.mjs";
 
 export default {
   // Name of plugin
@@ -9,5 +10,6 @@ export default {
   rules: {
     "discourse/no-at-class": NoAtClass,
     "discourse/no-implicit-this": NoImplicitThis,
+    "discourse/plugin-outlet-lazy-hash": PluginOutletLazyHash,
   },
 };

package/template-lint-rules/plugin-outlet-lazy-hash.mjs

@@ -0,0 +1,27 @@
+import { Rule } from "ember-template-lint";
+
+export default class PluginOutletLazyHash extends Rule {
+  visitor() {
+    return {
+      ElementNode(node) {
+        if (node.tag === "PluginOutlet") {
+          const outletArgsAttr = node.attributes.find(
+            (attr) => attr.name === "@outletArgs"
+          );
+
+          if (
+            outletArgsAttr &&
+            outletArgsAttr.value.type === "MustacheStatement" &&
+            outletArgsAttr.value.path.original === "hash"
+          ) {
+            this.log({
+              message:
+                "Use {{lazyHash}} instead of {{hash}} for @outletArgs in <PluginOutlet>.",
+              node: outletArgsAttr.value,
+            });
+          }
+        }
+      },
+    };
+  }
+}

package/template-lint.config.cjs

@@ -29,6 +29,7 @@ module.exports = {
     "no-unnecessary-curly-strings": true,
     "simple-modifiers": true,
     "no-chained-this": true,
+    "require-strict-mode": true,
 
     // Pending non-default rules
     "attribute-order": false,
@@ -53,6 +54,7 @@ module.exports = {
         /-/, // kebab-case, probably a component or helper
       ],
     },
+    "discourse/plugin-outlet-lazy-hash": true,
   },
   overrides: [
     {