@discourse/lint-configs 2.17.1 → 2.18.0

package/eslint-rules/line-before-default-export.mjs

@@ -1,3 +1,7 @@
+function isCommentNode(node) {
+  return node.type === "Line" || node.type === "Block";
+}
+
 export default {
   meta: {
     type: "layout",
@@ -13,23 +17,33 @@ export default {
 
     return {
       ExportDefaultDeclaration(node) {
-        const declaration = node.declaration;
-        const decorators = declaration?.decorators || [];
-        const targetNode = decorators.length > 0 ? decorators[0] : node;
-
-        const previousToken = sourceCode.getTokenBefore(targetNode, {
-          includeComments: true,
-        });
-
-        if (!previousToken) {
-          return;
+        let targetNode = node;
+        if (node.declaration?.decorators?.length) {
+          targetNode = node.declaration.decorators[0];
         }
 
-        const isPadded =
-          targetNode.loc.start.line - previousToken.loc.end.line > 1;
-
-        if (isPadded) {
-          return;
+        let previousToken;
+        while (true) {
+          previousToken = sourceCode.getTokenBefore(targetNode, {
+            includeComments: true,
+          });
+          if (!previousToken) {
+            // Top of file, no need for newline
+            return;
+          }
+
+          const isPadded =
+            targetNode.loc.start.line - previousToken.loc.end.line > 1;
+          if (isPadded) {
+            return;
+          }
+
+          if (isCommentNode(previousToken)) {
+            targetNode = previousToken;
+            continue;
+          }
+
+          break;
         }
 
         context.report({

package/eslint-rules/no-register-connector-class.mjs

@@ -0,0 +1,30 @@
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description: "disallow api.registerConnectorClass() uses",
+    },
+    fixable: "code",
+    schema: [], // no options
+  },
+
+  create(context) {
+    return {
+      CallExpression(node) {
+        const { callee, arguments: args } = node;
+
+        if (
+          callee.type === "MemberExpression" &&
+          callee.property.name === "registerConnectorClass" &&
+          args.length === 3
+        ) {
+          context.report({
+            node,
+            message:
+              "registerConnectorClass is deprecated. Create a glimmer component in a plugin connector directory or use renderInOutlet instead.",
+          });
+        }
+      },
+    };
+  },
+};

package/eslint.mjs

@@ -19,6 +19,7 @@ import i18nT from "./eslint-rules/i18n-t.mjs";
 import lineAfterImports from "./eslint-rules/line-after-imports.mjs";
 import lineBeforeDefaultExport from "./eslint-rules/line-before-default-export.mjs";
 import linesBetweenClassMembers from "./eslint-rules/lines-between-class-members.mjs";
+import noRegisterConnectorClass from "./eslint-rules/no-register-connector-class.mjs";
 import noSimpleQuerySelector from "./eslint-rules/no-simple-query-selector.mjs";
 import serviceInjectImport from "./eslint-rules/service-inject-import.mjs";
 import truthHelpersImports from "./eslint-rules/truth-helpers-imports.mjs";
@@ -118,6 +119,7 @@ export default [
           "deprecated-lookups": deprecatedLookups,
           "discourse-common-imports": discourseCommonImports,
           "lines-between-class-members": linesBetweenClassMembers,
+          "no-register-connector-class": noRegisterConnectorClass,
           "line-after-imports": lineAfterImports,
           "line-before-default-export": lineBeforeDefaultExport,
         },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discourse/lint-configs",
-  "version": "2.17.1",
+  "version": "2.18.0",
   "description": "Shareable lint configs for Discourse core, plugins, and themes",
   "author": "Discourse",
   "license": "MIT",
@@ -33,26 +33,26 @@
     "@babel/core": "^7.27.1",
     "@babel/eslint-parser": "^7.27.1",
     "@babel/plugin-proposal-decorators": "^7.27.1",
-    "ember-template-lint": "^7.6.0",
-    "eslint": "^9.26.0",
+    "ember-template-lint": "^7.7.0",
+    "eslint": "^9.27.0",
     "eslint-plugin-decorator-position": "^6.0.0",
     "eslint-plugin-ember": "^12.5.0",
     "eslint-plugin-import": "^2.31.0",
     "eslint-plugin-qunit": "^8.1.2",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-sort-class-members": "^1.21.0",
-    "globals": "^16.0.0",
+    "globals": "^16.1.0",
     "prettier": "^3.5.3",
     "prettier-plugin-ember-template-tag": "^2.0.5",
     "stylelint": "^16.19.1",
     "stylelint-config-standard": "^38.0.0",
-    "stylelint-config-standard-scss": "^14.0.0",
+    "stylelint-config-standard-scss": "^15.0.1",
     "stylelint-scss": "^6.12.0",
     "typescript": "^5.8.3"
   },
   "peerDependencies": {
-    "ember-template-lint": "7.6.0",
-    "eslint": "9.26.0",
+    "ember-template-lint": "7.7.0",
+    "eslint": "9.27.0",
     "prettier": "3.5.3",
     "stylelint": "16.19.1"
   }

package/template-lint.config.cjs

@@ -29,6 +29,7 @@ module.exports = {
     "no-unnecessary-curly-strings": true,
     "simple-modifiers": true,
     "no-chained-this": true,
+    "require-strict-mode": true,
 
     // Pending non-default rules
     "attribute-order": false,