@discourse/lint-configs 2.13.2 → 2.15.0

package/eslint-rules/line-before-default-export.mjs

@@ -0,0 +1,47 @@
+export default {
+  meta: {
+    type: "layout",
+    docs: {
+      description: "Require an empty line before the default export",
+    },
+    fixable: "whitespace",
+    schema: [], // no options
+  },
+
+  create(context) {
+    const sourceCode = context.sourceCode;
+
+    return {
+      Program(node) {
+        const body = node.body;
+        const index = body.findIndex(
+          (n) => n.type === "ExportDefaultDeclaration"
+        );
+
+        if (index === -1 || index === 0) {
+          // No default export or starts with the export
+          return;
+        }
+
+        const currentToken = body[index];
+        const previousToken = sourceCode.getTokenBefore(currentToken);
+
+        const isPadded =
+          currentToken.loc.end.line - previousToken.loc.end.line > 1;
+
+        if (isPadded) {
+          return;
+        }
+
+        context.report({
+          node: body[index],
+          message: "Expected blank line before the default export.",
+
+          fix(fixer) {
+            return fixer.insertTextAfter(previousToken, "\n");
+          },
+        });
+      },
+    };
+  },
+};

package/eslint.mjs

@@ -17,6 +17,7 @@ import discourseCommonImports from "./eslint-rules/discourse-common-imports.mjs"
 import i18nImport from "./eslint-rules/i18n-import-location.mjs";
 import i18nT from "./eslint-rules/i18n-t.mjs";
 import lineAfterImports from "./eslint-rules/line-after-imports.mjs";
+import lineBeforeDefaultExport from "./eslint-rules/line-before-default-export.mjs";
 import linesBetweenClassMembers from "./eslint-rules/lines-between-class-members.mjs";
 import noSimpleQuerySelector from "./eslint-rules/no-simple-query-selector.mjs";
 import serviceInjectImport from "./eslint-rules/service-inject-import.mjs";
@@ -118,6 +119,7 @@ export default [
           "discourse-common-imports": discourseCommonImports,
           "lines-between-class-members": linesBetweenClassMembers,
           "line-after-imports": lineAfterImports,
+          "line-before-default-export": lineBeforeDefaultExport,
         },
       },
     },
@@ -291,6 +293,7 @@ export default [
       "discourse/discourse-common-imports": ["error"],
       "discourse/lines-between-class-members": ["error"],
       "discourse/line-after-imports": ["error"],
+      "discourse/line-before-default-export": ["error"],
     },
   },
   {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discourse/lint-configs",
-  "version": "2.13.2",
+  "version": "2.15.0",
   "description": "Shareable lint configs for Discourse core, plugins, and themes",
   "author": "Discourse",
   "license": "MIT",
@@ -31,10 +31,10 @@
   },
   "dependencies": {
     "@babel/core": "^7.26.10",
-    "@babel/eslint-parser": "^7.26.10",
+    "@babel/eslint-parser": "^7.27.0",
     "@babel/plugin-proposal-decorators": "^7.25.9",
-    "ember-template-lint": "^7.0.1",
-    "eslint": "^9.22.0",
+    "ember-template-lint": "^7.0.7",
+    "eslint": "^9.24.0",
     "eslint-plugin-decorator-position": "^6.0.0",
     "eslint-plugin-ember": "^12.5.0",
     "eslint-plugin-import": "^2.31.0",
@@ -43,16 +43,16 @@
     "eslint-plugin-sort-class-members": "^1.21.0",
     "globals": "^16.0.0",
     "prettier": "^3.5.3",
-    "prettier-plugin-ember-template-tag": "^2.0.4",
-    "stylelint": "^16.16.0",
-    "stylelint-config-standard": "^37.0.0",
+    "prettier-plugin-ember-template-tag": "^2.0.5",
+    "stylelint": "^16.18.0",
+    "stylelint-config-standard": "^38.0.0",
     "stylelint-config-standard-scss": "^14.0.0",
-    "typescript": "^5.8.2"
+    "typescript": "^5.8.3"
   },
   "peerDependencies": {
-    "ember-template-lint": "7.0.1",
-    "eslint": "9.22.0",
+    "ember-template-lint": "7.0.7",
+    "eslint": "9.24.0",
     "prettier": "3.5.3",
-    "stylelint": "16.16.0"
+    "stylelint": "16.18.0"
   }
 }

package/template-lint.config.cjs

@@ -58,6 +58,13 @@ module.exports = {
       files: ["**/*.gjs", "**/*.gts"],
       rules: {
         "discourse/no-implicit-this": false,
+        "no-action-modifiers": true,
+      },
+    },
+    {
+      files: ["**/templates/**/*.gjs"],
+      rules: {
+        "no-action": true,
       },
     },
   ],