@discourse/lint-configs 2.11.2 → 2.13.0

package/eslint-rules/truth-helpers-imports.mjs

@@ -0,0 +1,36 @@
+export default {
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "use the shorter form of truth-helpers import",
+    },
+    fixable: "code",
+    schema: [], // no options
+  },
+
+  create(context) {
+    return {
+      ImportDeclaration(node) {
+        if (node.source.value.startsWith("truth-helpers/helpers/")) {
+          context.report({
+            node,
+            message: `It is recommended to use 'truth-helpers' import instead of '${node.source.value}'.`,
+            fix(fixer) {
+              let code;
+              const localName = node.specifiers[0].local.name;
+              const sourceName = node.source.value.match(/([^/]+)$/)[0];
+
+              if (localName === sourceName) {
+                code = `import { ${sourceName} } from 'truth-helpers';`;
+              } else {
+                code = `import { ${sourceName} as ${localName} } from 'truth-helpers';`;
+              }
+
+              return fixer.replaceText(node, code);
+            },
+          });
+        }
+      },
+    };
+  },
+};

package/eslint.mjs

@@ -20,6 +20,7 @@ import lineAfterImports from "./eslint-rules/line-after-imports.mjs";
 import linesBetweenClassMembers from "./eslint-rules/lines-between-class-members.mjs";
 import noSimpleQuerySelector from "./eslint-rules/no-simple-query-selector.mjs";
 import serviceInjectImport from "./eslint-rules/service-inject-import.mjs";
+import truthHelpersImports from "./eslint-rules/truth-helpers-imports.mjs";
 
 // Copied from "ember-template-imports/lib/utils"
 const TEMPLATE_TAG_PLACEHOLDER = "__GLIMMER_TEMPLATE";
@@ -111,6 +112,7 @@ export default [
           "i18n-import-location": i18nImport,
           "i18n-t": i18nT,
           "service-inject-import": serviceInjectImport,
+          "truth-helpers-imports": truthHelpersImports,
           "no-simple-query-selector": noSimpleQuerySelector,
           "deprecated-lookups": deprecatedLookups,
           "discourse-common-imports": discourseCommonImports,
@@ -283,6 +285,7 @@ export default [
       "discourse/i18n-import-location": ["error"],
       "discourse/i18n-t": ["error"],
       "discourse/service-inject-import": ["error"],
+      "discourse/truth-helpers-imports": ["error"],
       "discourse/no-simple-query-selector": ["error"],
       "discourse/deprecated-lookups": ["error"],
       "discourse/discourse-common-imports": ["error"],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discourse/lint-configs",
-  "version": "2.11.2",
+  "version": "2.13.0",
   "description": "Shareable lint configs for Discourse core, plugins, and themes",
   "author": "Discourse",
   "license": "MIT",

package/stylelint.mjs

@@ -26,6 +26,5 @@ export default {
     "scss/at-function-pattern": null,
     "scss/comment-no-empty": null,
     "scss/at-mixin-pattern": null,
-    "media-feature-range-notation": "prefix",
   },
 };