@discourse/lint-configs 1.3.10 → 1.4.1

package/eslintrc.cjs

@@ -7,7 +7,11 @@ const TEMPLATE_TAG_PLACEHOLDER = "__GLIMMER_TEMPLATE";
 
 module.exports = {
   root: true,
-  extends: ["eslint:recommended", "plugin:qunit/recommended"],
+  extends: [
+    "eslint:recommended",
+    "plugin:qunit/recommended",
+    "plugin:ember/recommended",
+  ],
   parser: "@babel/eslint-parser",
   env: {
     browser: true,
@@ -125,20 +129,17 @@ module.exports = {
     "object-shorthand": ["error", "properties"],
     "no-dupe-class-members": "error",
 
-    "ember/no-attrs-in-components": "error",
-    "ember/no-attrs-snapshot": "error",
-    "ember/no-arrow-function-computed-properties": "off",
+    "ember/no-classic-components": "off",
+    "ember/no-component-lifecycle-hooks": "off",
+    "ember/require-tagless-components": "off",
     "ember/no-assignment-of-untracked-properties-used-in-tracking-contexts":
       "off",
-    "ember/no-duplicate-dependent-keys": "error",
+    "ember/no-computed-properties-in-native-classes": "off",
     "ember/no-side-effects": "off",
-    "ember/no-volatile-computed-properties": "error",
+    "ember/require-computed-property-dependencies": "off",
     "ember/require-return-from-computed": "off",
-    "ember/avoid-using-needs-in-controllers": "error",
-    "ember/new-module-imports": "error",
+    "ember/use-brace-expansion": "off", // we no longer recommend using @computed
     "ember/no-deprecated-router-transition-methods": "off", // this rule is broken
-    "ember/no-function-prototype-extensions": "error",
-    "ember/no-string-prototype-extensions": "error",
     "ember/avoid-leaking-state-in-ember-objects": "off",
     "ember/no-get": "off",
     "ember/no-observers": "off",
@@ -146,31 +147,23 @@ module.exports = {
     "ember/no-new-mixins": "off",
     "ember/no-implicit-injections": "off", // this rule is broken
     "ember/no-array-prototype-extensions": "off",
-    "ember/no-try-invoke": "error",
-    "ember/require-super-in-lifecycle-hooks": "error",
+    "ember/no-at-ember-render-modifiers": "off",
     "ember/classic-decorator-hooks": "off",
+    "ember/classic-decorator-no-classic-methods": "off",
     "ember/no-actions-hash": "off",
     "ember/no-classic-classes": "off",
-    "ember/no-ember-super-in-es-classes": "error",
-    "ember/no-empty-glimmer-component-classes": "error",
-    "ember/no-global-jquery": "error",
+    "ember/no-tracked-properties-from-args": "off",
     "ember/no-jquery": "off",
-    "ember/no-incorrect-calls-with-inline-anonymous-functions": "error",
-    "ember/no-invalid-debug-function-arguments": "error",
+    "ember/no-runloop": "off",
     "ember/no-capital-letters-in-routes": "off",
     "ember/no-controller-access-in-routes": "off",
-    "ember/no-private-routing-service": "error",
     "ember/no-shadow-route-definition": "off",
     "ember/no-unnecessary-index-route": "off",
-    "ember/no-unnecessary-route-path-option": "error",
     "ember/no-unnecessary-service-injection-argument": "error",
     "ember/route-path-style": "off",
     "ember/routes-segments-snake-case": "off",
-    "ember/no-pause-test": "error",
     "ember/no-replace-test-comments": "error",
-    "ember/no-settled-after-test-helper": "error",
-    "ember/prefer-ember-test-helpers": "error",
-    "ember/require-valid-css-selector-in-test-helpers": "error",
+    "ember/template-no-let-reference": "off", // we have valid cases of using let variables in templates
 
     "qunit/no-assert-equal-boolean": "off",
     "qunit/no-assert-equal": "off",
@@ -259,8 +252,9 @@ module.exports = {
 
   overrides: [
     {
-      files: ["**/*.gjs", "**/*.gts"],
+      files: ["**/*.gjs"],
       parser: "ember-eslint-parser",
+      extends: ["plugin:ember/recommended-gjs"],
     },
   ],
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discourse/lint-configs",
-  "version": "1.3.10",
+  "version": "1.4.1",
   "description": "Shareable lint configs for Discourse core, plugins, and themes",
   "author": "Discourse",
   "license": "MIT",
@@ -32,20 +32,20 @@
     "test": "cd ../test && node test.js"
   },
   "dependencies": {
-    "@babel/core": "^7.25.2",
-    "@babel/eslint-parser": "^7.25.1",
-    "@babel/plugin-proposal-decorators": "^7.24.7",
+    "@babel/core": "^7.25.8",
+    "@babel/eslint-parser": "^7.25.8",
+    "@babel/plugin-proposal-decorators": "^7.25.7",
     "ember-template-lint": "^6.0.0",
     "eslint": "^8.57.0",
     "eslint-plugin-decorator-position": "^5.0.2",
-    "eslint-plugin-ember": "^12.2.0",
+    "eslint-plugin-ember": "^12.2.1",
     "eslint-plugin-qunit": "^8.1.2",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-sort-class-members": "^1.20.0",
-    "globals": "^15.9.0",
+    "globals": "^15.11.0",
     "prettier": "^2.8.8",
     "prettier-plugin-ember-template-tag": "^0.3.2",
-    "typescript": "^5.5.4"
+    "typescript": "^5.6.3"
   },
   "peerDependencies": {
     "ember-template-lint": "6.0.0",