@discord/intl-loader-core 0.18.0-canary.8b215fd → 0.18.0-rc.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@discord/intl-loader-core",
-  "version": "0.18.0-canary.8b215fd",
+  "version": "0.18.0-rc.0",
   "license": "MIT",
   "description": "Core utilities for writing loaders and transformers using @discord/intl",
   "author": "Jon Egeland",
@@ -28,7 +28,7 @@
   "dependencies": {
     "chokidar": "^3.6.0",
     "debug": "^4.3.6",
-    "@discord/intl-message-database": "0.18.0"
+    "@discord/intl-message-database": "0.18.0-rc.0"
   },
   "devDependencies": {
     "@types/debug": "^4.1.12",

package/src/transformer.js

@@ -118,12 +118,20 @@ class MessageDefinitionsTransformer {
    * binds during initialization. The Proxy supports `key in proxy` queries, getter access,
    * spreads, and more.
    *
+   * @param {string} keyArrayName Name of an Array to use for `keys` queries.
+   * @param {string} keySetName Name of a Set to use for `has` queries.
    * @param {string} bindFunc Code expression that creates a getter bind
    * @returns {string}
    */
-  createBindsProxy(bindFunc) {
+  createBindsProxy(keyArrayName, keySetName, bindFunc) {
     return `new Proxy({},
       {
+        has(self, prop) {
+          return ${keySetName}.has(prop);
+        },
+        ownKeys(self) {
+          return ${keyArrayName};
+        },
         getOwnPropertyDescriptor(self, prop) {
           return {
             value: self[prop] ||= ${bindFunc},
@@ -140,6 +148,8 @@ class MessageDefinitionsTransformer {
             return 'proxyAssign';
           }
           
+          if(!${keySetName}.has(prop)) return undefined;
+          
           self[prop] ||= ${bindFunc};
           return self[prop];
         },
@@ -157,10 +167,10 @@ class MessageDefinitionsTransformer {
   createLoaderAndBinds() {
     if (this.options.preGenerateBinds === 'proxy') {
       return [
-        // `const _keys = ${JSON.stringify(Object.keys(this.options.messageKeys))};`,
-        // 'const _keySet = new Set(_keys);',
-        `const ${this.loaderName} = createLoader([], _locales, _defaultLocale);`,
-        `const binds = ${this.createBindsProxy(`(locale) => ${this.loaderName}.get(prop, locale)`)};`,
+        `const _keys = ${JSON.stringify(Object.keys(this.options.messageKeys))};`,
+        'const _keySet = new Set(_keys);',
+        `const ${this.loaderName} = createLoader(_keys, _locales, _defaultLocale);`,
+        `const binds = ${this.createBindsProxy('_keys', '_keySet', `(locale) => ${this.loaderName}.get(prop, locale)`)};`,
       ];
     } else if (this.options.preGenerateBinds === true) {
       const bindLines = Object.keys(this.options.messageKeys).map(

package/types/src/transformer.d.ts

@@ -98,10 +98,12 @@ export class MessageDefinitionsTransformer {
      * binds during initialization. The Proxy supports `key in proxy` queries, getter access,
      * spreads, and more.
      *
+     * @param {string} keyArrayName Name of an Array to use for `keys` queries.
+     * @param {string} keySetName Name of a Set to use for `has` queries.
      * @param {string} bindFunc Code expression that creates a getter bind
      * @returns {string}
      */
-    createBindsProxy(bindFunc: string): string;
+    createBindsProxy(keyArrayName: string, keySetName: string, bindFunc: string): string;
     /**
      * Return a map of key names to bound message getter functions. If `preGenerateBinds` is
      * configured to be `true`, the binds will be created as a constant object in the output.