@dineroregnskab/eslint-plugin-custom-rules 2.1.0 → 2.1.2

package/README.md

@@ -68,14 +68,12 @@ module.exports = {
 
 ### Publish & install new rule locally
 
-Run:
+1. Log in to npm using `npm login`
+2. run:
 
 ```bash
-npm patch
-```
-
-```bash
-npm publish
+# {version_type}: The type of version increment (patch, minor, major)
+npm version {version_type} && npm publish
 ```
 
 - In dinero.Frontend and/or dinero.Admin, update the root `package.json` file with the newly published version number.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dineroregnskab/eslint-plugin-custom-rules",
-  "version": "2.1.0",
+  "version": "2.1.2",
   "description": "ESLint plugin with custom rules for Dinero Regnskab",
   "main": "eslint-plugin-custom-rules.js",
   "scripts": {},

package/rules/replace-first-with-take.js

@@ -3,7 +3,7 @@ module.exports = {
         type: "suggestion",
         docs: {
             description:
-                "Replace `first()` with `take(1)` in TypeScript files.",
+                "Replace `first()` with `take(1)` and require `filter()` to be used with `take(1)` in pipe.",
         },
         fixable: "code",
         schema: [],
@@ -17,7 +17,7 @@ module.exports = {
                 if (
                     node.callee.type === "Identifier" &&
                     node.callee.name === "first" &&
-                    node.arguments.length === 0 // Ensure `first` is called with no arguments
+                    node.arguments.length === 0
                 ) {
                     context.report({
                         node,
@@ -25,6 +25,39 @@ module.exports = {
                             "Replace `first()` with `take(1)` to avoid errors if no value is ever emitted.",
                     });
                 }
+
+                // Check for `pipe()` with `take(1)`
+                if (
+                    node.callee.type === "MemberExpression" &&
+                    node.callee.property.name === "pipe"
+                ) {
+                    const pipeArguments = node.arguments;
+
+                    // Check if `take(1)` is present
+                    const hasTakeOne = pipeArguments.some(
+                        (arg) =>
+                            arg.type === "CallExpression" &&
+                            arg.callee.name === "take" &&
+                            arg.arguments.length === 1 &&
+                            arg.arguments[0].value === 1
+                    );
+
+                    // Check if `filter()` is present
+                    const hasFilter = pipeArguments.some(
+                        (arg) =>
+                            arg.type === "CallExpression" &&
+                            arg.callee.name === "filter"
+                    );
+
+                    // Report an error if `take(1)` is used without `filter()`
+                    if (hasTakeOne && !hasFilter) {
+                        context.report({
+                            node,
+                            message:
+                                "Using `take(1)` requires `filter()` to be used in the same pipe to avoid `null` or `undefined` values which will trigger an error. Example using the nullish coalescing operator (??): `filter((value) => value ?? false),`",
+                        });
+                    }
+                }
             },
         };
     },

package/rules/use-danish-currency-pipe.js

@@ -13,7 +13,7 @@ module.exports = {
         return {
             Program(node) {
                 const templateContent = node.value;
-                const currencyPipeRegex = /\|\s*currency/g;
+                const currencyPipeRegex = /\|\s*currency\b/g;
 
                 let match;
                 while (