@dineroregnskab/eslint-plugin-custom-rules 1.0.4 → 1.0.6

package/eslint-plugin-custom-rules.js

@@ -0,0 +1,5 @@
+const returnReducerRule = require('./rules/reducers-should-always-return');
+
+const customRulesplugin = { rules: { "reducers-should-always-return": returnReducerRule } };
+module.exports = customRulesplugin;
+

package/package.json

@@ -1,10 +1,10 @@
 {
   "name": "@dineroregnskab/eslint-plugin-custom-rules",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "description": "ESLint plugin with custom rules for Dineroregnskab",
   "main": "eslint-plugin-custom-rules.js",
   "scripts": {
-    "test": "node rules/reducers-should-always-return.test.js"
+    "test": ""
   },
   "keywords": [],
   "author": "",

package/rules/reducers-should-always-return.js

@@ -0,0 +1,46 @@
+module.exports = {
+    meta: {
+        type: 'problem',
+        docs: {
+            description:
+                'Enforce that a ngrx reducer always returns a value, so the store state remains intact.',
+        },
+        fixable: 'code',
+        schema: [],
+    },
+
+    create(context) {
+        return {
+            'CallExpression[callee.name="createReducer"]': function (node) {
+                node.arguments.forEach(function (arg) {
+                    if (
+                        arg.type === 'CallExpression' &&
+                        arg.callee.name === 'on'
+                    ) {
+                        arg.arguments.slice(1).forEach(function (handler) {
+                            const isFunction =
+                                handler.type === 'FunctionExpression' ||
+                                handler.type === 'ArrowFunctionExpression';
+                            const isBlockStatement =
+                                handler.body.type === 'BlockStatement';
+                            const hasNoReturn =
+                                isBlockStatement &&
+                                !handler.body.body.some(
+                                    (statement) =>
+                                        statement.type === 'ReturnStatement',
+                                );
+
+                            if (isFunction && isBlockStatement && hasNoReturn) {
+                                context.report({
+                                    node: handler,
+                                    message:
+                                        'Reducer function must return a value to avoid undefined state.',
+                                });
+                            }
+                        });
+                    }
+                });
+            },
+        };
+    },
+};

package/eslint-plugin-custom-rules.ts

@@ -1,4 +0,0 @@
-import returnReducerRule from './rules/reducers-should-always-return';
-
-export default { rules: { "reducers-should-always-return": returnReducerRule } };
-

package/rules/reducers-should-always-return.ts

@@ -1,40 +0,0 @@
-export default {
-    meta: {
-        type: "problem",
-        docs: {
-            description: "Enforce that a ngrx reducer always returns a value, so the store state remains intact.",
-        },
-        fixable: "code",
-        schema: []
-    },
-
-    create: function(context) {
-        return {
-          'CallExpression[callee.name="createReducer"]': function(node) {
-            node.arguments.forEach(function(arg) {
-              if (arg.type === 'CallExpression' && arg.callee.name === 'on') {
-                arg.arguments.slice(1).forEach(function(handler) {
-                  const isFunction = handler.type === 'FunctionExpression' || handler.type === 'ArrowFunctionExpression';
-                  const isBlockStatement = handler.body.type === 'BlockStatement';
-                  const hasNoReturn = isBlockStatement && !handler.body.body.some(statement => statement.type === 'ReturnStatement');
-
-                  if (isFunction && isBlockStatement && hasNoReturn) {
-                    context.report({
-                      node: handler,
-                      message: 'Reducer function must return a value to avoid undefined state.'
-                    });
-                  }
-                });
-              }
-            });
-          }
-        };
-      }
-};
-
-// tilføj fixer?
-// tilføj lint til filerne her
-// convert til ts?
-
-
-// readme med guide til tilføjelse af regel (+ version patch & publish, adding the rule to html/ts, nameing, adding to projects (main app/admin))