@dineroregnskab/eslint-plugin-custom-rules 1.0.3 → 1.0.4

package/eslint-plugin-custom-rules.ts

@@ -0,0 +1,4 @@
+import returnReducerRule from './rules/reducers-should-always-return';
+
+export default { rules: { "reducers-should-always-return": returnReducerRule } };
+

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dineroregnskab/eslint-plugin-custom-rules",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "ESLint plugin with custom rules for Dineroregnskab",
   "main": "eslint-plugin-custom-rules.js",
   "scripts": {

package/rules/reducers-should-always-return.ts

@@ -0,0 +1,40 @@
+export default {
+    meta: {
+        type: "problem",
+        docs: {
+            description: "Enforce that a ngrx reducer always returns a value, so the store state remains intact.",
+        },
+        fixable: "code",
+        schema: []
+    },
+
+    create: function(context) {
+        return {
+          'CallExpression[callee.name="createReducer"]': function(node) {
+            node.arguments.forEach(function(arg) {
+              if (arg.type === 'CallExpression' && arg.callee.name === 'on') {
+                arg.arguments.slice(1).forEach(function(handler) {
+                  const isFunction = handler.type === 'FunctionExpression' || handler.type === 'ArrowFunctionExpression';
+                  const isBlockStatement = handler.body.type === 'BlockStatement';
+                  const hasNoReturn = isBlockStatement && !handler.body.body.some(statement => statement.type === 'ReturnStatement');
+
+                  if (isFunction && isBlockStatement && hasNoReturn) {
+                    context.report({
+                      node: handler,
+                      message: 'Reducer function must return a value to avoid undefined state.'
+                    });
+                  }
+                });
+              }
+            });
+          }
+        };
+      }
+};
+
+// tilføj fixer?
+// tilføj lint til filerne her
+// convert til ts?
+
+
+// readme med guide til tilføjelse af regel (+ version patch & publish, adding the rule to html/ts, nameing, adding to projects (main app/admin))

package/eslint-plugin-custom-rules.js

@@ -1,5 +0,0 @@
-const returnReducerRule = require('./rules/reducers-should-always-return');
-
-const customRulesplugin = { rules: { "reducers-should-always-return": returnReducerRule } };
-module.exports = customRulesplugin;
-

package/rules/reducers-should-always-return.js

@@ -1,35 +0,0 @@
-module.exports = {
-    meta: {
-        type: "problem",
-        docs: {
-            description: "Enforce that a ngrx reducer always returns a value, so the store state remains intact.",
-        },
-        fixable: "code",
-        schema: []
-    },
-
-    create(context) {
-        return {
-            FunctionDeclaration(node) {
-                if (node.id.name.endsWith('Reducer')) {
-                    let hasReturnStatement = false;
-
-                    node.body.body.forEach(statement => {
-                        if (statement.type === 'ReturnStatement') {
-                            hasReturnStatement = true;
-                        }
-                    });
-
-                    if (!hasReturnStatement) {
-                        context.report({
-                            node,
-                            message: 'Reducer function must return a value to avoid undefined state.',
-                        });
-                    }
-                }
-            },
-          };
-    }
-};
-
-// tilføj fixer?

package/rules/reducers-should-always-return.test.js

@@ -1,42 +0,0 @@
-const returnReducerRule = require('./reducers-should-always-return');
-const { RuleTester } = require('eslint');
-
-const ruleTester = new RuleTester({
-    parserOptions: { ecmaVersion: 2019 },
-});
-
-ruleTester.run('reducers-should-always-return', returnReducerRule, {
-    valid: [
-        // This reducer returns a value in all code paths
-        {
-            code:
-            `function myReducer(state, action) {
-                if (action.type === 'ACTION_TYPE') {
-                    return { ...state, data: action.data };
-                }
-                return state;
-            }`,
-        },
-    ],
-
-    invalid: [
-        // This reducer doesn't return a value if action.type is not 'ACTION_TYPE'
-        {
-            code:
-                `function badReducer(state, action) {
-                    if (action.type === 'ACTION_TYPE') {
-                        return { ...state, data: action.data };
-                    }
-                }`,
-            errors: [
-                {
-                    message:
-                        'Reducer function must return a value to avoid undefined state.',
-                    type: 'FunctionDeclaration',
-                },
-            ],
-        },
-    ],
-});
-
-console.log('All tests passed!');