@digitalbazaar/vc 6.0.0 → 6.0.2

package/README.md

@@ -1,6 +1,6 @@
 # Verifiable Credentials JS Library _(@digitalbazaar/vc)_
 
-[![Build Status](https://img.shields.io/github/workflow/status/digitalbazaar/vc/Node.js%20CI)](https://github.com/digitalbazaar/vc/actions?query=workflow%3A%22Node.js+CI%22)
+[![Build Status](https://img.shields.io/github/actions/workflow/status/digitalbazaar/vc/main.yml)](https://github.com/digitalbazaar/vc/actions/workflow/main.yml)
 [![NPM Version](https://img.shields.io/npm/v/@digitalbazaar/vc.svg)](https://npm.im/@digitalbazaar/vc)
 
 > A Javascript library for issuing and verifying Verifiable Credentials.

package/lib/index.js

@@ -139,7 +139,7 @@ export async function issue({
   }
 
   // run common credential checks
-  _checkCredential({credential, now});
+  _checkCredential({credential, now, mode: 'issue'});
 
   return jsigs.sign(credential, {purpose, documentLoader, suite});
 }
@@ -290,7 +290,7 @@ async function _verifyCredential(options = {}) {
   });
 
   const result = await jsigs.verify(
-    credential, {purpose, documentLoader, ...options});
+    credential, {...options, purpose, documentLoader});
 
   // if verification has already failed, skip status check
   if(!result.verified) {
@@ -382,7 +382,7 @@ export async function signPresentation(options = {}) {
 
   const documentLoader = options.documentLoader || defaultDocumentLoader;
 
-  return jsigs.sign(presentation, {purpose, documentLoader, ...options});
+  return jsigs.sign(presentation, {...options, purpose, documentLoader});
 }
 
 /**
@@ -441,7 +441,7 @@ async function _verifyPresentation(options = {}) {
   if(credentials.length > 0) {
     // verify every credential in `verifiableCredential`
     credentialResults = await Promise.all(credentials.map(credential => {
-      return verifyCredential({credential, documentLoader, ...options});
+      return verifyCredential({...options, credential, documentLoader});
     }));
 
     for(const [i, credentialResult] of credentialResults.entries()) {
@@ -469,7 +469,7 @@ async function _verifyPresentation(options = {}) {
     new AuthenticationProofPurpose({controller, domain, challenge});
 
   const presentationResult = await jsigs.verify(
-    presentation, {purpose, documentLoader, ...options});
+    presentation, {...options, purpose, documentLoader});
 
   return {
     presentationResult,
@@ -536,7 +536,7 @@ export function _checkPresentation(presentation) {
  * @throws {Error}
  * @private
  */
-export function _checkCredential({credential, now = new Date()}) {
+export function _checkCredential({credential, now = new Date(), mode = 'verify'}) {
   if(typeof now === 'string') {
     now = new Date(now);
   }
@@ -586,12 +586,14 @@ export function _checkCredential({credential, now = new Date()}) {
     if(!dateRegex.test(issuanceDate)) {
       throw new Error(`"issuanceDate" must be a valid date: ${issuanceDate}`);
     }
-    // check if `now` is before `issuanceDate`
-    issuanceDate = new Date(issuanceDate);
-    if(now < issuanceDate) {
-      throw new Error(
-        `The current date time (${now.toISOString()}) is before the ` +
-        `"issuanceDate" (${issuanceDate.toISOString()}).`);
+    // check if `now` is before `issuanceDate` on verification
+    if(mode === 'verify') {
+      issuanceDate = new Date(issuanceDate);
+      if(now < issuanceDate) {
+        throw new Error(
+          `The current date time (${now.toISOString()}) is before the ` +
+          `"issuanceDate" (${issuanceDate.toISOString()}).`);
+      }
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@digitalbazaar/vc",
-  "version": "6.0.0",
+  "version": "6.0.2",
   "description": "Verifiable Credentials JavaScript library.",
   "homepage": "https://github.com/digitalbazaar/vc",
   "author": {
@@ -82,7 +82,7 @@
     "test": "npm run test-node",
     "test-node": "cross-env NODE_ENV=test mocha --preserve-symlinks -t 10000 test/*.spec.js",
     "test-karma": "karma start karma.conf.cjs",
-    "lint": "eslint .",
+    "lint": "eslint 'lib/**/*.js' 'test/**/*.js'",
     "coverage": "cross-env NODE_ENV=test c8 npm run test-node",
     "coverage-ci": "cross-env NODE_ENV=test c8 --reporter=lcovonly --reporter=text-summary --reporter=text npm run test-node",
     "coverage-report": "c8 report"