@difflab/pi 0.8.0 → 0.9.0

package/skills/review/references/workflows/new.md

@@ -2,20 +2,21 @@
 
 ## Parse arguments
 
-Accept `new [title] [--intent text] [--base branch] [--local]` and a target named in the request. Fuzzy-match draft intent. Prefer explicit arguments/flags, then safe natural-language or repository title/intent/target/base/backend, then available defaults. Select local for an explicit working-tree request. Call `ask_user_question` only for material ambiguity before launch; return a precise blocker if a new decision arises later.
+Accept `new [title] [--intent text] [--base branch] [--local]`. Resolve explicit target, plan/ticket, title, and backend first. For local work, ask `ask_user_question` when multiple plans or tickets match; do not guess.
 
-## Steps
+## Local steps
 
-1. Resolve the concrete target/backend/local and base with `review_context`. Substitute actual values for every placeholder, including the exact request and issue URL if applicable; never send raw `{placeholders}`. When native subagents are available, launch a lightweight/low `diffpi-worker` background subagent for this bounded draft-creation task. Pass the following self-contained prompt with ambient capabilities:
+Use a background `diffpi-worker` when native subagents are available; otherwise follow the foreground fallback after confirmation. The worker performs only direct-file creation.
 
-   ```text
-   Create a review draft.
-   - Repository: {absolute repo cwd}; exact request: {exact request}.
-   - Resolved target: {target}; backend: {backend}; local: {local}; title: {title}; intent: {intent}; base: {base}; issue URL: {issue URL or none}; approved policy: {policy}.
-   - This explicitly assigned review-draft creation is the only review lifecycle mutation authorized here. Call review_context first. Reuse its target/backend/local/cwd for all subsequent calls; never switch backend silently.
-   - Reject unsupported forge, dirty remote branch or unavailable local base/default with exact evidence.
-   - Call review_new to create the local tuicr review or remote draft PR/MR. Call review_launch_ui only if needed; report a returned launch command if automatic launch fails.
-   - Verify and report the actual created target and draft state or exact failure. Do not stage findings, publish, complete or merge.
-   ```
+1. Inspect `.diffpi/review/` and the matching plan/ticket directory before choosing a number. Derive `YYMMDD-{slug}` from the unique matching plan after stripping its date prefix, otherwise the ticket ID, otherwise a descriptive slug.
+2. Create `.diffpi/review/YYMMDD-{slug}/REVIEW-{n}.md` by reading `templates/REVIEW.md` and writing a copy. Numbering is best effort, not atomic; preserve existing files.
+3. Fill every known title, intent, target, base, and status field. If review text was pasted in the request, record it directly in the file and assign stable `F-001`-style IDs. Preserve replies and checkbox state on later edits.
+4. Report the exact path. Do not call `review_new`, create a backend, or claim atomic allocation.
 
-2. If no native subagents are available, follow [foreground fallback](foreground-fallback.md) before creation. Only after explicit confirmation, perform the draft-creation steps above inline and verify with `review_status`; do not claim a Worker result. Otherwise require the completed child result and verify the created target/draft with `review_status`. Stop on failure; report the actual result, not merely a queued ID or claim. Do not assign the Worker publication, merge, findings judgment or substantive inspection.
+## Remote steps
+
+Call `review_context`, then launch a `diffpi-worker` only for draft creation. Give the worker the resolved repository, branch, base, issue URL (if any), and exact request. The worker must:
+
+1. Read the packaged PR template at `../../templates/review/draft-pr.md` relative to the review skill directory. Inspect the actual branch changes against the selected base and any completed checks; do not invent validation results.
+2. Fill **every** template section: distinct intent and concrete changes, checks actually run (or `Not run (draft)`), the issue URL (or `No linked issue`), and known further work (or `Not yet assessed`). Remove all `{{...}}` markers and HTML comments. Pass the fully rendered Markdown as `body` to the existing `review_new` tool, with the resolved title/base/issue URL. The tool rejects missing or incomplete bodies before calling the forge.
+3. Report the actual PR/MR URL and draft state or the precise failure. Do not publish, complete, merge, or stage findings.

package/skills/review/references/workflows/publish.md

@@ -2,11 +2,11 @@
 
 ## Parse arguments
 
-Accept `publish [target] [--local] [--comment|--approve|--request-changes|--close]`. Fuzzy-match target/backend/status from the request and repository. Prefer explicit arguments/flags, then safe inference, then current-review target and comment status. Call `ask_user_question` only for material ambiguity before launch; return a precise blocker if a new decision arises later.
+Accept `publish [target] [--comment|--approve|--request-changes|--close]`. Local publish is unsupported; reject stale `--local` or working-tree selectors. Fuzzy-match target/backend/status from the request and repository. Prefer explicit arguments/flags, then safe inference, then current-review target and comment status. Call `ask_user_question` only for material ambiguity before launch; return a precise blocker if a new decision arises later.
 
 ## Steps
 
-1. Call `review_context` first with the selected target/backend/local. For a short, explicitly approved publication with no substantive inspection, call `review_publish` directly using its resolved values and selected status (`COMMENT` by default, `APPROVE`, `REQUEST_CHANGES`, or `CLOSE`). Remote findings and replies stay pending until this call. Promote only drafts matching the remote PR/MR; preserve `local:true` for a working-tree session. Report unmatched promotion, GitLab request-changes rejection, and exact failures; verify the final status. Do not merge or resolve threads.
+1. Call `review_context` first with the selected remote target/backend and `local:false`. For a short, explicitly approved publication with no substantive inspection, call `review_publish` directly using its resolved values and selected status (`COMMENT` by default, `APPROVE`, `REQUEST_CHANGES`, or `CLOSE`). Remote findings and replies stay pending until this call. Reject stale local or working-tree selectors; never promote local drafts. Report unmatched promotion, GitLab request-changes rejection, and exact failures; verify the final status. Do not merge or resolve threads.
 2. If the request instead needs substantive inspection or judgment before publication, when native subagents are available, delegate only that analysis to medium `diffpi-orchestrator` in the background with ambient capabilities. Fill every field in this self-contained prompt with actual values (or `none`), including the exact request; never send raw placeholders:
 
    ```text

package/skills/review/references/workflows/status.md

@@ -7,4 +7,4 @@ Accept `status [target] [--local]`. Fuzzy-match the status target/backend from t
 ## Steps
 
 1. Call `review_context` first with the selected target/backend/local; reuse its target/backend/local/cwd. Reject unsupported selections without switching backend.
-2. Call `review_status` with those same values. Report branch, worktree, local or remote review, URLs, tuicr session, pending/draft state and exact errors. Do not create a review or mutate source, comments or lifecycle state.
+2. Call `review_status` with those same values. Report branch, worktree, local or remote review, URLs, pending/draft state and exact errors. Do not create a review or mutate source, comments or lifecycle state.

package/skills/review/templates/REVIEW.md

@@ -0,0 +1,39 @@
+# Local Review
+
+- **Review:** <!-- descriptive title or plan/ticket slug -->
+- **Status:** OPEN
+- **Source:** <!-- pasted review text, local diff, or request -->
+- **Created:** <!-- YYYY-MM-DD -->
+- **Updated:** <!-- YYYY-MM-DD -->
+
+## Intent
+
+<!-- State what this review is checking. -->
+
+## Findings
+
+<!-- Keep findings in stable ID order. Preserve IDs, replies, and checkbox state when editing. -->
+
+### F-001 [ ] <!-- short finding title -->
+
+- **Severity:** BLOCKING | CONSIDER | NOTE
+- **Location:** `path/to/file.ts:1`
+- **Finding:** <!-- Explain the problem and its impact. -->
+- **Evidence:** <!-- Quote the relevant source or review text. -->
+- **Resolution:** <!-- Leave blank while open; record the verified fix here. -->
+
+<!-- Copy the finding shape above for F-002, F-003, and so on. -->
+
+## Replies
+
+<!-- Preserve human replies verbatim. Add dated replies below without deleting prior context. -->
+
+## Verification
+
+- [ ] Focused check run for each addressed finding
+- [ ] Remaining open findings reviewed
+- [ ] Overall status updated only after verification
+
+## Status Notes
+
+<!-- Record blockers, partial work, and decisions. Do not close a finding without evidence. -->

package/templates/plan/PLAN.md

@@ -3,8 +3,12 @@
 - **Plan ID:** {{id}}
 - **Branch:** {{branch}}
 - **Status:** draft
+- **Execution state:** inactive
+- **Execution worktree:** None
+- **Execution reason:** None
 - **Issue:** {{issue_id}}
 - **Issue URL:** {{issue_url}}
+- **Revision:** 0
 
 ## Intent
 
@@ -44,4 +48,8 @@
 
 ## References
 
-<!-- Add repository or external references. Record one completed Plan Reviewer round per authoring cycle: reviewed file hashes, Git state, verdict and findings; each finding's disposition; post-fix structural verification and current snapshot. A repaired BLOCKING verdict is not a reviewer PASS. Keep DRAFT until explicit finalize/go. -->
+<!-- Add repository or external references before Feedback. -->
+
+### Feedback
+
+<!-- Capture pending user feedback before an update. Archive the complete plan and numbered briefs before substantive edits, then increment Revision exactly once and address or disposition the feedback. -->

package/templates/review/draft-pr.md

@@ -4,22 +4,16 @@
 
 ## Changes
 
-<!-- List the user-visible or architectural changes. -->
+{{changes}}
 
 ## Validation
 
-<!-- List the checks that were run. -->
-
-- [ ] Existing tests pass
+{{validation}}
 
 ## References
 
-<!-- Link the issue that defines this task. Add related project, epic, and public documentation links when available. -->
-
 - Issue: {{issue_url}}
 
 ## Further Work
 
-<!-- Optional: list intentionally deferred follow-up work as bullets, or remove this section. -->
-
--
+{{further_work}}

package/dist/cli/plan.d.ts

@@ -1,17 +0,0 @@
-import { Command } from 'commander';
-export interface PlanCliIO {
-    stdout: Pick<NodeJS.WriteStream, 'write'>;
-    stderr: Pick<NodeJS.WriteStream, 'write'>;
-}
-interface PlanCliRuntime {
-    execute: (command: string, args: string[], cwd: string, interactive: boolean) => Promise<{
-        code: number;
-        stdout: string;
-        stderr: string;
-    }>;
-}
-export declare function createPlanCliCommand(io?: PlanCliIO, planRuntime?: PlanCliRuntime): Command;
-export declare function runPlanCli(args: string[], io?: PlanCliIO): Promise<number>;
-export declare function planCliHelp(): string;
-export {};
-//# sourceMappingURL=plan.d.ts.map

package/dist/cli/plan.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"plan.d.ts","sourceRoot":"","sources":["../../src/cli/plan.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAkB,MAAM,WAAW,CAAC;AAKpD,MAAM,WAAW,SAAS;IACxB,MAAM,EAAE,IAAI,CAAC,MAAM,CAAC,WAAW,EAAE,OAAO,CAAC,CAAC;IAC1C,MAAM,EAAE,IAAI,CAAC,MAAM,CAAC,WAAW,EAAE,OAAO,CAAC,CAAC;CAC3C;AAED,UAAU,cAAc;IACtB,OAAO,EAAE,CACP,OAAO,EAAE,MAAM,EACf,IAAI,EAAE,MAAM,EAAE,EACd,GAAG,EAAE,MAAM,EACX,WAAW,EAAE,OAAO,KACjB,OAAO,CAAC;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,MAAM,EAAE,MAAM,CAAC;QAAC,MAAM,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;CAChE;AAMD,wBAAgB,oBAAoB,CAAC,EAAE,GAAE,SAAmB,EAAE,WAAW,GAAE,cAAwB,GAAG,OAAO,CA0B5G;AAED,wBAAsB,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,GAAE,SAAmB,GAAG,OAAO,CAAC,MAAM,CAAC,CASzF;AAED,wBAAgB,WAAW,IAAI,MAAM,CAEpC"}

package/dist/cli.d.ts

@@ -1,4 +0,0 @@
-#!/usr/bin/env node
-import { type PlanCliIO } from './cli/plan';
-export declare function main(argv?: string[], io?: PlanCliIO): Promise<number>;
-//# sourceMappingURL=cli.d.ts.map

package/dist/cli.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"cli.d.ts","sourceRoot":"","sources":["../src/cli.ts"],"names":[],"mappings":";AAGA,OAAO,EAAwB,KAAK,SAAS,EAAE,MAAM,YAAY,CAAC;AAElE,wBAAsB,IAAI,CAAC,IAAI,WAAwB,EAAE,EAAE,GAAE,SAAmB,GAAG,OAAO,CAAC,MAAM,CAAC,CAkBjG"}