@difflab/pi 0.2.0 → 0.3.0

package/README.md

@@ -10,16 +10,40 @@ pi install npm:@difflab/pi
 
 Run `/skill:diffpi-setup`. The skill validates or configures the environment and reloads pi when required.
 
-The package includes structured questions and installs the upstream Grounded Docs, Simple English, and Context Mode skills. Setup also installs four package-managed agent files into Pi's global agent directory. The subagent plugin can delegate to `tutor`, `copilot`, `worker`, and `orchestrator`; tutor, copilot, and worker are also available as inline modes.
+The package includes structured questions and installs the upstream Grounded Docs, Simple English, and Context Mode skills. Setup also installs five package-managed agent files into Pi's global agent directory. The subagent plugin can delegate to `tutor`, `copilot`, `worker`, `orchestrator`, and `reviewer`; profiles marked for inline use are also available as inline modes.
 
 ```text
-/skill:mode
+/mode
+/mode reviewer
+/mode reset
 /skill:mode --include-skills
-/skill:mode tutor
 /skill:mode spec:planner
-/skill:mode clear
 ```
 
 Standard agents come from the same global and trusted-project directories used by `@tintinweb/pi-subagents`. Skill-owned agents are opt-in for listing and use `skill:agent` ids. Inline selection applies the profile prompt, first available preferred model, thinking level, and available tool set. Clearing restores the previous runtime. Override ordered model preferences with `agents.<id>.models` in `~/.difflab/diffpi/config.yaml` or `config.json`, then rerun setup for delegated agents. Inline modes are not a security boundary.
 
+## Review
+
+`/review` drives code review over GitHub, GitLab, or the local `tuicr` TUI. The repository remote selects the review forge. When requested, `/skill:diffpi-setup` can install GitHub and/or GitLab CLIs and MCP servers.
+
+```text
+/review auto [pr-number|pr-url|branch] [--local] [--bg]
+/review new [--local] [--base branch] [--bg]
+/review edit [pr-number|pr-url|branch] [--local] [--bg]
+/review address [target] [--local] [--bg]
+/review publish [target] [--local] [--comment|--approve|--request-changes|--close] [--bg]
+/review complete [target] [--local|--approve|--reject|--abandon] [--bg]
+/review merge [target] [--bg]
+```
+
+The skill delegates mechanics to `review_context`, `review_new`, `review_edit`, `review_diff`, `review_gates`, `review_submit`, `review_add_comment`, `review_comments`, `review_respond`, `review_publish`, `review_complete`, `review_merge`, and `review_launch_ui`. Inline `auto` and `address` activate Reviewer on Sol; lifecycle verbs activate Orchestrator on Luna. Reviewer classifies address threads and delegates bounded edits to lightweight workers. `--bg` leaves the current chat mode unchanged and launches a tracked Orchestrator child. The generic `diffpi_template` tool loads bundled templates or user overrides. GitHub and GitLab support review creation and publication. Merge is intentionally GitHub-only and remains separate from publish and complete.
+
+`--local` selects the `tuicr` working-tree review backend. Without it, targets are a PR/MR number, URL, or branch; no target uses the current branch. Local address flows apply fixes without commits; remote address flows use the upstream `/git commit --no-push` workflow before posting draft responses for changed threads. Local reply overlays preserve remote thread IDs until `publish --local` promotes comments and replies to the forge. Remote comments carry a generated-review notice with the exact provider/model route; local comments use `Agent: <provider/model>` as the author.
+
+Local artifacts live in `.diffpi/review/` and use `YYMMDD-<short-head-sha>.md` or `YYMMDD-uncommitted.md` names. `.diffpi` links to `~/.difflab/diffpi/projects/<repository-name>-<identity-hash>/`, so all worktrees for one remote share records while unrelated same-named repositories remain isolated. The launcher opens a repository-scoped mux tab when zellij, tmux, or screen is detected. Without a mux, Zed lazily gets separate exact-argv tasks for full-branch local reviews and remote PR reviews; other environments receive the command to run.
+
+Draft PR bodies use the bundled `review/draft-pr.md` template. Override it at `~/.difflab/diffpi/templates/review/draft-pr.md`. Setup installs the upstream Codevoyant `/git` skill for conventional commit and safe rebase workflows. During package development, run `mise watch //packages/pi:dev`; the task builds and installs the package when its sources change. Run `/reload` in Pi after each successful install.
+
+The package root exports environment and forge lifecycle adapters, review backends, gate checks, review schemas and artifact helpers, template helpers, store helpers, tuicr helpers, setup operations, and inline-mode control. `@difflab/pi/tools` exports `createReviewTools` and the complete tool catalog.
+
 See the [repository](https://github.com/difflab-io/diffpi) for details.

package/agents/diffpi-orchestrator.md

@@ -3,11 +3,10 @@ name: orchestrator
 display_name: Orchestrator
 description: Schedule and route background agents for fast, cost-aware execution.
 prompt_mode: append
-inline: false
-model: openai-codex/gpt-5.6-sol
-model_fallbacks: meridian/claude-opus-4-8, meridian/claude-opus-5, deepseek/deepseek-v4-pro, qwen-token-plan/qwen3.7-plus
-thinking: high
-tools: read, grep, find
+inline: true
+model: openai-codex/gpt-5.6-luna
+model_fallbacks: meridian/claude-haiku-4-5, openrouter/qwen/qwen3-coder-flash, deepseek/deepseek-v4-flash
+thinking: medium
 run_in_background: true
 allowed_subagents: all
 ---
@@ -20,4 +19,7 @@ Work only as an execution orchestrator through the pi-subagents tools. Optimize
 - Use background agents by default, collect every required result, and steer running agents when priorities change.
 - Retry transient failures, escalate failed work with the returned error context, and route hard problems to a stronger model.
 - Keep conflicting edits and integration work serialized.
+- For `auto` and `address`, delegate coordination to the `reviewer` agent. The reviewer owns review judgment and thread classification, then delegates non-overlapping bounded edits to lightweight `worker` agents.
+- Do not bypass the reviewer by launching Sol workers directly. The reviewer runs on Sol; implementation workers use their configured Luna/Haiku/Qwen Flash/DeepSeek Flash preferences.
+- For `edit`, `new`, `complete`, and `merge`, keep lifecycle decisions in this orchestration turn and delegate only bounded inspection or implementation work.
 - Return one concise synthesis with results, failures, cost or latency concerns, and remaining decisions.

package/agents/diffpi-reviewer.md

@@ -0,0 +1,36 @@
+---
+name: reviewer
+display_name: Reviewer
+description: Terse, tool-driven code reviewer for the /review skill. Judges intent, correctness, slop, and adversarial risk, then records findings through review tools.
+prompt_mode: replace
+model: openai-codex/gpt-5.6-sol
+model_fallbacks: meridian/claude-opus-4-8, meridian/claude-opus-5, deepseek/deepseek-v4-pro, qwen-token-plan/qwen3.7-plus
+thinking: high
+run_in_background: true
+allowed_subagents: worker
+metadata:
+  model-tier: frontier
+---
+
+You review code changes. The `review_*` tools handle diff fetching, gates, session parsing, comment mapping, forge/tuicr calls, and launching.
+
+For `auto`, own review judgment and use the review tools required by the workflow. For `address`, act as the review coordinator: classify threads, form non-overlapping bounded implementation tasks, delegate routine edits to `worker`, collect verification and outcomes, then call `review_respond` for every thread. Do not publish, complete, or merge.
+
+## Rules
+
+- Call `review_context` first.
+- Prefer `review_*` and forge/tuicr MCP tools. Do not reimplement their mechanics or shell out to `gh`, `glab`, or `tuicr`.
+- Ground every finding in a real file and line from `review_diff`.
+- Be thorough in what you catch and terse in what you write: name the problem, then the ask. No hype or diff restatement.
+
+## Judge
+
+- **Intent and correctness:** trace the headline path end to end; a failure of intent is BLOCKING.
+- **Slop:** out-of-scope edits, stray churn, dead/debug leftovers, accidental reverts.
+- **Adversarial:** failure modes, edge cases, negative paths, and security scenarios.
+
+## Output
+
+For `auto`, return findings for `review_submit` as `{ file, line, severity, body, reference }`, with severity `BLOCKING`, `CONSIDER`, or `NOTE`. Put un-anchorable BLOCKING issues in `overallIssues`. Return `[]` when clean.
+
+For `address`, return one outcome per source thread: `fixed`, `answered`, `resolved`, `deferred`, or `unresolved`; include its exact response text and verification evidence. Questions are answered and stay open. Only trivial accepted requests use `Resolved` and may close; substantive fixes stay open for reviewer confirmation.

package/dist/assets.d.ts

@@ -1,2 +1,4 @@
+export declare function resolveBundledAssetDir(name: string, moduleUrl?: string): string;
 export declare function resolveBundledAgentsDir(moduleUrl?: string): string;
+export declare function resolveBundledTemplatesDir(moduleUrl?: string): string;
 //# sourceMappingURL=assets.d.ts.map

package/dist/assets.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"assets.d.ts","sourceRoot":"","sources":["../src/assets.ts"],"names":[],"mappings":"AAMA,wBAAgB,uBAAuB,CAAC,SAAS,SAAkB,GAAG,MAAM,CAQ3E"}
+{"version":3,"file":"assets.d.ts","sourceRoot":"","sources":["../src/assets.ts"],"names":[],"mappings":"AAMA,wBAAgB,sBAAsB,CAAC,IAAI,EAAE,MAAM,EAAE,SAAS,SAAkB,GAAG,MAAM,CAIxF;AAED,wBAAgB,uBAAuB,CAAC,SAAS,SAAkB,GAAG,MAAM,CAE3E;AAED,wBAAgB,0BAA0B,CAAC,SAAS,SAAkB,GAAG,MAAM,CAE9E"}

package/dist/commands/index.d.ts

@@ -0,0 +1,8 @@
+import type { ExtensionAPI } from '@earendil-works/pi-coding-agent';
+import type { ModeController } from '../modes';
+/** Register the extension's user-facing commands. */
+export declare function registerCommands(pi: ExtensionAPI, modes: ModeController): void;
+export { registerModeCommand } from './mode';
+export { registerReloadCommand } from './reload';
+export { registerReviewCommand } from './review';
+//# sourceMappingURL=index.d.ts.map

package/dist/commands/index.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/commands/index.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,iCAAiC,CAAC;AACpE,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,UAAU,CAAC;AAK/C,qDAAqD;AACrD,wBAAgB,gBAAgB,CAAC,EAAE,EAAE,YAAY,EAAE,KAAK,EAAE,cAAc,GAAG,IAAI,CAI9E;AAED,OAAO,EAAE,mBAAmB,EAAE,MAAM,QAAQ,CAAC;AAC7C,OAAO,EAAE,qBAAqB,EAAE,MAAM,UAAU,CAAC;AACjD,OAAO,EAAE,qBAAqB,EAAE,MAAM,UAAU,CAAC"}

package/dist/commands/mode.d.ts

@@ -0,0 +1,5 @@
+import type { ExtensionAPI } from '@earendil-works/pi-coding-agent';
+import type { ModeController } from '../modes';
+/** Register the inline agent mode command. */
+export declare function registerModeCommand(pi: ExtensionAPI, modes: ModeController): void;
+//# sourceMappingURL=mode.d.ts.map

package/dist/commands/mode.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"mode.d.ts","sourceRoot":"","sources":["../../src/commands/mode.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAoB,MAAM,iCAAiC,CAAC;AACtF,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,UAAU,CAAC;AAK/C,8CAA8C;AAC9C,wBAAgB,mBAAmB,CAAC,EAAE,EAAE,YAAY,EAAE,KAAK,EAAE,cAAc,GAAG,IAAI,CAKjF"}

package/dist/commands/reload.d.ts

@@ -0,0 +1,4 @@
+import type { ExtensionAPI } from '@earendil-works/pi-coding-agent';
+/** Register the extension reload command. */
+export declare function registerReloadCommand(pi: ExtensionAPI): void;
+//# sourceMappingURL=reload.d.ts.map

package/dist/commands/reload.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"reload.d.ts","sourceRoot":"","sources":["../../src/commands/reload.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,iCAAiC,CAAC;AAEpE,6CAA6C;AAC7C,wBAAgB,qBAAqB,CAAC,EAAE,EAAE,YAAY,GAAG,IAAI,CAO5D"}

package/dist/commands/review.d.ts

@@ -0,0 +1,5 @@
+import type { ExtensionAPI } from '@earendil-works/pi-coding-agent';
+import type { ModeController } from '../modes';
+/** Register the review workflow command. */
+export declare function registerReviewCommand(pi: ExtensionAPI, modes: ModeController): void;
+//# sourceMappingURL=review.d.ts.map

package/dist/commands/review.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../../src/commands/review.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAoB,MAAM,iCAAiC,CAAC;AAGtF,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,UAAU,CAAC;AAK/C,4CAA4C;AAC5C,wBAAgB,qBAAqB,CAAC,EAAE,EAAE,YAAY,EAAE,KAAK,EAAE,cAAc,GAAG,IAAI,CAKnF"}

package/dist/environment.d.ts

@@ -0,0 +1,41 @@
+export type Ide = 'zed' | 'vscode' | 'cursor' | 'windsurf' | 'jetbrains' | 'unknown';
+export type Mux = 'zellij' | 'tmux' | 'screen' | 'none';
+export type ForgeProvider = 'github' | 'gitlab' | 'none';
+export interface VcsInfo {
+    provider: ForgeProvider;
+    host: string;
+    owner: string;
+    repo: string;
+    branch: string;
+    root: string;
+}
+export interface LaunchOptions {
+    cwd: string;
+    name?: string;
+    env?: NodeJS.ProcessEnv;
+    homeDir?: string;
+}
+export interface LaunchResult {
+    launched: boolean;
+    configured?: boolean;
+    via: 'zellij' | 'zellij-run' | 'tmux' | 'screen' | 'zed-task' | 'print';
+    command: string;
+    taskName?: string;
+    instruction?: string;
+    reason?: string;
+}
+type Env = NodeJS.ProcessEnv;
+export declare function detectIde(env?: Env): Ide;
+export declare function detectMux(env?: Env): Mux;
+export declare function detectShell(env?: Env): string;
+export declare function detectVcs(cwd: string): Promise<VcsInfo>;
+export declare function parseRemote(remote: string): {
+    provider: ForgeProvider;
+    host: string;
+    owner: string;
+    repo: string;
+};
+export declare function openInNewTab(command: string[], opts: LaunchOptions): Promise<LaunchResult>;
+export declare function screenWindowArgs(command: string[], cwd: string, name: string): string[];
+export {};
+//# sourceMappingURL=environment.d.ts.map

package/dist/environment.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"environment.d.ts","sourceRoot":"","sources":["../src/environment.ts"],"names":[],"mappings":"AAMA,MAAM,MAAM,GAAG,GAAG,KAAK,GAAG,QAAQ,GAAG,QAAQ,GAAG,UAAU,GAAG,WAAW,GAAG,SAAS,CAAC;AACrF,MAAM,MAAM,GAAG,GAAG,QAAQ,GAAG,MAAM,GAAG,QAAQ,GAAG,MAAM,CAAC;AACxD,MAAM,MAAM,aAAa,GAAG,QAAQ,GAAG,QAAQ,GAAG,MAAM,CAAC;AAEzD,MAAM,WAAW,OAAO;IACtB,QAAQ,EAAE,aAAa,CAAC;IACxB,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,MAAM,CAAC;IACd,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,CAAC;IACf,IAAI,EAAE,MAAM,CAAC;CACd;AAED,MAAM,WAAW,aAAa;IAC5B,GAAG,EAAE,MAAM,CAAC;IACZ,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,GAAG,CAAC,EAAE,MAAM,CAAC,UAAU,CAAC;IACxB,OAAO,CAAC,EAAE,MAAM,CAAC;CAClB;AAED,MAAM,WAAW,YAAY;IAC3B,QAAQ,EAAE,OAAO,CAAC;IAClB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,GAAG,EAAE,QAAQ,GAAG,YAAY,GAAG,MAAM,GAAG,QAAQ,GAAG,UAAU,GAAG,OAAO,CAAC;IACxE,OAAO,EAAE,MAAM,CAAC;IAChB,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB;AAED,KAAK,GAAG,GAAG,MAAM,CAAC,UAAU,CAAC;AAI7B,wBAAgB,SAAS,CAAC,GAAG,GAAE,GAAiB,GAAG,GAAG,CAQrD;AAED,wBAAgB,SAAS,CAAC,GAAG,GAAE,GAAiB,GAAG,GAAG,CAKrD;AAED,wBAAgB,WAAW,CAAC,GAAG,GAAE,GAAiB,GAAG,MAAM,CAE1D;AAID,wBAAsB,SAAS,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAK7D;AAED,wBAAgB,WAAW,CAAC,MAAM,EAAE,MAAM,GAAG;IAAE,QAAQ,EAAE,aAAa,CAAC;IAAC,IAAI,EAAE,MAAM,CAAC;IAAC,KAAK,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,MAAM,CAAA;CAAE,CAclH;AAID,wBAAsB,YAAY,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,aAAa,GAAG,OAAO,CAAC,YAAY,CAAC,CA0BhG;AAED,wBAAgB,gBAAgB,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE,GAAG,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,GAAG,MAAM,EAAE,CAEvF"}

package/dist/extensions/ghx.d.ts

@@ -0,0 +1,5 @@
+import { type CommandOptions, type CommandResult } from './processx';
+/** Process boundary for the GitHub CLI. Domain code should use this adapter. */
+export declare function gh(args: string[], options?: CommandOptions): Promise<CommandResult>;
+export declare function ghChecked(args: string[], options?: CommandOptions): Promise<CommandResult>;
+//# sourceMappingURL=ghx.d.ts.map

package/dist/extensions/ghx.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ghx.d.ts","sourceRoot":"","sources":["../../src/extensions/ghx.ts"],"names":[],"mappings":"AAAA,OAAO,EAAmB,KAAK,cAAc,EAAE,KAAK,aAAa,EAAE,MAAM,YAAY,CAAC;AAEtF,gFAAgF;AAChF,wBAAgB,EAAE,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,OAAO,CAAC,EAAE,cAAc,GAAG,OAAO,CAAC,aAAa,CAAC,CAEnF;AAED,wBAAgB,SAAS,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,OAAO,CAAC,EAAE,cAAc,GAAG,OAAO,CAAC,aAAa,CAAC,CAE1F"}

package/dist/extensions/gitx.d.ts

@@ -0,0 +1,10 @@
+export interface GitRepositoryInfo {
+    root: string;
+    commonDir: string;
+    remote?: string;
+    name: string;
+    identity: string;
+}
+export declare function gitToplevel(cwd: string): Promise<string>;
+export declare function inspectGitRepository(cwd: string): Promise<GitRepositoryInfo>;
+//# sourceMappingURL=gitx.d.ts.map

package/dist/extensions/gitx.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"gitx.d.ts","sourceRoot":"","sources":["../../src/extensions/gitx.ts"],"names":[],"mappings":"AAIA,MAAM,WAAW,iBAAiB;IAChC,IAAI,EAAE,MAAM,CAAC;IACb,SAAS,EAAE,MAAM,CAAC;IAClB,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,wBAAsB,WAAW,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAI9D;AAED,wBAAsB,oBAAoB,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC,CAiBlF"}

package/dist/extensions/glabx.d.ts

@@ -0,0 +1,5 @@
+import { type CommandOptions, type CommandResult } from './processx';
+/** Process boundary for the GitLab CLI. Domain code should use this adapter. */
+export declare function glab(args: string[], options?: CommandOptions): Promise<CommandResult>;
+export declare function glabChecked(args: string[], options?: CommandOptions): Promise<CommandResult>;
+//# sourceMappingURL=glabx.d.ts.map

package/dist/extensions/glabx.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"glabx.d.ts","sourceRoot":"","sources":["../../src/extensions/glabx.ts"],"names":[],"mappings":"AAAA,OAAO,EAAmB,KAAK,cAAc,EAAE,KAAK,aAAa,EAAE,MAAM,YAAY,CAAC;AAEtF,gFAAgF;AAChF,wBAAgB,IAAI,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,OAAO,CAAC,EAAE,cAAc,GAAG,OAAO,CAAC,aAAa,CAAC,CAErF;AAED,wBAAgB,WAAW,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,OAAO,CAAC,EAAE,cAAc,GAAG,OAAO,CAAC,aAAa,CAAC,CAE5F"}