@diff-review-system/drs 4.0.1 → 4.1.0

package/.pi/agents/review/unified-reviewer.md

@@ -96,12 +96,8 @@ Follow these steps **in order** before reporting any issues:
 
 ## Output Requirements
 
-- You MUST call the `write_json_output` tool with:
-  - `outputType`: `"review_output"`
-  - `payload`: the JSON object described below
-  - After calling the tool, return **only** the JSON pointer returned by the tool
-    (e.g. `{"outputType":"review_output","outputPath":".drs/review-output.json"}`)
-- Do **not** return raw JSON directly.
+- Return **only** the raw JSON object described below.
+- Do **not** call `write_json_output`.
 - Do **not** include markdown, code fences, or extra text.
 - Follow this exact schema:
 

package/.pi/agents/task/review-assistant.md

@@ -0,0 +1,22 @@
+---
+description: Conversational assistant for DRS review and workflow artifacts
+color: "#2563eb"
+hidden: false
+tools:
+  Read: true
+  Glob: true
+  Grep: true
+---
+
+You are the conversational DRS review assistant.
+
+Users ask questions about DRS review output, workflow output, local diffs, and specific findings. Use the supplied artifacts as the source of truth. Cite finding ids, file paths, severities, and workflow names when they are available.
+
+## Rules
+
+- Prefer concise, direct answers grounded in the artifact content.
+- If the user asks why a finding matters, explain the risk and the smallest safe remediation.
+- If the user asks whether a finding is valid, inspect relevant repository context before answering when tools are available.
+- If the user asks for a fix, first state the intended scope and keep any changes minimal. Do not commit changes.
+- Do not invent findings or workflow results that are not present in the supplied artifacts.
+- If artifact context is missing, say what is missing and answer only from available repository context.

package/.pi/workflows/github-pr-fix-review-issues-stacked.yaml

@@ -1,5 +1,12 @@
 name: github-pr-fix-review-issues-stacked
 description: Fix high-severity GitHub PR review issues and open a stacked PR
+metadata:
+  kind: review
+  tags: [review, fix, github, pull-request]
+  review:
+    source: github-pr
+    diff: true
+    issues: true
 inputs:
   owner: ''
   repo: ''
@@ -37,7 +44,6 @@ nodes:
     if: '{{artifacts.stackGuard.allowed}} == true'
     with:
       source: change
-      artifact: persistedReviewArtifact
     output: review
 
   threshold:
@@ -70,7 +76,7 @@ nodes:
 
       Only fix findings at or above severity {{inputs.severity}} unless a lower-severity issue is directly required by such a fix.
 
-      Review artifact path: {{artifacts.persistedReviewArtifact.path}}
+      Review artifact path: {{artifacts.reviewArtifact.path}}
 
       Use the read_artifact tool with this path to get the finding manifest, then pull full details for specific findings by id. Do not assume the review JSON is in this prompt — call the tool.
 
@@ -121,7 +127,7 @@ nodes:
 
         Threshold: {{inputs.severity}}, minimum issues: {{inputs.minIssues}}
 
-        Review artifact: {{artifacts.persistedReviewArtifact.path}}
+        Review artifact: {{artifacts.reviewArtifact.path}}
 
         <!-- drs-stack-source: github:{{inputs.owner}}/{{inputs.repo}}#{{inputs.pr}} -->
         <!-- drs-stack-kind: fix -->
@@ -138,7 +144,7 @@ nodes:
       repo: '{{inputs.repo}}'
       pr: '{{inputs.pr}}'
       source: change
-      reviewArtifact: persistedReviewArtifact
+      reviewArtifact: reviewArtifact
       severity: '{{inputs.severity}}'
       stackedPrUrl: '{{artifacts.changeRequest.url}}'
       marker: drs-fix-status

package/.pi/workflows/github-pr-review-post.yaml

@@ -30,7 +30,6 @@ nodes:
       - describe
     with:
       source: change
-      artifact: persistedReviewArtifact
     output: review
 
   post-comments:

package/.pi/workflows/github-pr-review.yaml

@@ -1,5 +1,12 @@
 name: github-pr-review
 description: Review a GitHub pull request, optionally posting a description, DRS comments, a visual HTML explainer, and a stacked fix PR
+metadata:
+  kind: review
+  tags: [review, github, pull-request]
+  review:
+    source: github-pr
+    diff: true
+    issues: true
 inputs:
   owner:
     type: string
@@ -88,7 +95,6 @@ nodes:
       - change
     with:
       source: change
-      artifact: persistedReviewArtifact
     output: review
 
   visual:
@@ -166,7 +172,7 @@ nodes:
 
       Only fix findings at or above severity {{inputs.fixSeverity}} unless a lower-severity issue is directly required by such a fix.
 
-      Review artifact path: {{artifacts.persistedReviewArtifact.path}}
+      Review artifact path: {{artifacts.reviewArtifact.path}}
 
       Use the read_artifact tool with this path to get the finding manifest, then pull full details for specific findings by id. Do not assume the review JSON is in this prompt — call the tool.
 
@@ -213,7 +219,7 @@ nodes:
     if: inputs.fixMode == internal
     with:
       source: verificationChange
-      reviewArtifact: persistedReviewArtifact
+      reviewArtifact: reviewArtifact
       severity: '{{inputs.fixSeverity}}'
     output: reReview
 
@@ -224,12 +230,12 @@ nodes:
       - fix-change
     if: inputs.fixMode == internal
     with:
-      artifact: persistedReviewArtifact
+      artifact: reviewArtifact
       review: reReview
       fixChange: fixChange
       severity: '{{inputs.fixSeverity}}'
       minIssues: '1'
-    output: persistedReviewArtifact
+    output: reviewArtifact
 
   fix-loop:
     control: loop
@@ -252,7 +258,7 @@ nodes:
       repo: '{{inputs.repo}}'
       pr: '{{inputs.pr}}'
       source: change
-      reviewArtifact: persistedReviewArtifact
+      reviewArtifact: reviewArtifact
       fixReview: reReview
       fixChange: fixChange
       severity: '{{inputs.fixSeverity}}'
@@ -320,7 +326,7 @@ nodes:
         Automated DRS fix stacked on PR #{{inputs.pr}} from the main github-pr-review workflow.
 
         Threshold: {{inputs.fixSeverity}}, minimum issues: {{inputs.fixMinIssues}}
-        Review artifact: {{artifacts.persistedReviewArtifact.path}}
+        Review artifact: {{artifacts.reviewArtifact.path}}
 
         <!-- drs-stack-source: github:{{inputs.owner}}/{{inputs.repo}}#{{inputs.pr}} -->
         <!-- drs-stack-kind: fix -->
@@ -354,7 +360,7 @@ nodes:
       repo: '{{inputs.repo}}'
       pr: '{{inputs.pr}}'
       source: change
-      reviewArtifact: persistedReviewArtifact
+      reviewArtifact: reviewArtifact
       severity: '{{inputs.fixSeverity}}'
       stackedPrUrl: '{{artifacts.changeRequest.url}}'
       marker: drs-fix-status

package/.pi/workflows/github-pr-visual-explain.yaml

@@ -17,10 +17,31 @@ nodes:
       pr: '{{inputs.pr}}'
     output: change
 
-  visual:
+  review-artifact:
+    action: artifact-exists
+    needs:
+      - change
+    with:
+      kind: review
+      source: change
+    output: reviewArtifactStatus
+
+  load-review-artifact:
+    action: load-artifact
+    needs:
+      - review-artifact
+    if: artifacts.reviewArtifactStatus.exists == true
+    with:
+      kind: review
+      source: change
+    output: reviewArtifact
+
+  visual-with-review:
     agent: visual/pr-explainer
     needs:
       - change
+      - load-review-artifact
+    if: artifacts.reviewArtifactStatus.exists == true
     input: |
       Generate a visual PR explainer HTML artifact.
 
@@ -31,5 +52,29 @@ nodes:
 
       DRS change-source context:
       {{artifacts.change}}
+
+      Current DRS review artifact path: {{artifacts.reviewArtifact.path}}
+
+      Use the read_artifact tool with this path to include confirmed DRS findings in a clearly labeled section. Do not assume the review JSON is in this prompt.
+    writes: '{{inputs.outputPath}}'
+    output: visualExplainer
+
+  visual:
+    agent: visual/pr-explainer
+    needs:
+      - review-artifact
+    if: artifacts.reviewArtifactStatus.exists == false
+    input: |
+      Generate a visual PR explainer HTML artifact.
+
+      Output path: {{inputs.outputPath}}
+      Slide mode: {{inputs.slides}}
+
+      Use the supplied DRS change-source context. If important file diffs are omitted or summarized, use git_diff for those files before explaining them.
+
+      DRS change-source context:
+      {{artifacts.change}}
+
+      No current DRS review artifact exists for this PR. Label the artifact as a PR explainer with no DRS findings included.
     writes: '{{inputs.outputPath}}'
     output: visualExplainer

package/.pi/workflows/gitlab-mr-fix-review-issues-stacked.yaml

@@ -1,5 +1,12 @@
 name: gitlab-mr-fix-review-issues-stacked
 description: Fix high-severity GitLab MR review issues and open a stacked MR
+metadata:
+  kind: review
+  tags: [review, fix, gitlab, merge-request]
+  review:
+    source: gitlab-mr
+    diff: true
+    issues: true
 inputs:
   project: ''
   mr: ''
@@ -35,7 +42,6 @@ nodes:
     if: '{{artifacts.stackGuard.allowed}} == true'
     with:
       source: change
-      artifact: persistedReviewArtifact
     output: review
 
   threshold:
@@ -68,7 +74,7 @@ nodes:
 
       Only fix findings at or above severity {{inputs.severity}} unless a lower-severity issue is directly required by such a fix.
 
-      Review artifact path: {{artifacts.persistedReviewArtifact.path}}
+      Review artifact path: {{artifacts.reviewArtifact.path}}
 
       Use the read_artifact tool with this path to get the finding manifest, then pull full details for specific findings by id. Do not assume the review JSON is in this prompt — call the tool.
 
@@ -118,7 +124,7 @@ nodes:
 
         Threshold: {{inputs.severity}}, minimum issues: {{inputs.minIssues}}
 
-        Review artifact: {{artifacts.persistedReviewArtifact.path}}
+        Review artifact: {{artifacts.reviewArtifact.path}}
 
         <!-- drs-stack-source: gitlab:{{inputs.project}}!{{inputs.mr}} -->
         <!-- drs-stack-kind: fix -->
@@ -134,7 +140,7 @@ nodes:
       project: '{{inputs.project}}'
       mr: '{{inputs.mr}}'
       source: change
-      reviewArtifact: persistedReviewArtifact
+      reviewArtifact: reviewArtifact
       severity: '{{inputs.severity}}'
       stackedPrUrl: '{{artifacts.changeRequest.url}}'
       marker: drs-fix-status

package/.pi/workflows/gitlab-mr-review.yaml

@@ -1,5 +1,12 @@
 name: gitlab-mr-review
 description: Review a GitLab merge request, optionally posting a description, DRS comments, Code Quality, and a visual HTML explainer
+metadata:
+  kind: review
+  tags: [review, gitlab, merge-request]
+  review:
+    source: gitlab-mr
+    diff: true
+    issues: true
 inputs:
   project:
     type: string
@@ -82,7 +89,6 @@ nodes:
       - change
     with:
       source: change
-      artifact: persistedReviewArtifact
     output: review
 
   visual:
@@ -170,7 +176,7 @@ nodes:
 
       Only fix findings at or above severity {{inputs.fixSeverity}} unless a lower-severity issue is directly required by such a fix.
 
-      Review artifact path: {{artifacts.persistedReviewArtifact.path}}
+      Review artifact path: {{artifacts.reviewArtifact.path}}
 
       Use the read_artifact tool with this path to get the finding manifest, then pull full details for specific findings by id. Do not assume the review JSON is in this prompt — call the tool.
 
@@ -217,7 +223,7 @@ nodes:
     if: inputs.fixMode == internal
     with:
       source: verificationChange
-      reviewArtifact: persistedReviewArtifact
+      reviewArtifact: reviewArtifact
       severity: '{{inputs.fixSeverity}}'
     output: reReview
 
@@ -228,12 +234,12 @@ nodes:
       - fix-change
     if: inputs.fixMode == internal
     with:
-      artifact: persistedReviewArtifact
+      artifact: reviewArtifact
       review: reReview
       fixChange: fixChange
       severity: '{{inputs.fixSeverity}}'
       minIssues: '1'
-    output: persistedReviewArtifact
+    output: reviewArtifact
 
   fix-loop:
     control: loop
@@ -255,7 +261,7 @@ nodes:
       project: '{{inputs.project}}'
       mr: '{{inputs.mr}}'
       source: change
-      reviewArtifact: persistedReviewArtifact
+      reviewArtifact: reviewArtifact
       fixReview: reReview
       fixChange: fixChange
       severity: '{{inputs.fixSeverity}}'
@@ -322,7 +328,7 @@ nodes:
         Automated DRS fix stacked on MR !{{inputs.mr}} from the main gitlab-mr-review workflow.
 
         Threshold: {{inputs.fixSeverity}}, minimum issues: {{inputs.fixMinIssues}}
-        Review artifact: {{artifacts.persistedReviewArtifact.path}}
+        Review artifact: {{artifacts.reviewArtifact.path}}
 
         <!-- drs-stack-source: gitlab:{{inputs.project}}!{{inputs.mr}} -->
         <!-- drs-stack-kind: fix -->
@@ -354,7 +360,7 @@ nodes:
       project: '{{inputs.project}}'
       mr: '{{inputs.mr}}'
       source: change
-      reviewArtifact: persistedReviewArtifact
+      reviewArtifact: reviewArtifact
       severity: '{{inputs.fixSeverity}}'
       stackedPrUrl: '{{artifacts.changeRequest.url}}'
       marker: drs-fix-status

package/.pi/workflows/gitlab-mr-visual-explain.yaml

@@ -15,10 +15,31 @@ nodes:
       mr: '{{inputs.mr}}'
     output: change
 
-  visual:
+  review-artifact:
+    action: artifact-exists
+    needs:
+      - change
+    with:
+      kind: review
+      source: change
+    output: reviewArtifactStatus
+
+  load-review-artifact:
+    action: load-artifact
+    needs:
+      - review-artifact
+    if: artifacts.reviewArtifactStatus.exists == true
+    with:
+      kind: review
+      source: change
+    output: reviewArtifact
+
+  visual-with-review:
     agent: visual/pr-explainer
     needs:
       - change
+      - load-review-artifact
+    if: artifacts.reviewArtifactStatus.exists == true
     input: |
       Generate a visual MR explainer HTML artifact.
 
@@ -29,5 +50,29 @@ nodes:
 
       DRS change-source context:
       {{artifacts.change}}
+
+      Current DRS review artifact path: {{artifacts.reviewArtifact.path}}
+
+      Use the read_artifact tool with this path to include confirmed DRS findings in a clearly labeled section. Do not assume the review JSON is in this prompt.
+    writes: '{{inputs.outputPath}}'
+    output: visualExplainer
+
+  visual:
+    agent: visual/pr-explainer
+    needs:
+      - review-artifact
+    if: artifacts.reviewArtifactStatus.exists == false
+    input: |
+      Generate a visual MR explainer HTML artifact.
+
+      Output path: {{inputs.outputPath}}
+      Slide mode: {{inputs.slides}}
+
+      Use the supplied DRS change-source context. If important file diffs are omitted or summarized, use git_diff for those files before explaining them.
+
+      DRS change-source context:
+      {{artifacts.change}}
+
+      No current DRS review artifact exists for this MR. Label the artifact as an MR explainer with no DRS findings included.
     writes: '{{inputs.outputPath}}'
     output: visualExplainer

package/.pi/workflows/local-fix-review-issues.yaml

@@ -1,5 +1,12 @@
 name: local-fix-review-issues
 description: Fix actionable issues from a saved local DRS review artifact with verification loop
+metadata:
+  kind: review
+  tags: [review, fix, local]
+  review:
+    source: local
+    diff: true
+    issues: true
 inputs:
   review:
     type: string
@@ -14,7 +21,7 @@ inputs:
   fixMaxIterations:
     type: number
     default: 3
-output: persistedReviewArtifact
+output: reviewArtifact
 nodes:
   change:
     action: change-source
@@ -31,7 +38,7 @@ nodes:
       kind: review
       source: change
       id: '{{inputs.review}}'
-    output: persistedReviewArtifact
+    output: reviewArtifact
 
   fix-issues:
     agent: task/review-issue-fixer
@@ -42,7 +49,7 @@ nodes:
 
       Only fix findings at or above severity {{inputs.fixSeverity}} unless a lower-severity issue is directly required by such a fix.
 
-      Review artifact path: {{artifacts.persistedReviewArtifact.path}}
+      Review artifact path: {{artifacts.reviewArtifact.path}}
 
       Use the read_artifact tool with this path to get the finding manifest, then pull full details for specific findings by id. Do not assume the review JSON is in this prompt — call the tool.
 
@@ -77,7 +84,7 @@ nodes:
       - verification-change
     with:
       source: verificationChange
-      reviewArtifact: persistedReviewArtifact
+      reviewArtifact: reviewArtifact
       severity: '{{inputs.fixSeverity}}'
     output: reReview
 
@@ -88,12 +95,12 @@ nodes:
       - load-review-artifact
       - final-change
     with:
-      artifact: persistedReviewArtifact
+      artifact: reviewArtifact
       review: reReview
       fixChange: finalChange
       severity: '{{inputs.fixSeverity}}'
       minIssues: '1'
-    output: persistedReviewArtifact
+    output: reviewArtifact
 
   fix-loop:
     control: loop

package/.pi/workflows/local-review.yaml

@@ -1,5 +1,12 @@
 name: local-review
 description: Review local git diff
+metadata:
+  kind: review
+  tags: [review, local]
+  review:
+    source: local
+    diff: true
+    issues: true
 inputs:
   staged:
     type: boolean
@@ -20,5 +27,4 @@ nodes:
       - change
     with:
       source: change
-      artifact: persistedReviewArtifact
     output: review

package/.pi/workflows/local-visual-explain.yaml

@@ -13,10 +13,31 @@ nodes:
       staged: '{{inputs.staged}}'
     output: change
 
-  visual:
+  review-artifact:
+    action: artifact-exists
+    needs:
+      - change
+    with:
+      kind: review
+      source: change
+    output: reviewArtifactStatus
+
+  load-review-artifact:
+    action: load-artifact
+    needs:
+      - review-artifact
+    if: artifacts.reviewArtifactStatus.exists == true
+    with:
+      kind: review
+      source: change
+    output: reviewArtifact
+
+  visual-with-review:
     agent: visual/pr-explainer
     needs:
       - change
+      - load-review-artifact
+    if: artifacts.reviewArtifactStatus.exists == true
     input: |
       Generate a visual local-diff explainer HTML artifact.
 
@@ -27,5 +48,29 @@ nodes:
 
       DRS change-source context:
       {{artifacts.change}}
+
+      Current DRS review artifact path: {{artifacts.reviewArtifact.path}}
+
+      Use the read_artifact tool with this path to include confirmed DRS findings in a clearly labeled section. Do not assume the review JSON is in this prompt.
+    writes: '{{inputs.outputPath}}'
+    output: visualExplainer
+
+  visual:
+    agent: visual/pr-explainer
+    needs:
+      - review-artifact
+    if: artifacts.reviewArtifactStatus.exists == false
+    input: |
+      Generate a visual local-diff explainer HTML artifact.
+
+      Output path: {{inputs.outputPath}}
+      Slide mode: {{inputs.slides}}
+
+      Use the supplied DRS change-source context. If important file diffs are omitted or summarized, use git_diff for those files before explaining them.
+
+      DRS change-source context:
+      {{artifacts.change}}
+
+      No current DRS review artifact exists for this diff. Label the artifact as a diff explainer with no DRS findings included.
     writes: '{{inputs.outputPath}}'
     output: visualExplainer

package/.pi/workflows/temporal-control-smoke.yaml

@@ -0,0 +1,63 @@
+name: temporal-control-smoke
+description: Smoke test Temporal control-flow execution with safe local write actions
+inputs:
+  mode:
+    type: enum
+    values:
+      - loop
+      - pass
+      - end
+    default: loop
+    description: 'Control route to exercise: loop, passThrough, or end'
+output: final
+nodes:
+  start:
+    action: write
+    input: '{{inputs.mode}}'
+    writes: .drs/artifacts/temporal-smoke/start.txt
+    output: mode
+
+  route:
+    control: switch
+    needs:
+      - start
+    value: '{{artifacts.mode}}'
+    cases:
+      loop: loop-body
+      end: stop
+    default: pass
+
+  loop-body:
+    action: write
+    needs:
+      - route
+    input: 'loop body for {{artifacts.mode}}'
+    writes: .drs/artifacts/temporal-smoke/loop-body.txt
+    output: loopBody
+
+  again:
+    control: loop
+    needs:
+      - loop-body
+    if: 'true'
+    target: loop-body
+    exit: done
+    maxIterations: 2
+    onMaxIterations: exit
+
+  pass:
+    control: passThrough
+    needs:
+      - route
+    target: done
+
+  stop:
+    control: end
+    needs:
+      - route
+
+  done:
+    action: write
+    input: 'temporal control smoke complete via {{inputs.mode}}'
+    writes: .drs/artifacts/temporal-smoke/done.txt
+    output: final

package/README.md

@@ -519,6 +519,45 @@ workflow:
 
 See [docs/WORKFLOWS.md](docs/WORKFLOWS.md) for the full workflow configuration reference.
 
+### Temporal Execution (Experimental)
+
+DRS can dispatch workflows through Temporal. The workflow YAML remains the source of truth; DRS compiles it to a JSON plan, runs deterministic scheduling in a generic Temporal workflow, and executes workflow nodes as Temporal activities.
+
+Configure Temporal in `.drs/drs.config.yaml` when the defaults do not match your environment:
+
+```yaml
+temporal:
+  address: localhost:7233
+  namespace: default
+  taskQueue: drs-workflows
+  workflowIdPrefix: drs
+```
+
+Start a worker in the repository where node activities should execute:
+
+```bash
+drs temporal worker
+```
+
+Run a supported workflow through Temporal:
+
+```bash
+drs workflow run local-review --executor temporal
+drs workflow run github-pr-show-changes --executor temporal --input owner=octocat --input repo=hello-world --input pr=456
+drs workflow run local-review --executor temporal --no-wait
+drs workflow run local-review --executor temporal --trace
+```
+
+For a safe local smoke test that does not require model or platform credentials, run the packaged control-flow workflow:
+
+```bash
+drs workflow run temporal-control-smoke --executor temporal --input mode=loop
+drs workflow run temporal-control-smoke --executor temporal --input mode=pass
+drs workflow run temporal-control-smoke --executor temporal --input mode=end
+```
+
+Temporal mode is experimental. It supports DAG workflows and DRS control-flow nodes (`loop`, `switch`, `passThrough`, `end`), structured logs, workflow queries, cancellation state, trace artifacts, and side-effect retry safeguards. See [docs/TEMPORAL.md](docs/TEMPORAL.md) for worker deployment, Temporal UI troubleshooting, and opt-in smoke coverage. See [TEMPORAL_EXECUTION_PLAN.md](TEMPORAL_EXECUTION_PLAN.md) for the rollout plan.
+
 ### Configure Review Behavior
 
 Edit `.drs/drs.config.yaml`: