@diff-review-system/drs 4.0.0-rc.4 → 4.1.0

package/.pi/workflows/gitlab-mr-fix-review-issues-stacked.yaml

@@ -0,0 +1,150 @@
+name: gitlab-mr-fix-review-issues-stacked
+description: Fix high-severity GitLab MR review issues and open a stacked MR
+metadata:
+  kind: review
+  tags: [review, fix, gitlab, merge-request]
+  review:
+    source: gitlab-mr
+    diff: true
+    issues: true
+inputs:
+  project: ''
+  mr: ''
+  severity: 'high'
+  minIssues: '1'
+  branchPrefix: 'drs-fix/mr-'
+  allowStackedSource: 'false'
+  draft: 'false'
+output: changeRequest
+nodes:
+  change:
+    action: change-source
+    with:
+      type: gitlab-mr
+      project: '{{inputs.project}}'
+      mr: '{{inputs.mr}}'
+    output: change
+
+  guard:
+    action: stack-guard
+    needs:
+      - change
+    with:
+      source: change
+      allowStackedSource: '{{inputs.allowStackedSource}}'
+    output: stackGuard
+
+  review:
+    action: review
+    needs:
+      - change
+      - guard
+    if: '{{artifacts.stackGuard.allowed}} == true'
+    with:
+      source: change
+    output: review
+
+  threshold:
+    action: review-threshold
+    needs:
+      - review
+    with:
+      review: review
+      severity: '{{inputs.severity}}'
+      minIssues: '{{inputs.minIssues}}'
+    output: reviewThreshold
+
+  branch:
+    action: git-branch
+    needs:
+      - threshold
+    if: '{{artifacts.reviewThreshold.matched}} == true'
+    with:
+      name: '{{inputs.branchPrefix}}{{inputs.mr}}'
+      force: true
+    output: branch
+
+  fix-issues:
+    agent: task/review-issue-fixer
+    needs:
+      - branch
+      - review
+    input: |
+      Fix actionable issues from this DRS review artifact for GitLab MR !{{inputs.mr}}.
+
+      Only fix findings at or above severity {{inputs.severity}} unless a lower-severity issue is directly required by such a fix.
+
+      Review artifact path: {{artifacts.reviewArtifact.path}}
+
+      Use the read_artifact tool with this path to get the finding manifest, then pull full details for specific findings by id. Do not assume the review JSON is in this prompt — call the tool.
+
+      Current MR change source files (read these as needed):
+      {{artifacts.change.files}}
+
+      Use the drs_check tool after making changes to run configured validation checks before returning.
+    output: fixes
+
+  diff:
+    action: has-diff
+    needs:
+      - fix-issues
+    output: fixDiff
+
+  commit:
+    action: git-commit
+    needs:
+      - diff
+    if: '{{artifacts.fixDiff.changed}} == true'
+    with:
+      message: 'fix: address DRS review issues for MR !{{inputs.mr}}'
+      paths: '.'
+    output: commit
+
+  push:
+    action: git-push
+    needs:
+      - commit
+    with:
+      branch: '{{inputs.branchPrefix}}{{inputs.mr}}'
+    output: push
+
+  create:
+    action: create-change-request
+    needs:
+      - push
+    with:
+      platform: gitlab
+      project: '{{inputs.project}}'
+      sourceBranch: '{{inputs.branchPrefix}}{{inputs.mr}}'
+      targetBranch: '{{artifacts.change.context.pullRequest.sourceBranch}}'
+      title: 'fix: address DRS review issues for MR !{{inputs.mr}}'
+      draft: '{{inputs.draft}}'
+      body: |
+        Automated DRS fix stacked on MR !{{inputs.mr}}.
+
+        Threshold: {{inputs.severity}}, minimum issues: {{inputs.minIssues}}
+
+        Review artifact: {{artifacts.reviewArtifact.path}}
+
+        <!-- drs-stack-source: gitlab:{{inputs.project}}!{{inputs.mr}} -->
+        <!-- drs-stack-kind: fix -->
+    output: changeRequest
+
+  post-fix-status:
+    action: post-fix-status
+    needs:
+      - create
+      - review
+    with:
+      platform: gitlab
+      project: '{{inputs.project}}'
+      mr: '{{inputs.mr}}'
+      source: change
+      reviewArtifact: reviewArtifact
+      severity: '{{inputs.severity}}'
+      stackedPrUrl: '{{artifacts.changeRequest.url}}'
+      marker: drs-fix-status
+    output: fixStatus
+
+  done:
+    control: end

package/.pi/workflows/gitlab-mr-post-comment.yaml

@@ -1,17 +1,17 @@
 name: gitlab-mr-post-comment
 description: Post or update a GitLab merge request comment
 inputs:
-  project: ""
-  mr: ""
-  body: ""
-  marker: ""
+  project: ''
+  mr: ''
+  body: ''
+  marker: ''
 nodes:
   comment:
     action: post-comment
-    input: "{{inputs.body}}"
+    input: '{{inputs.body}}'
     with:
       platform: gitlab
-      project: "{{inputs.project}}"
-      mr: "{{inputs.mr}}"
-      marker: "{{inputs.marker}}"
+      project: '{{inputs.project}}'
+      mr: '{{inputs.mr}}'
+      marker: '{{inputs.marker}}'
     output: comment

package/.pi/workflows/gitlab-mr-review.yaml

@@ -1,17 +1,88 @@
 name: gitlab-mr-review
-description: Review a GitLab merge request
+description: Review a GitLab merge request, optionally posting a description, DRS comments, Code Quality, and a visual HTML explainer
+metadata:
+  kind: review
+  tags: [review, gitlab, merge-request]
+  review:
+    source: gitlab-mr
+    diff: true
+    issues: true
 inputs:
-  project: ""
-  mr: ""
+  project:
+    type: string
+    required: true
+    description: GitLab project path or id
+  mr:
+    type: number
+    required: true
+    description: Merge request IID
+  describe:
+    type: boolean
+    default: false
+  post:
+    type: boolean
+    default: false
+  visual:
+    type: boolean
+    default: false
+  fix:
+    type: boolean
+    default: false
+  fixMode:
+    type: enum
+    values: [stacked, internal]
+    default: stacked
+  fixSeverity:
+    type: enum
+    values: [critical, high, medium, low]
+    default: high
+  fixMinIssues:
+    type: number
+    default: 1
+  fixBranchPrefix:
+    type: string
+    default: drs-fix/mr-
+  fixCreateChangeRequest:
+    type: boolean
+    default: false
+  fixMaxIterations:
+    type: number
+    default: 3
+  allowStackedSource:
+    type: boolean
+    default: false
+  fixDraft:
+    type: boolean
+    default: false
+  visualOutputPath:
+    type: string
+    default: .drs/visual-mr-explainer.html
+  codeQuality:
+    type: boolean
+    default: false
+  codeQualityReport:
+    type: string
+    default: gl-code-quality-report.json
+output: review
 nodes:
   change:
     action: change-source
     with:
       type: gitlab-mr
-      project: "{{inputs.project}}"
-      mr: "{{inputs.mr}}"
+      project: '{{inputs.project}}'
+      mr: '{{inputs.mr}}'
     output: change
 
+  describe:
+    action: describe
+    needs:
+      - change
+    if: inputs.describe == true
+    with:
+      source: change
+      post: true
+    output: description
+
   review:
     action: review
     needs:
@@ -19,3 +90,281 @@ nodes:
     with:
       source: change
     output: review
+
+  visual:
+    agent: visual/pr-explainer
+    needs:
+      - change
+      - review
+    if: inputs.visual == true
+    input: |
+      Generate a visual MR explainer HTML artifact.
+
+      Output path: {{inputs.visualOutputPath}}
+      Slide mode: false
+
+      Use the supplied DRS change-source context. If important file diffs are omitted or summarized, use git_diff for those files before explaining them.
+
+      DRS change-source context:
+      {{artifacts.change}}
+
+      DRS review result:
+      {{artifacts.review}}
+    writes: '{{inputs.visualOutputPath}}'
+    output: visualExplainer
+
+  post-comments:
+    action: post-review-comments
+    needs:
+      - review
+    if: inputs.post == true
+    with:
+      source: change
+      review: review
+    output: postedReview
+
+  code-quality:
+    action: code-quality-report
+    needs:
+      - review
+    if: inputs.codeQuality == true
+    with:
+      review: review
+      path: '{{inputs.codeQualityReport}}'
+    output: codeQualityReport
+
+  stack-guard:
+    action: stack-guard
+    needs:
+      - change
+      - review
+    if: inputs.fix == true
+    with:
+      source: change
+      allowStackedSource: '{{inputs.allowStackedSource}}'
+    output: stackGuard
+
+  fix-threshold:
+    action: review-threshold
+    needs:
+      - review
+      - stack-guard
+    if: artifacts.stackGuard.allowed == true
+    with:
+      review: review
+      severity: '{{inputs.fixSeverity}}'
+      minIssues: '{{inputs.fixMinIssues}}'
+    output: reviewThreshold
+
+  fix-branch:
+    action: git-branch
+    needs:
+      - fix-threshold
+    if: artifacts.reviewThreshold.matched == true
+    with:
+      name: '{{inputs.fixBranchPrefix}}{{inputs.mr}}'
+      force: true
+    output: fixBranch
+
+  fix-issues:
+    agent: task/review-issue-fixer
+    needs:
+      - fix-branch
+      - review
+    input: |
+      Fix actionable issues from this DRS review artifact for GitLab MR !{{inputs.mr}}.
+
+      Only fix findings at or above severity {{inputs.fixSeverity}} unless a lower-severity issue is directly required by such a fix.
+
+      Review artifact path: {{artifacts.reviewArtifact.path}}
+
+      Use the read_artifact tool with this path to get the finding manifest, then pull full details for specific findings by id. Do not assume the review JSON is in this prompt — call the tool.
+
+      Current MR change source files (read these as needed):
+      {{artifacts.change.files}}
+
+      Use the drs_check tool after making changes to run configured validation checks before returning.
+    output: fixes
+
+  fix-change:
+    action: change-source
+    needs:
+      - fix-issues
+    if: inputs.fixMode == internal
+    with:
+      type: local
+      staged: false
+    output: fixChange
+
+  stage-fixes:
+    action: git-add
+    needs:
+      - fix-change
+    if: inputs.fixMode == internal
+    with:
+      paths: '.'
+    output: stagedFixes
+
+  verification-change:
+    action: change-source
+    needs:
+      - fix-change
+    if: inputs.fixMode == internal
+    with:
+      type: fix-verification
+      source: change
+      fixChange: fixChange
+    output: verificationChange
+
+  re-review:
+    action: review
+    needs:
+      - verification-change
+    if: inputs.fixMode == internal
+    with:
+      source: verificationChange
+      reviewArtifact: reviewArtifact
+      severity: '{{inputs.fixSeverity}}'
+    output: reReview
+
+  verify-fix:
+    action: verify-fix
+    needs:
+      - re-review
+      - fix-change
+    if: inputs.fixMode == internal
+    with:
+      artifact: reviewArtifact
+      review: reReview
+      fixChange: fixChange
+      severity: '{{inputs.fixSeverity}}'
+      minIssues: '1'
+    output: reviewArtifact
+
+  fix-loop:
+    control: loop
+    needs:
+      - verify-fix
+    if: artifacts.verify-fix.shouldContinue == true && inputs.fixMode == internal
+    target: fix-issues
+    exit: post-fix-status-internal
+    maxIterations: '{{inputs.fixMaxIterations}}'
+    onMaxIterations: exit
+
+  post-fix-status-internal:
+    action: post-fix-status
+    needs:
+      - verify-fix
+    if: inputs.fixMode == internal
+    with:
+      platform: gitlab
+      project: '{{inputs.project}}'
+      mr: '{{inputs.mr}}'
+      source: change
+      reviewArtifact: reviewArtifact
+      fixReview: reReview
+      fixChange: fixChange
+      severity: '{{inputs.fixSeverity}}'
+      marker: drs-fix-status
+    output: fixStatus
+
+  commit-internal-fix:
+    action: git-commit
+    needs:
+      - post-fix-status-internal
+    if: artifacts.verify-fix.fixFiles > 0
+    with:
+      message: 'fix: address DRS review issues for MR !{{inputs.mr}}'
+      paths: '.'
+    output: internalFixCommit
+
+  push-internal-fix:
+    action: git-push
+    needs:
+      - commit-internal-fix
+    with:
+      branch: HEAD
+      remoteBranch: '{{artifacts.change.context.pullRequest.sourceBranch}}'
+      setUpstream: false
+    output: internalFixPush
+
+  fix-diff:
+    action: has-diff
+    needs:
+      - fix-issues
+    if: inputs.fixMode != internal
+    output: fixDiff
+
+  fix-commit:
+    action: git-commit
+    needs:
+      - fix-diff
+    if: '{{artifacts.fixDiff.changed}} == true && {{inputs.fixCreateChangeRequest}} == true && {{inputs.fixMode}} != internal'
+    with:
+      message: 'fix: address DRS review issues for MR !{{inputs.mr}}'
+      paths: '.'
+    output: fixCommit
+
+  fix-push:
+    action: git-push
+    needs:
+      - fix-commit
+    with:
+      branch: '{{inputs.fixBranchPrefix}}{{inputs.mr}}'
+    output: fixPush
+
+  create-fix-mr:
+    action: create-change-request
+    needs:
+      - fix-push
+    with:
+      platform: gitlab
+      project: '{{inputs.project}}'
+      sourceBranch: '{{inputs.fixBranchPrefix}}{{inputs.mr}}'
+      targetBranch: '{{artifacts.change.context.pullRequest.sourceBranch}}'
+      title: 'fix: address DRS review issues for MR !{{inputs.mr}}'
+      draft: '{{inputs.fixDraft}}'
+      body: |
+        Automated DRS fix stacked on MR !{{inputs.mr}} from the main gitlab-mr-review workflow.
+
+        Threshold: {{inputs.fixSeverity}}, minimum issues: {{inputs.fixMinIssues}}
+        Review artifact: {{artifacts.reviewArtifact.path}}
+
+        <!-- drs-stack-source: gitlab:{{inputs.project}}!{{inputs.mr}} -->
+        <!-- drs-stack-kind: fix -->
+    output: changeRequest
+
+  notify-fix-mr:
+    action: post-comment
+    needs:
+      - create-fix-mr
+    with:
+      platform: gitlab
+      project: '{{inputs.project}}'
+      mr: '{{inputs.mr}}'
+      marker: drs-stacked-fix-notification
+    input: |
+      🔧 DRS created a stacked fix MR: {{artifacts.changeRequest.url}}
+
+      The fix addresses {{inputs.fixSeverity}}-priority review findings from this MR's review run.
+
+      <!-- drs-stacked-fix-notification -->
+
+  post-fix-status-stacked:
+    action: post-fix-status
+    needs:
+      - create-fix-mr
+      - review
+    with:
+      platform: gitlab
+      project: '{{inputs.project}}'
+      mr: '{{inputs.mr}}'
+      source: change
+      reviewArtifact: reviewArtifact
+      severity: '{{inputs.fixSeverity}}'
+      stackedPrUrl: '{{artifacts.changeRequest.url}}'
+      marker: drs-fix-status
+    output: fixStatus
+
+  done:
+    control: end

package/.pi/workflows/gitlab-mr-show-changes.yaml

@@ -1,16 +1,16 @@
 name: gitlab-mr-show-changes
 description: Show the review context for a GitLab merge request
 inputs:
-  project: ""
-  mr: ""
-  file: ""
+  project: ''
+  mr: ''
+  file: ''
 nodes:
   change:
     action: change-source
     with:
       type: gitlab-mr
-      project: "{{inputs.project}}"
-      mr: "{{inputs.mr}}"
+      project: '{{inputs.project}}'
+      mr: '{{inputs.mr}}'
     output: change
 
   context:
@@ -19,5 +19,5 @@ nodes:
       - change
     with:
       source: change
-      file: "{{inputs.file}}"
+      file: '{{inputs.file}}'
     output: reviewContext

package/.pi/workflows/gitlab-mr-update-agents-md-stacked.yaml

@@ -0,0 +1,100 @@
+name: gitlab-mr-update-agents-md-stacked
+description: Update agent guidance for a GitLab MR and open a stacked MR when warranted
+inputs:
+  project: ''
+  mr: ''
+  paths: 'AGENTS.md,CLAUDE.md,.github/copilot-instructions.md'
+  branchPrefix: 'drs-guidance/mr-'
+  allowStackedSource: 'false'
+  draft: 'false'
+output: changeRequest
+nodes:
+  change:
+    action: change-source
+    with:
+      type: gitlab-mr
+      project: '{{inputs.project}}'
+      mr: '{{inputs.mr}}'
+    output: change
+
+  guard:
+    action: stack-guard
+    needs:
+      - change
+    with:
+      source: change
+      allowStackedSource: '{{inputs.allowStackedSource}}'
+    output: stackGuard
+
+  branch:
+    action: git-branch
+    needs:
+      - guard
+    if: '{{artifacts.stackGuard.allowed}} == true'
+    with:
+      name: '{{inputs.branchPrefix}}{{inputs.mr}}'
+      force: true
+    output: branch
+
+  update-guidance:
+    agent: task/agents-md-updater
+    needs:
+      - change
+      - branch
+    input: |
+      Decide whether this GitLab MR warrants an update to repository coding-agent guidance.
+
+      Guidance paths to consider: {{inputs.paths}}
+
+      If no durable guidance update is warranted, leave files unchanged and say so.
+
+      GitLab MR change source:
+      {{artifacts.change}}
+    output: guidance
+
+  diff:
+    action: has-diff
+    needs:
+      - update-guidance
+    with:
+      paths: '{{inputs.paths}}'
+    output: guidanceDiff
+
+  commit:
+    action: git-commit
+    needs:
+      - diff
+    if: '{{artifacts.guidanceDiff.changed}} == true'
+    with:
+      message: 'docs: update agent guidance for MR !{{inputs.mr}}'
+      paths: '{{inputs.paths}}'
+    output: commit
+
+  push:
+    action: git-push
+    needs:
+      - commit
+    with:
+      branch: '{{inputs.branchPrefix}}{{inputs.mr}}'
+    output: push
+
+  create:
+    action: create-change-request
+    needs:
+      - push
+    with:
+      platform: gitlab
+      project: '{{inputs.project}}'
+      sourceBranch: '{{inputs.branchPrefix}}{{inputs.mr}}'
+      targetBranch: '{{artifacts.change.context.pullRequest.sourceBranch}}'
+      title: 'docs: update agent guidance for MR !{{inputs.mr}}'
+      draft: '{{inputs.draft}}'
+      body: |
+        Automated DRS guidance update stacked on MR !{{inputs.mr}}.
+
+        <!-- drs-stack-source: gitlab:{{inputs.project}}!{{inputs.mr}} -->
+        <!-- drs-stack-kind: guidance -->
+    output: changeRequest
+
+  done:
+    control: end