@diff-review-system/drs 4.0.0-rc.4 → 4.0.1

package/dist/lib/comment-manager.test.js

@@ -1,680 +0,0 @@
-import { describe, it, expect } from 'vitest';
-import { createIssueFingerprint, extractCommentId, extractIssueFingerprints, filterCriticalAndHigh, filterDuplicateIssues, findExistingSummaryComment, findExistingErrorComment, collectExistingFingerprints, prepareIssuesForPosting, BOT_COMMENT_ID, ERROR_COMMENT_ID, } from './comment-manager.js';
-describe('comment-manager', () => {
-    describe('createIssueFingerprint', () => {
-        it('should create fingerprint with line number', () => {
-            const issue = {
-                category: 'SECURITY',
-                severity: 'HIGH',
-                title: 'SQL Injection',
-                file: 'src/db.ts',
-                line: 42,
-                problem: 'Unsafe query',
-                solution: 'Use parameterized queries',
-                agent: 'security',
-            };
-            const fingerprint = createIssueFingerprint(issue);
-            expect(fingerprint).toBe('src/db.ts:42:SECURITY:SQL Injection');
-        });
-        it('should create fingerprint without line number', () => {
-            const issue = {
-                category: 'QUALITY',
-                severity: 'MEDIUM',
-                title: 'Code smell',
-                file: 'src/app.ts',
-                problem: 'Complex function',
-                solution: 'Refactor',
-                agent: 'quality',
-            };
-            const fingerprint = createIssueFingerprint(issue);
-            expect(fingerprint).toBe('src/app.ts:general:QUALITY:Code smell');
-        });
-        it('should create fingerprint with line 0 (treated as general)', () => {
-            const issue = {
-                category: 'STYLE',
-                severity: 'LOW',
-                title: 'Missing import',
-                file: 'src/utils.ts',
-                line: 0,
-                problem: 'Missing import',
-                solution: 'Add import',
-                agent: 'style',
-            };
-            const fingerprint = createIssueFingerprint(issue);
-            expect(fingerprint).toBe('src/utils.ts:general:STYLE:Missing import');
-        });
-        it('should create unique fingerprints for different issues', () => {
-            const issue1 = {
-                category: 'SECURITY',
-                severity: 'HIGH',
-                title: 'Issue 1',
-                file: 'file1.ts',
-                line: 10,
-                problem: 'Problem',
-                solution: 'Solution',
-                agent: 'security',
-            };
-            const issue2 = {
-                category: 'SECURITY',
-                severity: 'HIGH',
-                title: 'Issue 2',
-                file: 'file1.ts',
-                line: 10,
-                problem: 'Problem',
-                solution: 'Solution',
-                agent: 'security',
-            };
-            const fp1 = createIssueFingerprint(issue1);
-            const fp2 = createIssueFingerprint(issue2);
-            expect(fp1).not.toBe(fp2);
-        });
-    });
-    describe('extractCommentId', () => {
-        it('should extract comment ID from body', () => {
-            const body = 'Some text\n<!-- drs-comment-id: drs-review-summary -->\nMore text';
-            const id = extractCommentId(body);
-            expect(id).toBe('drs-review-summary');
-        });
-        it('should return null if no comment ID found', () => {
-            const body = 'Just some regular text without markers';
-            const id = extractCommentId(body);
-            expect(id).toBeNull();
-        });
-        it('should extract custom comment ID', () => {
-            const body = '<!-- drs-comment-id: custom-id-123 -->';
-            const id = extractCommentId(body);
-            expect(id).toBe('custom-id-123');
-        });
-        it('should handle multiple comment IDs and return first', () => {
-            const body = '<!-- drs-comment-id: first-id -->\n<!-- drs-comment-id: second-id -->';
-            const id = extractCommentId(body);
-            expect(id).toBe('first-id');
-        });
-    });
-    describe('extractIssueFingerprints', () => {
-        it('should extract single fingerprint', () => {
-            const body = 'Issue here\n<!-- issue-fp: src/app.ts:10:SECURITY:SQL Injection -->';
-            const fingerprints = extractIssueFingerprints(body);
-            expect(fingerprints.size).toBe(1);
-            expect(fingerprints.has('src/app.ts:10:SECURITY:SQL Injection')).toBe(true);
-        });
-        it('should extract multiple fingerprints', () => {
-            const body = `
-        <!-- issue-fp: src/app.ts:10:SECURITY:Issue 1 -->
-        Some text
-        <!-- issue-fp: src/db.ts:20:QUALITY:Issue 2 -->
-        More text
-        <!-- issue-fp: src/utils.ts:general:STYLE:Issue 3 -->
-      `;
-            const fingerprints = extractIssueFingerprints(body);
-            expect(fingerprints.size).toBe(3);
-            expect(fingerprints.has('src/app.ts:10:SECURITY:Issue 1')).toBe(true);
-            expect(fingerprints.has('src/db.ts:20:QUALITY:Issue 2')).toBe(true);
-            expect(fingerprints.has('src/utils.ts:general:STYLE:Issue 3')).toBe(true);
-        });
-        it('should return empty set if no fingerprints found', () => {
-            const body = 'Just regular text with no fingerprints';
-            const fingerprints = extractIssueFingerprints(body);
-            expect(fingerprints.size).toBe(0);
-        });
-        it('should handle duplicate fingerprints in same comment', () => {
-            const body = `
-        <!-- issue-fp: src/app.ts:10:SECURITY:Issue -->
-        <!-- issue-fp: src/app.ts:10:SECURITY:Issue -->
-      `;
-            const fingerprints = extractIssueFingerprints(body);
-            expect(fingerprints.size).toBe(1);
-        });
-    });
-    describe('filterCriticalAndHigh', () => {
-        it('should filter only CRITICAL issues', () => {
-            const issues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'CRITICAL',
-                    title: 'Critical issue',
-                    file: 'file.ts',
-                    line: 1,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'QUALITY',
-                    severity: 'MEDIUM',
-                    title: 'Medium issue',
-                    file: 'file.ts',
-                    line: 2,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'quality',
-                },
-            ];
-            const filtered = filterCriticalAndHigh(issues);
-            expect(filtered).toHaveLength(1);
-            expect(filtered[0].severity).toBe('CRITICAL');
-        });
-        it('should filter only HIGH issues', () => {
-            const issues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'HIGH',
-                    title: 'High issue',
-                    file: 'file.ts',
-                    line: 1,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'QUALITY',
-                    severity: 'LOW',
-                    title: 'Low issue',
-                    file: 'file.ts',
-                    line: 2,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'quality',
-                },
-            ];
-            const filtered = filterCriticalAndHigh(issues);
-            expect(filtered).toHaveLength(1);
-            expect(filtered[0].severity).toBe('HIGH');
-        });
-        it('should filter both CRITICAL and HIGH issues', () => {
-            const issues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'CRITICAL',
-                    title: 'Critical',
-                    file: 'file.ts',
-                    line: 1,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'SECURITY',
-                    severity: 'HIGH',
-                    title: 'High',
-                    file: 'file.ts',
-                    line: 2,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'QUALITY',
-                    severity: 'MEDIUM',
-                    title: 'Medium',
-                    file: 'file.ts',
-                    line: 3,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'quality',
-                },
-                {
-                    category: 'STYLE',
-                    severity: 'LOW',
-                    title: 'Low',
-                    file: 'file.ts',
-                    line: 4,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'style',
-                },
-            ];
-            const filtered = filterCriticalAndHigh(issues);
-            expect(filtered).toHaveLength(2);
-            expect(filtered.every((i) => i.severity === 'CRITICAL' || i.severity === 'HIGH')).toBe(true);
-        });
-        it('should return empty array if no critical/high issues', () => {
-            const issues = [
-                {
-                    category: 'QUALITY',
-                    severity: 'MEDIUM',
-                    title: 'Medium',
-                    file: 'file.ts',
-                    line: 1,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'quality',
-                },
-                {
-                    category: 'STYLE',
-                    severity: 'LOW',
-                    title: 'Low',
-                    file: 'file.ts',
-                    line: 2,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'style',
-                },
-            ];
-            const filtered = filterCriticalAndHigh(issues);
-            expect(filtered).toHaveLength(0);
-        });
-    });
-    describe('filterDuplicateIssues', () => {
-        it('should filter out duplicate issues', () => {
-            const issues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'HIGH',
-                    title: 'SQL Injection',
-                    file: 'src/db.ts',
-                    line: 42,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'QUALITY',
-                    severity: 'MEDIUM',
-                    title: 'Code smell',
-                    file: 'src/app.ts',
-                    line: 10,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'quality',
-                },
-            ];
-            const existingFingerprints = new Set(['src/db.ts:42:SECURITY:SQL Injection']);
-            const filtered = filterDuplicateIssues(issues, existingFingerprints);
-            expect(filtered).toHaveLength(1);
-            expect(filtered[0].title).toBe('Code smell');
-        });
-        it('should return all issues if no duplicates', () => {
-            const issues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'HIGH',
-                    title: 'Issue 1',
-                    file: 'file1.ts',
-                    line: 1,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'QUALITY',
-                    severity: 'MEDIUM',
-                    title: 'Issue 2',
-                    file: 'file2.ts',
-                    line: 2,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'quality',
-                },
-            ];
-            const existingFingerprints = new Set();
-            const filtered = filterDuplicateIssues(issues, existingFingerprints);
-            expect(filtered).toHaveLength(2);
-        });
-        it('should filter all issues if all are duplicates', () => {
-            const issues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'HIGH',
-                    title: 'Issue 1',
-                    file: 'file1.ts',
-                    line: 1,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'QUALITY',
-                    severity: 'MEDIUM',
-                    title: 'Issue 2',
-                    file: 'file2.ts',
-                    line: 2,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'quality',
-                },
-            ];
-            const existingFingerprints = new Set([
-                'file1.ts:1:SECURITY:Issue 1',
-                'file2.ts:2:QUALITY:Issue 2',
-            ]);
-            const filtered = filterDuplicateIssues(issues, existingFingerprints);
-            expect(filtered).toHaveLength(0);
-        });
-    });
-    describe('findExistingSummaryComment', () => {
-        it('should find summary comment with bot marker', () => {
-            const comments = [
-                { id: 1, body: 'Regular comment' },
-                {
-                    id: 2,
-                    body: `Review Summary\n<!-- drs-comment-id: ${BOT_COMMENT_ID} -->\nSummary text`,
-                },
-                { id: 3, body: 'Another comment' },
-            ];
-            const found = findExistingSummaryComment(comments);
-            expect(found).not.toBeNull();
-            expect(found?.id).toBe(2);
-        });
-        it('should return null if no summary comment exists', () => {
-            const comments = [
-                { id: 1, body: 'Regular comment 1' },
-                { id: 2, body: 'Regular comment 2' },
-            ];
-            const found = findExistingSummaryComment(comments);
-            expect(found).toBeNull();
-        });
-        it('should return first summary comment if multiple exist', () => {
-            const comments = [
-                {
-                    id: 1,
-                    body: `Summary 1\n<!-- drs-comment-id: ${BOT_COMMENT_ID} -->`,
-                },
-                {
-                    id: 2,
-                    body: `Summary 2\n<!-- drs-comment-id: ${BOT_COMMENT_ID} -->`,
-                },
-            ];
-            const found = findExistingSummaryComment(comments);
-            expect(found?.id).toBe(1);
-        });
-        it('should handle empty comments array', () => {
-            const comments = [];
-            const found = findExistingSummaryComment(comments);
-            expect(found).toBeNull();
-        });
-    });
-    describe('findExistingErrorComment', () => {
-        it('should find error comment with error marker', () => {
-            const comments = [
-                { id: 1, body: 'Regular comment' },
-                {
-                    id: 2,
-                    body: `Error!\n<!-- drs-comment-id: ${ERROR_COMMENT_ID} -->\nError details`,
-                },
-                { id: 3, body: 'Another comment' },
-            ];
-            const found = findExistingErrorComment(comments);
-            expect(found).not.toBeNull();
-            expect(found?.id).toBe(2);
-        });
-        it('should return null if no error comment exists', () => {
-            const comments = [
-                { id: 1, body: 'Regular comment 1' },
-                { id: 2, body: 'Regular comment 2' },
-                {
-                    id: 3,
-                    body: `Summary\n<!-- drs-comment-id: ${BOT_COMMENT_ID} -->`,
-                },
-            ];
-            const found = findExistingErrorComment(comments);
-            expect(found).toBeNull();
-        });
-        it('should return first error comment if multiple exist', () => {
-            const comments = [
-                {
-                    id: 1,
-                    body: `Error 1\n<!-- drs-comment-id: ${ERROR_COMMENT_ID} -->`,
-                },
-                {
-                    id: 2,
-                    body: `Error 2\n<!-- drs-comment-id: ${ERROR_COMMENT_ID} -->`,
-                },
-            ];
-            const found = findExistingErrorComment(comments);
-            expect(found?.id).toBe(1);
-        });
-        it('should handle empty comments array', () => {
-            const comments = [];
-            const found = findExistingErrorComment(comments);
-            expect(found).toBeNull();
-        });
-        it('should distinguish between error and summary comments', () => {
-            const comments = [
-                {
-                    id: 1,
-                    body: `Summary\n<!-- drs-comment-id: ${BOT_COMMENT_ID} -->`,
-                },
-                {
-                    id: 2,
-                    body: `Error\n<!-- drs-comment-id: ${ERROR_COMMENT_ID} -->`,
-                },
-            ];
-            const errorComment = findExistingErrorComment(comments);
-            const summaryComment = findExistingSummaryComment(comments);
-            expect(errorComment?.id).toBe(2);
-            expect(summaryComment?.id).toBe(1);
-        });
-    });
-    describe('collectExistingFingerprints', () => {
-        it('should collect fingerprints from multiple comments', () => {
-            const comments = [
-                {
-                    id: 1,
-                    body: `Issue 1\n<!-- issue-fp: file1.ts:10:SECURITY:Issue 1 -->`,
-                },
-                {
-                    id: 2,
-                    body: `Issue 2\n<!-- issue-fp: file2.ts:20:QUALITY:Issue 2 -->`,
-                },
-            ];
-            const fingerprints = collectExistingFingerprints(comments);
-            expect(fingerprints.size).toBe(2);
-            expect(fingerprints.has('file1.ts:10:SECURITY:Issue 1')).toBe(true);
-            expect(fingerprints.has('file2.ts:20:QUALITY:Issue 2')).toBe(true);
-        });
-        it('should collect multiple fingerprints from single comment', () => {
-            const comments = [
-                {
-                    id: 1,
-                    body: `
-            <!-- issue-fp: file1.ts:10:SECURITY:Issue 1 -->
-            <!-- issue-fp: file2.ts:20:QUALITY:Issue 2 -->
-            <!-- issue-fp: file3.ts:30:STYLE:Issue 3 -->
-          `,
-                },
-            ];
-            const fingerprints = collectExistingFingerprints(comments);
-            expect(fingerprints.size).toBe(3);
-        });
-        it('should deduplicate fingerprints across comments', () => {
-            const comments = [
-                {
-                    id: 1,
-                    body: `<!-- issue-fp: file1.ts:10:SECURITY:Issue -->`,
-                },
-                {
-                    id: 2,
-                    body: `<!-- issue-fp: file1.ts:10:SECURITY:Issue -->`,
-                },
-            ];
-            const fingerprints = collectExistingFingerprints(comments);
-            expect(fingerprints.size).toBe(1);
-        });
-        it('should return empty set for comments with no fingerprints', () => {
-            const comments = [
-                { id: 1, body: 'Regular comment 1' },
-                { id: 2, body: 'Regular comment 2' },
-            ];
-            const fingerprints = collectExistingFingerprints(comments);
-            expect(fingerprints.size).toBe(0);
-        });
-        it('should handle empty comments array', () => {
-            const comments = [];
-            const fingerprints = collectExistingFingerprints(comments);
-            expect(fingerprints.size).toBe(0);
-        });
-    });
-    describe('prepareIssuesForPosting', () => {
-        it('should filter and prepare issues correctly', () => {
-            const allIssues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'CRITICAL',
-                    title: 'New critical issue',
-                    file: 'file1.ts',
-                    line: 10,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'SECURITY',
-                    severity: 'HIGH',
-                    title: 'New high issue',
-                    file: 'file2.ts',
-                    line: 20,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'QUALITY',
-                    severity: 'MEDIUM',
-                    title: 'Medium issue',
-                    file: 'file3.ts',
-                    line: 30,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'quality',
-                },
-                {
-                    category: 'STYLE',
-                    severity: 'LOW',
-                    title: 'Low issue',
-                    file: 'file4.ts',
-                    line: 40,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'style',
-                },
-            ];
-            const existingComments = [];
-            const result = prepareIssuesForPosting(allIssues, existingComments);
-            expect(result.inlineIssues).toHaveLength(2);
-            expect(result.deduplicatedCount).toBe(0);
-            expect(result.nonInlineCount).toBe(2); // MEDIUM + LOW
-        });
-        it('should deduplicate existing issues', () => {
-            const allIssues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'CRITICAL',
-                    title: 'Existing issue',
-                    file: 'file1.ts',
-                    line: 10,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'SECURITY',
-                    severity: 'HIGH',
-                    title: 'New issue',
-                    file: 'file2.ts',
-                    line: 20,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-            ];
-            const existingComments = [
-                {
-                    id: 1,
-                    body: '<!-- issue-fp: file1.ts:10:SECURITY:Existing issue -->',
-                },
-            ];
-            const result = prepareIssuesForPosting(allIssues, existingComments);
-            expect(result.inlineIssues).toHaveLength(1);
-            expect(result.inlineIssues[0].title).toBe('New issue');
-            expect(result.deduplicatedCount).toBe(1);
-        });
-        it('should filter out issues without line numbers', () => {
-            const allIssues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'CRITICAL',
-                    title: 'With line',
-                    file: 'file1.ts',
-                    line: 10,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'SECURITY',
-                    severity: 'HIGH',
-                    title: 'Without line',
-                    file: 'file2.ts',
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-            ];
-            const existingComments = [];
-            const result = prepareIssuesForPosting(allIssues, existingComments);
-            expect(result.inlineIssues).toHaveLength(1);
-            expect(result.inlineIssues[0].title).toBe('With line');
-        });
-        it('should apply custom valid lines checker', () => {
-            const allIssues = [
-                {
-                    category: 'SECURITY',
-                    severity: 'CRITICAL',
-                    title: 'Valid line',
-                    file: 'file1.ts',
-                    line: 10,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-                {
-                    category: 'SECURITY',
-                    severity: 'HIGH',
-                    title: 'Invalid line',
-                    file: 'file2.ts',
-                    line: 999,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'security',
-                },
-            ];
-            const existingComments = [];
-            // Only allow lines <= 100
-            const validLinesChecker = (issue) => {
-                return issue.line !== undefined && issue.line <= 100;
-            };
-            const result = prepareIssuesForPosting(allIssues, existingComments, validLinesChecker);
-            expect(result.inlineIssues).toHaveLength(1);
-            expect(result.inlineIssues[0].title).toBe('Valid line');
-        });
-        it('should handle all issues being filtered out', () => {
-            const allIssues = [
-                {
-                    category: 'QUALITY',
-                    severity: 'MEDIUM',
-                    title: 'Medium issue',
-                    file: 'file1.ts',
-                    line: 10,
-                    problem: 'Problem',
-                    solution: 'Solution',
-                    agent: 'quality',
-                },
-            ];
-            const existingComments = [];
-            const result = prepareIssuesForPosting(allIssues, existingComments);
-            expect(result.inlineIssues).toHaveLength(0);
-            expect(result.nonInlineCount).toBe(1);
-            expect(result.deduplicatedCount).toBe(0);
-        });
-        it('should handle empty issues array', () => {
-            const allIssues = [];
-            const existingComments = [];
-            const result = prepareIssuesForPosting(allIssues, existingComments);
-            expect(result.inlineIssues).toHaveLength(0);
-            expect(result.nonInlineCount).toBe(0);
-            expect(result.deduplicatedCount).toBe(0);
-        });
-    });
-});
-//# sourceMappingURL=comment-manager.test.js.map