@diff-review-system/drs 2.2.1 → 3.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (240) hide show
  1. package/README.md +228 -92
  2. package/dist/ci/runner.d.ts.map +1 -1
  3. package/dist/ci/runner.js +19 -22
  4. package/dist/ci/runner.js.map +1 -1
  5. package/dist/cli/describe-mr.d.ts.map +1 -1
  6. package/dist/cli/describe-mr.js +39 -20
  7. package/dist/cli/describe-mr.js.map +1 -1
  8. package/dist/cli/describe-pr.d.ts.map +1 -1
  9. package/dist/cli/describe-pr.js +39 -20
  10. package/dist/cli/describe-pr.js.map +1 -1
  11. package/dist/cli/index.js +11 -7
  12. package/dist/cli/index.js.map +1 -1
  13. package/dist/cli/init.d.ts.map +1 -1
  14. package/dist/cli/init.js +30 -2
  15. package/dist/cli/init.js.map +1 -1
  16. package/dist/cli/post-comments.d.ts.map +1 -1
  17. package/dist/cli/post-comments.js +5 -5
  18. package/dist/cli/post-comments.js.map +1 -1
  19. package/dist/cli/review-local.d.ts.map +1 -1
  20. package/dist/cli/review-local.integration.test.d.ts +2 -0
  21. package/dist/cli/review-local.integration.test.d.ts.map +1 -0
  22. package/dist/cli/review-local.integration.test.js +343 -0
  23. package/dist/cli/review-local.integration.test.js.map +1 -0
  24. package/dist/cli/review-local.js +5 -4
  25. package/dist/cli/review-local.js.map +1 -1
  26. package/dist/cli/review-local.live.e2e.test.d.ts +2 -0
  27. package/dist/cli/review-local.live.e2e.test.d.ts.map +1 -0
  28. package/dist/cli/review-local.live.e2e.test.js +154 -0
  29. package/dist/cli/review-local.live.e2e.test.js.map +1 -0
  30. package/dist/cli/review-local.test.d.ts +2 -0
  31. package/dist/cli/review-local.test.d.ts.map +1 -0
  32. package/dist/cli/review-local.test.js +164 -0
  33. package/dist/cli/review-local.test.js.map +1 -0
  34. package/dist/cli/review-mr.d.ts +1 -1
  35. package/dist/cli/review-mr.d.ts.map +1 -1
  36. package/dist/cli/review-mr.js +92 -17
  37. package/dist/cli/review-mr.js.map +1 -1
  38. package/dist/cli/review-mr.test.d.ts +2 -0
  39. package/dist/cli/review-mr.test.d.ts.map +1 -0
  40. package/dist/cli/review-mr.test.js +142 -0
  41. package/dist/cli/review-mr.test.js.map +1 -0
  42. package/dist/cli/review-pr.d.ts +1 -1
  43. package/dist/cli/review-pr.d.ts.map +1 -1
  44. package/dist/cli/review-pr.js +96 -13
  45. package/dist/cli/review-pr.js.map +1 -1
  46. package/dist/cli/review-pr.test.d.ts +2 -0
  47. package/dist/cli/review-pr.test.d.ts.map +1 -0
  48. package/dist/cli/review-pr.test.js +137 -0
  49. package/dist/cli/review-pr.test.js.map +1 -0
  50. package/dist/cli/show-changes.js +4 -4
  51. package/dist/github/platform-adapter.js +2 -2
  52. package/dist/gitlab/client.js +1 -1
  53. package/dist/lib/code-quality-report.js +1 -1
  54. package/dist/lib/comment-formatter.d.ts +2 -1
  55. package/dist/lib/comment-formatter.d.ts.map +1 -1
  56. package/dist/lib/comment-formatter.js +33 -1
  57. package/dist/lib/comment-formatter.js.map +1 -1
  58. package/dist/lib/comment-formatter.test.js +43 -0
  59. package/dist/lib/comment-formatter.test.js.map +1 -1
  60. package/dist/lib/comment-manager.d.ts.map +1 -1
  61. package/dist/lib/comment-manager.js +4 -3
  62. package/dist/lib/comment-manager.js.map +1 -1
  63. package/dist/lib/comment-poster.d.ts +2 -1
  64. package/dist/lib/comment-poster.d.ts.map +1 -1
  65. package/dist/lib/comment-poster.js +2 -2
  66. package/dist/lib/comment-poster.js.map +1 -1
  67. package/dist/lib/comment-poster.test.js +27 -11
  68. package/dist/lib/comment-poster.test.js.map +1 -1
  69. package/dist/lib/config-model-overrides.test.d.ts +1 -1
  70. package/dist/lib/config-model-overrides.test.js +2 -2
  71. package/dist/lib/config-model-overrides.test.js.map +1 -1
  72. package/dist/lib/config.d.ts +34 -7
  73. package/dist/lib/config.d.ts.map +1 -1
  74. package/dist/lib/config.js +35 -13
  75. package/dist/lib/config.js.map +1 -1
  76. package/dist/lib/config.test.js +16 -0
  77. package/dist/lib/config.test.js.map +1 -1
  78. package/dist/lib/context-compression.d.ts +27 -1
  79. package/dist/lib/context-compression.d.ts.map +1 -1
  80. package/dist/lib/context-compression.js +106 -4
  81. package/dist/lib/context-compression.js.map +1 -1
  82. package/dist/lib/context-compression.test.js +305 -1
  83. package/dist/lib/context-compression.test.js.map +1 -1
  84. package/dist/lib/context-loader.d.ts +3 -2
  85. package/dist/lib/context-loader.d.ts.map +1 -1
  86. package/dist/lib/context-loader.js +11 -11
  87. package/dist/lib/context-loader.js.map +1 -1
  88. package/dist/lib/description-executor.d.ts +19 -2
  89. package/dist/lib/description-executor.d.ts.map +1 -1
  90. package/dist/lib/description-executor.js +52 -21
  91. package/dist/lib/description-executor.js.map +1 -1
  92. package/dist/lib/description-executor.test.d.ts +2 -0
  93. package/dist/lib/description-executor.test.d.ts.map +1 -0
  94. package/dist/lib/description-executor.test.js +120 -0
  95. package/dist/lib/description-executor.test.js.map +1 -0
  96. package/dist/lib/description-formatter.d.ts +8 -3
  97. package/dist/lib/description-formatter.d.ts.map +1 -1
  98. package/dist/lib/description-formatter.js +88 -13
  99. package/dist/lib/description-formatter.js.map +1 -1
  100. package/dist/lib/description-formatter.test.d.ts +2 -0
  101. package/dist/lib/description-formatter.test.d.ts.map +1 -0
  102. package/dist/lib/description-formatter.test.js +57 -0
  103. package/dist/lib/description-formatter.test.js.map +1 -0
  104. package/dist/lib/diff-parser.test.d.ts +2 -0
  105. package/dist/lib/diff-parser.test.d.ts.map +1 -0
  106. package/dist/lib/diff-parser.test.js +335 -0
  107. package/dist/lib/diff-parser.test.js.map +1 -0
  108. package/dist/lib/exit.d.ts +35 -0
  109. package/dist/lib/exit.d.ts.map +1 -0
  110. package/dist/lib/exit.js +53 -0
  111. package/dist/lib/exit.js.map +1 -0
  112. package/dist/lib/exit.test.d.ts +2 -0
  113. package/dist/lib/exit.test.d.ts.map +1 -0
  114. package/dist/lib/exit.test.js +120 -0
  115. package/dist/lib/exit.test.js.map +1 -0
  116. package/dist/lib/format-utils.d.ts +3 -0
  117. package/dist/lib/format-utils.d.ts.map +1 -0
  118. package/dist/lib/format-utils.js +7 -0
  119. package/dist/lib/format-utils.js.map +1 -0
  120. package/dist/lib/json-output.d.ts +4 -1
  121. package/dist/lib/json-output.d.ts.map +1 -1
  122. package/dist/lib/json-output.js +2 -1
  123. package/dist/lib/json-output.js.map +1 -1
  124. package/dist/lib/json-output.test.d.ts +2 -0
  125. package/dist/lib/json-output.test.d.ts.map +1 -0
  126. package/dist/lib/json-output.test.js +135 -0
  127. package/dist/lib/json-output.test.js.map +1 -0
  128. package/dist/lib/logger.d.ts +10 -2
  129. package/dist/lib/logger.d.ts.map +1 -1
  130. package/dist/lib/logger.js +22 -4
  131. package/dist/lib/logger.js.map +1 -1
  132. package/dist/lib/logger.test.d.ts +2 -0
  133. package/dist/lib/logger.test.d.ts.map +1 -0
  134. package/dist/lib/logger.test.js +324 -0
  135. package/dist/lib/logger.test.js.map +1 -0
  136. package/dist/lib/position-validator.test.d.ts +2 -0
  137. package/dist/lib/position-validator.test.d.ts.map +1 -0
  138. package/dist/lib/position-validator.test.js +128 -0
  139. package/dist/lib/position-validator.test.js.map +1 -0
  140. package/dist/lib/repository-validator.js +1 -1
  141. package/dist/lib/review-core.d.ts +9 -4
  142. package/dist/lib/review-core.d.ts.map +1 -1
  143. package/dist/lib/review-core.js +207 -112
  144. package/dist/lib/review-core.js.map +1 -1
  145. package/dist/lib/review-core.test.js +76 -30
  146. package/dist/lib/review-core.test.js.map +1 -1
  147. package/dist/lib/review-orchestrator.d.ts +12 -7
  148. package/dist/lib/review-orchestrator.d.ts.map +1 -1
  149. package/dist/lib/review-orchestrator.js +78 -22
  150. package/dist/lib/review-orchestrator.js.map +1 -1
  151. package/dist/lib/review-orchestrator.test.js +160 -42
  152. package/dist/lib/review-orchestrator.test.js.map +1 -1
  153. package/dist/lib/review-parser.test.d.ts +2 -0
  154. package/dist/lib/review-parser.test.d.ts.map +1 -0
  155. package/dist/lib/review-parser.test.js +130 -0
  156. package/dist/lib/review-parser.test.js.map +1 -0
  157. package/dist/lib/review-usage.d.ts +32 -0
  158. package/dist/lib/review-usage.d.ts.map +1 -0
  159. package/dist/lib/review-usage.js +72 -0
  160. package/dist/lib/review-usage.js.map +1 -0
  161. package/dist/lib/review-usage.test.d.ts +2 -0
  162. package/dist/lib/review-usage.test.d.ts.map +1 -0
  163. package/dist/lib/review-usage.test.js +83 -0
  164. package/dist/lib/review-usage.test.js.map +1 -0
  165. package/dist/lib/unified-review-executor.d.ts +6 -2
  166. package/dist/lib/unified-review-executor.d.ts.map +1 -1
  167. package/dist/lib/unified-review-executor.js +54 -28
  168. package/dist/lib/unified-review-executor.js.map +1 -1
  169. package/dist/lib/unified-review-executor.test.js +138 -16
  170. package/dist/lib/unified-review-executor.test.js.map +1 -1
  171. package/dist/lib/write-json-output.test.d.ts +2 -0
  172. package/dist/lib/write-json-output.test.d.ts.map +1 -0
  173. package/dist/lib/write-json-output.test.js +259 -0
  174. package/dist/lib/write-json-output.test.js.map +1 -0
  175. package/dist/pi/sdk.d.ts +94 -0
  176. package/dist/pi/sdk.d.ts.map +1 -0
  177. package/dist/pi/sdk.js +486 -0
  178. package/dist/pi/sdk.js.map +1 -0
  179. package/dist/pi/sdk.test.d.ts +2 -0
  180. package/dist/pi/sdk.test.d.ts.map +1 -0
  181. package/dist/pi/sdk.test.js +331 -0
  182. package/dist/pi/sdk.test.js.map +1 -0
  183. package/dist/{opencode → runtime}/agent-loader.d.ts +7 -5
  184. package/dist/runtime/agent-loader.d.ts.map +1 -0
  185. package/dist/{opencode → runtime}/agent-loader.js +24 -19
  186. package/dist/runtime/agent-loader.js.map +1 -0
  187. package/dist/runtime/agent-loader.test.d.ts +2 -0
  188. package/dist/runtime/agent-loader.test.d.ts.map +1 -0
  189. package/dist/runtime/agent-loader.test.js +280 -0
  190. package/dist/runtime/agent-loader.test.js.map +1 -0
  191. package/dist/runtime/built-in-paths.d.ts +2 -0
  192. package/dist/runtime/built-in-paths.d.ts.map +1 -0
  193. package/dist/runtime/built-in-paths.js +14 -0
  194. package/dist/runtime/built-in-paths.js.map +1 -0
  195. package/dist/{opencode → runtime}/client.d.ts +35 -18
  196. package/dist/runtime/client.d.ts.map +1 -0
  197. package/dist/runtime/client.js +486 -0
  198. package/dist/runtime/client.js.map +1 -0
  199. package/dist/{opencode → runtime}/client.test.d.ts.map +1 -1
  200. package/dist/runtime/client.test.js +392 -0
  201. package/dist/runtime/client.test.js.map +1 -0
  202. package/dist/runtime/path-config.d.ts +8 -0
  203. package/dist/runtime/path-config.d.ts.map +1 -0
  204. package/dist/runtime/path-config.js +68 -0
  205. package/dist/runtime/path-config.js.map +1 -0
  206. package/dist/runtime/path-config.test.d.ts +2 -0
  207. package/dist/runtime/path-config.test.d.ts.map +1 -0
  208. package/dist/runtime/path-config.test.js +103 -0
  209. package/dist/runtime/path-config.test.js.map +1 -0
  210. package/package.json +5 -5
  211. package/.opencode/opencode.jsonc +0 -15
  212. package/.opencode/tool/write_json_output.ts +0 -24
  213. package/.opencode/tools/drs_skill.ts +0 -67
  214. package/dist/lib/skills-prompt.d.ts +0 -3
  215. package/dist/lib/skills-prompt.d.ts.map +0 -1
  216. package/dist/lib/skills-prompt.js +0 -70
  217. package/dist/lib/skills-prompt.js.map +0 -1
  218. package/dist/opencode/agent-loader.d.ts.map +0 -1
  219. package/dist/opencode/agent-loader.js.map +0 -1
  220. package/dist/opencode/client.d.ts.map +0 -1
  221. package/dist/opencode/client.js +0 -456
  222. package/dist/opencode/client.js.map +0 -1
  223. package/dist/opencode/client.test.js +0 -317
  224. package/dist/opencode/client.test.js.map +0 -1
  225. package/dist/opencode/opencode-paths.d.ts +0 -2
  226. package/dist/opencode/opencode-paths.d.ts.map +0 -1
  227. package/dist/opencode/opencode-paths.js +0 -7
  228. package/dist/opencode/opencode-paths.js.map +0 -1
  229. package/dist/opencode/skill-loader.d.ts +0 -15
  230. package/dist/opencode/skill-loader.d.ts.map +0 -1
  231. package/dist/opencode/skill-loader.js +0 -88
  232. package/dist/opencode/skill-loader.js.map +0 -1
  233. /package/{.opencode/agent → .pi/agents}/describe/pr-describer.md +0 -0
  234. /package/{.opencode/agent → .pi/agents}/review/documentation.md +0 -0
  235. /package/{.opencode/agent → .pi/agents}/review/performance.md +0 -0
  236. /package/{.opencode/agent → .pi/agents}/review/quality.md +0 -0
  237. /package/{.opencode/agent → .pi/agents}/review/security.md +0 -0
  238. /package/{.opencode/agent → .pi/agents}/review/style.md +0 -0
  239. /package/{.opencode/agent → .pi/agents}/review/unified-reviewer.md +0 -0
  240. /package/dist/{opencode → runtime}/client.test.d.ts +0 -0
@@ -0,0 +1,164 @@
1
+ import { beforeEach, describe, expect, it, vi } from 'vitest';
2
+ import { reviewLocal } from './review-local.js';
3
+ const { mockGit, parseDiff, getChangedFiles, getFilesWithDiffs, executeReview, displayReviewSummary, hasBlockingIssues, formatReviewJson, writeReviewJson, printReviewJson, formatTerminalIssue, } = vi.hoisted(() => ({
4
+ mockGit: {
5
+ checkIsRepo: vi.fn(),
6
+ diff: vi.fn(),
7
+ },
8
+ parseDiff: vi.fn(),
9
+ getChangedFiles: vi.fn(),
10
+ getFilesWithDiffs: vi.fn(),
11
+ executeReview: vi.fn(),
12
+ displayReviewSummary: vi.fn(),
13
+ hasBlockingIssues: vi.fn(),
14
+ formatReviewJson: vi.fn(),
15
+ writeReviewJson: vi.fn(),
16
+ printReviewJson: vi.fn(),
17
+ formatTerminalIssue: vi.fn(),
18
+ }));
19
+ vi.mock('simple-git', () => ({
20
+ default: vi.fn(() => mockGit),
21
+ }));
22
+ vi.mock('../lib/diff-parser.js', () => ({
23
+ parseDiff,
24
+ getChangedFiles,
25
+ getFilesWithDiffs,
26
+ }));
27
+ vi.mock('../lib/review-orchestrator.js', () => ({
28
+ executeReview,
29
+ displayReviewSummary,
30
+ hasBlockingIssues,
31
+ }));
32
+ vi.mock('../lib/json-output.js', () => ({
33
+ formatReviewJson,
34
+ writeReviewJson,
35
+ printReviewJson,
36
+ }));
37
+ vi.mock('../lib/comment-formatter.js', () => ({
38
+ formatTerminalIssue,
39
+ }));
40
+ const baseConfig = {
41
+ pi: {},
42
+ gitlab: { url: '', token: '' },
43
+ github: { token: '' },
44
+ review: {
45
+ agents: ['security', 'quality'],
46
+ ignorePatterns: ['*.test.ts'],
47
+ },
48
+ };
49
+ const emptySummary = {
50
+ filesReviewed: 1,
51
+ issuesFound: 0,
52
+ bySeverity: { CRITICAL: 0, HIGH: 0, MEDIUM: 0, LOW: 0 },
53
+ byCategory: {
54
+ SECURITY: 0,
55
+ QUALITY: 0,
56
+ STYLE: 0,
57
+ PERFORMANCE: 0,
58
+ DOCUMENTATION: 0,
59
+ },
60
+ };
61
+ describe('review-local', () => {
62
+ beforeEach(() => {
63
+ vi.clearAllMocks();
64
+ vi.spyOn(console, 'log').mockImplementation(() => { });
65
+ mockGit.checkIsRepo.mockResolvedValue(true);
66
+ mockGit.diff.mockResolvedValue('diff --git a/src/app.ts b/src/app.ts');
67
+ parseDiff.mockReturnValue([{ filename: 'src/app.ts' }]);
68
+ getChangedFiles.mockReturnValue(['src/app.ts']);
69
+ getFilesWithDiffs.mockReturnValue([{ filename: 'src/app.ts', patch: '+const answer = 42;' }]);
70
+ executeReview.mockResolvedValue({
71
+ issues: [],
72
+ summary: emptySummary,
73
+ filesReviewed: 1,
74
+ });
75
+ hasBlockingIssues.mockReturnValue(false);
76
+ formatReviewJson.mockReturnValue({ result: 'ok' });
77
+ writeReviewJson.mockResolvedValue(undefined);
78
+ printReviewJson.mockImplementation(() => { });
79
+ displayReviewSummary.mockImplementation(() => { });
80
+ formatTerminalIssue.mockReturnValue('formatted issue');
81
+ });
82
+ it('runs staged reviews through the shared review executor', async () => {
83
+ await reviewLocal(baseConfig, { staged: true });
84
+ expect(mockGit.diff).toHaveBeenCalledWith(['--cached']);
85
+ expect(executeReview).toHaveBeenCalledWith(expect.objectContaining({
86
+ review: expect.objectContaining({
87
+ agents: ['security', 'quality'],
88
+ }),
89
+ }), expect.objectContaining({
90
+ name: 'Local staged diff',
91
+ files: ['src/app.ts'],
92
+ filesWithDiffs: [{ filename: 'src/app.ts', patch: '+const answer = 42;' }],
93
+ staged: true,
94
+ workingDir: process.cwd(),
95
+ }));
96
+ });
97
+ it('throws when executed outside a git repository', async () => {
98
+ mockGit.checkIsRepo.mockResolvedValue(false);
99
+ await expect(reviewLocal(baseConfig, { staged: false })).rejects.toThrow('Not a git repository');
100
+ });
101
+ it('returns early when there are no local changes', async () => {
102
+ mockGit.diff.mockResolvedValue(' ');
103
+ await reviewLocal(baseConfig, { staged: false });
104
+ expect(parseDiff).not.toHaveBeenCalled();
105
+ expect(executeReview).not.toHaveBeenCalled();
106
+ });
107
+ it('exits with code 1 when blocking issues are found', async () => {
108
+ executeReview.mockResolvedValueOnce({
109
+ issues: [
110
+ {
111
+ category: 'SECURITY',
112
+ severity: 'HIGH',
113
+ title: 'SQL Injection risk',
114
+ file: 'src/app.ts',
115
+ line: 10,
116
+ problem: 'Unsanitized SQL input',
117
+ solution: 'Use parameterized query',
118
+ agent: 'security',
119
+ },
120
+ ],
121
+ summary: {
122
+ ...emptySummary,
123
+ issuesFound: 1,
124
+ bySeverity: { CRITICAL: 0, HIGH: 1, MEDIUM: 0, LOW: 0 },
125
+ byCategory: { SECURITY: 1, QUALITY: 0, STYLE: 0, PERFORMANCE: 0, DOCUMENTATION: 0 },
126
+ },
127
+ filesReviewed: 1,
128
+ });
129
+ hasBlockingIssues.mockReturnValueOnce(true);
130
+ const exitSpy = vi.spyOn(process, 'exit').mockImplementation((() => undefined));
131
+ await reviewLocal(baseConfig, { staged: false });
132
+ expect(exitSpy).toHaveBeenCalledWith(1);
133
+ exitSpy.mockRestore();
134
+ });
135
+ it('writes and prints JSON output when requested', async () => {
136
+ await reviewLocal(baseConfig, {
137
+ staged: false,
138
+ outputPath: '.drs/review-output.json',
139
+ jsonOutput: true,
140
+ });
141
+ expect(formatReviewJson).toHaveBeenCalledWith(emptySummary, [], {
142
+ source: 'local-unstaged',
143
+ }, undefined);
144
+ expect(writeReviewJson).toHaveBeenCalledWith({ result: 'ok' }, '.drs/review-output.json', process.cwd());
145
+ expect(printReviewJson).toHaveBeenCalledWith({ result: 'ok' });
146
+ });
147
+ it('writes JSON output when only outputPath is provided', async () => {
148
+ await reviewLocal(baseConfig, {
149
+ staged: false,
150
+ outputPath: '.drs/review-output.json',
151
+ jsonOutput: false,
152
+ });
153
+ expect(formatReviewJson).toHaveBeenCalledWith(emptySummary, [], {
154
+ source: 'local-unstaged',
155
+ }, undefined);
156
+ expect(writeReviewJson).toHaveBeenCalledWith({ result: 'ok' }, '.drs/review-output.json', process.cwd());
157
+ expect(printReviewJson).not.toHaveBeenCalled();
158
+ });
159
+ it('surfaces runtime failures from review execution', async () => {
160
+ executeReview.mockRejectedValueOnce(new Error('Pi runtime unavailable'));
161
+ await expect(reviewLocal(baseConfig, { staged: false })).rejects.toThrow('Pi runtime unavailable');
162
+ });
163
+ });
164
+ //# sourceMappingURL=review-local.test.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"review-local.test.js","sourceRoot":"","sources":["../../src/cli/review-local.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAE9D,OAAO,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAEhD,MAAM,EACJ,OAAO,EACP,SAAS,EACT,eAAe,EACf,iBAAiB,EACjB,aAAa,EACb,oBAAoB,EACpB,iBAAiB,EACjB,gBAAgB,EAChB,eAAe,EACf,eAAe,EACf,mBAAmB,GACpB,GAAG,EAAE,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;IACpB,OAAO,EAAE;QACP,WAAW,EAAE,EAAE,CAAC,EAAE,EAAE;QACpB,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;KACd;IACD,SAAS,EAAE,EAAE,CAAC,EAAE,EAAE;IAClB,eAAe,EAAE,EAAE,CAAC,EAAE,EAAE;IACxB,iBAAiB,EAAE,EAAE,CAAC,EAAE,EAAE;IAC1B,aAAa,EAAE,EAAE,CAAC,EAAE,EAAE;IACtB,oBAAoB,EAAE,EAAE,CAAC,EAAE,EAAE;IAC7B,iBAAiB,EAAE,EAAE,CAAC,EAAE,EAAE;IAC1B,gBAAgB,EAAE,EAAE,CAAC,EAAE,EAAE;IACzB,eAAe,EAAE,EAAE,CAAC,EAAE,EAAE;IACxB,eAAe,EAAE,EAAE,CAAC,EAAE,EAAE;IACxB,mBAAmB,EAAE,EAAE,CAAC,EAAE,EAAE;CAC7B,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,YAAY,EAAE,GAAG,EAAE,CAAC,CAAC;IAC3B,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,OAAO,CAAC;CAC9B,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,uBAAuB,EAAE,GAAG,EAAE,CAAC,CAAC;IACtC,SAAS;IACT,eAAe;IACf,iBAAiB;CAClB,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,+BAA+B,EAAE,GAAG,EAAE,CAAC,CAAC;IAC9C,aAAa;IACb,oBAAoB;IACpB,iBAAiB;CAClB,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,uBAAuB,EAAE,GAAG,EAAE,CAAC,CAAC;IACtC,gBAAgB;IAChB,eAAe;IACf,eAAe;CAChB,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,6BAA6B,EAAE,GAAG,EAAE,CAAC,CAAC;IAC5C,mBAAmB;CACpB,CAAC,CAAC,CAAC;AAEJ,MAAM,UAAU,GAAG;IACjB,EAAE,EAAE,EAAE;IACN,MAAM,EAAE,EAAE,GAAG,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,EAAE;IAC9B,MAAM,EAAE,EAAE,KAAK,EAAE,EAAE,EAAE;IACrB,MAAM,EAAE;QACN,MAAM,EAAE,CAAC,UAAU,EAAE,SAAS,CAAC;QAC/B,cAAc,EAAE,CAAC,WAAW,CAAC;KAC9B;CACsB,CAAC;AAE1B,MAAM,YAAY,GAAG;IACnB,aAAa,EAAE,CAAC;IAChB,WAAW,EAAE,CAAC;IACd,UAAU,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC,EAAE;IACvD,UAAU,EAAE;QACV,QAAQ,EAAE,CAAC;QACX,OAAO,EAAE,CAAC;QACV,KAAK,EAAE,CAAC;QACR,WAAW,EAAE,CAAC;QACd,aAAa,EAAE,CAAC;KACjB;CACF,CAAC;AAEF,QAAQ,CAAC,cAAc,EAAE,GAAG,EAAE;IAC5B,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACnB,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QAEtD,OAAO,CAAC,WAAW,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAC5C,OAAO,CAAC,IAAI,CAAC,iBAAiB,CAAC,sCAAsC,CAAC,CAAC;QAEvE,SAAS,CAAC,eAAe,CAAC,CAAC,EAAE,QAAQ,EAAE,YAAY,EAAE,CAAC,CAAC,CAAC;QACxD,eAAe,CAAC,eAAe,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC;QAChD,iBAAiB,CAAC,eAAe,CAAC,CAAC,EAAE,QAAQ,EAAE,YAAY,EAAE,KAAK,EAAE,qBAAqB,EAAE,CAAC,CAAC,CAAC;QAE9F,aAAa,CAAC,iBAAiB,CAAC;YAC9B,MAAM,EAAE,EAAE;YACV,OAAO,EAAE,YAAY;YACrB,aAAa,EAAE,CAAC;SACjB,CAAC,CAAC;QAEH,iBAAiB,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC;QACzC,gBAAgB,CAAC,eAAe,CAAC,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,CAAC;QACnD,eAAe,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QAC7C,eAAe,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QAC7C,oBAAoB,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QAClD,mBAAmB,CAAC,eAAe,CAAC,iBAAiB,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,KAAK,IAAI,EAAE;QACtE,MAAM,WAAW,CAAC,UAAU,EAAE,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,CAAC;QAEhD,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC;QACxD,MAAM,CAAC,aAAa,CAAC,CAAC,oBAAoB,CACxC,MAAM,CAAC,gBAAgB,CAAC;YACtB,MAAM,EAAE,MAAM,CAAC,gBAAgB,CAAC;gBAC9B,MAAM,EAAE,CAAC,UAAU,EAAE,SAAS,CAAC;aAChC,CAAC;SACH,CAAC,EACF,MAAM,CAAC,gBAAgB,CAAC;YACtB,IAAI,EAAE,mBAAmB;YACzB,KAAK,EAAE,CAAC,YAAY,CAAC;YACrB,cAAc,EAAE,CAAC,EAAE,QAAQ,EAAE,YAAY,EAAE,KAAK,EAAE,qBAAqB,EAAE,CAAC;YAC1E,MAAM,EAAE,IAAI;YACZ,UAAU,EAAE,OAAO,CAAC,GAAG,EAAE;SAC1B,CAAC,CACH,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;QAC7D,OAAO,CAAC,WAAW,CAAC,iBAAiB,CAAC,KAAK,CAAC,CAAC;QAE7C,MAAM,MAAM,CAAC,WAAW,CAAC,UAAU,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CACtE,sBAAsB,CACvB,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;QAC7D,OAAO,CAAC,IAAI,CAAC,iBAAiB,CAAC,KAAK,CAAC,CAAC;QAEtC,MAAM,WAAW,CAAC,UAAU,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;QAEjD,MAAM,CAAC,SAAS,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QACzC,MAAM,CAAC,aAAa,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kDAAkD,EAAE,KAAK,IAAI,EAAE;QAChE,aAAa,CAAC,qBAAqB,CAAC;YAClC,MAAM,EAAE;gBACN;oBACE,QAAQ,EAAE,UAAU;oBACpB,QAAQ,EAAE,MAAM;oBAChB,KAAK,EAAE,oBAAoB;oBAC3B,IAAI,EAAE,YAAY;oBAClB,IAAI,EAAE,EAAE;oBACR,OAAO,EAAE,uBAAuB;oBAChC,QAAQ,EAAE,yBAAyB;oBACnC,KAAK,EAAE,UAAU;iBAClB;aACF;YACD,OAAO,EAAE;gBACP,GAAG,YAAY;gBACf,WAAW,EAAE,CAAC;gBACd,UAAU,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC,EAAE;gBACvD,UAAU,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,KAAK,EAAE,CAAC,EAAE,WAAW,EAAE,CAAC,EAAE,aAAa,EAAE,CAAC,EAAE;aACpF;YACD,aAAa,EAAE,CAAC;SACjB,CAAC,CAAC;QACH,iBAAiB,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QAE5C,MAAM,OAAO,GAAG,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,kBAAkB,CAAC,CAAC,GAAG,EAAE,CAAC,SAAS,CAAQ,CAAC,CAAC;QAEvF,MAAM,WAAW,CAAC,UAAU,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;QAEjD,MAAM,CAAC,OAAO,CAAC,CAAC,oBAAoB,CAAC,CAAC,CAAC,CAAC;QACxC,OAAO,CAAC,WAAW,EAAE,CAAC;IACxB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8CAA8C,EAAE,KAAK,IAAI,EAAE;QAC5D,MAAM,WAAW,CAAC,UAAU,EAAE;YAC5B,MAAM,EAAE,KAAK;YACb,UAAU,EAAE,yBAAyB;YACrC,UAAU,EAAE,IAAI;SACjB,CAAC,CAAC;QAEH,MAAM,CAAC,gBAAgB,CAAC,CAAC,oBAAoB,CAC3C,YAAY,EACZ,EAAE,EACF;YACE,MAAM,EAAE,gBAAgB;SACzB,EACD,SAAS,CACV,CAAC;QACF,MAAM,CAAC,eAAe,CAAC,CAAC,oBAAoB,CAC1C,EAAE,MAAM,EAAE,IAAI,EAAE,EAChB,yBAAyB,EACzB,OAAO,CAAC,GAAG,EAAE,CACd,CAAC;QACF,MAAM,CAAC,eAAe,CAAC,CAAC,oBAAoB,CAAC,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,CAAC;IACjE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,KAAK,IAAI,EAAE;QACnE,MAAM,WAAW,CAAC,UAAU,EAAE;YAC5B,MAAM,EAAE,KAAK;YACb,UAAU,EAAE,yBAAyB;YACrC,UAAU,EAAE,KAAK;SAClB,CAAC,CAAC;QAEH,MAAM,CAAC,gBAAgB,CAAC,CAAC,oBAAoB,CAC3C,YAAY,EACZ,EAAE,EACF;YACE,MAAM,EAAE,gBAAgB;SACzB,EACD,SAAS,CACV,CAAC;QACF,MAAM,CAAC,eAAe,CAAC,CAAC,oBAAoB,CAC1C,EAAE,MAAM,EAAE,IAAI,EAAE,EAChB,yBAAyB,EACzB,OAAO,CAAC,GAAG,EAAE,CACd,CAAC;QACF,MAAM,CAAC,eAAe,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;QAC/D,aAAa,CAAC,qBAAqB,CAAC,IAAI,KAAK,CAAC,wBAAwB,CAAC,CAAC,CAAC;QAEzE,MAAM,MAAM,CAAC,WAAW,CAAC,UAAU,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CACtE,wBAAwB,CACzB,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
@@ -13,7 +13,7 @@ export interface ReviewMROptions {
13
13
  debug?: boolean;
14
14
  }
15
15
  /**
16
- * Review a GitLab merge request
16
+ * Review a GitLab merge request.
17
17
  */
18
18
  export declare function reviewMR(config: DRSConfig, options: ReviewMROptions): Promise<void>;
19
19
  //# sourceMappingURL=review-mr.d.ts.map
@@ -1 +1 @@
1
- {"version":3,"file":"review-mr.d.ts","sourceRoot":"","sources":["../../src/cli/review-mr.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,kBAAkB,CAAC;AAOlD,MAAM,WAAW,eAAe;IAC9B,SAAS,EAAE,MAAM,CAAC;IAClB,KAAK,EAAE,MAAM,CAAC;IACd,YAAY,EAAE,OAAO,CAAC;IACtB,gBAAgB,EAAE,OAAO,CAAC;IAC1B,QAAQ,EAAE,OAAO,CAAC;IAClB,eAAe,EAAE,OAAO,CAAC;IACzB,iBAAiB,CAAC,EAAE,MAAM,CAAC;IAC3B,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAwCD;;GAEG;AACH,wBAAsB,QAAQ,CAAC,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,eAAe,GAAG,OAAO,CAAC,IAAI,CAAC,CAyEzF"}
1
+ {"version":3,"file":"review-mr.d.ts","sourceRoot":"","sources":["../../src/cli/review-mr.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,kBAAkB,CAAC;AAYlD,MAAM,WAAW,eAAe;IAC9B,SAAS,EAAE,MAAM,CAAC;IAClB,KAAK,EAAE,MAAM,CAAC;IACd,YAAY,EAAE,OAAO,CAAC;IACtB,gBAAgB,EAAE,OAAO,CAAC;IAC1B,QAAQ,EAAE,OAAO,CAAC;IAClB,eAAe,EAAE,OAAO,CAAC;IACzB,iBAAiB,CAAC,EAAE,MAAM,CAAC;IAC3B,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAmKD;;GAEG;AACH,wBAAsB,QAAQ,CAAC,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,eAAe,GAAG,OAAO,CAAC,IAAI,CAAC,CAwEzF"}
@@ -2,8 +2,8 @@ import { createGitLabClient } from '../gitlab/client.js';
2
2
  import { GitLabPlatformAdapter } from '../gitlab/platform-adapter.js';
3
3
  import { executeUnifiedReview } from '../lib/unified-review-executor.js';
4
4
  /**
5
- * Parse a GitLab diff to extract valid line numbers for review comments
6
- * GitLab only allows comments on lines that are in the diff (added or context)
5
+ * Parse a GitLab diff to extract valid line numbers for review comments.
6
+ * GitLab only allows comments on lines that are in the diff (added or context).
7
7
  */
8
8
  function parseValidLinesFromDiff(diff) {
9
9
  const validLines = new Set();
@@ -37,27 +37,100 @@ function parseValidLinesFromDiff(diff) {
37
37
  }
38
38
  return validLines;
39
39
  }
40
+ function parseStatusCodeFromMessage(message) {
41
+ const match = message.match(/\b(401|403|404|429)\b/);
42
+ return match ? parseInt(match[1], 10) : undefined;
43
+ }
44
+ function extractStatusCode(error) {
45
+ if (!error || typeof error !== 'object') {
46
+ return undefined;
47
+ }
48
+ const candidate = error;
49
+ if (typeof candidate.statusCode === 'number') {
50
+ return candidate.statusCode;
51
+ }
52
+ if (typeof candidate.status === 'number') {
53
+ return candidate.status;
54
+ }
55
+ if (candidate.response && typeof candidate.response === 'object') {
56
+ if (typeof candidate.response.statusCode === 'number') {
57
+ return candidate.response.statusCode;
58
+ }
59
+ if (typeof candidate.response.status === 'number') {
60
+ return candidate.response.status;
61
+ }
62
+ }
63
+ if (candidate.cause && candidate.cause !== error) {
64
+ return extractStatusCode(candidate.cause);
65
+ }
66
+ return undefined;
67
+ }
68
+ function mapGitLabContextError(error, options) {
69
+ const rawMessage = error instanceof Error ? error.message : String(error);
70
+ const normalized = rawMessage.toLowerCase();
71
+ const statusCode = extractStatusCode(error) ?? parseStatusCodeFromMessage(rawMessage);
72
+ const gitlabUrl = process.env.GITLAB_URL ?? 'https://gitlab.com';
73
+ if (normalized.includes('gitlab_token environment variable is required')) {
74
+ return new Error('GitLab authentication is required. Set GITLAB_TOKEN with an API token that can access the target merge request.');
75
+ }
76
+ if (statusCode === 401 || normalized.includes('unauthorized')) {
77
+ return new Error(`GitLab authentication failed for ${options.projectId}!${options.mrIid}. Verify GITLAB_TOKEN for ${gitlabUrl} and ensure it has API access.`);
78
+ }
79
+ if (statusCode === 403 || normalized.includes('forbidden')) {
80
+ return new Error(`GitLab authorization failed for ${options.projectId}!${options.mrIid}. Ensure the token has permission to read the project and merge request.`);
81
+ }
82
+ if (statusCode === 404 || normalized.includes('not found')) {
83
+ return new Error(`GitLab merge request not found: ${options.projectId}!${options.mrIid}. Verify --project/--mr values and that the token can access the project.`);
84
+ }
85
+ if (statusCode === 429 || normalized.includes('rate limit')) {
86
+ return new Error(`GitLab API rate limit reached while loading ${options.projectId}!${options.mrIid}. Retry after cooldown or use a token with higher limits.`);
87
+ }
88
+ const connectivityError = normalized.includes('fetch failed') ||
89
+ normalized.includes('econnrefused') ||
90
+ normalized.includes('enotfound') ||
91
+ normalized.includes('etimedout');
92
+ if (connectivityError) {
93
+ return new Error(`Unable to reach GitLab at ${gitlabUrl} while loading ${options.projectId}!${options.mrIid}. Check GITLAB_URL and network connectivity.`);
94
+ }
95
+ return new Error(`Failed to load GitLab merge request context for ${options.projectId}!${options.mrIid}: ${rawMessage}`);
96
+ }
97
+ async function loadMergeRequestContext(platformClient, options) {
98
+ try {
99
+ const pullRequest = await platformClient.getPullRequest(options.projectId, options.mrIid);
100
+ const changedFiles = await platformClient.getChangedFiles(options.projectId, options.mrIid);
101
+ return {
102
+ pullRequest,
103
+ changedFiles,
104
+ };
105
+ }
106
+ catch (error) {
107
+ throw mapGitLabContextError(error, options);
108
+ }
109
+ }
40
110
  /**
41
- * Review a GitLab merge request
111
+ * Review a GitLab merge request.
42
112
  */
43
113
  export async function reviewMR(config, options) {
44
- // Create GitLab client and adapter
45
- const gitlabClient = createGitLabClient();
46
- const platformClient = new GitLabPlatformAdapter(gitlabClient);
47
- // Fetch MR details to get diff refs
48
- const mr = await gitlabClient.getMergeRequest(options.projectId, options.mrIid);
49
- // Fetch MR changes to build valid lines map
50
- const changes = await gitlabClient.getMRChanges(options.projectId, options.mrIid);
114
+ let platformClient;
115
+ try {
116
+ const gitlabClient = createGitLabClient();
117
+ platformClient = new GitLabPlatformAdapter(gitlabClient);
118
+ }
119
+ catch (error) {
120
+ throw mapGitLabContextError(error, options);
121
+ }
122
+ const { pullRequest, changedFiles } = await loadMergeRequestContext(platformClient, options);
51
123
  // Build a map of file -> valid line numbers (lines that are in the diff)
52
124
  const validLinesMap = new Map();
53
- for (const change of changes) {
54
- if (change.diff && !change.deletedFile) {
55
- const validLines = parseValidLinesFromDiff(change.diff);
56
- validLinesMap.set(change.newPath, validLines);
125
+ for (const file of changedFiles) {
126
+ if (file.patch && file.status !== 'removed') {
127
+ const validLines = parseValidLinesFromDiff(file.patch);
128
+ validLinesMap.set(file.filename, validLines);
57
129
  }
58
130
  }
131
+ const platformData = pullRequest.platformData;
132
+ const diffRefs = platformData?.diff_refs;
59
133
  // Create line validator - only allow comments on lines that are in the diff
60
- const diffRefs = mr.diff_refs;
61
134
  const lineValidator = {
62
135
  isValidLine(file, line) {
63
136
  if (!diffRefs?.base_sha || !diffRefs.head_sha || !diffRefs.start_sha) {
@@ -68,8 +141,8 @@ export async function reviewMR(config, options) {
68
141
  },
69
142
  };
70
143
  // Create inline position builder
71
- const createInlinePosition = (issue, platformData) => {
72
- const data = platformData;
144
+ const createInlinePosition = (issue, platformDataInput) => {
145
+ const data = platformDataInput;
73
146
  const refs = data.diff_refs;
74
147
  return {
75
148
  path: issue.file,
@@ -84,6 +157,8 @@ export async function reviewMR(config, options) {
84
157
  platformClient,
85
158
  projectId: options.projectId,
86
159
  prNumber: options.mrIid,
160
+ pullRequest,
161
+ changedFiles,
87
162
  postComments: options.postComments,
88
163
  postErrorComment: options.postErrorComment,
89
164
  codeQualityReport: options.codeQualityReport,
@@ -1 +1 @@
1
- {"version":3,"file":"review-mr.js","sourceRoot":"","sources":["../../src/cli/review-mr.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,MAAM,qBAAqB,CAAC;AACzD,OAAO,EAAE,qBAAqB,EAAE,MAAM,+BAA+B,CAAC;AACtE,OAAO,EAAE,oBAAoB,EAAE,MAAM,mCAAmC,CAAC;AAkBzE;;;GAGG;AACH,SAAS,uBAAuB,CAAC,IAAY;IAC3C,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAC/B,IAAI,WAAW,GAAG,CAAC,CAAC;IAEpB,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,qEAAqE;QACrE,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,uCAAuC,CAAC,CAAC;QACtE,IAAI,SAAS,EAAE,CAAC;YACd,WAAW,GAAG,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YACzC,SAAS;QACX,CAAC;QAED,uDAAuD;QACvD,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAEzC,MAAM,MAAM,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;QACvB,IAAI,MAAM,KAAK,GAAG,EAAE,CAAC;YACnB,mCAAmC;YACnC,UAAU,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;YAC5B,WAAW,EAAE,CAAC;QAChB,CAAC;aAAM,IAAI,MAAM,KAAK,GAAG,EAAE,CAAC;YAC1B,qCAAqC;YACrC,UAAU,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;YAC5B,WAAW,EAAE,CAAC;QAChB,CAAC;aAAM,IAAI,MAAM,KAAK,GAAG,EAAE,CAAC;YAC1B,uDAAuD;YACvD,SAAS;QACX,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;GAEG;AACH,MAAM,CAAC,KAAK,UAAU,QAAQ,CAAC,MAAiB,EAAE,OAAwB;IACxE,mCAAmC;IACnC,MAAM,YAAY,GAAG,kBAAkB,EAAE,CAAC;IAC1C,MAAM,cAAc,GAAG,IAAI,qBAAqB,CAAC,YAAY,CAAC,CAAC;IAE/D,oCAAoC;IACpC,MAAM,EAAE,GAAG,MAAM,YAAY,CAAC,eAAe,CAAC,OAAO,CAAC,SAAS,EAAE,OAAO,CAAC,KAAK,CAAC,CAAC;IAEhF,4CAA4C;IAC5C,MAAM,OAAO,GAAG,MAAM,YAAY,CAAC,YAAY,CAAC,OAAO,CAAC,SAAS,EAAE,OAAO,CAAC,KAAK,CAAC,CAAC;IAElF,yEAAyE;IACzE,MAAM,aAAa,GAAG,IAAI,GAAG,EAAuB,CAAC;IACrD,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;QAC7B,IAAI,MAAM,CAAC,IAAI,IAAI,CAAC,MAAM,CAAC,WAAW,EAAE,CAAC;YACvC,MAAM,UAAU,GAAG,uBAAuB,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;YACxD,aAAa,CAAC,GAAG,CAAC,MAAM,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;QAChD,CAAC;IACH,CAAC;IAED,4EAA4E;IAC5E,MAAM,QAAQ,GAAG,EAAE,CAAC,SAMP,CAAC;IACd,MAAM,aAAa,GAAkB;QACnC,WAAW,CAAC,IAAY,EAAE,IAAY;YACpC,IAAI,CAAC,QAAQ,EAAE,QAAQ,IAAI,CAAC,QAAQ,CAAC,QAAQ,IAAI,CAAC,QAAQ,CAAC,SAAS,EAAE,CAAC;gBACrE,OAAO,KAAK,CAAC;YACf,CAAC;YACD,MAAM,UAAU,GAAG,aAAa,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAC3C,OAAO,UAAU,KAAK,SAAS,IAAI,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QAC1D,CAAC;KACF,CAAC;IAEF,iCAAiC;IACjC,MAAM,oBAAoB,GAAG,CAC3B,KAAkB,EAClB,YAAqB,EACE,EAAE;QACzB,MAAM,IAAI,GAAG,YAEZ,CAAC;QACF,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;QAC5B,OAAO;YACL,IAAI,EAAE,KAAK,CAAC,IAAI;YAChB,IAAI,EAAE,KAAK,CAAC,IAAK;YACjB,OAAO,EAAE,IAAI,EAAE,QAAQ;YACvB,OAAO,EAAE,IAAI,EAAE,QAAQ;YACvB,QAAQ,EAAE,IAAI,EAAE,SAAS;SAC1B,CAAC;IACJ,CAAC,CAAC;IAEF,yBAAyB;IACzB,MAAM,oBAAoB,CAAC,MAAM,EAAE;QACjC,cAAc;QACd,SAAS,EAAE,OAAO,CAAC,SAAS;QAC5B,QAAQ,EAAE,OAAO,CAAC,KAAK;QACvB,YAAY,EAAE,OAAO,CAAC,YAAY;QAClC,gBAAgB,EAAE,OAAO,CAAC,gBAAgB;QAC1C,iBAAiB,EAAE,OAAO,CAAC,iBAAiB;QAC5C,UAAU,EAAE,OAAO,CAAC,UAAU;QAC9B,UAAU,EAAE,OAAO,CAAC,UAAU;QAC9B,UAAU,EAAE,OAAO,CAAC,UAAU;QAC9B,aAAa;QACb,oBAAoB;QACpB,QAAQ,EAAE,OAAO,CAAC,QAAQ;QAC1B,eAAe,EAAE,OAAO,CAAC,eAAe;QACxC,KAAK,EAAE,OAAO,CAAC,KAAK;KACrB,CAAC,CAAC;AACL,CAAC"}
1
+ {"version":3,"file":"review-mr.js","sourceRoot":"","sources":["../../src/cli/review-mr.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,MAAM,qBAAqB,CAAC;AACzD,OAAO,EAAE,qBAAqB,EAAE,MAAM,+BAA+B,CAAC;AACtE,OAAO,EAAE,oBAAoB,EAAE,MAAM,mCAAmC,CAAC;AAuCzE;;;GAGG;AACH,SAAS,uBAAuB,CAAC,IAAY;IAC3C,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAC/B,IAAI,WAAW,GAAG,CAAC,CAAC;IAEpB,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,qEAAqE;QACrE,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,uCAAuC,CAAC,CAAC;QACtE,IAAI,SAAS,EAAE,CAAC;YACd,WAAW,GAAG,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YACzC,SAAS;QACX,CAAC;QAED,uDAAuD;QACvD,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAEzC,MAAM,MAAM,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;QACvB,IAAI,MAAM,KAAK,GAAG,EAAE,CAAC;YACnB,mCAAmC;YACnC,UAAU,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;YAC5B,WAAW,EAAE,CAAC;QAChB,CAAC;aAAM,IAAI,MAAM,KAAK,GAAG,EAAE,CAAC;YAC1B,qCAAqC;YACrC,UAAU,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;YAC5B,WAAW,EAAE,CAAC;QAChB,CAAC;aAAM,IAAI,MAAM,KAAK,GAAG,EAAE,CAAC;YAC1B,uDAAuD;YACvD,SAAS;QACX,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,SAAS,0BAA0B,CAAC,OAAe;IACjD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,uBAAuB,CAAC,CAAC;IACrD,OAAO,KAAK,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;AACpD,CAAC;AAED,SAAS,iBAAiB,CAAC,KAAc;IACvC,IAAI,CAAC,KAAK,IAAI,OAAO,KAAK,KAAK,QAAQ,EAAE,CAAC;QACxC,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,SAAS,GAAG,KAAwB,CAAC;IAE3C,IAAI,OAAO,SAAS,CAAC,UAAU,KAAK,QAAQ,EAAE,CAAC;QAC7C,OAAO,SAAS,CAAC,UAAU,CAAC;IAC9B,CAAC;IAED,IAAI,OAAO,SAAS,CAAC,MAAM,KAAK,QAAQ,EAAE,CAAC;QACzC,OAAO,SAAS,CAAC,MAAM,CAAC;IAC1B,CAAC;IAED,IAAI,SAAS,CAAC,QAAQ,IAAI,OAAO,SAAS,CAAC,QAAQ,KAAK,QAAQ,EAAE,CAAC;QACjE,IAAI,OAAO,SAAS,CAAC,QAAQ,CAAC,UAAU,KAAK,QAAQ,EAAE,CAAC;YACtD,OAAO,SAAS,CAAC,QAAQ,CAAC,UAAU,CAAC;QACvC,CAAC;QAED,IAAI,OAAO,SAAS,CAAC,QAAQ,CAAC,MAAM,KAAK,QAAQ,EAAE,CAAC;YAClD,OAAO,SAAS,CAAC,QAAQ,CAAC,MAAM,CAAC;QACnC,CAAC;IACH,CAAC;IAED,IAAI,SAAS,CAAC,KAAK,IAAI,SAAS,CAAC,KAAK,KAAK,KAAK,EAAE,CAAC;QACjD,OAAO,iBAAiB,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;IAC5C,CAAC;IAED,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,qBAAqB,CAAC,KAAc,EAAE,OAAwB;IACrE,MAAM,UAAU,GAAG,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;IAC1E,MAAM,UAAU,GAAG,UAAU,CAAC,WAAW,EAAE,CAAC;IAC5C,MAAM,UAAU,GAAG,iBAAiB,CAAC,KAAK,CAAC,IAAI,0BAA0B,CAAC,UAAU,CAAC,CAAC;IACtF,MAAM,SAAS,GAAG,OAAO,CAAC,GAAG,CAAC,UAAU,IAAI,oBAAoB,CAAC;IAEjE,IAAI,UAAU,CAAC,QAAQ,CAAC,+CAA+C,CAAC,EAAE,CAAC;QACzE,OAAO,IAAI,KAAK,CACd,iHAAiH,CAClH,CAAC;IACJ,CAAC;IAED,IAAI,UAAU,KAAK,GAAG,IAAI,UAAU,CAAC,QAAQ,CAAC,cAAc,CAAC,EAAE,CAAC;QAC9D,OAAO,IAAI,KAAK,CACd,oCAAoC,OAAO,CAAC,SAAS,IAAI,OAAO,CAAC,KAAK,6BAA6B,SAAS,gCAAgC,CAC7I,CAAC;IACJ,CAAC;IAED,IAAI,UAAU,KAAK,GAAG,IAAI,UAAU,CAAC,QAAQ,CAAC,WAAW,CAAC,EAAE,CAAC;QAC3D,OAAO,IAAI,KAAK,CACd,mCAAmC,OAAO,CAAC,SAAS,IAAI,OAAO,CAAC,KAAK,0EAA0E,CAChJ,CAAC;IACJ,CAAC;IAED,IAAI,UAAU,KAAK,GAAG,IAAI,UAAU,CAAC,QAAQ,CAAC,WAAW,CAAC,EAAE,CAAC;QAC3D,OAAO,IAAI,KAAK,CACd,mCAAmC,OAAO,CAAC,SAAS,IAAI,OAAO,CAAC,KAAK,2EAA2E,CACjJ,CAAC;IACJ,CAAC;IAED,IAAI,UAAU,KAAK,GAAG,IAAI,UAAU,CAAC,QAAQ,CAAC,YAAY,CAAC,EAAE,CAAC;QAC5D,OAAO,IAAI,KAAK,CACd,+CAA+C,OAAO,CAAC,SAAS,IAAI,OAAO,CAAC,KAAK,2DAA2D,CAC7I,CAAC;IACJ,CAAC;IAED,MAAM,iBAAiB,GACrB,UAAU,CAAC,QAAQ,CAAC,cAAc,CAAC;QACnC,UAAU,CAAC,QAAQ,CAAC,cAAc,CAAC;QACnC,UAAU,CAAC,QAAQ,CAAC,WAAW,CAAC;QAChC,UAAU,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAC;IAEnC,IAAI,iBAAiB,EAAE,CAAC;QACtB,OAAO,IAAI,KAAK,CACd,6BAA6B,SAAS,kBAAkB,OAAO,CAAC,SAAS,IAAI,OAAO,CAAC,KAAK,8CAA8C,CACzI,CAAC;IACJ,CAAC;IAED,OAAO,IAAI,KAAK,CACd,mDAAmD,OAAO,CAAC,SAAS,IAAI,OAAO,CAAC,KAAK,KAAK,UAAU,EAAE,CACvG,CAAC;AACJ,CAAC;AAED,KAAK,UAAU,uBAAuB,CACpC,cAAqC,EACrC,OAAwB;IAExB,IAAI,CAAC;QACH,MAAM,WAAW,GAAG,MAAM,cAAc,CAAC,cAAc,CAAC,OAAO,CAAC,SAAS,EAAE,OAAO,CAAC,KAAK,CAAC,CAAC;QAC1F,MAAM,YAAY,GAAG,MAAM,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,SAAS,EAAE,OAAO,CAAC,KAAK,CAAC,CAAC;QAE5F,OAAO;YACL,WAAW;YACX,YAAY;SACb,CAAC;IACJ,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,MAAM,qBAAqB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC;IAC9C,CAAC;AACH,CAAC;AAED;;GAEG;AACH,MAAM,CAAC,KAAK,UAAU,QAAQ,CAAC,MAAiB,EAAE,OAAwB;IACxE,IAAI,cAAqC,CAAC;IAE1C,IAAI,CAAC;QACH,MAAM,YAAY,GAAG,kBAAkB,EAAE,CAAC;QAC1C,cAAc,GAAG,IAAI,qBAAqB,CAAC,YAAY,CAAC,CAAC;IAC3D,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,MAAM,qBAAqB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC;IAC9C,CAAC;IAED,MAAM,EAAE,WAAW,EAAE,YAAY,EAAE,GAAG,MAAM,uBAAuB,CAAC,cAAc,EAAE,OAAO,CAAC,CAAC;IAE7F,yEAAyE;IACzE,MAAM,aAAa,GAAG,IAAI,GAAG,EAAuB,CAAC;IACrD,KAAK,MAAM,IAAI,IAAI,YAAY,EAAE,CAAC;QAChC,IAAI,IAAI,CAAC,KAAK,IAAI,IAAI,CAAC,MAAM,KAAK,SAAS,EAAE,CAAC;YAC5C,MAAM,UAAU,GAAG,uBAAuB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACvD,aAAa,CAAC,GAAG,CAAC,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;QAC/C,CAAC;IACH,CAAC;IAED,MAAM,YAAY,GAAG,WAAW,CAAC,YAA0D,CAAC;IAC5F,MAAM,QAAQ,GAAG,YAAY,EAAE,SAAS,CAAC;IAEzC,4EAA4E;IAC5E,MAAM,aAAa,GAAkB;QACnC,WAAW,CAAC,IAAY,EAAE,IAAY;YACpC,IAAI,CAAC,QAAQ,EAAE,QAAQ,IAAI,CAAC,QAAQ,CAAC,QAAQ,IAAI,CAAC,QAAQ,CAAC,SAAS,EAAE,CAAC;gBACrE,OAAO,KAAK,CAAC;YACf,CAAC;YACD,MAAM,UAAU,GAAG,aAAa,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAC3C,OAAO,UAAU,KAAK,SAAS,IAAI,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QAC1D,CAAC;KACF,CAAC;IAEF,iCAAiC;IACjC,MAAM,oBAAoB,GAAG,CAC3B,KAAkB,EAClB,iBAA0B,EACH,EAAE;QACzB,MAAM,IAAI,GAAG,iBAEZ,CAAC;QACF,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;QAC5B,OAAO;YACL,IAAI,EAAE,KAAK,CAAC,IAAI;YAChB,IAAI,EAAE,KAAK,CAAC,IAAK;YACjB,OAAO,EAAE,IAAI,EAAE,QAAQ;YACvB,OAAO,EAAE,IAAI,EAAE,QAAQ;YACvB,QAAQ,EAAE,IAAI,EAAE,SAAS;SAC1B,CAAC;IACJ,CAAC,CAAC;IAEF,yBAAyB;IACzB,MAAM,oBAAoB,CAAC,MAAM,EAAE;QACjC,cAAc;QACd,SAAS,EAAE,OAAO,CAAC,SAAS;QAC5B,QAAQ,EAAE,OAAO,CAAC,KAAK;QACvB,WAAW;QACX,YAAY;QACZ,YAAY,EAAE,OAAO,CAAC,YAAY;QAClC,gBAAgB,EAAE,OAAO,CAAC,gBAAgB;QAC1C,iBAAiB,EAAE,OAAO,CAAC,iBAAiB;QAC5C,UAAU,EAAE,OAAO,CAAC,UAAU;QAC9B,UAAU,EAAE,OAAO,CAAC,UAAU;QAC9B,UAAU,EAAE,OAAO,CAAC,UAAU;QAC9B,aAAa;QACb,oBAAoB;QACpB,QAAQ,EAAE,OAAO,CAAC,QAAQ;QAC1B,eAAe,EAAE,OAAO,CAAC,eAAe;QACxC,KAAK,EAAE,OAAO,CAAC,KAAK;KACrB,CAAC,CAAC;AACL,CAAC"}
@@ -0,0 +1,2 @@
1
+ export {};
2
+ //# sourceMappingURL=review-mr.test.d.ts.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"review-mr.test.d.ts","sourceRoot":"","sources":["../../src/cli/review-mr.test.ts"],"names":[],"mappings":""}
@@ -0,0 +1,142 @@
1
+ import { beforeEach, describe, expect, it, vi } from 'vitest';
2
+ import { reviewMR } from './review-mr.js';
3
+ const { mockGitLabClient, createGitLabClient, executeUnifiedReview } = vi.hoisted(() => ({
4
+ mockGitLabClient: {
5
+ getMergeRequest: vi.fn(),
6
+ getMRChanges: vi.fn(),
7
+ },
8
+ createGitLabClient: vi.fn(),
9
+ executeUnifiedReview: vi.fn(),
10
+ }));
11
+ vi.mock('../gitlab/client.js', () => ({
12
+ createGitLabClient,
13
+ }));
14
+ vi.mock('../lib/unified-review-executor.js', () => ({
15
+ executeUnifiedReview,
16
+ }));
17
+ const baseConfig = {
18
+ pi: {},
19
+ gitlab: { url: 'https://gitlab.com', token: 'token' },
20
+ github: { token: 'token' },
21
+ review: {
22
+ agents: ['security', 'quality'],
23
+ ignorePatterns: [],
24
+ },
25
+ };
26
+ const baseOptions = {
27
+ projectId: 'group/repo',
28
+ mrIid: 42,
29
+ postComments: true,
30
+ postErrorComment: true,
31
+ describe: false,
32
+ postDescription: false,
33
+ };
34
+ describe('review-mr', () => {
35
+ beforeEach(() => {
36
+ vi.clearAllMocks();
37
+ createGitLabClient.mockReturnValue(mockGitLabClient);
38
+ executeUnifiedReview.mockResolvedValue(undefined);
39
+ mockGitLabClient.getMergeRequest.mockResolvedValue({
40
+ iid: 42,
41
+ title: 'Test MR',
42
+ source_branch: 'feature/pi-migration',
43
+ target_branch: 'main',
44
+ author: { name: 'test-user' },
45
+ diff_refs: {
46
+ base_sha: 'base-sha',
47
+ head_sha: 'head-sha',
48
+ start_sha: 'start-sha',
49
+ },
50
+ });
51
+ mockGitLabClient.getMRChanges.mockResolvedValue([
52
+ {
53
+ oldPath: 'src/app.ts',
54
+ newPath: 'src/app.ts',
55
+ newFile: false,
56
+ renamedFile: false,
57
+ deletedFile: false,
58
+ diff: '@@ -8,2 +8,3 @@\n context line\n+new line\n-removed line',
59
+ },
60
+ {
61
+ oldPath: 'src/old.ts',
62
+ newPath: 'src/old.ts',
63
+ newFile: false,
64
+ renamedFile: false,
65
+ deletedFile: true,
66
+ diff: '@@ -1 +0,0 @@\n-old line',
67
+ },
68
+ ]);
69
+ });
70
+ it('loads MR context once and forwards diff-aware validators to unified review', async () => {
71
+ await reviewMR(baseConfig, baseOptions);
72
+ expect(createGitLabClient).toHaveBeenCalledTimes(1);
73
+ expect(mockGitLabClient.getMergeRequest).toHaveBeenCalledWith('group/repo', 42);
74
+ expect(mockGitLabClient.getMRChanges).toHaveBeenCalledWith('group/repo', 42);
75
+ const unifiedOptions = vi.mocked(executeUnifiedReview).mock.calls[0][1];
76
+ expect(unifiedOptions.pullRequest).toEqual(expect.objectContaining({
77
+ number: 42,
78
+ title: 'Test MR',
79
+ }));
80
+ expect(unifiedOptions.changedFiles).toEqual(expect.arrayContaining([
81
+ expect.objectContaining({ filename: 'src/app.ts', status: 'modified' }),
82
+ expect.objectContaining({ filename: 'src/old.ts', status: 'removed' }),
83
+ ]));
84
+ expect(unifiedOptions.lineValidator?.isValidLine('src/app.ts', 8)).toBe(true);
85
+ expect(unifiedOptions.lineValidator?.isValidLine('src/app.ts', 9)).toBe(true);
86
+ expect(unifiedOptions.lineValidator?.isValidLine('src/app.ts', 10)).toBe(false);
87
+ expect(unifiedOptions.lineValidator?.isValidLine('src/old.ts', 1)).toBe(false);
88
+ const inlinePosition = unifiedOptions.createInlinePosition?.({
89
+ category: 'QUALITY',
90
+ severity: 'HIGH',
91
+ title: 'Example issue',
92
+ file: 'src/app.ts',
93
+ line: 9,
94
+ problem: 'Problem',
95
+ solution: 'Solution',
96
+ agent: 'quality',
97
+ }, {
98
+ diff_refs: {
99
+ base_sha: 'base-sha',
100
+ head_sha: 'head-sha',
101
+ start_sha: 'start-sha',
102
+ },
103
+ });
104
+ expect(inlinePosition).toEqual({
105
+ path: 'src/app.ts',
106
+ line: 9,
107
+ baseSha: 'base-sha',
108
+ headSha: 'head-sha',
109
+ startSha: 'start-sha',
110
+ });
111
+ });
112
+ it('rejects with actionable guidance when GITLAB_TOKEN is missing', async () => {
113
+ createGitLabClient.mockImplementationOnce(() => {
114
+ throw new Error('GITLAB_TOKEN environment variable is required');
115
+ });
116
+ await expect(reviewMR(baseConfig, baseOptions)).rejects.toThrow('Set GITLAB_TOKEN');
117
+ expect(executeUnifiedReview).not.toHaveBeenCalled();
118
+ });
119
+ it('maps GitLab authentication failures to actionable errors', async () => {
120
+ mockGitLabClient.getMergeRequest.mockRejectedValueOnce(new Error('401 Unauthorized'));
121
+ await expect(reviewMR(baseConfig, baseOptions)).rejects.toThrow('GitLab authentication failed for group/repo!42');
122
+ expect(executeUnifiedReview).not.toHaveBeenCalled();
123
+ });
124
+ it('maps GitLab not found failures with project/mr remediation', async () => {
125
+ mockGitLabClient.getMergeRequest.mockRejectedValueOnce(new Error('404 Not Found'));
126
+ await expect(reviewMR(baseConfig, baseOptions)).rejects.toThrow('GitLab merge request not found: group/repo!42');
127
+ expect(executeUnifiedReview).not.toHaveBeenCalled();
128
+ });
129
+ it('disables line validation when diff refs are unavailable', async () => {
130
+ mockGitLabClient.getMergeRequest.mockResolvedValueOnce({
131
+ iid: 42,
132
+ title: 'Missing refs',
133
+ source_branch: 'feature/pi-migration',
134
+ target_branch: 'main',
135
+ author: { name: 'test-user' },
136
+ });
137
+ await reviewMR(baseConfig, baseOptions);
138
+ const unifiedOptions = vi.mocked(executeUnifiedReview).mock.calls[0][1];
139
+ expect(unifiedOptions.lineValidator?.isValidLine('src/app.ts', 8)).toBe(false);
140
+ });
141
+ });
142
+ //# sourceMappingURL=review-mr.test.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"review-mr.test.js","sourceRoot":"","sources":["../../src/cli/review-mr.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAI9D,OAAO,EAAE,QAAQ,EAAE,MAAM,gBAAgB,CAAC;AAE1C,MAAM,EAAE,gBAAgB,EAAE,kBAAkB,EAAE,oBAAoB,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;IACvF,gBAAgB,EAAE;QAChB,eAAe,EAAE,EAAE,CAAC,EAAE,EAAE;QACxB,YAAY,EAAE,EAAE,CAAC,EAAE,EAAE;KACtB;IACD,kBAAkB,EAAE,EAAE,CAAC,EAAE,EAAE;IAC3B,oBAAoB,EAAE,EAAE,CAAC,EAAE,EAAE;CAC9B,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,qBAAqB,EAAE,GAAG,EAAE,CAAC,CAAC;IACpC,kBAAkB;CACnB,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,mCAAmC,EAAE,GAAG,EAAE,CAAC,CAAC;IAClD,oBAAoB;CACrB,CAAC,CAAC,CAAC;AAEJ,MAAM,UAAU,GAAG;IACjB,EAAE,EAAE,EAAE;IACN,MAAM,EAAE,EAAE,GAAG,EAAE,oBAAoB,EAAE,KAAK,EAAE,OAAO,EAAE;IACrD,MAAM,EAAE,EAAE,KAAK,EAAE,OAAO,EAAE;IAC1B,MAAM,EAAE;QACN,MAAM,EAAE,CAAC,UAAU,EAAE,SAAS,CAAC;QAC/B,cAAc,EAAE,EAAE;KACnB;CACsB,CAAC;AAE1B,MAAM,WAAW,GAAG;IAClB,SAAS,EAAE,YAAY;IACvB,KAAK,EAAE,EAAE;IACT,YAAY,EAAE,IAAI;IAClB,gBAAgB,EAAE,IAAI;IACtB,QAAQ,EAAE,KAAK;IACf,eAAe,EAAE,KAAK;CACvB,CAAC;AAEF,QAAQ,CAAC,WAAW,EAAE,GAAG,EAAE;IACzB,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QAEnB,kBAAkB,CAAC,eAAe,CAAC,gBAAgB,CAAC,CAAC;QACrD,oBAAoB,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QAElD,gBAAgB,CAAC,eAAe,CAAC,iBAAiB,CAAC;YACjD,GAAG,EAAE,EAAE;YACP,KAAK,EAAE,SAAS;YAChB,aAAa,EAAE,sBAAsB;YACrC,aAAa,EAAE,MAAM;YACrB,MAAM,EAAE,EAAE,IAAI,EAAE,WAAW,EAAE;YAC7B,SAAS,EAAE;gBACT,QAAQ,EAAE,UAAU;gBACpB,QAAQ,EAAE,UAAU;gBACpB,SAAS,EAAE,WAAW;aACvB;SACF,CAAC,CAAC;QAEH,gBAAgB,CAAC,YAAY,CAAC,iBAAiB,CAAC;YAC9C;gBACE,OAAO,EAAE,YAAY;gBACrB,OAAO,EAAE,YAAY;gBACrB,OAAO,EAAE,KAAK;gBACd,WAAW,EAAE,KAAK;gBAClB,WAAW,EAAE,KAAK;gBAClB,IAAI,EAAE,0DAA0D;aACjE;YACD;gBACE,OAAO,EAAE,YAAY;gBACrB,OAAO,EAAE,YAAY;gBACrB,OAAO,EAAE,KAAK;gBACd,WAAW,EAAE,KAAK;gBAClB,WAAW,EAAE,IAAI;gBACjB,IAAI,EAAE,0BAA0B;aACjC;SACF,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4EAA4E,EAAE,KAAK,IAAI,EAAE;QAC1F,MAAM,QAAQ,CAAC,UAAU,EAAE,WAAW,CAAC,CAAC;QAExC,MAAM,CAAC,kBAAkB,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QACpD,MAAM,CAAC,gBAAgB,CAAC,eAAe,CAAC,CAAC,oBAAoB,CAAC,YAAY,EAAE,EAAE,CAAC,CAAC;QAChF,MAAM,CAAC,gBAAgB,CAAC,YAAY,CAAC,CAAC,oBAAoB,CAAC,YAAY,EAAE,EAAE,CAAC,CAAC;QAE7E,MAAM,cAAc,GAAG,EAAE,CAAC,MAAM,CAAC,oBAAoB,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAyB,CAAC;QAEhG,MAAM,CAAC,cAAc,CAAC,WAAW,CAAC,CAAC,OAAO,CACxC,MAAM,CAAC,gBAAgB,CAAC;YACtB,MAAM,EAAE,EAAE;YACV,KAAK,EAAE,SAAS;SACjB,CAAC,CACH,CAAC;QACF,MAAM,CAAC,cAAc,CAAC,YAAY,CAAC,CAAC,OAAO,CACzC,MAAM,CAAC,eAAe,CAAC;YACrB,MAAM,CAAC,gBAAgB,CAAC,EAAE,QAAQ,EAAE,YAAY,EAAE,MAAM,EAAE,UAAU,EAAE,CAAC;YACvE,MAAM,CAAC,gBAAgB,CAAC,EAAE,QAAQ,EAAE,YAAY,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC;SACvE,CAAC,CACH,CAAC;QAEF,MAAM,CAAC,cAAc,CAAC,aAAa,EAAE,WAAW,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC9E,MAAM,CAAC,cAAc,CAAC,aAAa,EAAE,WAAW,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC9E,MAAM,CAAC,cAAc,CAAC,aAAa,EAAE,WAAW,CAAC,YAAY,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChF,MAAM,CAAC,cAAc,CAAC,aAAa,EAAE,WAAW,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAE/E,MAAM,cAAc,GAAG,cAAc,CAAC,oBAAoB,EAAE,CAC1D;YACE,QAAQ,EAAE,SAAS;YACnB,QAAQ,EAAE,MAAM;YAChB,KAAK,EAAE,eAAe;YACtB,IAAI,EAAE,YAAY;YAClB,IAAI,EAAE,CAAC;YACP,OAAO,EAAE,SAAS;YAClB,QAAQ,EAAE,UAAU;YACpB,KAAK,EAAE,SAAS;SACF,EAChB;YACE,SAAS,EAAE;gBACT,QAAQ,EAAE,UAAU;gBACpB,QAAQ,EAAE,UAAU;gBACpB,SAAS,EAAE,WAAW;aACvB;SACF,CACF,CAAC;QAEF,MAAM,CAAC,cAAc,CAAC,CAAC,OAAO,CAAC;YAC7B,IAAI,EAAE,YAAY;YAClB,IAAI,EAAE,CAAC;YACP,OAAO,EAAE,UAAU;YACnB,OAAO,EAAE,UAAU;YACnB,QAAQ,EAAE,WAAW;SACtB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+DAA+D,EAAE,KAAK,IAAI,EAAE;QAC7E,kBAAkB,CAAC,sBAAsB,CAAC,GAAG,EAAE;YAC7C,MAAM,IAAI,KAAK,CAAC,+CAA+C,CAAC,CAAC;QACnE,CAAC,CAAC,CAAC;QAEH,MAAM,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,kBAAkB,CAAC,CAAC;QACpF,MAAM,CAAC,oBAAoB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACtD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0DAA0D,EAAE,KAAK,IAAI,EAAE;QACxE,gBAAgB,CAAC,eAAe,CAAC,qBAAqB,CAAC,IAAI,KAAK,CAAC,kBAAkB,CAAC,CAAC,CAAC;QAEtF,MAAM,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAC7D,gDAAgD,CACjD,CAAC;QACF,MAAM,CAAC,oBAAoB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACtD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4DAA4D,EAAE,KAAK,IAAI,EAAE;QAC1E,gBAAgB,CAAC,eAAe,CAAC,qBAAqB,CAAC,IAAI,KAAK,CAAC,eAAe,CAAC,CAAC,CAAC;QAEnF,MAAM,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAC7D,+CAA+C,CAChD,CAAC;QACF,MAAM,CAAC,oBAAoB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACtD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,KAAK,IAAI,EAAE;QACvE,gBAAgB,CAAC,eAAe,CAAC,qBAAqB,CAAC;YACrD,GAAG,EAAE,EAAE;YACP,KAAK,EAAE,cAAc;YACrB,aAAa,EAAE,sBAAsB;YACrC,aAAa,EAAE,MAAM;YACrB,MAAM,EAAE,EAAE,IAAI,EAAE,WAAW,EAAE;SAC9B,CAAC,CAAC;QAEH,MAAM,QAAQ,CAAC,UAAU,EAAE,WAAW,CAAC,CAAC;QAExC,MAAM,cAAc,GAAG,EAAE,CAAC,MAAM,CAAC,oBAAoB,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAyB,CAAC;QAChG,MAAM,CAAC,cAAc,CAAC,aAAa,EAAE,WAAW,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IACjF,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
@@ -13,7 +13,7 @@ export interface ReviewPROptions {
13
13
  debug?: boolean;
14
14
  }
15
15
  /**
16
- * Review a GitHub pull request
16
+ * Review a GitHub pull request.
17
17
  */
18
18
  export declare function reviewPR(config: DRSConfig, options: ReviewPROptions): Promise<void>;
19
19
  //# sourceMappingURL=review-pr.d.ts.map
@@ -1 +1 @@
1
- {"version":3,"file":"review-pr.d.ts","sourceRoot":"","sources":["../../src/cli/review-pr.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,kBAAkB,CAAC;AAOlD,MAAM,WAAW,eAAe;IAC9B,KAAK,EAAE,MAAM,CAAC;IACd,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,EAAE,MAAM,CAAC;IACjB,YAAY,EAAE,OAAO,CAAC;IACtB,gBAAgB,EAAE,OAAO,CAAC;IAC1B,QAAQ,EAAE,OAAO,CAAC;IAClB,eAAe,EAAE,OAAO,CAAC;IACzB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAwCD;;GAEG;AACH,wBAAsB,QAAQ,CAAC,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,eAAe,GAAG,OAAO,CAAC,IAAI,CAAC,CA0DzF"}
1
+ {"version":3,"file":"review-pr.d.ts","sourceRoot":"","sources":["../../src/cli/review-pr.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,kBAAkB,CAAC;AAYlD,MAAM,WAAW,eAAe;IAC9B,KAAK,EAAE,MAAM,CAAC;IACd,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,EAAE,MAAM,CAAC;IACjB,YAAY,EAAE,OAAO,CAAC;IACtB,gBAAgB,EAAE,OAAO,CAAC;IAC1B,QAAQ,EAAE,OAAO,CAAC;IAClB,eAAe,EAAE,OAAO,CAAC;IACzB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AA8KD;;GAEG;AACH,wBAAsB,QAAQ,CAAC,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,eAAe,GAAG,OAAO,CAAC,IAAI,CAAC,CA6DzF"}