@diegovelasquezweb/a11y-engine 0.11.51 → 0.11.53

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@diegovelasquezweb/a11y-engine",
-  "version": "0.11.51",
+  "version": "0.11.53",
   "description": "WCAG 2.2 accessibility audit engine — scanner, analyzer, and report builders",
   "type": "module",
   "license": "MIT",

package/src/fixes/apply-finding-fix.mjs

@@ -465,16 +465,32 @@ function detectStylingSystem(aiInput) {
   return "inline";
 }
 
+export function buildStyleInstruction(stylingSystem) {
+  if (stylingSystem === "tailwind") {
+    return (
+      "This project uses Tailwind CSS. Apply style fixes as Tailwind utility classes in the HTML/JSX file — do not write raw CSS. " +
+      "For inline style attributes that suppress focus (e.g. style=\"outline: none\"): remove outline: none from the style attribute and add focus-visible: Tailwind utility classes (e.g. focus-visible:outline-2 focus-visible:outline-offset-2) directly on the element instead."
+    );
+  }
+  if (stylingSystem === "css") {
+    return (
+      "CSS/SCSS files are available in the files array. Prefer fixing visual issues (touch targets, color contrast) in the CSS/SCSS file using proper selectors. " +
+      "For violations in a CSS/SCSS file: add or update the rule there directly. " +
+      "For violations in an inline HTML style attribute (e.g. style=\"outline: none\"): make TWO changes — " +
+      "(1) remove outline: none / outline: 0 from the HTML style attribute, " +
+      "(2) add a :focus-visible rule in the CSS/SCSS file targeting the element."
+    );
+  }
+  return (
+    "No CSS file was provided. Remove outline: none or outline: 0 from the style attribute entirely and rely on the browser default focus indicator. " +
+    "Do not add new CSS files."
+  );
+}
+
 async function callClaudeForPatch({ apiKey, model, aiInput, remediationPath }) {
   const remediationContext = extractRemediationContext(remediationPath);
   const stylingSystem = detectStylingSystem(aiInput);
-
-  const styleInstruction =
-    stylingSystem === "tailwind"
-      ? "This project uses Tailwind CSS. Apply style fixes as Tailwind utility classes in the HTML/JSX file — do not write raw CSS."
-      : stylingSystem === "css"
-      ? "CSS/SCSS files are available in the files array. Prefer fixing visual issues (touch targets, color contrast, focus outlines) in the CSS/SCSS file using proper selectors rather than inline styles."
-      : "No CSS file was provided. Apply style fixes using inline style attributes in the HTML file.";
+  const styleInstruction = buildStyleInstruction(stylingSystem);
 
   const system = [
     "You are an accessibility fix engine.",
@@ -696,19 +712,36 @@ export async function applyFindingFix(input) {
 
     const validation = validateAiPatchOutput(patchOutput, projectDir, candidateSet);
     if (!validation.ok) {
-      // When Claude returns no changes, it may be because a prior fix (e.g. the DOM
-      // batch) already resolved this issue. Verify by checking if the pattern's
-      // context_reject_regex now matches the surroundingLines of the target element.
+      // When Claude returns no changes OR a no-op patch (search===replace), it may be
+      // because a prior fix (e.g. the DOM batch) already resolved this issue.
+      // Verify by checking if the pattern's context_reject_regex now matches the
+      // current file content around the target element.
       // If it does, the element is already accessible — count as resolved.
-      if (validation.reason === "AI patch output has no changes") {
+      const isNoChanges = validation.reason === "AI patch output has no changes";
+      const isNoop = validation.reason.startsWith("AI generated a no-op patch for ");
+      if (isNoChanges || isNoop) {
         const patternId = finding.pattern_id || finding.patternId || "";
         const patternDef = (ASSETS.remediation.codePatterns?.patterns || [])
           .find((p) => p.id === patternId);
         const rejectRegex = patternDef?.context_reject_regex;
         if (rejectRegex) {
-          const context = [aiInput.finding.surroundingLines, aiInput.finding.matchLine]
-            .filter(Boolean)
-            .join("\n");
+          // For no-op patches, read the CURRENT file content — the DOM batch may have
+          // already resolved this finding by modifying the file after the scan.
+          let context;
+          if (isNoop) {
+            try {
+              const currentContent = fs.readFileSync(candidate.abs, "utf8");
+              const fileLines = currentContent.split("\n");
+              const lineIdx = Math.max(0, (aiInput.finding.line || 1) - 1);
+              const start = Math.max(0, lineIdx - 4);
+              const end = Math.min(fileLines.length, lineIdx + 5);
+              context = fileLines.slice(start, end).join("\n");
+            } catch {
+              context = [aiInput.finding.surroundingLines, aiInput.finding.matchLine].filter(Boolean).join("\n");
+            }
+          } else {
+            context = [aiInput.finding.surroundingLines, aiInput.finding.matchLine].filter(Boolean).join("\n");
+          }
           try {
             if (new RegExp(rejectRegex, "i").test(context)) {
               return buildResult({