@diegopetrucci/pi-extensions 0.1.74 → 0.1.78

package/extensions/review/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@diegopetrucci/pi-review",
-  "version": "0.1.14",
+  "version": "0.1.15",
   "description": "A standalone pi extension that adds /review and /end-review commands adapted from mitsuhiko/agent-stuff.",
   "keywords": [
     "pi-package",

package/extensions/todo/index.ts

@@ -1,301 +1,301 @@
-/**
- * Todo Extension - Demonstrates state management via session entries
- *
- * This extension:
- * - Registers a `todo` tool for the LLM to manage todos
- * - Registers a `/todos` command for users to view the list
- *
- * State is stored in tool result details (not external files), which allows
- * proper branching - when you branch, the todo state is automatically
- * correct for that point in history.
- */
-
 import { StringEnum } from "@earendil-works/pi-ai";
 import type { ExtensionAPI, ExtensionContext, Theme } from "@earendil-works/pi-coding-agent";
 import { matchesKey, Text, truncateToWidth } from "@earendil-works/pi-tui";
 import { Type } from "typebox";
 
 interface Todo {
-	id: number;
-	text: string;
-	done: boolean;
+  id: number;
+  text: string;
+  done: boolean;
 }
 
 interface TodoDetails {
-	action: "list" | "add" | "toggle" | "clear";
-	todos: Todo[];
-	nextId: number;
-	error?: string;
+  action: "list" | "add" | "toggle" | "clear";
+  todos: Todo[];
+  nextId: number;
+  error?: string;
 }
 
 const cloneTodos = (items: Todo[]): Todo[] => items.map((todo) => ({ ...todo }));
 
 const TodoParams = Type.Object({
-	action: StringEnum(["list", "add", "toggle", "clear"] as const),
-	text: Type.Optional(Type.String({ description: "Todo text (for add)" })),
-	id: Type.Optional(Type.Number({ description: "Todo ID (for toggle)" })),
+  action: StringEnum(["list", "add", "toggle", "clear"] as const),
+  text: Type.Optional(Type.String({ description: "Todo text (for add)" })),
+  id: Type.Optional(Type.Number({ description: "Todo ID (for toggle)" })),
 });
 
-/**
- * UI component for the /todos command
- */
 class TodoListComponent {
-	private todos: Todo[];
-	private theme: Theme;
-	private onClose: () => void;
-	private cachedWidth?: number;
-	private cachedLines?: string[];
-
-	constructor(todos: Todo[], theme: Theme, onClose: () => void) {
-		this.todos = todos;
-		this.theme = theme;
-		this.onClose = onClose;
-	}
-
-	handleInput(data: string): void {
-		if (matchesKey(data, "escape") || matchesKey(data, "ctrl+c")) {
-			this.onClose();
-		}
-	}
-
-	render(width: number): string[] {
-		if (this.cachedLines && this.cachedWidth === width) {
-			return this.cachedLines;
-		}
-
-		const lines: string[] = [];
-		const th = this.theme;
-
-		lines.push("");
-		const title = th.fg("accent", " Todos ");
-		const headerLine =
-			th.fg("borderMuted", "─".repeat(3)) + title + th.fg("borderMuted", "─".repeat(Math.max(0, width - 10)));
-		lines.push(truncateToWidth(headerLine, width));
-		lines.push("");
-
-		if (this.todos.length === 0) {
-			lines.push(truncateToWidth(`  ${th.fg("dim", "No todos yet. Ask the agent to add some!")}`, width));
-		} else {
-			const done = this.todos.filter((t) => t.done).length;
-			const total = this.todos.length;
-			lines.push(truncateToWidth(`  ${th.fg("muted", `${done}/${total} completed`)}`, width));
-			lines.push("");
-
-			for (const todo of this.todos) {
-				const check = todo.done ? th.fg("success", "✓") : th.fg("dim", "○");
-				const id = th.fg("accent", `#${todo.id}`);
-				const text = todo.done ? th.fg("dim", todo.text) : th.fg("text", todo.text);
-				lines.push(truncateToWidth(`  ${check} ${id} ${text}`, width));
-			}
-		}
-
-		lines.push("");
-		lines.push(truncateToWidth(`  ${th.fg("dim", "Press Escape to close")}`, width));
-		lines.push("");
-
-		this.cachedWidth = width;
-		this.cachedLines = lines;
-		return lines;
-	}
-
-	invalidate(): void {
-		this.cachedWidth = undefined;
-		this.cachedLines = undefined;
-	}
+  private todos: Todo[];
+  private theme: Theme;
+  private onClose: () => void;
+  private cachedWidth?: number;
+  private cachedLines?: string[];
+
+  constructor(todos: Todo[], theme: Theme, onClose: () => void) {
+    this.todos = todos;
+    this.theme = theme;
+    this.onClose = onClose;
+  }
+
+  handleInput(data: string): void {
+    if (matchesKey(data, "escape") || matchesKey(data, "ctrl+c")) {
+      this.onClose();
+    }
+  }
+
+  render(width: number): string[] {
+    if (this.cachedLines && this.cachedWidth === width) {
+      return this.cachedLines;
+    }
+
+    const lines: string[] = [];
+    const th = this.theme;
+
+    lines.push("");
+    const title = th.fg("accent", " Todos ");
+    const headerLine =
+      th.fg("borderMuted", "─".repeat(3)) +
+      title +
+      th.fg("borderMuted", "─".repeat(Math.max(0, width - 10)));
+    lines.push(truncateToWidth(headerLine, width));
+    lines.push("");
+
+    if (this.todos.length === 0) {
+      lines.push(
+        truncateToWidth(`  ${th.fg("dim", "No todos yet. Ask the agent to add some!")}`, width),
+      );
+    } else {
+      const done = this.todos.filter((t) => t.done).length;
+      const total = this.todos.length;
+      lines.push(truncateToWidth(`  ${th.fg("muted", `${done}/${total} completed`)}`, width));
+      lines.push("");
+
+      for (const todo of this.todos) {
+        const check = todo.done ? th.fg("success", "✓") : th.fg("dim", "○");
+        const id = th.fg("accent", `#${todo.id}`);
+        const text = todo.done ? th.fg("dim", todo.text) : th.fg("text", todo.text);
+        lines.push(truncateToWidth(`  ${check} ${id} ${text}`, width));
+      }
+    }
+
+    lines.push("");
+    lines.push(truncateToWidth(`  ${th.fg("dim", "Press Escape to close")}`, width));
+    lines.push("");
+
+    this.cachedWidth = width;
+    this.cachedLines = lines;
+    return lines;
+  }
+
+  invalidate(): void {
+    this.cachedWidth = undefined;
+    this.cachedLines = undefined;
+  }
 }
 
 export default function (pi: ExtensionAPI) {
-	// In-memory state (reconstructed from session on load)
-	let todos: Todo[] = [];
-	let nextId = 1;
-
-	/**
-	 * Reconstruct state from session entries.
-	 * Scans tool results for this tool and applies them in order.
-	 */
-	const reconstructState = (ctx: ExtensionContext) => {
-		todos = [];
-		nextId = 1;
-
-		for (const entry of ctx.sessionManager.getBranch()) {
-			if (entry.type !== "message") continue;
-			const msg = entry.message;
-			if (msg.role !== "toolResult" || msg.toolName !== "todo") continue;
-
-			const details = msg.details as TodoDetails | undefined;
-			if (details) {
-				todos = cloneTodos(details.todos);
-				nextId = details.nextId;
-			}
-		}
-	};
-
-	// Reconstruct state on session events
-	pi.on("session_start", async (_event, ctx) => reconstructState(ctx));
-	pi.on("session_tree", async (_event, ctx) => reconstructState(ctx));
-
-	// Register the todo tool for the LLM
-	pi.registerTool({
-		name: "todo",
-		label: "Todo",
-		description: "Manage a todo list. Actions: list, add (text), toggle (id), clear",
-		parameters: TodoParams,
-
-		async execute(_toolCallId, params, _signal, _onUpdate, _ctx) {
-			switch (params.action) {
-				case "list":
-					return {
-						content: [
-							{
-								type: "text",
-								text: todos.length
-									? todos.map((t) => `[${t.done ? "x" : " "}] #${t.id}: ${t.text}`).join("\n")
-									: "No todos",
-							},
-						],
-						details: { action: "list", todos: cloneTodos(todos), nextId } as TodoDetails,
-					};
-
-				case "add": {
-					if (!params.text) {
-						return {
-							content: [{ type: "text", text: "Error: text required for add" }],
-							details: { action: "add", todos: cloneTodos(todos), nextId, error: "text required" } as TodoDetails,
-						};
-					}
-					const newTodo: Todo = { id: nextId++, text: params.text, done: false };
-					todos = [...todos, newTodo];
-					return {
-						content: [{ type: "text", text: `Added todo #${newTodo.id}: ${newTodo.text}` }],
-						details: { action: "add", todos: cloneTodos(todos), nextId } as TodoDetails,
-					};
-				}
-
-				case "toggle": {
-					if (params.id === undefined) {
-						return {
-							content: [{ type: "text", text: "Error: id required for toggle" }],
-							details: { action: "toggle", todos: cloneTodos(todos), nextId, error: "id required" } as TodoDetails,
-						};
-					}
-					const targetId = params.id;
-					const todo = todos.find((t) => t.id === targetId);
-					if (!todo) {
-						return {
-							content: [{ type: "text", text: `Todo #${targetId} not found` }],
-							details: {
-								action: "toggle",
-								todos: cloneTodos(todos),
-								nextId,
-								error: `#${targetId} not found`,
-							} as TodoDetails,
-						};
-					}
-					todos = todos.map((t) => (t.id === targetId ? { ...t, done: !t.done } : t));
-					const updated = todos.find((t) => t.id === targetId)!;
-					return {
-						content: [{ type: "text", text: `Todo #${updated.id} ${updated.done ? "completed" : "uncompleted"}` }],
-						details: { action: "toggle", todos: cloneTodos(todos), nextId } as TodoDetails,
-					};
-				}
-
-				case "clear": {
-					const count = todos.length;
-					todos = [];
-					nextId = 1;
-					return {
-						content: [{ type: "text", text: `Cleared ${count} todos` }],
-						details: { action: "clear", todos: [], nextId: 1 } as TodoDetails,
-					};
-				}
-
-				default:
-					return {
-						content: [{ type: "text", text: `Unknown action: ${params.action}` }],
-						details: {
-							action: "list",
-							todos: cloneTodos(todos),
-							nextId,
-							error: `unknown action: ${params.action}`,
-						} as TodoDetails,
-					};
-			}
-		},
-
-		renderCall(args, theme, _context) {
-			let text = theme.fg("toolTitle", theme.bold("todo ")) + theme.fg("muted", args.action);
-			if (args.text) text += ` ${theme.fg("dim", `"${args.text}"`)}`;
-			if (args.id !== undefined) text += ` ${theme.fg("accent", `#${args.id}`)}`;
-			return new Text(text, 0, 0);
-		},
-
-		renderResult(result, { expanded }, theme, _context) {
-			const details = result.details as TodoDetails | undefined;
-			if (!details) {
-				const text = result.content[0];
-				return new Text(text?.type === "text" ? text.text : "", 0, 0);
-			}
-
-			if (details.error) {
-				return new Text(theme.fg("error", `Error: ${details.error}`), 0, 0);
-			}
-
-			const todoList = details.todos;
-
-			switch (details.action) {
-				case "list": {
-					if (todoList.length === 0) {
-						return new Text(theme.fg("dim", "No todos"), 0, 0);
-					}
-					let listText = theme.fg("muted", `${todoList.length} todo(s):`);
-					const display = expanded ? todoList : todoList.slice(0, 5);
-					for (const t of display) {
-						const check = t.done ? theme.fg("success", "✓") : theme.fg("dim", "○");
-						const itemText = t.done ? theme.fg("dim", t.text) : theme.fg("muted", t.text);
-						listText += `\n${check} ${theme.fg("accent", `#${t.id}`)} ${itemText}`;
-					}
-					if (!expanded && todoList.length > 5) {
-						listText += `\n${theme.fg("dim", `... ${todoList.length - 5} more`)}`;
-					}
-					return new Text(listText, 0, 0);
-				}
-
-				case "add": {
-					const added = todoList[todoList.length - 1];
-					return new Text(
-						theme.fg("success", "✓ Added ") +
-							theme.fg("accent", `#${added.id}`) +
-							" " +
-							theme.fg("muted", added.text),
-						0,
-						0,
-					);
-				}
-
-				case "toggle": {
-					const text = result.content[0];
-					const msg = text?.type === "text" ? text.text : "";
-					return new Text(theme.fg("success", "✓ ") + theme.fg("muted", msg), 0, 0);
-				}
-
-				case "clear":
-					return new Text(theme.fg("success", "✓ ") + theme.fg("muted", "Cleared all todos"), 0, 0);
-			}
-		},
-	});
-
-	// Register the /todos command for users
-	pi.registerCommand("todos", {
-		description: "Show all todos on the current branch",
-		handler: async (_args, ctx) => {
-			if (ctx.mode !== "tui") {
-				ctx.ui.notify("/todos requires interactive mode", "error");
-				return;
-			}
-
-			await ctx.ui.custom<void>((_tui, theme, _kb, done) => {
-				return new TodoListComponent(todos, theme, () => done());
-			});
-		},
-	});
+  let todos: Todo[] = [];
+  let nextId = 1;
+
+  /**
+   * Reconstruct state from session entries.
+   * Scans tool results for this tool and applies them in order.
+   */
+  const reconstructState = (ctx: ExtensionContext) => {
+    todos = [];
+    nextId = 1;
+
+    for (const entry of ctx.sessionManager.getBranch()) {
+      if (entry.type !== "message") continue;
+      const msg = entry.message;
+      if (msg.role !== "toolResult" || msg.toolName !== "todo") continue;
+
+      const details = msg.details as TodoDetails | undefined;
+      if (details) {
+        todos = cloneTodos(details.todos);
+        nextId = details.nextId;
+      }
+    }
+  };
+
+  pi.on("session_start", async (_event, ctx) => reconstructState(ctx));
+  pi.on("session_tree", async (_event, ctx) => reconstructState(ctx));
+
+  pi.registerTool({
+    name: "todo",
+    label: "Todo",
+    description: "Manage a todo list. Actions: list, add (text), toggle (id), clear",
+    parameters: TodoParams,
+
+    async execute(_toolCallId, params, _signal, _onUpdate, _ctx) {
+      switch (params.action) {
+        case "list":
+          return {
+            content: [
+              {
+                type: "text",
+                text: todos.length
+                  ? todos.map((t) => `[${t.done ? "x" : " "}] #${t.id}: ${t.text}`).join("\n")
+                  : "No todos",
+              },
+            ],
+            details: { action: "list", todos: cloneTodos(todos), nextId } as TodoDetails,
+          };
+
+        case "add": {
+          if (!params.text) {
+            return {
+              content: [{ type: "text", text: "Error: text required for add" }],
+              details: {
+                action: "add",
+                todos: cloneTodos(todos),
+                nextId,
+                error: "text required",
+              } as TodoDetails,
+            };
+          }
+          const newTodo: Todo = { id: nextId++, text: params.text, done: false };
+          todos = [...todos, newTodo];
+          return {
+            content: [{ type: "text", text: `Added todo #${newTodo.id}: ${newTodo.text}` }],
+            details: { action: "add", todos: cloneTodos(todos), nextId } as TodoDetails,
+          };
+        }
+
+        case "toggle": {
+          if (params.id === undefined) {
+            return {
+              content: [{ type: "text", text: "Error: id required for toggle" }],
+              details: {
+                action: "toggle",
+                todos: cloneTodos(todos),
+                nextId,
+                error: "id required",
+              } as TodoDetails,
+            };
+          }
+          const targetId = params.id;
+          const todo = todos.find((t) => t.id === targetId);
+          if (!todo) {
+            return {
+              content: [{ type: "text", text: `Todo #${targetId} not found` }],
+              details: {
+                action: "toggle",
+                todos: cloneTodos(todos),
+                nextId,
+                error: `#${targetId} not found`,
+              } as TodoDetails,
+            };
+          }
+          todos = todos.map((t) => (t.id === targetId ? { ...t, done: !t.done } : t));
+          const updated = todos.find((t) => t.id === targetId)!;
+          return {
+            content: [
+              {
+                type: "text",
+                text: `Todo #${updated.id} ${updated.done ? "completed" : "uncompleted"}`,
+              },
+            ],
+            details: { action: "toggle", todos: cloneTodos(todos), nextId } as TodoDetails,
+          };
+        }
+
+        case "clear": {
+          const count = todos.length;
+          todos = [];
+          nextId = 1;
+          return {
+            content: [{ type: "text", text: `Cleared ${count} todos` }],
+            details: { action: "clear", todos: [], nextId: 1 } as TodoDetails,
+          };
+        }
+
+        default:
+          return {
+            content: [{ type: "text", text: `Unknown action: ${params.action}` }],
+            details: {
+              action: "list",
+              todos: cloneTodos(todos),
+              nextId,
+              error: `unknown action: ${params.action}`,
+            } as TodoDetails,
+          };
+      }
+    },
+
+    renderCall(args, theme, _context) {
+      let text = theme.fg("toolTitle", theme.bold("todo ")) + theme.fg("muted", args.action);
+      if (args.text) text += ` ${theme.fg("dim", `"${args.text}"`)}`;
+      if (args.id !== undefined) text += ` ${theme.fg("accent", `#${args.id}`)}`;
+      return new Text(text, 0, 0);
+    },
+
+    renderResult(result, { expanded }, theme, _context) {
+      const details = result.details as TodoDetails | undefined;
+      if (!details) {
+        const text = result.content[0];
+        return new Text(text?.type === "text" ? text.text : "", 0, 0);
+      }
+
+      if (details.error) {
+        return new Text(theme.fg("error", `Error: ${details.error}`), 0, 0);
+      }
+
+      const todoList = details.todos;
+
+      switch (details.action) {
+        case "list": {
+          if (todoList.length === 0) {
+            return new Text(theme.fg("dim", "No todos"), 0, 0);
+          }
+          let listText = theme.fg("muted", `${todoList.length} todo(s):`);
+          const display = expanded ? todoList : todoList.slice(0, 5);
+          for (const t of display) {
+            const check = t.done ? theme.fg("success", "✓") : theme.fg("dim", "○");
+            const itemText = t.done ? theme.fg("dim", t.text) : theme.fg("muted", t.text);
+            listText += `\n${check} ${theme.fg("accent", `#${t.id}`)} ${itemText}`;
+          }
+          if (!expanded && todoList.length > 5) {
+            listText += `\n${theme.fg("dim", `... ${todoList.length - 5} more`)}`;
+          }
+          return new Text(listText, 0, 0);
+        }
+
+        case "add": {
+          const added = todoList[todoList.length - 1];
+          return new Text(
+            theme.fg("success", "✓ Added ") +
+              theme.fg("accent", `#${added.id}`) +
+              " " +
+              theme.fg("muted", added.text),
+            0,
+            0,
+          );
+        }
+
+        case "toggle": {
+          const text = result.content[0];
+          const msg = text?.type === "text" ? text.text : "";
+          return new Text(theme.fg("success", "✓ ") + theme.fg("muted", msg), 0, 0);
+        }
+
+        case "clear":
+          return new Text(theme.fg("success", "✓ ") + theme.fg("muted", "Cleared all todos"), 0, 0);
+      }
+    },
+  });
+
+  pi.registerCommand("todos", {
+    description: "Show all todos on the current branch",
+    handler: async (_args, ctx) => {
+      if (ctx.mode !== "tui") {
+        ctx.ui.notify("/todos requires interactive mode", "error");
+        return;
+      }
+
+      await ctx.ui.custom<void>((_tui, theme, _kb, done) => {
+        return new TodoListComponent(todos, theme, () => done());
+      });
+    },
+  });
 }

package/extensions/todo/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@diegopetrucci/pi-todo",
-  "version": "0.1.11",
+  "version": "0.1.12",
   "description": "A pi extension that adds a branch-aware todo tool and /todos viewer.",
   "keywords": [
     "pi-package",

package/extensions/triage-comments/README.md

@@ -1,8 +1,8 @@
 # triage-comments
 
-Adds `/triage-comments` plus a read-only `triage_comments` subagent tool for evidence-based review-comment triage.
+Adds `/triage-comments` plus a `triage_comments` subagent tool with read-only built-in tools and configured MCP tools for evidence-based review-comment triage.
 
-Use it when you want The Last Harness to inspect selected PR feedback, classify whether each comment is valid, cite local evidence, draft review-thread responses, and propose handling options. It does **not** implement changes; after triage, the main agent should ask which handling option to take before editing anything.
+Use it when you want `/triage-comments` to inspect selected PR feedback, classify whether each comment is valid, cite local evidence, draft review-thread responses, and propose handling options. It does **not** implement changes; after triage, the main agent should ask which handling option to take before editing anything.
 
 ## Install
 
@@ -43,7 +43,7 @@ The extension registers `/triage-comments` as an interactive intake flow.
 /triage-comments 123
 ```
 
-- With no arguments, The Last Harness asks whether to paste feedback or fetch PR comments.
+- With no arguments, `/triage-comments` asks whether to paste feedback or fetch PR comments.
 - `paste` opens an editor for multiline reviewer feedback, then sends one selected feedback item to the main agent.
 - `pr` with no explicit target first tries to detect an existing PR for the current named non-`main` git branch using read-only `git` and `gh pr view` calls. If the branch is `main`, detached, outside a git repository, `gh` is unavailable or unauthenticated, or no PR is found, it falls back to the PR URL/number prompt.
 - `pr <PR URL or number>` and a bare PR URL/number fetch that explicit PR directly, display PR review comments, PR issue comments, and review bodies with `gh` as numbered items with stable IDs, and ask whether to investigate all displayed comments or an explicit subset such as `1,3-5`.
@@ -71,7 +71,8 @@ The tool accepts selected comments and optional PR, base, diff, and caller conte
 When called, it launches an isolated in-memory subagent with:
 
 - no inherited extensions, skills, prompt templates, themes, context files, or agents files;
-- read-only tools only: `read`, `grep`, `find`, `ls`, and guarded `bash`;
+- read-only built-in tools: `read`, `grep`, `find`, `ls`, and guarded `bash`;
+- configured MCP tools (run without confirmation in the subagent; may have side effects; use for evidence gathering only; requires host Pi >=1.0.4; older hosts degrade to no MCP, no error); the global `mcp.json` always applies; a project `.pi/mcp.json` is loaded only when the host session has already trusted the project;
 - a local-checkout path guard for file inspection;
 - a bash guard that allows only direct read-only `git`, `gh`, or `pwd` invocations and blocks write/edit tools, shell pipelines, redirection, destructive git commands, and mutating `gh`/GitHub API calls;
 - a fixed triage output format with verdicts, evidence, reasoning, suggested responses, handling options, and a list of read-only checks performed.
@@ -83,6 +84,7 @@ Verdicts are one of `valid`, `invalid`, `partially valid`, `subjective`, or `nee
 - The slash command only collects/selects comments and asks the main agent to run triage.
 - The subagent is explicitly instructed not to implement changes.
 - Runtime guards block write tools, filesystem mutation through shell syntax, mutating git commands, and mutating GitHub CLI/API calls.
+- Runtime guards apply to built-in tools only; configured MCP tools pass the guard, run without confirmation, and are limited only by prompt guidance.
 - The generated prompt tells the main agent to summarize findings and ask which handling option to take before implementation.
 - Suggested responses are drafts for the user/agent to adapt; the extension does not post them to GitHub.