@diegopetrucci/pi-extensions 0.1.72 → 0.1.73

package/README.md

@@ -24,8 +24,8 @@ A collection of [pi](https://pi.dev) agent extensions I made. (Btw, [I am also b
 ### / Slash commands
 
 - [`agent-workflow-audit`](./extensions/agent-workflow-audit): Adds `/agent-workflow-audit`, which runs an isolated repo workflow audit subagent and returns only the final distilled report to the main session.
-- [`annotate-git-diff`](./extensions/annotate-git-diff): Adds `/annotate-git-diff`, a native Glimpse UI for annotating git diffs and appending structured feedback prompts to the editor.
-- [`annotate-last-message`](./extensions/annotate-last-message): Adds `/annotate-last-message`, a native Glimpse UI for annotating the latest assistant reply and sending planning-oriented feedback back through the editor.
+- [`annotate-git-diff`](./extensions/annotate-git-diff): Adds `/annotate-git-diff`, a native Glimpse UI where explicit Submit sends structured feedback to the agent and close recovery keeps an unsent draft in the editor.
+- [`annotate-last-message`](./extensions/annotate-last-message): Adds `/annotate-last-message`, a native Glimpse UI for annotating the latest assistant reply and sending planning-oriented feedback directly to the agent.
 - [`review`](./extensions/review): Adds `/review` and `/end-review` for interactive code reviews of local changes, commits, PRs, and selected paths.
 - [`triage-comments`](./extensions/triage-comments): Adds `/triage-comments` and a read-only `triage_comments` subagent tool that can auto-detect the current branch's PR, filter resolved/outdated inline comments, classify selected review comments with evidence, and suggest handling options without implementing changes
 

package/extensions/agent-workflow-audit/index.ts

@@ -148,14 +148,39 @@ function messageContentToText(content: unknown): string {
 	return parts.join("\n").trim();
 }
 
-function extractLastAssistantText(messages: unknown[]): string {
+type AuditAssistantOutcome =
+	| { ok: true; answer: string; stopReason?: string }
+	| { ok: false; reason: string; stopReason?: string; errorMessage?: string };
+
+function inspectFinalAssistant(messages: unknown[]): AuditAssistantOutcome {
 	for (let i = messages.length - 1; i >= 0; i--) {
-		const message = messages[i] as { role?: string; content?: unknown };
+		const message = messages[i] as { role?: string; content?: unknown; stopReason?: unknown; errorMessage?: unknown };
 		if (message?.role !== "assistant") continue;
-		const text = messageContentToText(message.content);
-		if (text.trim()) return text.trim();
+		const stopReason = typeof message.stopReason === "string" ? message.stopReason.trim() : "";
+		const errorMessage = typeof message.errorMessage === "string" ? message.errorMessage.trim() : "";
+		const answer = messageContentToText(message.content);
+		if (stopReason === "error") {
+			return { ok: false, reason: `Agent Workflow Audit subagent error: ${errorMessage || "provider/model error"}`, stopReason, errorMessage };
+		}
+		if (stopReason === "aborted") {
+			return { ok: false, reason: "Agent Workflow Audit subagent aborted before producing a usable report", stopReason };
+		}
+		if (answer) return { ok: true, answer, stopReason: stopReason || undefined };
+		return {
+			ok: false,
+			reason: stopReason
+				? `Agent Workflow Audit subagent produced no final assistant text (stopReason: ${stopReason})`
+				: "Agent Workflow Audit subagent produced no final assistant text",
+			...(stopReason ? { stopReason } : {}),
+			...(errorMessage ? { errorMessage } : {}),
+		};
 	}
-	return "";
+	return { ok: false, reason: "Agent Workflow Audit subagent produced no assistant message" };
+}
+
+function extractLastAssistantText(messages: unknown[]): string {
+	const outcome = inspectFinalAssistant(messages);
+	return outcome.ok ? outcome.answer : "";
 }
 
 function isAbortLikeError(error: unknown): boolean {
@@ -1085,9 +1110,16 @@ async function runAudit(
 			await Promise.race([promptPromise, timeoutPromise]);
 		}
 
-		const answer = session ? extractLastAssistantText(session.state.messages) : "";
-		lastContent = answer || (aborted ? "Aborted" : "(no output)");
-		details.status = aborted ? "aborted" : "done";
+		const outcome = session ? inspectFinalAssistant(session.state.messages) : { ok: false as const, reason: "Agent Workflow Audit subagent produced no assistant message" };
+		if (outcome.ok) {
+			lastContent = outcome.answer;
+			details.status = "done";
+		} else if (aborted) {
+			lastContent = "Aborted";
+			details.status = "aborted";
+		} else {
+			throw new Error(outcome.reason);
+		}
 		details.endedAt = Date.now();
 		details.reportLength = lastContent.length;
 		emit();
@@ -1116,6 +1148,7 @@ export const __test__ = {
 	buildSystemPrompt,
 	buildUserPrompt,
 	createAuditRuntimeGuardExtension,
+	inspectFinalAssistant,
 	formatToolCall,
 	getBlockedBashReason,
 	parseArgs,

package/extensions/agent-workflow-audit/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@diegopetrucci/pi-agent-workflow-audit",
-  "version": "0.1.11",
+  "version": "0.1.12",
   "description": "A pi extension that runs an isolated repo workflow audit and returns only the final report to the main session.",
   "keywords": [
     "pi-package",

package/extensions/annotate-git-diff/README.md

@@ -1,6 +1,6 @@
 # annotate-git-diff
 
-A standalone pi extension that adds `/annotate-git-diff`, a native Glimpse window for reviewing git changes and sending structured feedback back to the current editor buffer.
+A standalone pi extension that adds `/annotate-git-diff`, a native Glimpse window for reviewing git changes. Explicit **Submit to agent** sends structured feedback directly to the active agent; closing with unsent comments pastes an editor-only draft instead.
 
 ## Attribution
 
@@ -25,12 +25,16 @@ Run `/annotate-git-diff` inside a git repository. The command opens a native rev
 - Monaco-based diff viewing,
 - branch diff, per-commit including working tree, and all-files scopes,
 - inline, file-level, and overall review comments,
-- submit-to-editor feedback prompt insertion.
+- explicit Submit sends review feedback directly to the agent; closing the window with unsent comments pastes a draft prompt to the editor instead.
 
-Submitting feedback does not auto-apply code changes. The extension appends a structured prompt to the current editor buffer so you can send that feedback back to the active agent.
+Submitting feedback does not auto-apply code changes. Clicking **Submit to agent** sends a structured prompt directly to the active agent. If you close the window with comments not yet submitted, the extension pastes a draft prompt into the editor instead, so an accidental close cannot fire a new agent turn.
 
 The review UI does not fetch assets from a CDN. While the window is open, the extension serves its packaged Monaco graph from an ephemeral, tokenized HTTP server bound only to `127.0.0.1`; closing, cancelling, submitting, startup failure, or Pi shutdown stops that server.
 
+## Rollback
+
+There is no runtime setting or toggle for submit behavior. To restore the prior editor-only Submit flow, reinstall the previous package version or revert this source change and rebuild/reinstall the package.
+
 ## Requirements
 
 - Run inside a git repository.

package/extensions/annotate-git-diff/git.ts

@@ -248,7 +248,7 @@ function buildCommitFileId(sha: string, comparison: ReviewFileComparison): strin
 }
 
 async function getRevisionContent(pi: ExtensionAPI, repoRoot: string, revision: string, path: string): Promise<string> {
-	const result = await pi.exec("git", ["show", `${revision}:${path}`], { cwd: repoRoot });
+	const result = await pi.exec("git", ["show", "--end-of-options", `${revision}:${path}`], { cwd: repoRoot });
 	if (result.code !== 0) {
 		return "";
 	}
@@ -327,7 +327,7 @@ async function getRevisionBytes(
 	path: string,
 ): Promise<Buffer | null> {
 	const spec = shellQuote(`${revision}:${path}`);
-	const result = await pi.exec("bash", ["-lc", `git show ${spec} | base64 | tr -d '\\n'`], { cwd: repoRoot });
+	const result = await pi.exec("bash", ["-lc", `git show --end-of-options ${spec} | base64 | tr -d '\\n'`], { cwd: repoRoot });
 	if (result.code !== 0) return null;
 	const encoded = (result.stdout ?? "").trim();
 	try {
@@ -706,6 +706,7 @@ export async function getCommitFiles(pi: ExtensionAPI, repoRoot: string, sha: st
 		"--name-status",
 		"--no-commit-id",
 		"-r",
+		"--end-of-options",
 		sha,
 	]);
 	const changes = parseNameStatus(output).filter((change) =>