@dicebear/core 7.0.1 → 8.0.0-rc.1

package/lib/core.js

@@ -9,8 +9,8 @@ export function createAvatar(style, options = {}) {
     options = mergeOptions(style, options);
     const prng = createPrng(options.seed);
     const result = style.create({ prng: prng, options });
-    const { primary: primaryBackgroundColor, secondary: secondaryBackgroundColor, } = getBackgroundColors(prng, (_a = options.backgroundColor) !== null && _a !== void 0 ? _a : []);
-    const backgroundType = prng.pick((_b = options.backgroundType) !== null && _b !== void 0 ? _b : [], 'solid');
+    const backgroundType = prng.pick((_a = options.backgroundType) !== null && _a !== void 0 ? _a : [], 'solid');
+    const { primary: primaryBackgroundColor, secondary: secondaryBackgroundColor, } = getBackgroundColors(prng, (_b = options.backgroundColor) !== null && _b !== void 0 ? _b : [], backgroundType);
     const backgroundRotation = prng.integer(((_c = options.backgroundRotation) === null || _c === void 0 ? void 0 : _c.length) ? Math.min(...options.backgroundRotation) : 0, ((_d = options.backgroundRotation) === null || _d === void 0 ? void 0 : _d.length) ? Math.max(...options.backgroundRotation) : 0);
     if (options.size) {
         result.attributes.width = options.size.toString();

package/lib/utils/color.d.ts

@@ -1,6 +1,6 @@
 import { Prng } from '../types.js';
 export declare function convertColor(color: string): string;
-export declare function getBackgroundColors(prng: Prng, backgroundColor: string[]): {
+export declare function getBackgroundColors(prng: Prng, backgroundColor: string[], backgroundType: 'solid' | 'gradientLinear'): {
     primary: string;
     secondary: string;
 };

package/lib/utils/color.js

@@ -1,13 +1,23 @@
 export function convertColor(color) {
     return 'transparent' === color ? color : `#${color}`;
 }
-export function getBackgroundColors(prng, backgroundColor) {
+export function getBackgroundColors(prng, backgroundColor, backgroundType) {
     var _a;
-    let shuffledBackgroundColors;
-    if (backgroundColor.length <= 2) {
+    let shuffledBackgroundColors = prng.shuffle(backgroundColor);
+    if (shuffledBackgroundColors.length <= 1) {
+        // If no background colour or only one background colour has been selected,
+        // the random sorting logic can be omitted.
+        shuffledBackgroundColors = backgroundColor;
         // A function call should in any case make an identical number of calls to the PRNG.
         prng.next();
+    }
+    else if (backgroundColor.length == 2 && backgroundType == 'gradientLinear') {
+        // If the background is to be a colour gradient and exactly two background
+        // colours have been specified, do not sort them randomly. In this case, we
+        // assume that the order of the background colours was chosen on purpose.
         shuffledBackgroundColors = backgroundColor;
+        // A function call should in any case make an identical number of calls to the PRNG.
+        prng.next();
     }
     else {
         shuffledBackgroundColors = prng.shuffle(backgroundColor);

package/lib/utils/prng.js

@@ -43,7 +43,15 @@ export function create(seed = '') {
             // Each method call should call the `next` function only once.
             // Therefore, we use a separate instance of the PRNG here.
             const internalPrng = create(next().toString());
-            return arr.sort(() => internalPrng.integer(-1, 1));
+            // Fisher-Yates shuffle algorithm - We do not use the Array.sort method
+            // because it is not stable and produces different results when used in
+            // different browsers. See: https://github.com/dicebear/dicebear/issues/394
+            const workingArray = [...arr];
+            for (let i = workingArray.length - 1; i > 0; i--) {
+                const j = internalPrng.integer(0, i);
+                [workingArray[i], workingArray[j]] = [workingArray[j], workingArray[i]];
+            }
+            return workingArray;
         },
         string(length, characters = 'abcdefghijklmnopqrstuvwxyz1234567890') {
             // Each method call should call the `next` function only once.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dicebear/core",
-  "version": "7.0.1",
+  "version": "8.0.0-rc.1",
   "description": "An avatar library for designers and developers.",
   "keywords": [
     "avatar",
@@ -32,7 +32,7 @@
     "test": "uvu tests"
   },
   "dependencies": {
-    "@dicebear/converter": "7.0.1",
+    "@dicebear/converter": "8.0.0-rc.1",
     "@types/json-schema": "^7.0.11"
   },
   "devDependencies": {
@@ -47,5 +47,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "2eb0f5a64333221c75bc5682f5fc0acf4c8c3ef2"
+  "gitHead": "d0e1e6de2c38449636f03090226d5a8989e29d5d"
 }