@dialpad/eslint-plugin-dialtone 1.0.1 → 1.1.0

package/.eslintrc.js

@@ -7,6 +7,9 @@ module.exports = {
     "plugin:eslint-plugin/recommended",
     "plugin:node/recommended",
   ],
+  parserOptions: {
+    ecmaVersion: 'latest'
+  },
   env: {
     node: true,
   },

package/README.md

@@ -10,6 +10,11 @@ We use yeoman generator to generate new rules, simply run the command below and
 yo eslint:rule
 ```
 
+### Writing rules
+
+You can try the code you're trying to detect here: https://astexplorer.net/ to know which function you need to call
+inside `create` function.
+
 ## Installation
 
 You'll first need to install [ESLint](https://eslint.org/):

package/docs/rules/custom-implementation.md

@@ -0,0 +1,29 @@
+# Detects custom dialtone icons implementations (custom-implementation)
+
+We detected some custom implementations of vue icons.
+
+## Rule Details
+
+This rule aims to detect and prevent custom implementations using require.context and @dIcon, @dSpot
+
+Examples of **incorrect** code for this rule:
+
+```js
+import SpotFileUpload from '@dSpot/SpotFileUpload';
+import IconDynamicLayout from '@dIcon/IconDynamicLayout';
+```
+
+```js
+const requireIcon = require.context(
+    '@dialpad/dialtone/lib/dist/vue/icons',
+    false,
+    /.*\\.vue$/,
+);
+```
+
+Examples of **correct** code for this rule:
+
+```js
+import { DtIcon } from '@dialpad/dialtone-vue';
+<dt-icon name="settings" />
+```

package/docs/rules/{old-svg-icons.md → deprecated-icons.md}

@@ -1,7 +1,7 @@
-# Finds old dialtone svg icons usage (old-svg-icons)
+# Finds deprecated dialtone svg and vue icons usage (deprecated-icons)
 
 We separated icons from dialtone into dialtone-icons repo, 
-so we are deprecating old svg icons on dialtone once the migrations are finished.
+so we are deprecating old svg and vue icons on dialtone once the migrations are finished.
 
 ## Rule Details
 
@@ -12,6 +12,8 @@ Examples of **incorrect** code for this rule:
 ```js
 import svgLockIcon from '@dialpad/dialtone/lib/build/svg/system/lock.svg';
 import svgLockIcon from '../node_modules/@dialpad/dialtone/lib/dist/svg/system/lock.svg';
+import IconSettings from '@dialpad/dialtone/vue/icons/IconSettings';
+import IconSettings from '../node_modules/@dialpad/dialtone/vue/icons/IconSettings';
 ```
 
 Examples of **correct** code for this rule:
@@ -23,8 +25,15 @@ import svgLockIcon from '@dialpad/dialtone-icons/dist/svg/lock.svg';
 
 **If you can use vue**
 ```js
-
 import { DtIcon } from '@dialpad/dialtone-vue';
 <dt-icon name="lock" />
+```
+
+## Exceptions
 
+For now, we are allowing the importing of `brand` and `spot illustrations` icons from dialtone, so this rule will not trigger if you import an
+icon like: 
+
+```js
+import dialpadAiIcon from '../../node_modules/@dialpad/dialtone/lib/build/svg/brand/dialpad-ai.svg';
 ```

package/lib/rules/custom-implementation.js

@@ -0,0 +1,69 @@
+/**
+ * @fileoverview Detects custom dialtone icons implementations
+ * @author julio ortega
+ */
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion', // `problem`, `suggestion`, or `layout`
+    docs: {
+      description: "Detects custom dialtone icons implementations",
+      recommended: false,
+      url: 'https://github.com/dialpad/eslint-plugin-dialtone/blob/main/docs/rules/custom-implementation.md', // URL to the documentation page for this rule
+    },
+    fixable: null, // Or `code` or `whitespace`
+    schema: [], // Add a schema if the rule has options
+    messages: {
+      avoidRequireContext: 'Avoid custom dialtone icons implementation. Use DtIcon component instead https://vue.dialpad.design/?path=/docs/components-icon--default',
+      avoidCustomImport: 'Avoid importing dialtone icons with custom webpack alias'
+    }
+  },
+
+  create(context) {
+    // variables should be defined here
+
+    //----------------------------------------------------------------------
+    // Helpers
+    //----------------------------------------------------------------------
+
+    // any helper functions should go here or else delete this section
+
+    //----------------------------------------------------------------------
+    // Public
+    //----------------------------------------------------------------------
+
+    return {
+      ImportDeclaration(node) {
+        const foundIndex = node.source.value.toLowerCase().search(/@d(spot|icon)/g);
+         if (foundIndex === -1) return;
+
+         context.report({
+            node: node,
+            messageId: 'avoidCustomImport',
+        });
+      },
+      VariableDeclaration(node) {
+        node.declarations.forEach(declaration => {
+          const calleeIsRequireContext = declaration?.init?.callee?.object?.name === 'require' && declaration?.init?.callee?.property?.name === 'context';
+          if (!calleeIsRequireContext) return;
+
+          const argumentsIncludeDialtone = declaration?.init?.arguments?.find(argument => {
+            if (typeof argument.value !== 'string') return false;
+            return argument.value.toLowerCase().search(/@dialpad\/dialtone\/.*\/icons/g) !== -1
+          });
+          if (!argumentsIncludeDialtone) return;
+          context.report({
+            node: node,
+            messageId: 'avoidRequireContext',
+          })
+        })
+      }
+    };
+  },
+};

package/lib/rules/{old-svg-icons.js → deprecated-icons.js}

@@ -13,37 +13,30 @@ module.exports = {
     meta: {
         type: 'suggestion', // `problem`, `suggestion`, or `layout`
         docs: {
-            description: 'Finds old svg icons imports from dialtone',
+            description: 'Finds deprecated svg and vue icon imports from dialtone',
             recommended: false,
-            url: null, // URL to the documentation page for this rule
+            url: 'https://github.com/dialpad/eslint-plugin-dialtone/blob/main/docs/rules/deprecated-icons.md', // URL to the documentation page for this rule
         },
         fixable: null, // Or `code` or `whitespace`
         schema: [], // Add a schema if the rule has options
         messages: {
-            avoidSVGImport: 'Avoid usage of old dialtone icons [deprecated]. Check https://dialpad.design/components/icon.html for details.',
+            avoidDeprecatedImport: 'Avoid usage of old dialtone icons [deprecated]. Check https://dialpad.design/components/icon.html for details.',
         },
     },
     create(context) {
-        // variables should be defined here
-
-        //----------------------------------------------------------------------
-        // Helpers
-        //----------------------------------------------------------------------
-
-        // any helper functions should go here or else delete this section
-
+        const iconRegex = /.*@dialpad\/dialtone\/(vue\/.*|.+\.svg)/gm;
         //----------------------------------------------------------------------
         // Public
         //----------------------------------------------------------------------
 
         return {
             ImportDeclaration(node) {
-                const foundIndex = node.source.value.toLowerCase().search(/@dialpad\/dialtone\/.*\.svg/g);
-                if (foundIndex === -1) return;
+                const matched = iconRegex.exec(node.source.value.toLowerCase());
+                if (!matched ||matched.input.includes('/brand/') || matched.input.includes('/spot/')) return;
 
                 context.report({
                     node: node,
-                    messageId: 'avoidSVGImport',
+                    messageId: 'avoidDeprecatedImport',
                 });
             }
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dialpad/eslint-plugin-dialtone",
-  "version": "1.0.1",
+  "version": "1.1.0",
   "description": "dialtone eslint plugin",
   "keywords": [
     "Dialpad",

package/tests/lib/rules/custom-implementation.js

@@ -0,0 +1,44 @@
+/**
+ * @fileoverview Detects custom dialtone icons implementations
+ * @author julio ortega
+ */
+"use strict";
+
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const rule = require("../../../lib/rules/custom-implementation"),
+    RuleTester = require("eslint").RuleTester;
+
+
+//------------------------------------------------------------------------------
+// Tests
+//------------------------------------------------------------------------------
+
+const ruleTester = new RuleTester({parserOptions: {sourceType: 'module', ecmaVersion: 'latest'}});
+ruleTester.run("custom-implementation", rule, {
+    valid: [
+        {
+            name: 'Dialtone-vue DtIcon import',
+            code: "import { DtIcon } from '@dialpad/dialtone-vue';",
+        },
+    ],
+
+    invalid: [
+        {
+            name: 'require context',
+            code: "const requireIcon = require.context(\n" +
+                "  '@dialpad/dialtone/lib/dist/vue/icons',\n" +
+                "  false,\n" +
+                "  /.*\\.vue$/\n" +
+                ");",
+            errors: [{messageId: 'avoidRequireContext'}],
+        },
+        {
+            name: 'custom import',
+            code: 'import SpotFileUpload from \'@dSpot/SpotFileUpload\';',
+            errors: [{messageId: 'avoidCustomImport'}],
+        },
+    ],
+});

package/tests/lib/rules/{old-svg-icons.js → deprecated-icons.js}

@@ -8,20 +8,28 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const rule = require("../../../lib/rules/old-svg-icons"), RuleTester = require("eslint").RuleTester;
+const rule = require("../../../lib/rules/deprecated-icons"), RuleTester = require("eslint").RuleTester;
 
 
 //------------------------------------------------------------------------------
 // Tests
 //------------------------------------------------------------------------------
 
-const ruleTester = new RuleTester({parserOptions: {ecmaVersion: 7, sourceType: 'module'}});
-ruleTester.run("old-svg-icons", rule, {
+const ruleTester = new RuleTester({parserOptions: {sourceType: 'module', ecmaVersion: 'latest'}});
+ruleTester.run("deprecated-icons", rule, {
     valid: [
         {
             name: 'New icon import',
             code: "import svgLockIcon from '@dialpad/dialtone-icons/dist/svg/lock.svg';",
         },
+        {
+            name: 'Brand icon import',
+            code: "import dialpadAiIcon from '../../node_modules/@dialpad/dialtone/lib/build/svg/brand/dialpad-ai.svg';",
+        },
+        {
+            name: 'Spot illustration import',
+            code: "import SpotBrowserTableGraph from '@dialpad/dialtone/vue/spot/SpotBrowserTableGraph';",
+        },
         {
             name: 'Dialtone Styles import',
             code: "import dialtoneCSS from '@dialpad/dialtone/lib/build/less/dialtone.less';",
@@ -30,22 +38,31 @@ ruleTester.run("old-svg-icons", rule, {
 
     invalid: [
         {
-            name: 'Old icon import from build',
+            name: 'Old SVG icon import from build',
             code: "import svgLockIcon from '../node_modules/@dialpad/dialtone/lib/build/svg/system/lock.svg';",
             errors: [
                 {
-                    messageId: "avoidSVGImport"
+                    messageId: "avoidDeprecatedImport"
                 }
             ],
         },
         {
-            name: 'Old icon import from dist',
+            name: 'Old SVG icon import from dist',
             code: "import svgLockIcon from '../node_modules/@dialpad/dialtone/lib/dist/svg/system/lock.svg';",
             errors: [
                 {
-                    messageId: "avoidSVGImport"
+                    messageId: "avoidDeprecatedImport"
                 }
             ],
-        }
+        },
+        {
+            name: 'Old VUE icon import',
+            code: "import IconSettings from '@dialpad/dialtone/vue/icons/IconSettings';",
+            errors: [
+                {
+                    messageId: "avoidDeprecatedImport"
+                }
+            ],
+        },
     ],
 });

package/docs/rules/old-vue-icons.md

@@ -1,21 +0,0 @@
-# Finds old dialtone vue icons usage (old-vue-icons)
-
-We separated icons from dialtone into dialtone-icons repo, 
-so we are deprecating old vue icons on dialtone once the migrations are finished.
-
-## Rule Details
-
-This rule aims to inform developers that they're importing icons from dialtone instead of using dtIcon component from dialtone-vue.
-
-Examples of **incorrect** code for this rule:
-
-```js
-import IconSettings from '@dialpad/dialtone/vue/icons/IconSettings';
-```
-
-Examples of **correct** code for this rule:
-
-```js
-import { DtIcon } from '@dialpad/dialtone-vue';
-<dt-icon name="settings" />
-```

package/lib/rules/old-vue-icons.js

@@ -1,50 +0,0 @@
-/**
- * @fileoverview Finds old dialtone vue icons usage
- * @author julio ortega
- */
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-/** @type {import('eslint').Rule.RuleModule} */
-module.exports = {
-    meta: {
-        type: 'suggestion', // `problem`, `suggestion`, or `layout`
-        docs: {
-            description: 'Finds old vue icons imports from dialtone',
-            recommended: false,
-            url: null, // URL to the documentation page for this rule
-        },
-        fixable: null, // Or `code` or `whitespace`
-        schema: [], // Add a schema if the rule has options
-        messages: {
-            avoidVueImport: 'Avoid usage of old dialtone vue icons [deprecated]. Use DtIcon component instead https://vue.dialpad.design/?path=/docs/components-icon--default'
-        }
-    },
-
-    create(context) {
-        // variables should be defined here
-
-        //----------------------------------------------------------------------
-        // Helpers
-        //----------------------------------------------------------------------
-
-        // any helper functions should go here or else delete this section
-
-        //----------------------------------------------------------------------
-        // Public
-        //----------------------------------------------------------------------
-
-        return {
-            ImportDeclaration(node) {
-                if (!node.source.value.toLowerCase().includes('@dialpad/dialtone/vue')) return;
-                context.report({
-                    node: node,
-                    messageId: 'avoidVueImport',
-                });
-            }
-        };
-    },
-};

package/tests/lib/rules/old-vue-icons.js

@@ -1,34 +0,0 @@
-/**
- * @fileoverview Finds old dialtone vue icons usage
- * @author julio ortega
- */
-"use strict";
-
-//------------------------------------------------------------------------------
-// Requirements
-//------------------------------------------------------------------------------
-
-const rule = require("../../../lib/rules/old-vue-icons"), RuleTester = require("eslint").RuleTester;
-
-
-//------------------------------------------------------------------------------
-// Tests
-//------------------------------------------------------------------------------
-
-const ruleTester = new RuleTester({parserOptions: {ecmaVersion: 7, sourceType: 'module'}});
-ruleTester.run("old-vue-icons", rule, {
-  valid: [
-    {
-      name: 'Dialtone-vue DtIcon import',
-      code: "import { DtIcon } from '@dialpad/dialtone-vue';",
-    },
-  ],
-
-  invalid: [
-    {
-      name: 'Dialtone vue icon import',
-      code: "import IconSettingsOld from '@dialpad/dialtone/vue/icons/IconSettings';",
-      errors: [{ messageId: 'avoidVueImport' }],
-    },
-  ],
-});