@dhyasama/totem-models 12.9.0 → 12.11.0

package/lib/LimitedPartner.js

@@ -213,23 +213,26 @@ module.exports = function(mongoose, config) {
   });
 
   LimitedPartner.virtual('email.primary').get(function () {
-    let primary = _.find(this.contact.email, function(email) {
-      return email.primary;
+    let emails = this && this.contact && this.contact.email ? this.contact.email : [];
+    let primary = _.find(emails, function(email) {
+      return email && email.primary;
     });
     return primary ? primary.email : '';
   });
 
   LimitedPartner.virtual('phone.primary').get(function () {
-    let primary = _.find(this.contact.phone, function(phone) {
-      return phone.primary;
+    let phones = this && this.contact && this.contact.phone ? this.contact.phone : [];
+    let primary = _.find(phones, function(phone) {
+      return phone && phone.primary;
     });
     return primary ? primary.number : '';
   });
 
   LimitedPartner.virtual('address.primary').get(function () {
 
-    let primary = _.find(this.contact.address, function(address) {
-      return address.primary;
+    let addresses = this && this.contact && this.contact.address ? this.contact.address : [];
+    let primary = _.find(addresses, function(address) {
+      return address && address.primary;
     });
 
     if (!primary) {

package/lib/Organization.js

@@ -639,10 +639,11 @@ module.exports = function(mongoose, config) {
   ///////////////////////////////////////////////////////////////////////////////////////
 
   Organization.virtual('address.primary').get(function () {
-    var primary = _.find(this.contact.address, function(address) {
-      return address.primary;
+    var addresses = this && this.contact && this.contact.address ? this.contact.address : [];
+    var primary = _.find(addresses, function(address) {
+      return address && address.primary;
     });
-    return primary ? primary.address : null;
+    return primary || null;
   });
 
   Organization.virtual('board.all').get(function () {

package/lib/Person.js

@@ -166,17 +166,21 @@ module.exports = function(mongoose, config) {
     // Absent that, use first email
     // Absent that, return empty string
     var self = this;
+    var emails = self && self.contact && self.contact.email ? self.contact.email : [];
     var result;
-    var primary = _.find(self.contact.email, function(email) { return email.primary; });
+    var primary = _.find(emails, function(email) {
+      return email && email.primary;
+    });
     if (primary) result = primary.email;
-    else if (self.contact.email && self.contact.email.length >= 1) result = self.contact.email[0].email;
+    else if (emails.length >= 1 && emails[0]) result = emails[0].email;
     else result = '';
     return result;
   });
 
   Person.virtual('phone.primary').get(function () {
-    var primary = _.find(this.contact.phone, function(phone) {
-      return phone.primary;
+    var phones = this && this.contact && this.contact.phone ? this.contact.phone : [];
+    var primary = _.find(phones, function(phone) {
+      return phone && phone.primary;
     });
     return primary ? primary.number : '';
   });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dhyasama/totem-models",
-  "version": "12.9.0",
+  "version": "12.11.0",
   "author": "Jason Reynolds",
   "license": "UNLICENSED",
   "description": "Models for Totem platform",

package/test/LimitedPartner.js

@@ -398,6 +398,25 @@ describe('Limited Partner', function() {
 
   });
 
+  it('does not throw when contact is omitted from a lean lp projection', function(done) {
+
+    LimitedPartner.findById(lp.id)
+      .select('name')
+      .lean({ virtuals: true })
+      .then(function(result) {
+        should.exist(result);
+        should.exist(result.email);
+        should.exist(result.phone);
+        should.exist(result.address);
+        result.email.primary.should.equal('');
+        result.phone.primary.should.equal('');
+        result.address.primary.postalCode.should.equal('');
+        done();
+      })
+      .catch(done);
+
+  });
+
   it('adds a flag', function(done) {
 
     LimitedPartner.addFlag(lp.id, person._id, 'incorrect phone', organization._id, function(err, result) {

package/test/Organization.js

@@ -1127,6 +1127,87 @@ describe('Organization', function() {
       });
     });
 
+    it('finds the primary address for an org', function(done) {
+
+      var o = new Organization();
+      o.name = 'Addressable';
+      o.slug = 'addressable';
+      o.website = 'addressable.org';
+
+      o.contact.address = [];
+      o.contact.address.push({
+        street: '1 Main Street',
+        city: 'Portland',
+        state: 'ME',
+        country: 'USA',
+        postalCode: '04101',
+        primary: false
+      });
+      o.contact.address.push({
+        street: '2 Center Street',
+        city: 'Bangor',
+        state: 'ME',
+        country: 'USA',
+        postalCode: '04412',
+        primary: true
+      });
+
+      Organization.upsert(o, 'test-user', function(err, org) {
+
+        should.not.exist(err);
+        should.exist(org);
+
+        Organization.findById(org._id).lean({ virtuals: true })
+          .then(function(result) {
+            should.exist(result);
+            should.exist(result.address);
+            should.exist(result.address.primary);
+            result.address.primary.postalCode.should.equal('04412');
+            done();
+          })
+          .catch(done);
+
+      });
+
+    });
+
+    it('does not throw when contact is omitted from a lean projection', function(done) {
+
+      var o = new Organization();
+      o.name = 'Projected';
+      o.slug = 'projected';
+      o.website = 'projected.org';
+
+      o.contact.address = [];
+      o.contact.address.push({
+        street: '10 Broad Street',
+        city: 'New York',
+        state: 'NY',
+        country: 'USA',
+        postalCode: '10004',
+        primary: true
+      });
+
+      Organization.upsert(o, 'test-user', function(err, org) {
+
+        should.not.exist(err);
+        should.exist(org);
+
+        Organization.findById(org._id)
+          .select('name')
+          .lean({ virtuals: true })
+          .then(function(result) {
+            should.exist(result);
+            should.exist(result.address);
+            should.equal(result.address.primary, null);
+            done();
+          })
+          .catch(done);
+
+      });
+
+    });
+
     it('cleans people', function (done) {
 
       var littleDirtyOrg = new Organization();

package/test/Person.js

@@ -718,6 +718,23 @@ describe('Person', function() {
 
   });
 
+  it('does not throw when contact is omitted from a lean person projection', function(done) {
+
+    Person.findById(person.id)
+      .select('name')
+      .lean({ virtuals: true })
+      .then(function(result) {
+        should.exist(result);
+        should.exist(result.email);
+        should.exist(result.phone);
+        result.email.primary.should.equal('');
+        result.phone.primary.should.equal('');
+        done();
+      })
+      .catch(done);
+
+  });
+
   it('gets sources', function(done) {
 
     Person.getSources(person.id, { CUSTOMER_ID: org._id }, function(err, result) {