@dhyasama/totem-models 12.15.0 → 12.16.0

package/lib/Financials.js

@@ -36,8 +36,8 @@ module.exports = function(mongoose, config) {
         period: { type: String, enum: [null, 'month', 'quarter', 'half', 'year']},
         time: {
           hour: { type: Number },
-          minute: { type: Number, default: 0 },
-          second: { type: Number, default: 0 }
+          minute: { type: Number },
+          second: { type: Number }
         }
       },
       remind: {
@@ -45,16 +45,16 @@ module.exports = function(mongoose, config) {
         occurrences: { type: Number },
         time: {
           hour: { type: Number },
-          minute: { type: Number, default: 0 },
-          second: { type: Number, default: 0 }
+          minute: { type: Number },
+          second: { type: Number }
         }
       },
       due: {
         daysAfter: { type: Number },
         time: {
           hour: { type: Number },
-          minute: { type: Number, default: 0 },
-          second: { type: Number, default: 0 }
+          minute: { type: Number },
+          second: { type: Number }
         }
       },
       fiscal: {

package/lib/Round.js

@@ -806,19 +806,15 @@ module.exports = function(mongoose, config) {
       if (!options) { throw new Error('options is required'); }
       if (!options.CUSTOMER_ID) { throw new Error('options.CUSTOMER_ID is required'); }
       if (!mongoose.Types.ObjectId.isValid(options.CUSTOMER_ID)) { throw new Error('options.CUSTOMER_ID is not a valid ObjectId'); }
-
-      // We need customerFunds to filter rounds - extract from options or get all customer funds
+      if (!options.customerFunds) { throw new Error('options.customerFunds is required'); }
+
+      // Fund has no direct customer field — callers are expected to compute
+      // customerFunds via the web-app's cacheHelpers.getCustomerFunds and pass
+      // it in. A previous fallback tried to call Fund.findByCustomer(), which
+      // has never existed on the Fund model; the fallback was unreachable dead
+      // code masked by the fact that every production caller already passes
+      // customerFunds explicitly.
       var customerFunds = options.customerFunds;
-      if (!customerFunds) {
-        const Fund = mongoose.model('Fund');
-        const funds = await new Promise((resolve, reject) => {
-          Fund.findByCustomer(options.CUSTOMER_ID, (err, result) => {
-            if (err) reject(err); else resolve(result);
-          });
-        });
-        options.customerFunds = funds;
-        customerFunds = funds;
-      }
 
       // Find organizations acquired by this org (acquirees)
       const acquirees = await Organization

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dhyasama/totem-models",
-  "version": "12.15.0",
+  "version": "12.16.0",
   "author": "Jason Reynolds",
   "license": "UNLICENSED",
   "description": "Models for Totem platform",