@dhyasama/totem-models 12.14.0 → 12.15.1

package/lib/Deal.js

@@ -331,27 +331,19 @@ module.exports = function(mongoose, config) {
         // },
 
         // get the referrer
+        // NOTE: use localField/foreignField (not sub-pipeline + $expr). The
+        // sub-pipeline form does not use the foreign collection's _id index
+        // and is ~100x slower in practice — for customers with hundreds of
+        // deals, the difference between the two forms is the difference
+        // between a sub-second response and a 120-second timeout. Verified on
+        // production data 2026-04-07: Saltwater (20 deals) 32.5s -> 61ms,
+        // Gobi Partners (1845 deals) timed out -> 920ms.
         {
           $lookup:
             {
               from: "people",
-              let: { referrerPersonId: "$referrer.person" },
-              pipeline: [
-                {
-                  $match: {
-                    $expr: {
-                      $eq: ["$_id", "$$referrerPersonId"]
-                    }
-                  }
-                },
-                {
-                  $project: {
-                    name: 1,
-                    avatarUrl: 1,
-                    title: 1
-                  }
-                }
-              ],
+              localField: "referrer.person",
+              foreignField: "_id",
               as: "referrerPerson"
             }
         },
@@ -361,27 +353,8 @@ module.exports = function(mongoose, config) {
           $lookup:
             {
               from: "documents",
-              let: { docIds: { $ifNull: ["$documents", []] } },
-              pipeline: [
-                {
-                  $match: {
-                    $expr: {
-                      $in: ["$_id", "$$docIds"]
-                    }
-                  }
-                },
-                {
-                  $project: {
-                    name: 1,
-                    type: 1,
-                    contentType: 1,
-                    s3: 1,
-                    createdOn: 1,
-                    createdBy: 1,
-                    customer: 1
-                  }
-                }
-              ],
+              localField: "documents",
+              foreignField: "_id",
               as: "documents"
             }
         },
@@ -391,16 +364,8 @@ module.exports = function(mongoose, config) {
           $lookup:
             {
               from: "messages",
-              let: { messageIds: { $ifNull: ["$messages", []] } },
-              pipeline: [
-                {
-                  $match: {
-                    $expr: {
-                      $in: ["$_id", "$$messageIds"]
-                    }
-                  }
-                }
-              ],
+              localField: "messages",
+              foreignField: "_id",
               as: "messages"
             }
         },
@@ -410,24 +375,8 @@ module.exports = function(mongoose, config) {
           $lookup:
             {
               from: "messages",
-              let: { latestMessageId: "$latestMessage" },
-              pipeline: [
-                {
-                  $match: {
-                    $expr: {
-                      $eq: ["$_id", "$$latestMessageId"]
-                    }
-                  }
-                },
-                {
-                  $project: {
-                    subject: 1,
-                    originalMessageDate: 1,
-                    createdOn: 1,
-                    messageDate: 1
-                  }
-                }
-              ],
+              localField: "latestMessage",
+              foreignField: "_id",
               as: "latestMessage"
             }
         }

package/lib/Round.js

@@ -806,19 +806,15 @@ module.exports = function(mongoose, config) {
       if (!options) { throw new Error('options is required'); }
       if (!options.CUSTOMER_ID) { throw new Error('options.CUSTOMER_ID is required'); }
       if (!mongoose.Types.ObjectId.isValid(options.CUSTOMER_ID)) { throw new Error('options.CUSTOMER_ID is not a valid ObjectId'); }
-
-      // We need customerFunds to filter rounds - extract from options or get all customer funds
+      if (!options.customerFunds) { throw new Error('options.customerFunds is required'); }
+
+      // Fund has no direct customer field — callers are expected to compute
+      // customerFunds via the web-app's cacheHelpers.getCustomerFunds and pass
+      // it in. A previous fallback tried to call Fund.findByCustomer(), which
+      // has never existed on the Fund model; the fallback was unreachable dead
+      // code masked by the fact that every production caller already passes
+      // customerFunds explicitly.
       var customerFunds = options.customerFunds;
-      if (!customerFunds) {
-        const Fund = mongoose.model('Fund');
-        const funds = await new Promise((resolve, reject) => {
-          Fund.findByCustomer(options.CUSTOMER_ID, (err, result) => {
-            if (err) reject(err); else resolve(result);
-          });
-        });
-        options.customerFunds = funds;
-        customerFunds = funds;
-      }
 
       // Find organizations acquired by this org (acquirees)
       const acquirees = await Organization

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@dhyasama/totem-models",
-  "version": "12.14.0",
+  "version": "12.15.1",
   "author": "Jason Reynolds",
   "license": "UNLICENSED",
   "description": "Models for Totem platform",
   "main": "index.js",
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=24 <25"
   },
   "scripts": {
     "smoke:mongoose8": "node scripts/run_mongoose8_smoke.js",