@dhis2/create-app 5.4.0-alpha.1 → 5.4.0

package/tests/is-git-template-specifier.js

@@ -0,0 +1,89 @@
+const test = require('tape')
+const {
+    isGitTemplateSpecifier,
+    parseGitTemplateSpecifier,
+} = require('../src/utils/isGitTemplateSpecifier')
+
+test('isGitTemplateSpecifier detects supported GitHub patterns', (t) => {
+    t.plan(7)
+
+    t.equal(isGitTemplateSpecifier('basic'), false, 'built-in key is not git')
+    t.equal(
+        isGitTemplateSpecifier('react-router'),
+        false,
+        'second built-in key is not git'
+    )
+    t.equal(
+        isGitTemplateSpecifier('owner/repo'),
+        true,
+        'owner/repo shorthand is git'
+    )
+    t.equal(
+        isGitTemplateSpecifier('owner/repo#main'),
+        true,
+        'owner/repo#ref shorthand is git'
+    )
+    t.equal(
+        isGitTemplateSpecifier('https://github.com/owner/repo'),
+        true,
+        'GitHub URL is git'
+    )
+    t.equal(
+        isGitTemplateSpecifier('owner/repo#main:templates/app'),
+        false,
+        'subdirectory syntax is no longer supported'
+    )
+    t.equal(isGitTemplateSpecifier(''), false, 'empty source is not git')
+})
+
+test('parseGitTemplateSpecifier parses shorthand with ref', (t) => {
+    t.plan(5)
+
+    const parsed = parseGitTemplateSpecifier('owner/repo#main')
+    t.equal(parsed.owner, 'owner', 'owner parsed')
+    t.equal(parsed.repo, 'repo', 'repo parsed')
+    t.equal(parsed.ref, 'main', 'ref parsed')
+    t.equal(
+        parsed.repoUrl,
+        'https://github.com/owner/repo.git',
+        'repo URL normalized'
+    )
+    t.equal(parsed.raw, 'owner/repo#main', 'raw source preserved')
+})
+
+test('parseGitTemplateSpecifier parses URL and strips .git suffix', (t) => {
+    t.plan(4)
+
+    const parsed = parseGitTemplateSpecifier(
+        'https://github.com/acme/template.git#release'
+    )
+    t.equal(parsed.owner, 'acme', 'owner parsed from URL')
+    t.equal(parsed.repo, 'template', 'repo parsed and .git removed')
+    t.equal(parsed.ref, 'release', 'ref parsed from URL')
+    t.equal(parsed.raw, 'https://github.com/acme/template.git#release', 'raw')
+})
+
+test('parseGitTemplateSpecifier rejects unsupported or malformed inputs', (t) => {
+    t.plan(4)
+
+    t.throws(
+        () => parseGitTemplateSpecifier('owner-only'),
+        /Invalid template source/,
+        'rejects malformed shorthand'
+    )
+    t.throws(
+        () => parseGitTemplateSpecifier('https://gitlab.com/acme/repo'),
+        /Only github.com repositories are supported|Unsupported template host/,
+        'rejects non-GitHub host'
+    )
+    t.throws(
+        () => parseGitTemplateSpecifier('owner/repo#'),
+        /Ref cannot be empty/,
+        'rejects empty ref'
+    )
+    t.throws(
+        () => parseGitTemplateSpecifier('owner/repo#main:templates/app'),
+        /Invalid template source/,
+        'rejects subdirectory syntax'
+    )
+})

package/tests/resolve-external-template-source.js

@@ -0,0 +1,69 @@
+const os = require('node:os')
+const path = require('node:path')
+const fs = require('fs-extra')
+const test = require('tape')
+const resolveExternalTemplateSource = require('../src/utils/resolveExternalTemplateSource')
+const validateTemplateDirectory = require('../src/utils/validateTemplateDirectory')
+
+const createTempTemplate = () => {
+    const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'd2-create-test-'))
+    fs.writeJsonSync(path.join(tempDir, 'package.json'), { name: 'fixture' })
+    return tempDir
+}
+
+test('validateTemplateDirectory accepts valid template directory', (t) => {
+    const tempDir = createTempTemplate()
+    t.plan(1)
+
+    try {
+        validateTemplateDirectory(tempDir, 'test-source')
+        t.pass('valid directory passes')
+    } finally {
+        fs.removeSync(tempDir)
+    }
+})
+
+test('resolveExternalTemplateSource fails for unknown non-git templates', async (t) => {
+    t.plan(1)
+
+    try {
+        await resolveExternalTemplateSource('unknown-template')
+        t.fail('should fail')
+    } catch (error) {
+        t.match(
+            String(error.message || error),
+            /Unknown template/,
+            'returns unknown-template error'
+        )
+    }
+})
+
+test('resolveExternalTemplateSource fails fast for unsupported git hosts', async (t) => {
+    t.plan(1)
+
+    try {
+        await resolveExternalTemplateSource('https://gitlab.com/acme/repo')
+        t.fail('should fail')
+    } catch (error) {
+        t.match(
+            String(error.message || error),
+            /Unsupported template host|Only github.com repositories are supported/,
+            'rejects unsupported host before clone'
+        )
+    }
+})
+
+test('resolveExternalTemplateSource rejects subdirectory syntax', async (t) => {
+    t.plan(1)
+
+    try {
+        await resolveExternalTemplateSource('owner/repo#main:templates/app')
+        t.fail('should fail')
+    } catch (error) {
+        t.match(
+            String(error.message || error),
+            /Unknown template|Invalid template source/,
+            'subdirectory syntax is rejected'
+        )
+    }
+})