@dhis2/app-service-data 3.2.4 → 3.2.8

package/build/cjs/__tests__/integration.test.js

@@ -10,8 +10,8 @@ function _getRequireWildcardCache() { if (typeof WeakMap !== "function") return
 
 function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } if (obj === null || typeof obj !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 
-describe('Testing custom data provider and useQuery hook', () => {
-  it('Should render without failing', async () => {
+describe('<DataQuery />', () => {
+  it('should render without failing', async () => {
     const data = {
       answer: 42
     };
@@ -22,18 +22,8 @@ describe('Testing custom data provider and useQuery hook', () => {
       data: data
     }, children);
 
-    const renderFunction = jest.fn(({
-      loading,
-      error,
-      data
-    }) => {
-      if (loading) return 'loading';
-      if (error) return /*#__PURE__*/React.createElement("div", null, "error: ", error.message);
-      return /*#__PURE__*/React.createElement("div", null, "data: ", data && data.answer);
-    });
-    const {
-      getByText
-    } = (0, _react.render)( /*#__PURE__*/React.createElement(_react3.DataQuery, {
+    const renderFunction = jest.fn(() => null);
+    (0, _react.render)( /*#__PURE__*/React.createElement(_react3.DataQuery, {
       query: {
         answer: {
           resource: 'answer'
@@ -42,24 +32,21 @@ describe('Testing custom data provider and useQuery hook', () => {
     }, renderFunction), {
       wrapper
     });
-    expect(getByText(/loading/i)).not.toBeUndefined();
     expect(renderFunction).toHaveBeenCalledTimes(1);
     expect(renderFunction).toHaveBeenLastCalledWith(expect.objectContaining({
       called: true,
       loading: true
     }));
     await (0, _react.waitFor)(() => {
-      getByText(/data: /i);
+      expect(renderFunction).toHaveBeenCalledTimes(2);
+      expect(renderFunction).toHaveBeenLastCalledWith(expect.objectContaining({
+        called: true,
+        loading: false,
+        data
+      }));
     });
-    expect(getByText(/data: /i)).toHaveTextContent("data: ".concat(data.answer));
-    expect(renderFunction).toHaveBeenCalledTimes(2);
-    expect(renderFunction).toHaveBeenLastCalledWith(expect.objectContaining({
-      called: true,
-      loading: false,
-      data
-    }));
   });
-  it('Should render an error', async () => {
+  it('should render an error', async () => {
     const expectedError = new Error('Something went wrong');
     const data = {
       test: () => {
@@ -73,18 +60,8 @@ describe('Testing custom data provider and useQuery hook', () => {
       data: data
     }, children);
 
-    const renderFunction = jest.fn(({
-      loading,
-      error,
-      data
-    }) => {
-      if (loading) return 'loading';
-      if (error) return /*#__PURE__*/React.createElement("div", null, "error: ", error.message);
-      return /*#__PURE__*/React.createElement("div", null, "data: ", data && data.test);
-    });
-    const {
-      getByText
-    } = (0, _react.render)( /*#__PURE__*/React.createElement(_react3.DataQuery, {
+    const renderFunction = jest.fn(() => null);
+    (0, _react.render)( /*#__PURE__*/React.createElement(_react3.DataQuery, {
       query: {
         test: {
           resource: 'test'
@@ -93,21 +70,18 @@ describe('Testing custom data provider and useQuery hook', () => {
     }, renderFunction), {
       wrapper
     });
-    expect(getByText(/loading/i)).not.toBeUndefined();
     expect(renderFunction).toHaveBeenCalledTimes(1);
     expect(renderFunction).toHaveBeenLastCalledWith(expect.objectContaining({
       called: true,
       loading: true
     }));
     await (0, _react.waitFor)(() => {
-      getByText(/error: /i);
+      expect(renderFunction).toHaveBeenCalledTimes(2);
+      expect(renderFunction).toHaveBeenLastCalledWith(expect.objectContaining({
+        called: true,
+        loading: false,
+        error: expectedError
+      }));
     });
-    expect(renderFunction).toHaveBeenCalledTimes(2);
-    expect(getByText(/error: /i)).toHaveTextContent("error: ".concat(expectedError.message));
-    expect(renderFunction).toHaveBeenLastCalledWith(expect.objectContaining({
-      called: true,
-      loading: false,
-      error: expectedError
-    }));
   });
 });

package/build/cjs/__tests__/mutations.test.js

@@ -2,82 +2,73 @@
 
 var _react = require("@testing-library/react");
 
-var _react2 = _interopRequireDefault(require("react"));
+var React = _interopRequireWildcard(require("react"));
 
 var _react3 = require("../react");
 
-function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+function _getRequireWildcardCache() { if (typeof WeakMap !== "function") return null; var cache = new WeakMap(); _getRequireWildcardCache = function () { return cache; }; return cache; }
 
-const mockBackend = {
-  target: jest.fn((type, query) => {
-    expect(query.resource).toBe('target');
-    expect(type).toBe('create');
-    expect(query.data).toMatchObject({
-      question: '?'
-    });
-    return Promise.resolve({
-      answer: 42
-    });
-  })
-};
-describe('Test mutations', () => {
-  it('Should call the mock callback', async () => {
-    let doMutation;
-    const renderFunction = jest.fn(([mutate, {
-      called,
-      loading,
-      error,
-      data
-    }]) => {
-      doMutation = mutate;
-      if (!called) return 'uncalled';
-      if (loading) return 'loading';
-      if (error) return /*#__PURE__*/_react2.default.createElement("div", null, "error: ", error.message);
-      if (data) return /*#__PURE__*/_react2.default.createElement("div", null, "data: ", data.answer);
-    });
-    const testMutation = {
-      resource: 'target',
+function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } if (obj === null || typeof obj !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
+
+describe('<DataMutation />', () => {
+  it('should render without failing', async () => {
+    const endpointSpy = jest.fn(() => Promise.resolve(42));
+    const mutation = {
+      resource: 'answer',
       type: 'create',
       data: {
         question: '?'
       }
     };
-    const {
-      getByText
-    } = (0, _react.render)( /*#__PURE__*/_react2.default.createElement(_react3.CustomDataProvider, {
-      data: mockBackend
-    }, /*#__PURE__*/_react2.default.createElement(_react3.DataMutation, {
-      mutation: testMutation
-    }, renderFunction)));
-    expect(getByText(/uncalled/i)).not.toBeUndefined();
-    expect(renderFunction).toHaveBeenCalledTimes(1);
-    expect(mockBackend.target).not.toHaveBeenCalled();
-    expect(renderFunction).toHaveBeenLastCalledWith([expect.any(Function), {
+    const data = {
+      answer: endpointSpy
+    };
+
+    const wrapper = ({
+      children
+    }) => /*#__PURE__*/React.createElement(_react3.CustomDataProvider, {
+      data: data
+    }, children);
+
+    const renderSpy = jest.fn(() => null);
+    (0, _react.render)( /*#__PURE__*/React.createElement(_react3.DataMutation, {
+      mutation: mutation
+    }, renderSpy), {
+      wrapper
+    });
+    expect(endpointSpy).toHaveBeenCalledTimes(0);
+    expect(renderSpy).toHaveBeenCalledTimes(1);
+    expect(renderSpy).toHaveBeenLastCalledWith([expect.any(Function), expect.objectContaining({
       called: false,
       loading: false,
       engine: expect.any(Object)
-    }]);
-    expect(doMutation).not.toBeUndefined();
-    (0, _react.act)(() => {
-      doMutation && doMutation();
+    })]);
+    await (0, _react.act)(async () => {
+      const firstRenderSpyCall = renderSpy.mock.calls[0];
+      const firstRenderSpyArgument = firstRenderSpyCall[0];
+      const [mutate] = firstRenderSpyArgument;
+      await mutate();
+    });
+    (0, _react.waitFor)(() => {
+      expect(endpointSpy).toHaveBeenCalledTimes(1);
+      expect(renderSpy).toHaveBeenCalledTimes(2);
+      expect(renderSpy).toHaveBeenLastCalledWith([expect.any(Function), expect.objectContaining({
+        called: true,
+        loading: true,
+        engine: expect.any(Object)
+      })]);
+    });
+    (0, _react.waitFor)(() => {
+      expect(endpointSpy).toHaveBeenCalledTimes(1);
+      expect(renderSpy).toHaveBeenCalledTimes(3);
+      expect(renderSpy).toHaveBeenLastCalledWith([expect.any(Function), expect.objectContaining({
+        called: true,
+        loading: false,
+        data: {
+          answer: 42
+        },
+        engine: expect.any(Object)
+      })]);
     });
-    expect(renderFunction).toHaveBeenCalledTimes(2);
-    expect(renderFunction).toHaveBeenLastCalledWith([doMutation, {
-      called: true,
-      loading: true,
-      engine: expect.any(Object)
-    }]);
-    expect(mockBackend.target).toHaveBeenCalledTimes(1);
-    await (0, _react.waitFor)(() => getByText(/data: /i));
-    expect(renderFunction).toHaveBeenCalledTimes(3);
-    expect(renderFunction).toHaveBeenLastCalledWith([doMutation, {
-      called: true,
-      loading: false,
-      data: {
-        answer: 42
-      },
-      engine: expect.any(Object)
-    }]);
-    expect(getByText(/data: /i)).toHaveTextContent("data: 42");
   });
 });

package/build/cjs/links/RestAPILink/queryToRequestOptions/textPlainMatchers.js

@@ -3,7 +3,7 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.isMetadataPackageInstallation = exports.addOrUpdateConfigurationProperty = exports.isAddOrUpdateSystemOrUserSetting = exports.isInterpretationCommentUpdate = exports.isCommentOnInterpretation = exports.isCreateOrUpdateInterpretation = exports.isCreateFeedbackMessage = exports.isReplyToMessageConversation = void 0;
+exports.isMetadataPackageInstallation = exports.addOrUpdateConfigurationProperty = exports.isAddOrUpdateSystemOrUserSetting = exports.isInterpretationCommentUpdate = exports.isCommentOnInterpretation = exports.isUpdateInterpretation = exports.isCreateInterpretation = exports.isCreateFeedbackMessage = exports.isReplyToMessageConversation = void 0;
 
 /*
  * Requests that expect a "text/plain" Content-Type have been collected by scanning
@@ -28,33 +28,43 @@ exports.isReplyToMessageConversation = isReplyToMessageConversation;
 
 const isCreateFeedbackMessage = (type, {
   resource
-}) => type === 'create' && resource === 'messageConversations/feedback'; // POST or PUT to `interpretations/${objectType}/${id}` (add or update an interpretation)
+}) => type === 'create' && resource === 'messageConversations/feedback'; // POST `interpretations/${objectType}/${id}` (add an interpretation to a visualization)
 
 
 exports.isCreateFeedbackMessage = isCreateFeedbackMessage;
 
-const isCreateOrUpdateInterpretation = (type, {
+const isCreateInterpretation = (type, {
+  resource
+}) => {
+  const pattern = /^interpretations\/(?:reportTable|chart|visualization|map|eventVisualization|eventReport|eventChart|dataSetReport)\/[a-zA-Z0-9]{11}$/;
+  return type === 'create' && pattern.test(resource);
+}; // PUT to `interpretations/${id}` (update an interpretation)
+
+
+exports.isCreateInterpretation = isCreateInterpretation;
+
+const isUpdateInterpretation = (type, {
   resource,
   id
 }) => {
-  if (type !== 'create' && type !== 'replace') {
+  if (type !== 'replace') {
     return false;
   }
 
   let resourcePattern;
 
-  if (type === 'replace' && id) {
-    resourcePattern = /^interpretations\/(?:reportTable|chart|visualization|map|eventReport|eventChart|dataSetReport)$/;
+  if (id) {
+    resourcePattern = /^interpretations$/;
     const idPattern = /^[a-zA-Z0-9]{11}$/;
     return resourcePattern.test(resource) && idPattern.test(id);
   }
 
-  resourcePattern = /^interpretations\/(?:reportTable|chart|visualization|map|eventReport|eventChart|dataSetReport)\/[a-zA-Z0-9]{11}$/;
+  resourcePattern = /^interpretations\/[a-zA-Z0-9]{11}$/;
   return resourcePattern.test(resource);
 }; // POST to `interpretations/${id}/comments` (comment on an interpretation)
 
 
-exports.isCreateOrUpdateInterpretation = isCreateOrUpdateInterpretation;
+exports.isUpdateInterpretation = isUpdateInterpretation;
 
 const isCommentOnInterpretation = (type, {
   resource

package/build/cjs/links/RestAPILink/queryToRequestOptions/textPlainMatchers.test.js

@@ -26,30 +26,58 @@ describe('isCreateFeedbackMessage', () => {
     })).toEqual(false);
   });
 });
-describe('isCreateOrUpdateInterpretation', () => {
+describe('isCreateInterpretation', () => {
   it('returns true for a POST to "interpretations/chart/${id}"', () => {
-    expect((0, _textPlainMatchers.isCreateOrUpdateInterpretation)('create', {
+    expect((0, _textPlainMatchers.isCreateInterpretation)('create', {
       resource: 'interpretations/chart/oXD88WWSQpR'
     })).toEqual(true);
   });
-  it('returns true for a PUT to "interpretations/chart/${id}"', () => {
-    expect((0, _textPlainMatchers.isCreateOrUpdateInterpretation)('replace', {
+  it('returns false for a PUT to "interpretations/chart/${id}"', () => {
+    expect((0, _textPlainMatchers.isCreateInterpretation)('replace', {
       resource: 'interpretations/chart/oXD88WWSQpR'
+    })).toEqual(false);
+  });
+  it('retuns false for PATCH requests with a valid query', () => {
+    expect((0, _textPlainMatchers.isCreateInterpretation)('update', {
+      resource: 'interpretations/chart/oXD88WWSQpR'
+    })).toEqual(false);
+  });
+  it('returns false for a request to a different resource', () => {
+    expect((0, _textPlainMatchers.isCreateInterpretation)('create', {
+      resource: 'interpretations/dummy/oXD88WWSQpR'
+    })).toEqual(false);
+  });
+});
+describe('isUpdateInterpretation', () => {
+  it('returns true for a PUT to "interpretations/${id}"', () => {
+    expect((0, _textPlainMatchers.isUpdateInterpretation)('replace', {
+      resource: 'interpretations/oXD88WWSQpR'
     })).toEqual(true);
   });
   it('returns true for PUT with populated query.id', () => {
-    expect((0, _textPlainMatchers.isCreateOrUpdateInterpretation)('replace', {
-      resource: 'interpretations/chart',
+    expect((0, _textPlainMatchers.isUpdateInterpretation)('replace', {
+      resource: 'interpretations',
       id: 'oXD88WWSQpR'
     })).toEqual(true);
   });
-  it('retuns false for PATCH requests with a valid query', () => {
-    expect((0, _textPlainMatchers.isCreateOrUpdateInterpretation)('update', {
-      resource: 'interpretations/chart/oXD88WWSQpR'
+  it('returns false for a POST to "interpretations/${id}"', () => {
+    expect((0, _textPlainMatchers.isUpdateInterpretation)('create', {
+      resource: 'interpretations/oXD88WWSQpR'
+    })).toEqual(false);
+  });
+  it('returns false for a PATCH to "interpretations/${id}"', () => {
+    expect((0, _textPlainMatchers.isUpdateInterpretation)('update', {
+      resource: 'interpretations/oXD88WWSQpR'
+    })).toEqual(false);
+  });
+  it('returns false for PATCH with populated query.id', () => {
+    expect((0, _textPlainMatchers.isUpdateInterpretation)('update', {
+      resource: 'interpretations',
+      id: 'oXD88WWSQpR'
     })).toEqual(false);
   });
   it('returns false for a request to a different resource', () => {
-    expect((0, _textPlainMatchers.isCreateOrUpdateInterpretation)('create', {
+    expect((0, _textPlainMatchers.isUpdateInterpretation)('create', {
       resource: 'interpretations/dummy/oXD88WWSQpR'
     })).toEqual(false);
   });