@dhis2/analytics 21.9.0 → 21.9.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [21.9.1](https://github.com/dhis2/analytics/compare/v21.9.0...v21.9.1) (2023-10-05)
+
+
+### Bug Fixes
+
+* avoid undefined in totals DHIS2-14511 ([#1552](https://github.com/dhis2/analytics/issues/1552)) ([#1585](https://github.com/dhis2/analytics/issues/1585)) ([f2c1fd1](https://github.com/dhis2/analytics/commit/f2c1fd1807af875e0af0f49bc2027862863ade35))
+
 # [21.9.0](https://github.com/dhis2/analytics/compare/v21.8.2...v21.9.0) (2023-03-02)
 
 

package/build/cjs/modules/pivotTable/PivotTableEngine.js

@@ -11,6 +11,8 @@ var _predefinedDimensions = require("../predefinedDimensions.js");
 
 var _AdaptiveClippingController = require("./AdaptiveClippingController.js");
 
+var _addToTotalIfNumber = require("./addToTotalIfNumber.js");
+
 var _parseValue = require("./parseValue.js");
 
 var _pivotTableConstants = require("./pivotTableConstants.js");
@@ -611,10 +613,7 @@ class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = (0, _parseValue.parseValue)(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            totalCell[field] = (totalCell[field] || 0) + value;
-          }
+          totalCell[field] = (0, _addToTotalIfNumber.addToTotalIfNumber)(value, totalCell[field]);
         });
       }
 
@@ -633,10 +632,7 @@ class PivotTableEngine {
       dataFields.forEach(field => {
         const headerIndex = this.dimensionLookup.dataHeaders[field];
         const value = (0, _parseValue.parseValue)(dataRow[headerIndex]);
-
-        if (value && !isNaN(value)) {
-          percentageTotal[field] = (percentageTotal[field] || 0) + value;
-        }
+        percentageTotal[field] = (0, _addToTotalIfNumber.addToTotalIfNumber)(value, percentageTotal[field]);
       });
 
       if (totals.columnSubtotal) {
@@ -651,10 +647,7 @@ class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = (0, _parseValue.parseValue)(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            percentageTotal[field] = (percentageTotal[field] || 0) + value;
-          }
+          percentageTotal[field] = (0, _addToTotalIfNumber.addToTotalIfNumber)(value, percentageTotal[field]);
         });
       }
 
@@ -670,10 +663,7 @@ class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = (0, _parseValue.parseValue)(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            percentageTotal[field] = (percentageTotal[field] || 0) + value;
-          }
+          percentageTotal[field] = (0, _addToTotalIfNumber.addToTotalIfNumber)(value, percentageTotal[field]);
         });
       }
     }
@@ -690,10 +680,7 @@ class PivotTableEngine {
       dataFields.forEach(field => {
         const headerIndex = this.dimensionLookup.dataHeaders[field];
         const value = (0, _parseValue.parseValue)(dataRow[headerIndex]);
-
-        if (value && !isNaN(value)) {
-          percentageTotal[field] = (percentageTotal[field] || 0) + value;
-        }
+        percentageTotal[field] = (0, _addToTotalIfNumber.addToTotalIfNumber)(value, percentageTotal[field]);
       });
 
       if (totals.rowSubtotal) {
@@ -708,10 +695,7 @@ class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = (0, _parseValue.parseValue)(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            percentageTotal[field] = (percentageTotal[field] || 0) + value;
-          }
+          percentageTotal[field] = (0, _addToTotalIfNumber.addToTotalIfNumber)(value, percentageTotal[field]);
         });
       }
 
@@ -727,10 +711,7 @@ class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = (0, _parseValue.parseValue)(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            percentageTotal[field] = (percentageTotal[field] || 0) + value;
-          }
+          percentageTotal[field] = (0, _addToTotalIfNumber.addToTotalIfNumber)(value, percentageTotal[field]);
         });
       }
     }

package/build/cjs/modules/pivotTable/__tests__/addToTotalIfNumber.js

@@ -0,0 +1,72 @@
+"use strict";
+
+var _addToTotalIfNumber = require("../addToTotalIfNumber.js");
+
+const tests = [{
+  testName: 'negative value',
+  value: -1,
+  total: undefined,
+  expected: -1
+}, {
+  testName: 'zero value',
+  value: 0,
+  total: undefined,
+  expected: 0
+}, {
+  testName: 'positive value',
+  value: 1,
+  total: undefined,
+  expected: 1
+}, {
+  testName: 'null value',
+  value: null,
+  total: undefined,
+  expected: undefined
+}, {
+  testName: 'undefined value',
+  value: undefined,
+  total: undefined,
+  expected: undefined
+}, {
+  testName: 'string value',
+  value: 'string',
+  total: undefined,
+  expected: undefined
+}, {
+  testName: 'negative value with existing total',
+  value: -1,
+  total: 100,
+  expected: 99
+}, {
+  testName: 'zero value with existing total',
+  value: 0,
+  total: 100,
+  expected: 100
+}, {
+  testName: 'positive value with existing total',
+  value: 1,
+  total: 100,
+  expected: 101
+}, {
+  testName: 'null value with existing total',
+  value: null,
+  total: 100,
+  expected: 100
+}, {
+  testName: 'undefined value with existing total',
+  value: undefined,
+  total: 100,
+  expected: 100
+}, {
+  testName: 'string value with existing total',
+  value: 'string',
+  total: 100,
+  expected: 100
+}];
+describe('addToTotalIfNumber', () => {
+  tests.forEach(t => {
+    it(t.testName, () => {
+      expect((0, _addToTotalIfNumber.addToTotalIfNumber)(t.value, t.total)).toEqual(t.expected);
+    });
+  });
+});

package/build/cjs/modules/pivotTable/addToTotalIfNumber.js

@@ -0,0 +1,10 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.addToTotalIfNumber = void 0;
+
+const addToTotalIfNumber = (value, total) => typeof value === 'number' && Number.isFinite(value) ? (total !== null && total !== void 0 ? total : 0) + value : total;
+
+exports.addToTotalIfNumber = addToTotalIfNumber;

package/build/es/modules/pivotTable/PivotTableEngine.js

@@ -3,6 +3,7 @@ function _defineProperty(obj, key, value) { if (key in obj) { Object.definePrope
 import times from 'lodash/times';
 import { DIMENSION_ID_ORGUNIT } from '../predefinedDimensions.js';
 import { AdaptiveClippingController } from './AdaptiveClippingController.js';
+import { addToTotalIfNumber } from './addToTotalIfNumber.js';
 import { parseValue } from './parseValue.js';
 import { AGGREGATE_TYPE_NA, AGGREGATE_TYPE_AVERAGE, AGGREGATE_TYPE_SUM, CELL_TYPE_VALUE, CELL_TYPE_TOTAL, CELL_TYPE_SUBTOTAL, SORT_ORDER_ASCENDING, SORT_ORDER_DESCENDING, DISPLAY_DENSITY_PADDING_COMPACT, DISPLAY_DENSITY_PADDING_COMFORTABLE, DISPLAY_DENSITY_OPTION_COMFORTABLE, DISPLAY_DENSITY_OPTION_COMPACT, DISPLAY_DENSITY_OPTION_NORMAL, DISPLAY_DENSITY_PADDING_NORMAL, FONT_SIZE_OPTION_SMALL, FONT_SIZE_SMALL, FONT_SIZE_OPTION_LARGE, FONT_SIZE_LARGE, FONT_SIZE_OPTION_NORMAL, FONT_SIZE_NORMAL, VALUE_TYPE_NUMBER, NUMBER_TYPE_COLUMN_PERCENTAGE, NUMBER_TYPE_ROW_PERCENTAGE, DIMENSION_TYPE_DATA, DIMENSION_TYPE_DATA_ELEMENT_GROUP_SET, DIMENSION_TYPE_ORGUNIT, DIMENSION_TYPE_PERIOD, VALUE_TYPE_TEXT, NUMBER_TYPE_VALUE } from './pivotTableConstants.js';
 import { renderValue } from './renderValue.js';
@@ -596,10 +597,7 @@ export class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = parseValue(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            totalCell[field] = (totalCell[field] || 0) + value;
-          }
+          totalCell[field] = addToTotalIfNumber(value, totalCell[field]);
         });
       }
 
@@ -618,10 +616,7 @@ export class PivotTableEngine {
       dataFields.forEach(field => {
         const headerIndex = this.dimensionLookup.dataHeaders[field];
         const value = parseValue(dataRow[headerIndex]);
-
-        if (value && !isNaN(value)) {
-          percentageTotal[field] = (percentageTotal[field] || 0) + value;
-        }
+        percentageTotal[field] = addToTotalIfNumber(value, percentageTotal[field]);
       });
 
       if (totals.columnSubtotal) {
@@ -636,10 +631,7 @@ export class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = parseValue(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            percentageTotal[field] = (percentageTotal[field] || 0) + value;
-          }
+          percentageTotal[field] = addToTotalIfNumber(value, percentageTotal[field]);
         });
       }
 
@@ -655,10 +647,7 @@ export class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = parseValue(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            percentageTotal[field] = (percentageTotal[field] || 0) + value;
-          }
+          percentageTotal[field] = addToTotalIfNumber(value, percentageTotal[field]);
         });
       }
     }
@@ -675,10 +664,7 @@ export class PivotTableEngine {
       dataFields.forEach(field => {
         const headerIndex = this.dimensionLookup.dataHeaders[field];
         const value = parseValue(dataRow[headerIndex]);
-
-        if (value && !isNaN(value)) {
-          percentageTotal[field] = (percentageTotal[field] || 0) + value;
-        }
+        percentageTotal[field] = addToTotalIfNumber(value, percentageTotal[field]);
       });
 
       if (totals.rowSubtotal) {
@@ -693,10 +679,7 @@ export class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = parseValue(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            percentageTotal[field] = (percentageTotal[field] || 0) + value;
-          }
+          percentageTotal[field] = addToTotalIfNumber(value, percentageTotal[field]);
         });
       }
 
@@ -712,10 +695,7 @@ export class PivotTableEngine {
         dataFields.forEach(field => {
           const headerIndex = this.dimensionLookup.dataHeaders[field];
           const value = parseValue(dataRow[headerIndex]);
-
-          if (value && !isNaN(value)) {
-            percentageTotal[field] = (percentageTotal[field] || 0) + value;
-          }
+          percentageTotal[field] = addToTotalIfNumber(value, percentageTotal[field]);
         });
       }
     }

package/build/es/modules/pivotTable/__tests__/addToTotalIfNumber.js

@@ -0,0 +1,69 @@
+import { addToTotalIfNumber } from '../addToTotalIfNumber.js';
+const tests = [{
+  testName: 'negative value',
+  value: -1,
+  total: undefined,
+  expected: -1
+}, {
+  testName: 'zero value',
+  value: 0,
+  total: undefined,
+  expected: 0
+}, {
+  testName: 'positive value',
+  value: 1,
+  total: undefined,
+  expected: 1
+}, {
+  testName: 'null value',
+  value: null,
+  total: undefined,
+  expected: undefined
+}, {
+  testName: 'undefined value',
+  value: undefined,
+  total: undefined,
+  expected: undefined
+}, {
+  testName: 'string value',
+  value: 'string',
+  total: undefined,
+  expected: undefined
+}, {
+  testName: 'negative value with existing total',
+  value: -1,
+  total: 100,
+  expected: 99
+}, {
+  testName: 'zero value with existing total',
+  value: 0,
+  total: 100,
+  expected: 100
+}, {
+  testName: 'positive value with existing total',
+  value: 1,
+  total: 100,
+  expected: 101
+}, {
+  testName: 'null value with existing total',
+  value: null,
+  total: 100,
+  expected: 100
+}, {
+  testName: 'undefined value with existing total',
+  value: undefined,
+  total: 100,
+  expected: 100
+}, {
+  testName: 'string value with existing total',
+  value: 'string',
+  total: 100,
+  expected: 100
+}];
+describe('addToTotalIfNumber', () => {
+  tests.forEach(t => {
+    it(t.testName, () => {
+      expect(addToTotalIfNumber(t.value, t.total)).toEqual(t.expected);
+    });
+  });
+});

package/build/es/modules/pivotTable/addToTotalIfNumber.js

@@ -0,0 +1 @@
+export const addToTotalIfNumber = (value, total) => typeof value === 'number' && Number.isFinite(value) ? (total !== null && total !== void 0 ? total : 0) + value : total;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@dhis2/analytics",
-    "version": "21.9.0",
+    "version": "21.9.1",
     "main": "./build/cjs/index.js",
     "module": "./build/es/index.js",
     "exports": {