@dharma-ai-labs/agent-fabric 0.2.15 → 0.2.17

package/dist/index.test.js

@@ -7,7 +7,7 @@ import { join } from 'node:path';
 import test from 'node:test';
 import { fileURLToPath, pathToFileURL } from 'node:url';
 import { promisify } from 'node:util';
-import { activateAgyPlugin, actionDecisionCapabilityFreshUntil, canonicalFilesystemPath, controlAgentDecisionUrl, installAvailableNativeAgentFabricBootstraps, assertCapsuleAuthorizedByCurrentPolicy, assertRecoveredTaskWorkspacePolicy, assertTaskWorkspacePolicy, assertTaskSkillPin, installNativeAgentFabricBootstrap, installRepositoryAgentFabricSkill, isDirectExecution, materializeWorkspacePolicy, applyServerEvidencePolicy, materializeInlineSkillFiles, nativeSkillDirectory, normalizeGitRemoteIdentity, postTaskOutcome, parseCliOptions, parseSelectedProviderIds, pathExistsOrThrow, portalUrl, rawLocalRetentionDays, recoverLegacySkillBundleIdAfterAuthorizationFailure, installedBundleIdForSkillPollAfterAuthorizationFailure, recoveredTaskPolicyWasSuperseded, relayProcessState, releaseDailyContentUpload, reserveDailyContentUpload, run, runAssistantCommand, sourceRepositoryFingerprint, responseTextFromEvent, taskResponsePreview, taskReceiptSession, taskSkillPinFailureCode, verifyAgentFabricSkillInstallation, withWorkspacePolicyRefreshLock, withWorkspaceSkillActivationLock, } from './index.js';
+import { activateAgyPlugin, attestAgySkillActivation, attestHermesSkillBundleActivation, actionDecisionCapabilityFreshUntil, canonicalFilesystemPath, controlAgentDecisionUrl, installAvailableNativeAgentFabricBootstraps, assertCapsuleAuthorizedByCurrentPolicy, assertRecoveredTaskWorkspacePolicy, assertTaskWorkspacePolicy, assertTaskSkillPin, installNativeAgentFabricBootstrap, installRepositoryAgentFabricSkill, isDirectExecution, materializeWorkspacePolicy, applyServerEvidencePolicy, materializeInlineSkillFiles, nativeSkillDirectory, normalizeGitRemoteIdentity, postTaskOutcome, parseCliOptions, parseSelectedProviderIds, pathExistsOrThrow, portalUrl, rawLocalRetentionDays, recoverLegacySkillBundleIdAfterAuthorizationFailure, installedBundleIdForSkillPollAfterAuthorizationFailure, recoveredTaskPolicyWasSuperseded, relayProcessState, releaseDailyContentUpload, reserveDailyContentUpload, run, runAssistantCommand, sourceRepositoryFingerprint, ensureAgyReadOnlyAttestationPermission, attestAgySkillBundleActivation, responseTextFromEvent, taskResponsePreview, taskReceiptSession, taskSkillPinFailureCode, verifyAgentFabricSkillInstallation, withWorkspacePolicyRefreshLock, withWorkspaceSkillActivationLock, } from './index.js';
 import { canonicalize, signCanonicalObject } from '@dharma-ai-labs/agent-fabric-contracts';
 import { buildTrajectoryCapsule } from '@dharma-ai-labs/agent-fabric-evidence-reduction';
 import { CLI_USAGE } from './usage.js';
@@ -401,7 +401,8 @@ test('CLI parser preserves repeated repository, key, and provider selections', (
     assert.equal(parsed.flags.get('non-interactive'), true);
     assert.deepEqual(parseSelectedProviderIds(parsed.repeated.get('provider') || []), ['codex', 'claude']);
     assert.deepEqual(parseSelectedProviderIds(['agy,codex', 'agy']), ['agy', 'codex']);
-    assert.throws(() => parseSelectedProviderIds(['unsupported']), /codex, claude, or agy/);
+    assert.deepEqual(parseSelectedProviderIds(['hermes,codex', 'hermes']), ['hermes', 'codex']);
+    assert.throws(() => parseSelectedProviderIds(['unsupported']), /codex, claude, agy, or hermes/);
 });
 test('workspace registration reuses a normalized repository identity across local paths', async () => {
     const root = await mkdtemp(join(tmpdir(), 'dharma-repository-identity-'));
@@ -590,12 +591,15 @@ test('workspace policy refreshes serialize before requesting a new signed author
     process.env.DHARMA_HOME = home;
     const events = [];
     try {
+        let firstEntered;
+        const firstStarted = new Promise((resolve) => { firstEntered = resolve; });
         const first = withWorkspacePolicyRefreshLock('workspace-concurrent', async () => {
             events.push('first-start');
+            firstEntered();
             await new Promise((accept) => setTimeout(accept, 40));
             events.push('first-end');
         });
-        await new Promise((accept) => setTimeout(accept, 5));
+        await firstStarted;
         const second = withWorkspacePolicyRefreshLock('workspace-concurrent', async () => {
             events.push('second-start');
             events.push('second-end');
@@ -616,12 +620,15 @@ test('task execution and skill synchronization share one workspace-provider acti
     process.env.DHARMA_HOME = home;
     const events = [];
     try {
+        let taskEntered;
+        const taskStarted = new Promise((resolve) => { taskEntered = resolve; });
         const task = withWorkspaceSkillActivationLock('workspace-concurrent', 'codex', async () => {
             events.push('task-start');
+            taskEntered();
             await new Promise((accept) => setTimeout(accept, 40));
             events.push('task-end');
         });
-        await new Promise((accept) => setTimeout(accept, 5));
+        await taskStarted;
         const sync = withWorkspaceSkillActivationLock('workspace-concurrent', 'codex', async () => {
             events.push('sync-start');
             events.push('sync-end');
@@ -1132,9 +1139,73 @@ test('provider skill roots map to each host native discovery directory', async (
     assert.equal(nativeSkillDirectory('codex', {}, home), join(home, '.codex', 'skills'));
     assert.equal(nativeSkillDirectory('claude', {}, home), join(home, '.claude', 'skills'));
     assert.equal(nativeSkillDirectory('agy', {}, home), join(home, '.gemini', 'antigravity-cli', 'plugins', 'dharma-agent-fabric', 'skills'));
+    assert.equal(nativeSkillDirectory('hermes', {}, home), join(home, '.hermes', 'skills'));
     assert.equal(nativeSkillDirectory('codex', { CODEX_HOME: join(home, 'custom-codex') }, home), join(home, 'custom-codex', 'skills'));
     assert.equal(nativeSkillDirectory('claude', { CLAUDE_CONFIG_DIR: join(home, 'custom-claude') }, home), join(home, 'custom-claude', 'skills'));
     assert.equal(nativeSkillDirectory('agy', { AGY_CONFIG_DIR: join(home, 'custom-agy') }, home), join(home, 'custom-agy', 'plugins', 'dharma-agent-fabric', 'skills'));
+    assert.equal(nativeSkillDirectory('hermes', { HERMES_HOME: join(home, 'custom-hermes') }, home), join(home, 'custom-hermes', 'skills'));
+});
+test('Hermes bootstrap trusts the repository and verifies native discovery', async () => {
+    const root = await mkdtemp(join(tmpdir(), 'dharma-hermes-skill-'));
+    const home = join(root, 'home');
+    const workspace = join(root, 'repo');
+    const calls = [];
+    await mkdir(workspace, { recursive: true });
+    const canonicalWorkspace = await realpath(workspace);
+    await installRepositoryAgentFabricSkill({
+        workspace,
+        hqUrl: 'https://www.dharma-ai.io',
+        organizationId: 'org_test',
+        workspaceId: 'workspace_test',
+        policyRevision: 'agent-fabric-policy-v1',
+    });
+    const installed = await installNativeAgentFabricBootstrap({
+        provider: 'hermes', workspace, workspaceId: 'workspace_test', organizationId: 'org_test',
+        hqUrl: 'https://www.dharma-ai.io', home, env: { HOME: home, PATH: '/usr/bin:/bin' },
+        executeHermes: async (executable, argv, options) => {
+            calls.push({ executable, argv, cwd: options.cwd });
+            return { stdout: '' };
+        },
+    });
+    assert.equal(installed.verified, true);
+    assert.deepEqual(calls[0], {
+        executable: 'hermes',
+        argv: ['skills', 'trust', canonicalWorkspace],
+        cwd: canonicalWorkspace,
+    });
+    const verified = await verifyAgentFabricSkillInstallation({
+        provider: 'hermes', workspace, home, env: { HOME: home, PATH: '/usr/bin:/bin' },
+        listHermesSkills: async () => ({ stdout: 'dharma-agent-fabric  local  trusted  enabled' }),
+    });
+    assert.equal(verified.ready, true);
+    assert.equal(verified.nativeDiscovered, true);
+    assert.equal(verified.activationAttested, false);
+    assert.match(verified.nextAction, /signed remediation bundle/);
+});
+test('Hermes signed activation requires every installed bundle skill to be discovered', async () => {
+    const workspace = await mkdtemp(join(tmpdir(), 'dharma-hermes-activation-'));
+    const canonicalWorkspace = await realpath(workspace);
+    const bundle = {
+        operation: 'install',
+        skills: [{ skillId: 'price-boundary' }, { skillId: 'handoff-authority' }],
+    };
+    const calls = [];
+    const passed = await attestHermesSkillBundleActivation({
+        bundle, workspace,
+        execute: async (_executable, argv) => {
+            calls.push(argv);
+            return { stdout: argv[1] === 'list' ? 'price-boundary\nhandoff-authority\n' : '' };
+        },
+    });
+    assert.equal(passed.status, 'pass');
+    assert.deepEqual(calls[0], ['skills', 'trust', canonicalWorkspace]);
+    assert.deepEqual(calls[1], ['skills', 'list', '--source', 'local', '--enabled-only']);
+    const failed = await attestHermesSkillBundleActivation({
+        bundle, workspace,
+        execute: async (_executable, argv) => ({ stdout: argv[1] === 'list' ? 'price-boundary\n' : '' }),
+    });
+    assert.equal(failed.status, 'fail');
+    assert.match(failed.details, /handoff-authority/);
 });
 test('native bootstrap installation makes the repository skill verifiable by Codex', async () => {
     const root = await mkdtemp(join(tmpdir(), 'dharma-native-skill-'));
@@ -1207,7 +1278,7 @@ test('Agy skill verification requires the native plugin to be discoverable by th
     assert.equal(discovered.signedLifecycleReady, false);
     assert.equal(discovered.ready, true);
     assert.equal(discovered.verificationScope, 'generic_bootstrap');
-    assert.match(discovered.nextAction, /signed activation and rollback remain unavailable/);
+    assert.match(discovered.nextAction, /content-bound activation challenge/);
 });
 test('native bootstrap installation refuses to overwrite an unmanaged provider skill', async () => {
     const root = await mkdtemp(join(tmpdir(), 'dharma-native-skill-unmanaged-'));
@@ -1242,6 +1313,105 @@ test('Agy activation validates and registers the generated plugin before enablin
         { executable: 'agy', argv: ['plugin', 'enable', 'dharma-agent-fabric'] },
     ]);
 });
+test('Agy attestation permission adds only the supported read-only Git preflight', async () => {
+    const home = await mkdtemp(join(tmpdir(), 'dharma-agy-permission-'));
+    const root = join(home, '.gemini', 'antigravity-cli');
+    await mkdir(root, { recursive: true });
+    await writeFile(join(root, 'settings.json'), `${JSON.stringify({
+        enableTelemetry: false,
+        permissions: { allow: ['command(ls)'] },
+    }, null, 2)}\n`);
+    const first = await ensureAgyReadOnlyAttestationPermission({ home, env: {} });
+    const second = await ensureAgyReadOnlyAttestationPermission({ home, env: {} });
+    const settings = JSON.parse(await readFile(join(root, 'settings.json'), 'utf8'));
+    assert.equal(first.changed, true);
+    assert.equal(second.changed, false);
+    assert.deepEqual(settings.permissions.allow, ['command(ls)', 'command(git status)']);
+    assert.equal(settings.enableTelemetry, false);
+});
+test('Agy activation attestation proves the invoked skill token without unsafe permission bypasses', async () => {
+    const root = await mkdtemp(join(tmpdir(), 'dharma-agy-attestation-'));
+    const workspace = join(root, 'repo');
+    const skillPath = join(root, 'SKILL.md');
+    await mkdir(workspace, { recursive: true });
+    await writeFile(skillPath, [
+        '# Signed remediation',
+        '',
+        'Dharma activation token: `sha256:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`',
+        '',
+    ].join('\n'));
+    let observed = {};
+    const result = await attestAgySkillActivation({
+        skillId: 'dharma-remediation',
+        skillPath,
+        workspace,
+        challenge: 'agy-test-challenge',
+        execute: async (executable, argv, options) => {
+            observed = { executable, argv, cwd: options.cwd };
+            return { stdout: JSON.stringify({
+                    status: 'SUCCESS',
+                    response: '```json\\n{"challenge":"agy-test-challenge","activationToken":"sha256:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"}\\n```',
+                }) };
+        },
+    });
+    assert.equal(result.status, 'pass');
+    assert.equal(observed.executable, 'agy');
+    assert.equal(observed.cwd, await realpath(workspace));
+    assert.ok(observed.argv?.includes('--sandbox'));
+    assert.ok(observed.argv?.includes('plan'));
+    assert.ok(observed.argv?.includes('gemini-3.7-flash-low'));
+    assert.equal(observed.argv?.includes('--dangerously-skip-permissions'), false);
+    assert.match(String(observed.argv?.[2]), /^\/dharma-remediation/);
+    assert.doesNotMatch(String(observed.argv?.[2]), /sha256:aaaaaaaa/);
+});
+test('Agy activation attestation fails closed on a mismatched content token', async () => {
+    const root = await mkdtemp(join(tmpdir(), 'dharma-agy-attestation-mismatch-'));
+    const skillPath = join(root, 'SKILL.md');
+    await writeFile(skillPath, 'Dharma activation token: `sha256:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`\n');
+    const result = await attestAgySkillActivation({
+        skillId: 'dharma-remediation',
+        skillPath,
+        workspace: root,
+        challenge: 'agy-test-challenge',
+        execute: async () => ({ stdout: JSON.stringify({
+                status: 'SUCCESS',
+                response: '{"challenge":"agy-test-challenge","activationToken":"sha256:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"}',
+            }) }),
+    });
+    assert.equal(result.status, 'fail');
+    assert.equal(result.details, 'Agy returned an activation token that does not match the installed signed skill.');
+});
+test('Agy does not report content attestation for an empty clear bundle', async () => {
+    const root = await mkdtemp(join(tmpdir(), 'dharma-agy-empty-attestation-'));
+    const result = await attestAgySkillBundleActivation({
+        bundle: {
+            schema: 'dharma.skill-bundle/v2',
+            bundleId: 'bundle_clear',
+            organizationId: 'org_test',
+            version: '0.0.0',
+            operation: 'clear',
+            riskClass: 'R0',
+            targetSelectors: {
+                organizationAgentIds: [],
+                deviceIds: [],
+                workspaceIds: [],
+                providers: ['agy'],
+            },
+            activationPolicy: 'next_session',
+            rollbackBundleId: null,
+            evaluationReceiptId: 'evaluation_clear',
+            bundleHash: 'unused-by-attestation',
+            createdAt: new Date().toISOString(),
+            expiresAt: new Date(Date.now() + 60_000).toISOString(),
+            skills: [],
+            signature: 'unused-by-attestation',
+        },
+        nativeSkillDirectory: root,
+        workspace: root,
+    });
+    assert.equal(result.status, 'unavailable');
+    assert.equal(result.details, 'The signed bundle contains no Agy skill content to attest.');
+});
 test('native bootstrap installation isolates provider failures during onboarding', async () => {
     const result = await installAvailableNativeAgentFabricBootstraps({
         providers: [