@dfosco/storyboard-react 3.11.1-beta.0 → 3.11.2

package/src/canvas/useUndoRedo.test.js

@@ -0,0 +1,231 @@
+import { renderHook, act } from '@testing-library/react'
+import useUndoRedo from './useUndoRedo.js'
+
+describe('useUndoRedo', () => {
+  it('starts with canUndo and canRedo as false', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    expect(result.current.canUndo).toBe(false)
+    expect(result.current.canRedo).toBe(false)
+  })
+
+  it('can undo after a snapshot', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    const widgets = [{ id: '1', type: 'sticky-note', props: { text: 'a' }, position: { x: 0, y: 0 } }]
+
+    act(() => result.current.snapshot(widgets, 'add'))
+
+    expect(result.current.canUndo).toBe(true)
+    expect(result.current.canRedo).toBe(false)
+  })
+
+  it('undo returns the previous state and enables redo', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    const before = [{ id: '1', props: { text: 'a' } }]
+    const after = [{ id: '1', props: { text: 'b' } }]
+
+    act(() => result.current.snapshot(before, 'edit', '1'))
+
+    let restored
+    act(() => { restored = result.current.undo(after) })
+
+    expect(restored).toEqual(before)
+    expect(result.current.canUndo).toBe(false)
+    expect(result.current.canRedo).toBe(true)
+  })
+
+  it('redo returns the next state', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    const before = [{ id: '1', props: { text: 'a' } }]
+    const after = [{ id: '1', props: { text: 'b' } }]
+
+    act(() => result.current.snapshot(before, 'edit', '1'))
+    act(() => { result.current.undo(after) })
+
+    let redone
+    act(() => { redone = result.current.redo(before) })
+
+    expect(redone).toEqual(after)
+    expect(result.current.canUndo).toBe(true)
+    expect(result.current.canRedo).toBe(false)
+  })
+
+  it('new mutation after undo clears the redo chain', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    const s0 = [{ id: '1' }]
+    const s1 = [{ id: '1' }, { id: '2' }]
+    const s2 = [{ id: '1' }, { id: '3' }] // eslint-disable-line no-unused-vars
+
+    act(() => result.current.snapshot(s0, 'add'))
+    act(() => result.current.undo(s1))
+    expect(result.current.canRedo).toBe(true)
+
+    // New mutation breaks redo
+    act(() => result.current.snapshot(s0, 'add'))
+    expect(result.current.canRedo).toBe(false)
+    expect(result.current.canUndo).toBe(true)
+  })
+
+  it('supports multi-step undo-redo-undo chains', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    const s0 = [{ id: '1' }]
+    const s1 = [{ id: '1' }, { id: '2' }]
+    const s2 = [{ id: '1' }, { id: '2' }, { id: '3' }]
+    const s3 = [{ id: '1' }, { id: '2' }, { id: '3' }, { id: '4' }]
+
+    // Build history: s0 → s1 → s2 → s3
+    act(() => result.current.snapshot(s0, 'add'))
+    act(() => result.current.snapshot(s1, 'add'))
+    act(() => result.current.snapshot(s2, 'add'))
+
+    // present = s3, past = [s0, s1, s2]
+    // Undo to s2
+    let r
+    act(() => { r = result.current.undo(s3) })
+    expect(r).toEqual(s2)
+
+    // Undo to s1
+    act(() => { r = result.current.undo(s2) })
+    expect(r).toEqual(s1)
+
+    // Redo to s2
+    act(() => { r = result.current.redo(s1) })
+    expect(r).toEqual(s2)
+
+    // Redo to s3
+    act(() => { r = result.current.redo(s2) })
+    expect(r).toEqual(s3)
+
+    // Undo to s2 again
+    act(() => { r = result.current.undo(s3) })
+    expect(r).toEqual(s2)
+
+    // Undo to s1
+    act(() => { r = result.current.undo(s2) })
+    expect(r).toEqual(s1)
+
+    // Undo to s0
+    act(() => { r = result.current.undo(s1) })
+    expect(r).toEqual(s0)
+
+    // Can't undo further
+    expect(result.current.canUndo).toBe(false)
+    act(() => { r = result.current.undo(s0) })
+    expect(r).toBeNull()
+  })
+
+  it('coalesces edits to the same widget within timeout', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    const s0 = [{ id: '1', props: { text: '' } }]
+
+    // First edit — creates snapshot
+    act(() => result.current.snapshot(s0, 'edit', '1'))
+    expect(result.current.canUndo).toBe(true)
+
+    // Second edit to same widget within 2s — coalesced, no new snapshot
+    act(() => result.current.snapshot(s0, 'edit', '1'))
+    // Still only one entry in past
+    let r
+    act(() => { r = result.current.undo([{ id: '1', props: { text: 'abc' } }]) })
+    expect(r).toEqual(s0)
+    // No more undo after that
+    expect(result.current.canUndo).toBe(false)
+  })
+
+  it('does NOT coalesce edits to different widgets', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    const s0 = [{ id: '1' }, { id: '2' }]
+    const s1 = [{ id: '1', props: { text: 'a' } }, { id: '2' }]
+
+    act(() => result.current.snapshot(s0, 'edit', '1'))
+    act(() => result.current.snapshot(s1, 'edit', '2'))
+
+    // Two entries in past
+    expect(result.current.canUndo).toBe(true)
+    act(() => { result.current.undo([]) })
+    expect(result.current.canUndo).toBe(true)
+    act(() => { result.current.undo([]) })
+    expect(result.current.canUndo).toBe(false)
+  })
+
+  it('does NOT coalesce edit after a different action type', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    const s0 = [{ id: '1' }]
+    const s1 = [{ id: '1' }, { id: '2' }]
+
+    act(() => result.current.snapshot(s0, 'edit', '1'))
+    act(() => result.current.snapshot(s1, 'add'))
+    act(() => result.current.snapshot(s1, 'edit', '1'))
+
+    // Three entries in past (edit + add + edit — not coalesced because add broke the sequence)
+    act(() => { result.current.undo([]) })
+    act(() => { result.current.undo([]) })
+    act(() => { result.current.undo([]) })
+    expect(result.current.canUndo).toBe(false)
+  })
+
+  it('reset clears all history', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    act(() => result.current.snapshot([{ id: '1' }], 'add'))
+    act(() => result.current.snapshot([{ id: '1' }, { id: '2' }], 'add'))
+    expect(result.current.canUndo).toBe(true)
+
+    act(() => result.current.reset())
+    expect(result.current.canUndo).toBe(false)
+    expect(result.current.canRedo).toBe(false)
+  })
+
+  it('undo returns null when history is empty', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    let r
+    act(() => { r = result.current.undo([]) })
+    expect(r).toBeNull()
+  })
+
+  it('redo returns null when future is empty', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    let r
+    act(() => { r = result.current.redo([]) })
+    expect(r).toBeNull()
+  })
+
+  it('snapshots are deep clones (mutations do not leak)', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    const widgets = [{ id: '1', props: { text: 'original' } }]
+
+    act(() => result.current.snapshot(widgets, 'add'))
+
+    // Mutate the original array
+    widgets[0].props.text = 'mutated'
+
+    let restored
+    act(() => { restored = result.current.undo(widgets) })
+    expect(restored[0].props.text).toBe('original')
+  })
+
+  it('caps history at 100 entries', () => {
+    const { result } = renderHook(() => useUndoRedo())
+
+    for (let i = 0; i < 110; i++) {
+      act(() => result.current.snapshot([{ id: String(i) }], 'add'))
+    }
+
+    // Should be capped at 100 — undo 100 times, then can't undo further
+    let count = 0
+    let r = true
+    while (r !== null) {
+      act(() => { r = result.current.undo([]) })
+      if (r !== null) count++
+    }
+    expect(count).toBe(100)
+  })
+
+  it('snapshots null widgets as empty array (first widget on new canvas)', () => {
+    const { result } = renderHook(() => useUndoRedo())
+    act(() => result.current.snapshot(null, 'add'))
+    expect(result.current.canUndo).toBe(true)
+
+    let restored
+    act(() => { restored = result.current.undo([{ id: '1' }]) })
+    expect(restored).toEqual([])
+  })
+})

package/src/canvas/widgets/ComponentWidget.jsx

@@ -11,7 +11,7 @@ import styles from './ComponentWidget.module.css'
  * Double-click the overlay to enter interactive mode (dropdowns, buttons work).
  * Click outside to exit interactive mode.
  */
-export default function ComponentWidget({ component: Component, width, height, onUpdate }) {
+export default function ComponentWidget({ component: Component, width, height, onUpdate, resizable }) {
   const containerRef = useRef(null)
   const [interactive, setInteractive] = useState(false)
 
@@ -51,12 +51,14 @@ export default function ComponentWidget({ component: Component, width, height, o
             onDoubleClick={enterInteractive}
           />
         )}
-        <ResizeHandle
-          targetRef={containerRef}
-          minWidth={100}
-          minHeight={60}
-          onResize={handleResize}
-        />
+        {resizable && (
+          <ResizeHandle
+            targetRef={containerRef}
+            minWidth={100}
+            minHeight={60}
+            onResize={handleResize}
+          />
+        )}
       </div>
     </WidgetWrapper>
   )

package/src/canvas/widgets/FigmaEmbed.jsx

@@ -0,0 +1,195 @@
+import { forwardRef, useImperativeHandle, useMemo, useCallback, useState, useEffect, useRef } from 'react'
+import { createPortal } from 'react-dom'
+import WidgetWrapper from './WidgetWrapper.jsx'
+import { readProp } from './widgetProps.js'
+import { schemas } from './widgetConfig.js'
+import { toFigmaEmbedUrl, getFigmaTitle, getFigmaType, isFigmaUrl } from './figmaUrl.js'
+import styles from './FigmaEmbed.module.css'
+
+const figmaEmbedSchema = schemas['figma-embed']
+
+/** Inline Figma logo SVG */
+function FigmaLogo() {
+  return (
+    <svg className={styles.figmaLogo} viewBox="0 0 38 57" fill="none" aria-hidden="true">
+      <path d="M19 28.5a9.5 9.5 0 1 1 19 0 9.5 9.5 0 0 1-19 0z" fill="#1ABCFE" />
+      <path d="M0 47.5A9.5 9.5 0 0 1 9.5 38H19v9.5a9.5 9.5 0 1 1-19 0z" fill="#0ACF83" />
+      <path d="M19 0v19h9.5a9.5 9.5 0 1 0 0-19H19z" fill="#FF7262" />
+      <path d="M0 9.5A9.5 9.5 0 0 0 9.5 19H19V0H9.5A9.5 9.5 0 0 0 0 9.5z" fill="#F24E1E" />
+      <path d="M0 28.5A9.5 9.5 0 0 0 9.5 38H19V19H9.5A9.5 9.5 0 0 0 0 28.5z" fill="#A259FF" />
+    </svg>
+  )
+}
+
+const TYPE_LABELS = { board: 'Board', design: 'Design', proto: 'Prototype' }
+
+export default forwardRef(function FigmaEmbed({ props, onUpdate, resizable }, ref) {
+  const url = readProp(props, 'url', figmaEmbedSchema)
+  const width = readProp(props, 'width', figmaEmbedSchema)
+  const height = readProp(props, 'height', figmaEmbedSchema)
+
+  const [interactive, setInteractive] = useState(false)
+  const [expanded, setExpanded] = useState(false)
+
+  const iframeRef = useRef(null)
+  const inlineContainerRef = useRef(null)
+  const modalContainerRef = useRef(null)
+
+  // Validate URL at render time — only embed known Figma URLs
+  const isValid = useMemo(() => isFigmaUrl(url), [url])
+  const embedUrl = useMemo(() => (isValid ? toFigmaEmbedUrl(url) : ''), [url, isValid])
+  const title = useMemo(() => (url ? getFigmaTitle(url) : 'Figma'), [url])
+  const figmaType = useMemo(() => getFigmaType(url), [url])
+  const typeLabel = figmaType ? TYPE_LABELS[figmaType] : 'Figma'
+
+  const enterInteractive = useCallback(() => setInteractive(true), [])
+
+  // Close expanded modal on Escape
+  useEffect(() => {
+    if (!expanded) return
+    function handleKeyDown(e) {
+      if (e.key === 'Escape') {
+        e.stopPropagation()
+        setExpanded(false)
+      }
+    }
+    document.addEventListener('keydown', handleKeyDown, true)
+    return () => document.removeEventListener('keydown', handleKeyDown, true)
+  }, [expanded])
+
+  // Reparent iframe DOM node between inline container and modal.
+  // Uses moveBefore() (Chrome 133+) which preserves the iframe's
+  // browsing context — no reload. Falls back to appendChild.
+  useEffect(() => {
+    const iframe = iframeRef.current
+    if (!iframe) return
+
+    if (expanded && modalContainerRef.current) {
+      iframe._savedClassName = iframe.className
+      iframe._savedStyle = iframe.getAttribute('style') || ''
+      iframe.className = styles.expandIframe
+      iframe.removeAttribute('style')
+      const target = modalContainerRef.current
+      if (target.moveBefore) {
+        target.moveBefore(iframe, target.firstChild)
+      } else {
+        target.prepend(iframe)
+      }
+    } else if (!expanded && inlineContainerRef.current) {
+      if (iframe._savedClassName !== undefined) {
+        iframe.className = iframe._savedClassName
+        iframe.setAttribute('style', iframe._savedStyle)
+        delete iframe._savedClassName
+        delete iframe._savedStyle
+      }
+      const target = inlineContainerRef.current
+      if (target.moveBefore) {
+        target.moveBefore(iframe, null)
+      } else {
+        target.appendChild(iframe)
+      }
+    }
+  }, [expanded])
+
+  useImperativeHandle(ref, () => ({
+    handleAction(actionId) {
+      if (actionId === 'open-external') {
+        if (url) window.open(url, '_blank', 'noopener')
+      } else if (actionId === 'expand') {
+        setExpanded(true)
+      }
+    },
+  }), [url])
+
+  return (
+    <>
+    <WidgetWrapper>
+      <div className={styles.embed} style={{ width, height }}>
+        <div className={styles.header}>
+          <FigmaLogo />
+          <span className={styles.headerTitle}>{title}</span>
+        </div>
+        {embedUrl ? (
+          <>
+            <div
+              ref={inlineContainerRef}
+              className={styles.iframeContainer}
+              style={expanded ? { visibility: 'hidden' } : undefined}
+            >
+              <iframe
+                ref={iframeRef}
+                src={embedUrl}
+                className={styles.iframe}
+                title={`Figma ${typeLabel}: ${title}`}
+                allowFullScreen
+              />
+            </div>
+            {!interactive && !expanded && (
+              <div
+                className={styles.dragOverlay}
+                onDoubleClick={enterInteractive}
+              />
+            )}
+          </>
+        ) : (
+          <div className={styles.iframeContainer} style={{ display: 'flex', alignItems: 'center', justifyContent: 'center' }}>
+            <p style={{ color: 'var(--fgColor-muted, #656d76)', fontSize: 14, fontStyle: 'italic' }}>
+              No Figma URL
+            </p>
+          </div>
+        )}
+      </div>
+      {resizable && (
+        <div
+          className={styles.resizeHandle}
+          onMouseDown={(e) => {
+            e.stopPropagation()
+            e.preventDefault()
+            const startX = e.clientX
+            const startY = e.clientY
+            const startW = width
+            const startH = height
+            function onMove(ev) {
+              const newW = Math.max(200, startW + ev.clientX - startX)
+              const newH = Math.max(150, startH + ev.clientY - startY)
+              onUpdate?.({ width: newW, height: newH })
+            }
+            function onUp() {
+              document.removeEventListener('mousemove', onMove)
+              document.removeEventListener('mouseup', onUp)
+            }
+            document.addEventListener('mousemove', onMove)
+            document.addEventListener('mouseup', onUp)
+          }}
+          onPointerDown={(e) => e.stopPropagation()}
+        />
+      )}
+    </WidgetWrapper>
+    {createPortal(
+      <div
+        className={styles.expandBackdrop}
+        style={expanded && embedUrl ? undefined : { display: 'none' }}
+        onClick={() => setExpanded(false)}
+        onPointerDown={(e) => e.stopPropagation()}
+        onKeyDown={(e) => e.stopPropagation()}
+        onWheel={(e) => e.stopPropagation()}
+      >
+        <div
+          ref={modalContainerRef}
+          className={styles.expandContainer}
+          onClick={(e) => e.stopPropagation()}
+        >
+          {/* iframe is reparented here via useEffect */}
+          <button
+            className={styles.expandClose}
+            onClick={() => setExpanded(false)}
+            aria-label="Close expanded view"
+            autoFocus
+          >✕</button>
+        </div>
+      </div>,
+      document.body
+    )}
+    </>
+  )
+})

package/src/canvas/widgets/FigmaEmbed.module.css

@@ -0,0 +1,147 @@
+.embed {
+  position: relative;
+  overflow: hidden;
+  background: var(--bgColor-default, #ffffff);
+  border: 3px solid var(--borderColor-default, #d0d7de);
+  border-radius: 12px;
+  box-shadow: 0 4px 16px rgba(0, 0, 0, 0.08);
+}
+
+.header {
+  display: flex;
+  align-items: center;
+  gap: 6px;
+  padding: 6px 10px;
+  font-size: 12px;
+  font-weight: 500;
+  color: var(--fgColor-muted, #656d76);
+  background: var(--bgColor-muted, #f6f8fa);
+  border-bottom: 1px solid var(--borderColor-muted, #d8dee4);
+  white-space: nowrap;
+  overflow: hidden;
+  text-overflow: ellipsis;
+  user-select: none;
+}
+
+.figmaLogo {
+  width: 14px;
+  height: 14px;
+  flex-shrink: 0;
+}
+
+.headerTitle {
+  overflow: hidden;
+  text-overflow: ellipsis;
+}
+
+.iframeContainer {
+  width: 100%;
+  height: calc(100% - 10px); /* subtract header height */
+  overflow: hidden;
+}
+
+.iframe {
+  width: 100%;
+  height: calc(100% + 24px); /* clip Figma's built-in bottom toolbar */
+  border: none;
+  display: block;
+}
+
+.dragOverlay {
+  position: absolute;
+  inset: 0;
+  z-index: 1;
+  cursor: grab;
+}
+
+.resizeHandle {
+  position: absolute;
+  bottom: 0;
+  right: 0;
+  width: 16px;
+  height: 16px;
+  cursor: nwse-resize;
+  background: linear-gradient(
+    135deg,
+    transparent 40%,
+    var(--borderColor-muted, rgba(0, 0, 0, 0.15)) 40%,
+    var(--borderColor-muted, rgba(0, 0, 0, 0.15)) 50%,
+    transparent 50%,
+    transparent 65%,
+    var(--borderColor-muted, rgba(0, 0, 0, 0.15)) 65%,
+    var(--borderColor-muted, rgba(0, 0, 0, 0.15)) 75%,
+    transparent 75%
+  );
+  opacity: 0;
+  transition: opacity 150ms;
+  z-index: 2;
+}
+
+.embed:hover ~ .resizeHandle,
+.resizeHandle:hover {
+  opacity: 1;
+}
+
+/* Expand modal — fullscreen overlay for expanded iframe */
+.expandBackdrop {
+  position: fixed;
+  inset: 0;
+  z-index: 100000;
+  background: rgba(0, 0, 0, 0.8);
+  display: flex;
+  align-items: center;
+  justify-content: center;
+  animation: expandFadeIn 0.15s ease;
+}
+
+@keyframes expandFadeIn {
+  from { opacity: 0; }
+  to { opacity: 1; }
+}
+
+.expandContainer {
+  width: 90vw;
+  height: 90vh;
+  position: relative;
+  border-radius: 12px;
+  overflow: hidden;
+  background: var(--bgColor-default, #ffffff);
+  box-shadow: 0 24px 64px rgba(0, 0, 0, 0.4);
+  animation: expandScaleIn 0.2s ease;
+}
+
+@keyframes expandScaleIn {
+  from { transform: scale(0.95); opacity: 0; }
+  to { transform: scale(1); opacity: 1; }
+}
+
+.expandIframe {
+  border: none;
+  display: block;
+  width: 100%;
+  height: 100%;
+}
+
+.expandClose {
+  all: unset;
+  cursor: pointer;
+  position: absolute;
+  top: 12px;
+  right: 12px;
+  width: 32px;
+  height: 32px;
+  display: flex;
+  align-items: center;
+  justify-content: center;
+  border-radius: 8px;
+  background: rgba(0, 0, 0, 0.5);
+  color: #ffffff;
+  font-size: 16px;
+  z-index: 1;
+  transition: background 100ms;
+  backdrop-filter: blur(4px);
+}
+
+.expandClose:hover {
+  background: rgba(0, 0, 0, 0.7);
+}