@dfosco/storyboard-core 4.2.0-alpha.7 → 4.2.0-alpha.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dfosco/storyboard-core",
-  "version": "4.2.0-alpha.7",
+  "version": "4.2.0-alpha.9",
   "type": "module",
   "license": "MIT",
   "bin": {

package/src/canvas/terminal-server.js

@@ -161,6 +161,12 @@ export function setupTerminalServer(httpServer, base = '/', branch = 'unknown')
     if (addr && addr.port) actualServerPort = addr.port
   } catch {}
 
+  // Ensure node-pty spawn-helper has execute permission (npm install can strip it)
+  try {
+    const nodePtyDir = resolve(process.cwd(), 'node_modules/node-pty/prebuilds')
+    execSync(`chmod +x "${nodePtyDir}"/darwin-*/spawn-helper 2>/dev/null || true`, { stdio: 'ignore' })
+  } catch {}
+
   // Initialize registry and terminal config
   const root = process.cwd()
   const termCfg = readTerminalConfig()
@@ -206,6 +212,21 @@ function handleConnection(ws, widgetId, canvasId, prettyName) {
   // Register in registry, check for conflicts
   const { entry, conflict } = registerSession({ branch, canvasId, widgetId, prettyName })
 
+  // Resolve server URL deterministically:
+  // 1. Use the actual port from httpServer (set at setup time)
+  // 2. Fall back to server registry (tracks running dev servers)
+  // 3. Last resort: default port 1234
+  let serverPort = actualServerPort
+  if (!serverPort) {
+    try {
+      const name = detectWorktreeName()
+      const servers = findByWorktree(name)
+      if (servers.length > 0) serverPort = servers[0].port
+    } catch {}
+  }
+  if (!serverPort) serverPort = 1234
+  const serverUrl = `http://localhost:${serverPort}`
+
   // Write terminal config for agent context
   writeTermConfig({ branch, canvasId, widgetId, serverUrl })
 
@@ -236,21 +257,6 @@ function handleConnection(ws, widgetId, canvasId, prettyName) {
     writeFileSync(join(zdotdir, '.zshrc'), `export PS1='${prompt.replace(/'/g, "'\\''")}'\nunset RPS1\n`)
   } catch { /* best effort */ }
 
-  // Resolve server URL deterministically:
-  // 1. Use the actual port from httpServer (set at setup time)
-  // 2. Fall back to server registry (tracks running dev servers)
-  // 3. Last resort: default port 1234
-  let serverPort = actualServerPort
-  if (!serverPort) {
-    try {
-      const name = detectWorktreeName()
-      const servers = findByWorktree(name)
-      if (servers.length > 0) serverPort = servers[0].port
-    } catch {}
-  }
-  if (!serverPort) serverPort = 1234
-  const serverUrl = `http://localhost:${serverPort}`
-
   const env = {
     ...process.env,
     TERM: 'xterm-256color',
@@ -270,6 +276,7 @@ function handleConnection(ws, widgetId, canvasId, prettyName) {
   let ptyProcess
   let isNewSession = false
 
+  try {
   if (hasTmux) {
     const reattach = tmuxSessionExists(tmuxName)
 
@@ -353,6 +360,15 @@ function handleConnection(ws, widgetId, canvasId, prettyName) {
       env,
     })
   }
+  } catch (spawnErr) {
+    console.error(`[storyboard] terminal spawn failed: ${spawnErr.message}`)
+    if (ws.readyState === ws.OPEN) {
+      ws.send(`\r\n\x1b[31m✖ Terminal failed to start: ${spawnErr.message}\x1b[0m\r\n`)
+      ws.send(`\x1b[2mTry: chmod +x node_modules/node-pty/prebuilds/darwin-*/spawn-helper\x1b[0m\r\n`)
+      ws.close()
+    }
+    return
+  }
 
   const generation = entry.generation
   ptyProcesses.set(tmuxName, ptyProcess)