@dforge-core/dforge-mcp 0.1.7 → 0.1.8

package/CHANGELOG.md

@@ -4,6 +4,28 @@ All notable changes to `@dforge-core/dforge-mcp`. This project uses semver-ish
 `0.1.0-rc.N` pre-release tags; the published version is set at publish time via
 the release workflow, so committed `package.json` versions are placeholders.
 
+## 0.1.8
+
+### Added
+- **`dforge_module_validate` now flags a grid-style data view over an entity
+  with no visible column.** Errors when a column-rendering view (grid, list,
+  kanban, calendar, gallery, tree-grid, master-detail, or the default) draws an
+  own-module entity that has no *visible scalar column* — a field whose `flags`
+  include `V` and whose `columnType` isn't a set (`S`). Without one the view
+  renders the runtime empty state *"No visible columns configured for this
+  entity."* This mirrors the server's install-time `DataViewVisibleColumnValidator`,
+  so authors catch it pre-flight instead of at pack/install. Column-agnostic view
+  types (`diagram`, `matrix`, `library`) are exempt; cross-module entities are
+  skipped; the check runs after trait expansion so a trait-contributed `V` field
+  counts.
+
+### Skill
+- `dforge-mcp-author`: documented the **visible-column requirement** for
+  column-rendering data views. `references/data-views.md` gains a "the entity
+  needs a visible column" rule (visibility is entity-driven via the `V` flag, not
+  the view's `columns` array) plus common-mistake bullets, and
+  `references/validation-checklist.md` gains matching checklist/red-flag entries.
+
 ## 0.1.7
 
 ### Changed

package/dist/server.js

@@ -33902,6 +33902,15 @@ var SYSTEM_ENTITY_PK = {
   menu_item: "menu_item_id",
   resource: "resource_id"
 };
+var COLUMN_AGNOSTIC_VIEW_TYPES = /* @__PURE__ */ new Set(["diagram", "matrix", "library"]);
+function hasVisibleScalarColumn(fields) {
+  for (const f of Object.values(fields)) {
+    if (!f || typeof f !== "object") continue;
+    const flags = typeof f.flags === "string" ? f.flags : "";
+    if (flags.includes("V") && f.columnType !== "S") return true;
+  }
+  return false;
+}
 function resolveTranslationFile(translationsDir, locale) {
   const exact = path10.join(translationsDir, `${locale}.json`);
   if (fs8.existsSync(exact)) return exact;
@@ -33933,6 +33942,7 @@ function moduleValidate(args) {
   const entityMap = manifest.entities ?? {};
   const entities = {};
   const columnsOf = {};
+  const fieldDefsOf = {};
   for (const [name, relPath] of Object.entries(entityMap)) {
     if (name.includes(".")) continue;
     const abs = path10.join(paths.root, relPath.replace(/^\.\//, ""));
@@ -33950,12 +33960,15 @@ function moduleValidate(args) {
     entities[name] = e;
     const fields = e.fields ?? {};
     const cols = new Set(Object.keys(fields));
+    let traitFields = {};
     const traits2 = e.traits ?? [];
     try {
-      for (const c of Object.keys(expandTraits(traits2, name))) cols.add(c);
+      traitFields = expandTraits(traits2, name);
+      for (const c of Object.keys(traitFields)) cols.add(c);
     } catch {
     }
     columnsOf[name] = cols;
+    fieldDefsOf[name] = { ...traitFields, ...fields };
   }
   const deps = new Set(Object.keys(manifest.dependencies ?? {}));
   const isKnownEntity = (code2) => {
@@ -34024,6 +34037,27 @@ function moduleValidate(args) {
       }
     }
   }
+  const vcSeen = /* @__PURE__ */ new Set();
+  for (const [vcode, v] of Object.entries(views)) {
+    const sources = v.dataSources ?? [];
+    if (sources.length === 0) continue;
+    const viewType = v.viewType ?? "grid";
+    if (COLUMN_AGNOSTIC_VIEW_TYPES.has(viewType)) continue;
+    for (const s of sources) {
+      const ent = s.entityCode;
+      if (!ent) continue;
+      const defs = fieldDefsOf[ent];
+      if (!defs) continue;
+      if (hasVisibleScalarColumn(defs)) continue;
+      const key = `${vcode}\0${ent}`;
+      if (vcSeen.has(key)) continue;
+      vcSeen.add(key);
+      err(
+        `data_views \u2192 ${vcode}`,
+        `view (${viewType}) renders entity '${ent}', which has no visible column \u2014 mark at least one of its fields visible with the 'V' flag (set columns / columnType 'S' don't count for a grid)`
+      );
+    }
+  }
   const menus = readJsonOrDefault(paths.menus, {});
   const walk = (node, where) => {
     if (!node || typeof node !== "object") return;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@dforge-core/dforge-mcp",
-	"version": "0.1.7",
+	"version": "0.1.8",
 	"description": "MCP server for dForge module authoring. Exposes scaffold/pack/install tools and schema resources so AI agents (Claude Code, Cursor, Zed) can create and ship dForge modules.",
 	"license": "MIT",
 	"homepage": "https://github.com/iash44/dForge-core",

package/skills/dforge-mcp-author/references/data-views.md

@@ -58,6 +58,28 @@ Lives in: `ui/data_views.json`
 }
 ```
 
+## Critical rule — the entity needs a visible column
+
+A grid-style view can only render an entity that has at least one **visible scalar column** — a field whose `flags` include `V` and whose `columnType` is **not** a set (`S`). Column visibility is entity-driven (the field's flags), **not** view-driven: the `columns` array inside `dataSources[]` is layout-only (reorder/pin/width among already-visible fields) — it can't make a non-`V` field appear.
+
+If none of an entity's fields are visible (or only its set/child-collection columns are), the view renders the runtime empty state *"No visible columns configured for this entity."* — a broken screen the user only hits when they open the menu item. `dforge_module_validate` and `dforge_module_pack` now **reject** this before install.
+
+```jsonc
+// WRONG — grid over an entity whose fields are all hidden (no "V")
+"fields": {
+    "code": { "fieldTypeCd": "text", "flags": "EM" },   // E=editable, M=… but no V
+    "lines": { "columnType": "S", "flags": "VEM" }        // visible, but a SET — doesn't count for a grid
+}
+// RIGHT — at least one visible scalar field
+"fields": {
+    "code": { "fieldTypeCd": "text", "flags": "VEM" }     // V present, not a set → satisfies the grid
+}
+```
+
+This applies to every column-rendering view type (grid, list, kanban, calendar, gallery, tree-grid, master-detail, and the default). The column-agnostic types — `diagram`, `matrix`, `library` — draw from `viewConfig`/relationships instead, so they're **exempt** from this rule.
+
+See [flags.md](flags.md) for the flag string, [column-types.md](column-types.md) for `columnType` (`R`/`S`/`F`).
+
 ## View types
 
 | `viewType` | Description | `viewConfig` | When to use |
@@ -243,3 +265,4 @@ Most views only have one source. Order is view-level and applies to the primary
 - Object-array order like `[{ column_cd: "...", direction: "asc" }]` — **wrong shape for data views**. Use `string[]` with leading `-` for descending.
 - `viewType` is **optional** — omitted or unknown values fall back to `grid` at runtime. Set it explicitly for any non-grid view (`kanban`, `calendar`, `matrix`, …); a `matrix` view also **requires** a `viewConfig` with `rowAxis`/`colAxis`/`cell`.
 - Inventing view types like `"spreadsheet"` or `"table"` — **wrong**. Use `grid`.
+- A grid-style view over an entity with **no visible scalar column** (no field flagged `V`, or only set columns) — **rejected** at validate/pack. Mark at least one non-set field visible. See the [critical rule above](#critical-rule--the-entity-needs-a-visible-column). `diagram`/`matrix`/`library` are exempt.

package/skills/dforge-mcp-author/references/validation-checklist.md

@@ -72,6 +72,7 @@ For each entity:
 - [ ] Each source has `entityCode` and `columns`
 - [ ] `entityCode` points to an entity that exists
 - [ ] Column codes in `columns` all exist on the entity
+- [ ] The rendered entity has **at least one visible scalar column** (a field with `V` in `flags`, `columnType` not `S`) — a grid/list/kanban/etc. view over an entity whose fields are all hidden (or only sets) is **rejected** at validate/pack and would render "No visible columns configured for this entity." `diagram`/`matrix`/`library` are exempt
 - [ ] If set, `viewType` is from the supported list (`grid`, `list`, `kanban`, `calendar`, `gallery`, `tree-grid`, `diagram`, `master-detail`, `library`, `matrix`)
 - [ ] A `matrix` view has a `viewConfig` with `rowAxis`, `colAxis`, and `cell` (cell `entity` matches the primary `dataSources` entity; `rowKey`/`colKey` are real cell columns)
 - [ ] Sort uses the view-def-root `order` key — a `string[]` like `["-created_date", "name"]` (leading `-` = descending), NOT `sort` / `[{column_cd, direction}]` (that object shape belongs to queries & reports, not data views)
@@ -172,6 +173,7 @@ If you see any of these, stop and investigate:
 - Menus with `children: [...]` (array, not dict)
 - Roles with `entityRights` (wrong key)
 - Data views with root-level `entityCode` (should be inside `dataSources`)
+- A grid/list/kanban/etc. view over an entity with no field flagged `V` (or only set columns visible) — rejected at validate/pack
 - Formula columns without `baseDatatypeCd`
 - DSL actions with JavaScript/Python syntax
 - Seed data files without numbered prefixes