@dfinity/eslint-config-oisy-wallet 0.2.3 → 0.3.0

package/configs/eslint.rules.mjs

@@ -67,7 +67,22 @@ export const eslintRules = [
 
       "local-rules/prefer-object-params": "warn",
 
-      "import/no-duplicates": ["error", { "prefer-inline": true }],
+      // We want to enforce ONLY `'newlines-between': 'never'`. The order/sorting is handled elsewhere.
+      "import/order": [
+        "error",
+        {
+          // disable all default grouping behaviour
+          groups: [],
+
+          // disable alphabetising
+          alphabetize: {
+            order: "ignore",
+            caseInsensitive: false,
+          },
+
+          "newlines-between": "never",
+        },
+      ],
       "import/no-relative-parent-imports": "error",
 
       "object-shorthand": "error",
@@ -75,6 +90,7 @@ export const eslintRules = [
       "no-console": ["error", { allow: ["error", "warn"] }],
       "no-continue": "warn",
       "no-delete-var": "error",
+      "no-duplicate-imports": "error",
       "no-else-return": ["warn", { allowElseIf: false }],
       "no-restricted-imports": [
         "error",

package/eslint-local-rules.cjs

@@ -1,6 +1,6 @@
 module.exports = {
   "no-svelte-store-in-api": require("./rules/no-svelte-store-in-api.cjs"),
-  "use-option-type-wrapper": require("./rules/use-option-type-wrapper.cjs"),
+  "use-option-type-wrapper": require("./rules/use-nullish-type-wrapper.cjs"),
   "prefer-object-params": require("./rules/prefer-object-params.cjs"),
   "no-relative-imports": require("./rules/no-relative-imports.cjs"),
   "explicit-non-void-return-type": require("./rules/explicit-non-void-return-type.cjs"),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dfinity/eslint-config-oisy-wallet",
-  "version": "0.2.3",
+  "version": "0.3.0",
   "license": "Apache-2.0",
   "description": "Shared ESLint configurations from the Oisy Wallet team",
   "repository": {
@@ -44,7 +44,8 @@
     "format:check": "prettier --check .",
     "lint": "eslint .",
     "lint:fix": "eslint --fix .",
-    "test": "vitest --run"
+    "test": "vitest --run",
+    "update:peer": "npm update $(node -e \"const p=require('./package.json');console.log(Object.keys(p.peerDependencies).filter(d=>/eslint|prettier/.test(d)).join(' '))\")"
   },
   "keywords": [
     "eslint",
@@ -64,30 +65,30 @@
   ],
   "peerDependencies": {
     "@dfinity/utils": "*",
-    "@eslint/compat": "^1.3.2",
-    "@eslint/eslintrc": "^3.3.1",
-    "@eslint/js": "^9.34.0",
-    "@typescript-eslint/eslint-plugin": "^8.42.0",
-    "@vitest/eslint-plugin": "^1.3.8",
-    "eslint": "^9.34.0",
-    "eslint-config-love": "^122.0.0",
+    "@eslint/compat": "^2.0.2",
+    "@eslint/eslintrc": "^3.3.3",
+    "@eslint/js": "^9.39.2",
+    "@typescript-eslint/eslint-plugin": "^8.56.0",
+    "@vitest/eslint-plugin": "^1.6.9",
+    "eslint": "^9.39.2",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-local-rules": "^3.0.2",
-    "eslint-plugin-n": "^17.21.3",
+    "eslint-plugin-n": "^17.24.0",
     "eslint-plugin-prefer-arrow": "^1.2.3",
-    "eslint-plugin-prettier": "^5.5.4",
+    "eslint-plugin-prettier": "^5.5.5",
     "eslint-plugin-promise": "^7.2.1",
-    "eslint-plugin-svelte": "^3",
-    "globals": "^16.3.0",
-    "prettier": "^3.6.2",
-    "prettier-plugin-organize-imports": "^4.1.0",
-    "typescript": "^5"
+    "eslint-plugin-svelte": "^3.15.0",
+    "globals": "^17.3.0",
+    "prettier": "^3.8.1",
+    "prettier-plugin-organize-imports": "^4.3.0",
+    "typescript": "^5",
+    "typescript-eslint": "^8.56.0"
   },
   "devDependencies": {
-    "@types/node": "^24.10.1",
-    "@typescript-eslint/rule-tester": "^8.47.0",
-    "vitest": "^4.0.10"
+    "@types/node": "^25.3.0",
+    "@typescript-eslint/rule-tester": "^8.56.0",
+    "vitest": "^4.0.18"
   },
   "engines": {
     "node": ">=22",

package/rules/{use-option-type-wrapper.cjs → use-nullish-type-wrapper.cjs}

@@ -2,19 +2,19 @@ module.exports = {
   meta: {
     type: "suggestion",
     docs: {
-      description: "Enforce use of Option<T> instead of T | null | undefined",
+      description: "Enforce use of Nullish<T> instead of T | null | undefined",
       category: "Best Practices",
       recommended: false,
     },
     messages: {
-      useOption:
-        "Use Option<{{ type }}> instead of {{ type }} | null | undefined.",
+      useNullish:
+        "Use Nullish<{{ type }}> instead of {{ type }} | null | undefined.",
     },
     fixable: "code",
     schema: [],
   },
   create: (context) => {
-    const checkForOptionType = (node) => {
+    const checkForNullishType = (node) => {
       if (
         node.typeAnnotation.type === "TSUnionType" &&
         node.typeAnnotation.types.length === 3 &&
@@ -34,12 +34,12 @@ module.exports = {
           try {
             context.report({
               node,
-              messageId: "useOption",
+              messageId: "useNullish",
               data: {
                 type: typeText,
               },
               fix: (fixer) =>
-                fixer.replaceText(node.typeAnnotation, `Option<${typeText}>`),
+                fixer.replaceText(node.typeAnnotation, `Nullish<${typeText}>`),
             });
           } catch (e) {
             console.error(e);
@@ -52,10 +52,10 @@ module.exports = {
 
     return {
       TSTypeAnnotation: (node) => {
-        checkForOptionType(node);
+        checkForNullishType(node);
       },
       TSTypeAliasDeclaration: (node) => {
-        checkForOptionType(node);
+        checkForNullishType(node);
       },
     };
   },