@dfinity/eslint-config-oisy-wallet 0.1.8 → 0.1.10

package/README.md

@@ -106,6 +106,34 @@ module.exports = {
 };
 ```
 
+Or in `eslint.config.ts`, adding an object with the `rules` property:
+
+```typescript
+import { default as svelteConfig } from "@dfinity/eslint-config-oisy-wallet/svelte";
+import { default as vitestConfig } from "@dfinity/eslint-config-oisy-wallet/vitest";
+
+export default [
+  ...vitestConfig,
+  ...svelteConfig,
+  {
+    rules: {
+      // Disable a built-in rule
+      "no-console": "off",
+      "vitest/expect-expect": "off",
+
+      // Disable a local custom rule
+      "local/use-nullish-checks": "off",
+
+      // Customize severity or options
+      "@typescript-eslint/no-unused-vars": [
+        "warn",
+        { argsIgnorePattern: "^_" },
+      ],
+    },
+  },
+];
+```
+
 Note: To override local rules, make sure you have the `eslint-local-rules.cjs` file at the root as described above.
 
 ## 🛠️ TypeScript Support

package/configs/eslint.rules.mjs

@@ -30,9 +30,9 @@ export const eslintRules = [
 
     rules: {
       "@typescript-eslint/consistent-type-imports": "error",
+      "@typescript-eslint/no-import-type-side-effects": "error",
       "@typescript-eslint/no-inferrable-types": "error",
       "@typescript-eslint/no-unnecessary-type-assertion": "error",
-
       "@typescript-eslint/no-unused-vars": [
         "warn",
         {
@@ -41,15 +41,12 @@ export const eslintRules = [
           caughtErrorsIgnorePattern: "^_",
         },
       ],
-
       "@typescript-eslint/prefer-nullish-coalescing": "error",
       "@typescript-eslint/prefer-reduce-type-parameter": "error",
+
       "arrow-body-style": ["warn", "as-needed"],
       curly: "error",
-
-      // TODO: Disabled for now to allow the migration of ESLint v9 in OISY, as the rule is not yet enforced.
-      // It should also be introduced as an optional rule.
-      // "func-style": "error",
+      "func-style": "error",
 
       "local-rules/prefer-object-params": "warn",
 
@@ -58,30 +55,28 @@ export const eslintRules = [
       // "local-rules/use-nullish-checks": "warn",
 
       "local-rules/use-option-type-wrapper": "warn",
+
       "import/no-duplicates": ["error", { "prefer-inline": true }],
       "import/no-relative-parent-imports": "error",
+
       "object-shorthand": "error",
+      "prefer-destructuring": "error",
       "no-console": ["error", { allow: ["error", "warn"] }],
       "no-continue": "warn",
       "no-delete-var": "error",
       "no-else-return": ["warn", { allowElseIf: false }],
       "no-unused-vars": "off",
       "no-useless-rename": "error",
+      "prefer-arrow-callback": "error",
 
-      // TODO: Disabled for now to allow the migration of ESLint v9 in OISY, as the rule is not yet enforced.
-      // It should also be introduced as an optional rule.
-      // "prefer-arrow-callback": "error",
-
-      // TODO: Disabled for now to allow the migration of ESLint v9 in OISY, as the rule is not yet enforced.
-      // It should also be introduced as an optional rule.
-      // "prefer-arrow/prefer-arrow-functions": [
-      // "error",
-      // {
-      //  disallowPrototype: true,
-      //  singleReturnOnly: false,
-      //  classPropertiesAllowed: false,
-      // },
-      // ],
+      "prefer-arrow/prefer-arrow-functions": [
+        "error",
+        {
+          disallowPrototype: true,
+          singleReturnOnly: false,
+          classPropertiesAllowed: false,
+        },
+      ],
 
       "prefer-template": "error",
       "require-await": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dfinity/eslint-config-oisy-wallet",
-  "version": "0.1.8",
+  "version": "0.1.10",
   "license": "Apache-2.0",
   "description": "Shared ESLint configurations from the Oisy Wallet team",
   "repository": {
@@ -43,6 +43,7 @@
     "format": "prettier . --write",
     "format:check": "prettier --check .",
     "lint": "eslint .",
+    "lint:fix": "eslint --fix .",
     "test": "vitest --run"
   },
   "keywords": [

package/rules/explicit-non-void-return-type.cjs

@@ -38,7 +38,7 @@ const inferReturnType = (node) => {
 };
 
 const checkReturnType = ({ node, context }) => {
-  const returnType = node.returnType;
+  const { returnType } = node;
 
   if (!returnType) {
     const inferredType = inferReturnType(node);

package/rules/prefer-object-params.cjs

@@ -13,7 +13,7 @@ module.exports = {
   },
   create: (context) => {
     const checkForMoreThanOneParameter = (node) => {
-      const parent = node.parent;
+      const { parent } = node;
 
       // Check if it is a callback for looping methods
       if (
@@ -43,6 +43,7 @@ module.exports = {
           "reduce",
           "reduceRight",
           "slice",
+          "some",
           "splice",
           "toLocaleString",
           "toSpliced",

package/vitest.mjs

@@ -11,8 +11,12 @@ export default [
 
       "vitest/no-alias-methods": ["error"],
       "vitest/no-duplicate-hooks": ["error"],
+      "vitest/no-test-return-statement": ["error"],
       "vitest/padding-around-all": ["error"],
       "vitest/prefer-comparison-matcher": ["error"],
+      "vitest/prefer-each": ["error"],
+      "vitest/prefer-equality-matcher": ["error"],
+      "vitest/prefer-expect-resolves": ["error"],
       "vitest/prefer-hooks-in-order": ["error"],
       "vitest/prefer-hooks-on-top": ["error"],
       "vitest/prefer-to-be-falsy": ["error"],
@@ -20,6 +24,7 @@ export default [
       "vitest/prefer-to-be-truthy": ["error"],
       "vitest/prefer-to-contain": ["error"],
       "vitest/prefer-to-have-length": ["error"],
+      "vitest/require-top-level-describe": ["error"],
     },
   },
   languageOptions(),