@dfinity/eslint-config-oisy-wallet 0.0.3 → 0.0.5

package/eslint-local-rules.cjs

@@ -1,187 +1,7 @@
 module.exports = {
-  "no-svelte-store-in-api": {
-    meta: {
-      docs: {
-        description:
-          "Svelte stores should not be used in APIs since they are also utilized by workers.",
-        category: "Possible Errors",
-        recommended: false,
-      },
-      schema: [],
-    },
-    create(context) {
-      return {
-        ImportDeclaration(node) {
-          const filePath = context.getFilename();
-
-          const {
-            source: { value },
-          } = node;
-
-          if (filePath.includes("/api/") && value === "svelte/store") {
-            context.report({
-              node,
-              message:
-                "Importing 'svelte/store' is not allowed in API modules.",
-            });
-          }
-        },
-      };
-    },
-  },
-  "use-option-type-wrapper": {
-    meta: {
-      type: "suggestion",
-      docs: {
-        description: "Enforce use of Option<T> instead of T | null | undefined",
-        category: "Best Practices",
-        recommended: true,
-      },
-      fixable: "code",
-      schema: [],
-    },
-    create: function (context) {
-      const checkForOptionType = (node) => {
-        if (
-          node.typeAnnotation.type === "TSUnionType" &&
-          node.typeAnnotation.types.length === 3 &&
-          node.typeAnnotation.types.some((t) => t.type === "TSNullKeyword") &&
-          node.typeAnnotation.types.some((t) => t.type === "TSUndefinedKeyword")
-        ) {
-          const type = node.typeAnnotation.types.find(
-            (t) =>
-              t.type !== "TSNullKeyword" && t.type !== "TSUndefinedKeyword",
-          );
-
-          const typeText =
-            type.type === "TSTypeReference" &&
-            type.typeName &&
-            type.typeName.name
-              ? type.typeName.name
-              : context.getSourceCode().getText(type);
-
-          if (type) {
-            try {
-              context.report({
-                node,
-                message: `Use Option<${typeText}> instead of ${typeText} | null | undefined.`,
-                fix(fixer) {
-                  return fixer.replaceText(
-                    node.typeAnnotation,
-                    `Option<${typeText}>`,
-                  );
-                },
-              });
-            } catch (e) {
-              // eslint-disable-next-line no-console
-              console.error(e);
-              // eslint-disable-next-line no-console
-              console.log(type);
-            }
-          }
-        }
-      };
-
-      return {
-        TSTypeAnnotation(node) {
-          checkForOptionType(node);
-        },
-        TSTypeAliasDeclaration(node) {
-          checkForOptionType(node);
-        },
-      };
-    },
-  },
-  "prefer-object-params": {
-    meta: {
-      type: "suggestion",
-      docs: {
-        description:
-          "Enforce passing parameters as an object when a function has more than one parameter",
-        category: "Best Practices",
-        recommended: true,
-      },
-      schema: [],
-    },
-    create(context) {
-      const checkForMoreThanOneParameter = (node) => {
-        const parent = node.parent;
-
-        const nonNullish = (element) =>
-          element !== undefined && element !== null;
-
-        // Check if it is a callback for looping methods
-        if (
-          nonNullish(parent) &&
-          parent.type === "CallExpression" &&
-          parent.callee.type === "MemberExpression" &&
-          ["map", "reduce", "forEach", "filter", "sort", "replace"].includes(
-            parent.callee.property.name,
-          )
-        ) {
-          return;
-        }
-
-        // Check if it is a callback for Array.from
-        if (
-          nonNullish(parent) &&
-          parent.type === "CallExpression" &&
-          parent.callee.type === "MemberExpression" &&
-          parent.callee.object.name === "Array" &&
-          parent.callee.property.name === "from"
-        ) {
-          return;
-        }
-
-        // Check if it is a callback in a Promise constructor
-        if (
-          nonNullish(parent) &&
-          parent.type === "NewExpression" &&
-          parent.callee.name === "Promise"
-        ) {
-          return;
-        }
-
-        // Check if it is a callback in JSON.stringify
-        if (
-          nonNullish(parent) &&
-          parent.type === "CallExpression" &&
-          parent.callee.type === "MemberExpression" &&
-          parent.callee.object.name === "JSON" &&
-          parent.callee.property.name === "stringify"
-        ) {
-          return;
-        }
-
-        // Check if it is inside a class constructor
-        if (
-          nonNullish(parent) &&
-          parent.type === "MethodDefinition" &&
-          parent.kind === "constructor"
-        ) {
-          return;
-        }
-
-        if (node.params.length > 1) {
-          context.report({
-            node,
-            message:
-              "Functions with more than one parameter should accept an object and use destructuring.",
-          });
-        }
-      };
-
-      return {
-        FunctionDeclaration(node) {
-          checkForMoreThanOneParameter(node);
-        },
-        FunctionExpression(node) {
-          checkForMoreThanOneParameter(node);
-        },
-        ArrowFunctionExpression(node) {
-          checkForMoreThanOneParameter(node);
-        },
-      };
-    },
-  },
+  "no-svelte-store-in-api": require("./rules/no-svelte-store-in-api"),
+  "use-option-type-wrapper": require("./rules/use-option-type-wrapper"),
+  "prefer-object-params": require("./rules/prefer-object-params"),
+  "no-relative-imports": require("./rules/no-relative-imports"),
+  "explicit-non-void-return-type": require("./rules/explicit-non-void-return-type"),
 };

package/index.cjs

@@ -32,6 +32,14 @@ module.exports = {
     es2017: true,
     node: true,
   },
+  overrides: [
+    {
+      files: ["*.ts"],
+      rules: {
+        "prefer-const": "error",
+      },
+    },
+  ],
   rules: {
     "@typescript-eslint/consistent-type-definitions": "error",
     "@typescript-eslint/no-inferrable-types": "error",
@@ -51,12 +59,14 @@ module.exports = {
     "local-rules/prefer-object-params": "warn",
     "local-rules/use-option-type-wrapper": "warn",
     "import/no-duplicates": ["error", { "prefer-inline": true }],
+    "import/no-relative-parent-imports": "error",
     "no-console": ["error", { allow: ["error", "warn"] }],
     "no-continue": "warn",
     "no-delete-var": "error",
     "no-else-return": ["warn", { allowElseIf: false }],
     "no-unused-vars": "off",
     "prefer-template": "error",
+    "require-await": "error",
   },
   globals: {
     NodeJS: true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dfinity/eslint-config-oisy-wallet",
-  "version": "0.0.3",
+  "version": "0.0.5",
   "license": "Apache-2.0",
   "description": "Shared ESLint configurations from the Oisy Wallet team",
   "repository": {
@@ -34,7 +34,8 @@
   "scripts": {
     "format": "prettier . --write",
     "format:check": "prettier --check .",
-    "lint": "eslint -c index.cjs . --ext .cjs"
+    "lint": "eslint -c index.cjs . --ext .cjs",
+    "test": "vitest --run"
   },
   "keywords": [
     "eslint",
@@ -55,8 +56,8 @@
   "peerDependencies": {
     "@typescript-eslint/eslint-plugin": "^6.20.0",
     "eslint": "^8.57.0",
+    "eslint-config-love": "^84.1.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-config-standard-with-typescript": "^43.0.1",
     "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-local-rules": "^3.0.2",
     "eslint-plugin-n": "^16.6.2",
@@ -66,5 +67,10 @@
     "prettier": "^3.3.3",
     "prettier-plugin-organize-imports": "^4.0.0",
     "typescript": "^5.3.3"
+  },
+  "devDependencies": {
+    "@types/node": "^22.7.3",
+    "@typescript-eslint/rule-tester": "^8.7.0",
+    "vitest": "^2.1.1"
   }
 }