@dfinity/eslint-config-oisy-wallet 0.0.2 → 0.0.4

package/eslint-local-rules.cjs

@@ -37,6 +37,10 @@ module.exports = {
         category: "Best Practices",
         recommended: true,
       },
+      messages: {
+        useOption:
+          "Use Option<{{ type }}> instead of {{ type }} | null | undefined.",
+      },
       fixable: "code",
       schema: [],
     },
@@ -64,7 +68,10 @@ module.exports = {
             try {
               context.report({
                 node,
-                message: `Use Option<${typeText}> instead of ${typeText} | null | undefined.`,
+                messageId: "useOption",
+                data: {
+                  type: typeText,
+                },
                 fix(fixer) {
                   return fixer.replaceText(
                     node.typeAnnotation,
@@ -115,9 +122,35 @@ module.exports = {
           nonNullish(parent) &&
           parent.type === "CallExpression" &&
           parent.callee.type === "MemberExpression" &&
-          ["map", "reduce", "forEach", "filter", "sort", "replace"].includes(
-            parent.callee.property.name,
-          )
+          [
+            "map",
+            "reduce",
+            "forEach",
+            "filter",
+            "sort",
+            "replace",
+            "concat",
+            "copyWithin",
+            "every",
+            "fill",
+            "find",
+            "findIndex",
+            "findLast",
+            "findLastIndex",
+            "flatMap",
+            "includes",
+            "indexOf",
+            "lastIndexOf",
+            "push",
+            "reduce",
+            "reduceRight",
+            "slice",
+            "splice",
+            "toLocaleString",
+            "toSpliced",
+            "unshift",
+            "with",
+          ].includes(parent.callee.property.name)
         ) {
           return;
         }
@@ -184,4 +217,33 @@ module.exports = {
       };
     },
   },
+  "no-relative-imports": {
+    meta: {
+      type: "suggestion",
+      docs: {
+        description: "Disallow all relative imports",
+        category: "Best Practices",
+        recommended: false,
+      },
+      messages: {
+        noRelativeImports:
+          "Relative imports are not allowed. Use an alias or absolute imports.",
+      },
+      schema: [],
+    },
+    create(context) {
+      return {
+        ImportDeclaration(node) {
+          const path = node.source.value;
+
+          if (path.startsWith("./")) {
+            context.report({
+              node,
+              messageId: "noRelativeImports",
+            });
+          }
+        },
+      };
+    },
+  },
 };

package/index.cjs

@@ -1,3 +1,18 @@
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const { join } = require("node:path");
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const { existsSync } = require("node:fs");
+
+const resolveProject = () => {
+  const eslintJson = join(process.cwd(), "tsconfig.eslint.json");
+
+  if (existsSync(eslintJson)) {
+    return eslintJson;
+  }
+
+  return join(process.cwd(), "tsconfig.json");
+};
+
 module.exports = {
   root: true,
   extends: [
@@ -10,13 +25,21 @@ module.exports = {
   parserOptions: {
     sourceType: "module",
     ecmaVersion: 2020,
-    project: ["./tsconfig.eslint.json"],
+    project: [resolveProject()],
   },
   env: {
     browser: true,
     es2017: true,
     node: true,
   },
+  overrides: [
+    {
+      files: ['*.ts'],
+      rules: {
+        'prefer-const': 'error'
+      }
+    }
+  ],
   rules: {
     "@typescript-eslint/consistent-type-definitions": "error",
     "@typescript-eslint/no-inferrable-types": "error",
@@ -36,6 +59,7 @@ module.exports = {
     "local-rules/prefer-object-params": "warn",
     "local-rules/use-option-type-wrapper": "warn",
     "import/no-duplicates": ["error", { "prefer-inline": true }],
+    "import/no-relative-parent-imports": "error",
     "no-console": ["error", { allow: ["error", "warn"] }],
     "no-continue": "warn",
     "no-delete-var": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dfinity/eslint-config-oisy-wallet",
-  "version": "0.0.2",
+  "version": "0.0.4",
   "license": "Apache-2.0",
   "description": "Shared ESLint configurations from the Oisy Wallet team",
   "repository": {
@@ -15,8 +15,7 @@
     "LICENSE",
     "index.cjs",
     "svelte.cjs",
-    "eslint-local-rules.cjs",
-    "tsconfig.eslint.json"
+    "eslint-local-rules.cjs"
   ],
   "exports": {
     ".": {
@@ -35,7 +34,8 @@
   "scripts": {
     "format": "prettier . --write",
     "format:check": "prettier --check .",
-    "lint": "eslint -c index.cjs . --ext .cjs"
+    "lint": "eslint -c index.cjs . --ext .cjs",
+    "test": "vitest --run"
   },
   "keywords": [
     "eslint",
@@ -67,5 +67,10 @@
     "prettier": "^3.3.3",
     "prettier-plugin-organize-imports": "^4.0.0",
     "typescript": "^5.3.3"
+  },
+  "devDependencies": {
+    "@types/node": "^22.7.3",
+    "@typescript-eslint/rule-tester": "^8.7.0",
+    "vitest": "^2.1.1"
   }
 }

package/tsconfig.eslint.json

@@ -1,39 +0,0 @@
-{
-  "compilerOptions": {
-    "strict": true,
-    "target": "ES2020",
-    "module": "ESNext",
-    "moduleResolution": "node",
-    "resolveJsonModule": true,
-    "esModuleInterop": true,
-    "skipLibCheck": true
-  },
-  "include": [
-    "./*.cjs",
-    "ambient.d.ts",
-    "non-ambient.d.ts",
-    "./types/**/$types.d.ts",
-    "./vite.config.js",
-    "./vite.config.ts",
-    "./src/**/*.js",
-    "./src/**/*.ts",
-    "./src/**/*.svelte",
-    "./env.utils.ts",
-    "./vitest.setup.ts",
-    "./vitest.config.ts",
-    "./tailwind.config.js",
-    "./svelte.config.js",
-    "./postcss.config.js",
-    "./playwright.config.ts",
-    "./e2e/**/*.js",
-    "./e2e/**/*.ts",
-    "./scripts/*.mjs",
-    "./scripts/*.ts"
-  ],
-  "exclude": [
-    "./node_modules/**",
-    "./src/frontend/service-worker.js",
-    "./src/frontend/service-worker.ts",
-    "./src/frontend/service-worker.d.ts"
-  ]
-}