@devvit/public-api 0.10.23-next-2024-06-13-72bd939c1.0 → 0.10.23-next-2024-06-13-cad38246a.0

package/devvit/internals/blocks/BlocksReconciler.js

@@ -212,14 +212,23 @@ export class BlocksReconciler {
         const blockElement = element;
         // Intrinsic elements
         if (typeof blockElement.type === 'string') {
-            const childrens = await Promise.all(blockElement.children.flatMap(async (child, i) => {
+            const childrens = [];
+            /**
+             * Resist the urge to clean this up with flatMap. We need to await each processBlock _in order_.
+             *
+             * Number of times this has caused a major headache: 3
+             *
+             * Please increment the counter above if you had to revert this.
+             */
+            for (let i = 0; i < blockElement.children.length; i++) {
+                const child = blockElement.children[i];
                 if (child === undefined || child === null)
-                    return [];
-                return await this.processBlock(child, idGenerator, [
+                    continue;
+                childrens.push(await this.processBlock(child, idGenerator, [
                     ...path,
                     `${blockElement.type}.${i}`,
-                ]);
-            }));
+                ]));
+            }
             const children = childrens.flat();
             const collapsedChildren = __classPrivateFieldGet(this, _BlocksReconciler_instances, "m", _BlocksReconciler_flatten).call(this, children);
             await this.processProps(blockElement);
@@ -263,6 +272,12 @@ export class BlocksReconciler {
             // Ensure that the number of hooks are same from the previous render.
             if (!this.isInitialRender) {
                 const previousState = this.getPreviousComponentState();
+                /**
+                 * Note: This relies on the magic of {0: "a", 1: "b"} => ["a", "b"] and back under many circumstances.
+                 * It is too magic, but as this component is complicated and deprecated, it is not worth fixing.
+                 *
+                 * In fact previousState is an array.  This is confusing.
+                 */
                 const prevHookCount = Object.keys(previousState).length;
                 if (prevHookCount !== this.currentHookIndex) {
                     throw new Error('Invalid hook call. Hooks can only be called at the top-level of a function component. Make sure that you are not calling hooks inside loops, conditions, or nested functions.');
@@ -412,6 +427,10 @@ export class BlocksReconciler {
         // {"0": "one", "2": "three"} (length: 2; fails consistency check, see line 251)
         // After:
         // ["one", undefined, "three"] (length: 3)
+        /**
+         * Note: This relies on the magic of {0: "a", 1: "b"} => ["a", "b"] and back under many circumstances.
+         * It is too magic, but as this component is complicated and deprecated, it is not worth fixing.
+         */
         for (const key of Object.keys(this.renderState)) {
             this.renderState[key] = Object.values(this.renderState[key]);
         }

package/meta.json

@@ -11894,7 +11894,7 @@
       "format": "esm"
     },
     "src/devvit/internals/blocks/BlocksReconciler.ts": {
-      "bytes": 18194,
+      "bytes": 19088,
       "imports": [
         {
           "path": "../protos/dist/index.js",
@@ -14383,7 +14383,7 @@
           "bytesInOutput": 22653
         },
         "src/devvit/internals/blocks/BlocksReconciler.ts": {
-          "bytesInOutput": 14129
+          "bytesInOutput": 14179
         },
         "src/devvit/internals/custom-post.ts": {
           "bytesInOutput": 697
@@ -14524,7 +14524,7 @@
           "bytesInOutput": 4450
         }
       },
-      "bytes": 14993506
+      "bytes": 14994832
     }
   }
 }

package/meta.min.json

@@ -3124,7 +3124,7 @@
       "format": "esm"
     },
     "src/devvit/internals/blocks/BlocksReconciler.ts": {
-      "bytes": 18194,
+      "bytes": 19088,
       "imports": [
         {
           "path": "@devvit/protos",
@@ -4642,7 +4642,7 @@
       "imports": [],
       "exports": [],
       "inputs": {},
-      "bytes": 1135284
+      "bytes": 1136297
     },
     "dist/public-api.min.js": {
       "imports": [
@@ -5277,7 +5277,7 @@
           "bytesInOutput": 350
         },
         "src/devvit/internals/blocks/BlocksReconciler.ts": {
-          "bytesInOutput": 7132
+          "bytesInOutput": 7153
         },
         "src/apis/ui/helpers/getEffectsFromUIClient.ts": {
           "bytesInOutput": 34
@@ -5427,7 +5427,7 @@
           "bytesInOutput": 2135
         }
       },
-      "bytes": 242949
+      "bytes": 242970
     }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devvit/public-api",
-  "version": "0.10.23-next-2024-06-13-72bd939c1.0",
+  "version": "0.10.23-next-2024-06-13-cad38246a.0",
   "license": "BSD-3-Clause",
   "repository": {
     "type": "git",
@@ -30,8 +30,8 @@
   },
   "types": "./index.d.ts",
   "dependencies": {
-    "@devvit/protos": "0.10.23-next-2024-06-13-72bd939c1.0",
-    "@devvit/shared-types": "0.10.23-next-2024-06-13-72bd939c1.0",
+    "@devvit/protos": "0.10.23-next-2024-06-13-cad38246a.0",
+    "@devvit/shared-types": "0.10.23-next-2024-06-13-cad38246a.0",
     "base64-js": "1.5.1",
     "clone-deep": "4.0.1",
     "core-js": "3.27.2",
@@ -41,7 +41,7 @@
     "@ampproject/filesize": "4.3.0",
     "@devvit/eslint-config": "0.10.22",
     "@devvit/repo-tools": "0.10.22",
-    "@devvit/tsconfig": "0.10.23-next-2024-06-13-72bd939c1.0",
+    "@devvit/tsconfig": "0.10.23-next-2024-06-13-cad38246a.0",
     "@microsoft/api-extractor": "7.41.0",
     "@reddit/faceplate-ui": "11.3.3",
     "@types/clone-deep": "4.0.1",
@@ -64,5 +64,5 @@
     }
   },
   "source": "./src/index.ts",
-  "gitHead": "231786e8fd7fe4c8d9b1e9846a93846127943980"
+  "gitHead": "f7de895f786949d9b7b476e7d9f1b8fd2124755a"
 }