@devvit/build-pack 0.12.0-next-2025-04-12-5721a9506.0 → 0.12.0-next-2025-04-28-276a82082.0

package/esbuild/BundleModule.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"BundleModule.d.ts","sourceRoot":"","sources":["../../src/esbuild/BundleModule.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,KAAK,EAAE,MAAM,+BAA+B,CAAC;AACtD,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,gCAAgC,CAAC;AAM7D;;;GAGG;AACH,wBAAsB,yBAAyB,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC,CAUxF;AAyCD,cAAM,aAAc,SAAQ,KAAK;gBACnB,GAAG,EAAE,MAAM;CAGxB;AAED,2DAA2D;AAC3D,MAAM,MAAM,iBAAiB,GAAG,OAAO,aAAa,CAAC"}
+{"version":3,"file":"BundleModule.d.ts","sourceRoot":"","sources":["../../src/esbuild/BundleModule.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,KAAK,EAAE,MAAM,+BAA+B,CAAC;AACtD,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,gCAAgC,CAAC;AAqB7D;;;GAGG;AACH,wBAAsB,yBAAyB,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC,CAUxF;AAyCD,cAAM,aAAc,SAAQ,KAAK;gBACnB,GAAG,EAAE,MAAM;CAGxB;AAED,2DAA2D;AAC3D,MAAM,MAAM,iBAAiB,GAAG,OAAO,aAAa,CAAC"}

package/esbuild/BundleModule.js

@@ -4,6 +4,20 @@ import { Actor } from '@devvit/shared-types/Actor.js';
 // Define require for server builds which may have externalized dependencies.
 // ESM does not define require but bundles are CJS and evaluated inline .
 globalThis.require ??= createRequire(import.meta.url);
+// because we evaluate the code to create the actor bundle webbit apps fail because they cannot
+// open their HTTP port. This overrides http.createServer().listen(), so it's a no-op
+const webbitBundlingHack = `
+  const http = require('http');
+  const createServer = http.createServer; 
+  http.createServer = () => {
+    const srv = createServer();
+    srv.listen = () => {};
+    return srv;
+  };
+`;
+const webbitBundlingHackRevert = ` 
+  http.createServer = createServer;
+`;
 /**
  * Dangerously executes untrusted code and returns the Actor class. An Error is
  * thrown if the code does not adhere to the BundleModule interface.
@@ -39,7 +53,7 @@ async function dangerouslyGetBundleDefaultExport(code) {
     // JS please forgive us
     // TODO DX-63
     // eslint-disable-next-line security/detect-eval-with-expression
-    eval(code);
+    eval(webbitBundlingHack + code + webbitBundlingHackRevert);
     return module.exports?.default;
 }
 // eslint-disable-next-line @typescript-eslint/no-unused-vars

package/esbuild/ESBuildPack.js

@@ -372,7 +372,58 @@ function esbuildConfig(disableExternDevvitProtos, targetRuntime, watchMode = fal
     return {
         // Recursively inline any imported dependencies.
         bundle: true,
-        external: ['node:*'],
+        external: [
+            'node:*',
+            // All .js files from https://github.com/nodejs/node/tree/b2405e9/lib that
+            // don't start with _. Another option is to mark everything external for
+            // server builds but then the user can't bundle _anything_.
+            'assert',
+            'async_hooks',
+            'buffer',
+            'child_process',
+            'cluster',
+            'console',
+            'constants',
+            'crypto',
+            'dgram',
+            'diagnostics_channel',
+            'dns',
+            'domain',
+            'events',
+            'fs',
+            'http',
+            'http2',
+            'https',
+            'inspector',
+            'module',
+            'net',
+            'os',
+            'path',
+            'perf_hooks',
+            'process',
+            'punycode',
+            'querystring',
+            'quic',
+            'readline',
+            'repl',
+            'sea',
+            'sqlite',
+            'stream',
+            'string_decoder',
+            'sys',
+            'test',
+            'timers',
+            'tls',
+            'trace_events',
+            'tty',
+            'url',
+            'util',
+            'v8',
+            'vm',
+            'wasi',
+            'worker_threads',
+            'zlib',
+        ],
         // Split the @devvit/protos from the LinkedBundle. This means apps assume
         // @devvit/protos is available for import at execution time.
         plugins: [
@@ -394,6 +445,7 @@ function esbuildConfig(disableExternDevvitProtos, targetRuntime, watchMode = fal
         // Do not show any console output. Warnings and errors are reported in the
         // response.
         logLevel: 'silent',
+        platform: targetRuntime === TargetRuntime.UNIVERSAL ? 'node' : 'browser',
         target: 'es2020',
         // Write to in-memory buffers.
         write: false,

package/esbuild/plugins/serverClientCodeSplit.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"serverClientCodeSplit.d.ts","sourceRoot":"","sources":["../../../src/esbuild/plugins/serverClientCodeSplit.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAKV,MAAM,EAEP,MAAM,SAAS,CAAC;AAgDjB;;;;GAIG;AACH,wBAAgB,qBAAqB,CAAC,SAAS,GAAE,OAAe,GAAG,MAAM,CAsGxE;AAED;;;;GAIG;AACH,wBAAgB,yBAAyB,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAO9D"}
+{"version":3,"file":"serverClientCodeSplit.d.ts","sourceRoot":"","sources":["../../../src/esbuild/plugins/serverClientCodeSplit.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAKV,MAAM,EAEP,MAAM,SAAS,CAAC;AAgDjB;;;;GAIG;AACH,wBAAgB,qBAAqB,CAAC,SAAS,GAAE,OAAe,GAAG,MAAM,CAmFxE;AAED;;;;GAIG;AACH,wBAAgB,yBAAyB,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAO9D"}

package/esbuild/plugins/serverClientCodeSplit.js

@@ -52,7 +52,6 @@ export function serverClientCodeSplit(watchMode = false) {
         name: 'removeServerCode',
         setup(build) {
             let publicApiDir;
-            let projectDirs;
             // We can't call build.resolve() outside of one of the plugin callbacks
             build.onStart(async () => {
                 const { path: resolvedPath } = await build.resolve('@devvit/public-api', {
@@ -61,21 +60,6 @@ export function serverClientCodeSplit(watchMode = false) {
                     pluginData: 'removeServerCodeStart',
                 });
                 publicApiDir = path.dirname(resolvedPath);
-                projectDirs = [];
-                if (!build.initialOptions.entryPoints) {
-                    throw new Error('Invalid state: no entry points defined');
-                }
-                // Gather the list of project entrypoint directories so we can ensure we're only stubbing project code
-                let entrypoints;
-                if (Array.isArray(build.initialOptions.entryPoints)) {
-                    entrypoints = build.initialOptions.entryPoints.map((entry) => typeof entry === 'string' ? entry : entry.in);
-                }
-                else {
-                    entrypoints = Object.keys(build.initialOptions.entryPoints);
-                }
-                entrypoints.forEach((entrypoint) => {
-                    projectDirs.push(path.dirname(path.resolve(entrypoint)));
-                });
             });
             // Remove code the developer has marked as server-only by naming convention:
             build.onResolve({ filter: /(\/server\/)|(\.server\.(js|ts)x?$)/ }, async (args) => {
@@ -83,8 +67,8 @@ export function serverClientCodeSplit(watchMode = false) {
                 if (args.pluginData) {
                     return {};
                 }
-                const absPath = path.resolve(path.dirname(args.importer), args.path);
-                if (!projectDirs.some((projectDir) => absPath.startsWith(projectDir))) {
+                // Only the local project code should be stubbed
+                if (args.path.includes('node_modules')) {
                     return {};
                 }
                 if (!watchMode) {
@@ -102,7 +86,7 @@ export function serverClientCodeSplit(watchMode = false) {
                     pluginData: true,
                 });
                 // clean up the paths so we don't stamp local paths in the final output
-                resolved.path = path.relative(args.resolveDir, resolved.path);
+                resolved.path = path.relative(process.cwd(), resolved.path);
                 resolved.namespace = SERVER_ONLY_NAMESPACE;
                 return resolved;
             });

package/lib/BuildPack.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"BuildPack.d.ts","sourceRoot":"","sources":["../../src/lib/BuildPack.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,KAAK,MAAM,MAAM,gBAAgB,CAAC;AAC9C,OAAO,KAAK,EAAE,SAAS,IAAI,gBAAgB,EAAE,MAAM,2DAA2D,CAAC;AAC/G,OAAO,KAAK,EACV,UAAU,EACV,aAAa,EACb,eAAe,EAChB,MAAM,kEAAkE,CAAC;AAE1E,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,MAAM,CAAC;AAEvC;;;GAGG;AACH,MAAM,MAAM,cAAc,GAAG,MAAM,CAAC;AAEpC,8BAAsB,SAAU,YAAW,gBAAgB;IACzD,oDAAoD;IACpD,MAAM,CAAC,sBAAsB,EAAE,MAAM,CAAa;IAElD,QAAQ,CAAC,OAAO,CACd,OAAO,EAAE,aAAa,EACtB,SAAS,EAAE,MAAM,CAAC,QAAQ,GAAG,SAAS,GACrC,OAAO,CAAC,eAAe,CAAC;IAE3B,QAAQ,CAAC,KAAK,CACZ,OAAO,EAAE,aAAa,EACtB,SAAS,EAAE,MAAM,CAAC,QAAQ,GAAG,SAAS,GACrC,UAAU,CAAC,eAAe,CAAC;IAE9B,QAAQ,CAAC,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;CAClC;AAED,wBAAgB,UAAU,CAAC,IAAI,EAAE,SAAS,QAAQ,CAAC,UAAU,CAAC,EAAE,GAAG,MAAM,CAExE;AAED,wBAAgB,SAAS,CAAC,GAAG,EAAE,QAAQ,CAAC,UAAU,CAAC,GAAG,MAAM,CAO3D;AAED,iEAAiE;AACjE,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,cAAc,GAAG,MAAM,CAqBhE"}
+{"version":3,"file":"BuildPack.d.ts","sourceRoot":"","sources":["../../src/lib/BuildPack.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,KAAK,MAAM,MAAM,gBAAgB,CAAC;AAC9C,OAAO,KAAK,EAAE,SAAS,IAAI,gBAAgB,EAAE,MAAM,2DAA2D,CAAC;AAC/G,OAAO,KAAK,EACV,UAAU,EACV,aAAa,EACb,eAAe,EAChB,MAAM,kEAAkE,CAAC;AAE1E,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,MAAM,CAAC;AAEvC;;;GAGG;AACH,MAAM,MAAM,cAAc,GAAG,MAAM,CAAC;AAEpC,8BAAsB,SAAU,YAAW,gBAAgB;IACzD,oDAAoD;IACpD,MAAM,CAAC,sBAAsB,EAAE,MAAM,CAAa;IAElD,QAAQ,CAAC,OAAO,CACd,OAAO,EAAE,aAAa,EACtB,SAAS,EAAE,MAAM,CAAC,QAAQ,GAAG,SAAS,GACrC,OAAO,CAAC,eAAe,CAAC;IAE3B,QAAQ,CAAC,KAAK,CACZ,OAAO,EAAE,aAAa,EACtB,SAAS,EAAE,MAAM,CAAC,QAAQ,GAAG,SAAS,GACrC,UAAU,CAAC,eAAe,CAAC;IAE9B,QAAQ,CAAC,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;CAClC;AAED,wBAAgB,UAAU,CAAC,IAAI,EAAE,SAAS,QAAQ,CAAC,UAAU,CAAC,EAAE,GAAG,MAAM,CAExE;AAED,wBAAgB,SAAS,CAAC,GAAG,EAAE,QAAQ,CAAC,UAAU,CAAC,GAAG,MAAM,CAO3D;AAED,iEAAiE;AACjE,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,cAAc,GAAG,MAAM,CAsChE"}

package/lib/BuildPack.js

@@ -19,22 +19,34 @@ export function formatLog(log) {
 }
 /** Returns path to source input. Eg, src/main.tsx or main.ts. */
 export function getModuleEntrypoint(root) {
-    // favor src/ if it exists. single file projects may point directly to the
-    // source directory.
-    const src = path.join(root, ACTOR_SRC_DIR);
-    // With the advent of webviews and LLMs, it's nice to have all devvit
-    // code in a single folder. This helps tsconfig.json support, LLM inference
-    // and general code hygiene!
-    const srcDevvit = path.join(src, 'devvit');
-    const dir = fs.existsSync(srcDevvit) ? srcDevvit : fs.existsSync(src) ? src : root;
-    // Support TSX files and give them priority is they exist.
-    // This is used to power UI (aka BlockKit)
-    // TS needs to have the `.tsx` extension separately because JSX has some
-    // minor syntax ambiguities with angle brackets for jsx vs type assertions
-    const ts = path.join(dir, BuildPack.DevvitModuleEntryPoint);
-    const tsx = `${ts}x`;
-    if (fs.existsSync(tsx)) {
-        return tsx;
+    const srcDir = path.join(root, ACTOR_SRC_DIR);
+    const srcDevvitDir = path.join(srcDir, 'devvit');
+    const entrypointBase = BuildPack.DevvitModuleEntryPoint; // e.g., 'main.ts'
+    const entrypointBaseNoExt = entrypointBase.replace(/\.(ts|js)$/, ''); // e.g., 'main'
+    const tsxEntrypoint = `${entrypointBaseNoExt}.tsx`;
+    const tsEntrypoint = `${entrypointBaseNoExt}.ts`;
+    const potentialPaths = [];
+    // Priority 1: src/devvit directory if it exists
+    if (fs.existsSync(srcDevvitDir)) {
+        potentialPaths.push(path.join(srcDevvitDir, tsxEntrypoint));
+        potentialPaths.push(path.join(srcDevvitDir, tsEntrypoint));
     }
-    return ts;
+    // Priority 2: src directory if it exists
+    if (fs.existsSync(srcDir)) {
+        potentialPaths.push(path.join(srcDir, tsxEntrypoint));
+        potentialPaths.push(path.join(srcDir, tsEntrypoint));
+    }
+    // Priority 3: root directory
+    potentialPaths.push(path.join(root, tsxEntrypoint));
+    potentialPaths.push(path.join(root, tsEntrypoint)); // Default fallback
+    // Find the first existing path in the priority order
+    for (const p of potentialPaths) {
+        if (fs.existsSync(p)) {
+            return p;
+        }
+    }
+    // Fallback to the root main.ts path if nothing else exists.
+    // This line should technically be unreachable if root always exists,
+    // but provides a safety net.
+    return path.join(root, tsEntrypoint);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devvit/build-pack",
-  "version": "0.12.0-next-2025-04-12-5721a9506.0",
+  "version": "0.12.0-next-2025-04-28-276a82082.0",
   "license": "BSD-3-Clause",
   "repository": {
     "type": "git",
@@ -23,8 +23,8 @@
   },
   "types": "./index.d.ts",
   "dependencies": {
-    "@devvit/protos": "0.12.0-next-2025-04-12-5721a9506.0",
-    "@devvit/shared-types": "0.12.0-next-2025-04-12-5721a9506.0",
+    "@devvit/protos": "0.12.0-next-2025-04-28-276a82082.0",
+    "@devvit/shared-types": "0.12.0-next-2025-04-28-276a82082.0",
     "esbuild": "0.23.0",
     "rxjs": "7.8.1",
     "tiny-glob": "0.2.9",
@@ -32,17 +32,17 @@
     "typescript": "5.3.2"
   },
   "devDependencies": {
-    "@devvit/public-api": "0.12.0-next-2025-04-12-5721a9506.0",
-    "@devvit/repo-tools": "0.12.0-next-2025-04-12-5721a9506.0",
-    "@devvit/tsconfig": "0.12.0-next-2025-04-12-5721a9506.0",
+    "@devvit/public-api": "0.12.0-next-2025-04-28-276a82082.0",
+    "@devvit/repo-tools": "0.12.0-next-2025-04-28-276a82082.0",
+    "@devvit/tsconfig": "0.12.0-next-2025-04-28-276a82082.0",
     "@types/tsv": "0.2.1",
     "eslint": "9.11.1",
     "typescript": "5.3.2",
-    "vitest": "1.6.0"
+    "vitest": "1.6.1"
   },
   "publishConfig": {
     "directory": "dist"
   },
   "source": "./src/index.ts",
-  "gitHead": "fa2e1667b35f959df42b8c0ef56f3e5e47565d39"
+  "gitHead": "67447f61a9459bee03909b59c8889a915e2be256"
 }