@devtron-labs/devtron-fe-common-lib 0.0.58-beta-7 → 0.0.58-beta-8

package/dist/Pages/GlobalConfigurations/BuildInfra/types.d.ts

@@ -246,7 +246,6 @@ export interface CreateBuildInfraServiceConfigurationType {
     id?: number;
 }
 export interface CreateBuildInfraServicePayloadType {
-    id: number;
     name: string;
     description: string;
     type: BuildInfraProfileVariants;

package/dist/index.js

@@ -29125,7 +29125,6 @@ var getBuildInfraProfilePayload = function (profileInput) {
     }, []);
     var payload = {
         name: profileInput.name,
-        id: profileInput.id,
         description: profileInput.description,
         type: profileInput.type,
         configurations: configurations,
@@ -29614,17 +29613,16 @@ var BuildInfraFormAction = function (_a) {
         };
         handleProfileInputChange({ action: actionType, data: data });
     };
-    // would also sort the units in order of conversionFactor
-    var _b = React.useMemo(function () {
+    var unitOptions = React.useMemo(function () {
         var _a, _b;
         var units = (_b = (_a = Object.values(profileUnitsMap)) === null || _a === void 0 ? void 0 : _a.map(function (unit) { return ({
             label: unit.name,
             value: String(unit.conversionFactor),
         }); })) !== null && _b !== void 0 ? _b : [];
-        var _currentUnit = units.find(function (unit) { return unit.label === currentUnitName; });
-        return { unitOptions: units.sort(function (a, b) { return Number(a.value) - Number(b.value); }), currentUnit: _currentUnit };
-    }, [profileUnitsMap]), unitOptions = _b.unitOptions, currentUnit = _b.currentUnit;
-    return (jsxRuntime.jsxs("div", __assign({ className: "flexbox-col dc__gap-4 dc__mxw-420 w-100 dc__align-start" }, { children: [jsxRuntime.jsx("label", __assign({ htmlFor: "".concat(actionType, "-input"), className: "fs-13 fw-4 lh-20 cn-7 ".concat(isRequired ? 'dc__required-field' : '') }, { children: label })), jsxRuntime.jsxs("div", __assign({ className: "w-100 flexbox dc__align-items-center" }, { children: [jsxRuntime.jsx("div", __assign({ className: "flex-grow-1" }, { children: jsxRuntime.jsx("input", { "data-testid": actionType, name: actionType, type: "number", step: BUILD_INFRA_INPUT_CONSTRAINTS.STEP, min: BUILD_INFRA_INPUT_CONSTRAINTS.MIN, className: "form__input dc__no-right-border dc__no-right-radius", placeholder: placeholder, value: currentValue, onChange: handleInputChange, required: isRequired, autoComplete: "off", id: "".concat(actionType, "-input") }) })), profileUnitsMap && (jsxRuntime.jsx(ReactSelect, { name: "".concat(actionType, "-unit"), className: "bcn-0 dc__mxw-120", options: unitOptions, value: currentUnit, onChange: handleUnitChange, isSearchable: false, components: {
+        return units.sort(function (a, b) { return Number(a.value) - Number(b.value); });
+    }, [profileUnitsMap]);
+    var currentUnit = React.useMemo(function () { return unitOptions.find(function (unit) { return unit.label === currentUnitName; }); }, [unitOptions, currentUnitName]);
+    return (jsxRuntime.jsxs("div", __assign({ className: "flexbox-col dc__gap-4 dc__mxw-420 w-100 dc__align-start" }, { children: [jsxRuntime.jsx("label", __assign({ htmlFor: "".concat(actionType, "-input"), className: "fs-13 fw-4 lh-20 cn-7 ".concat(isRequired ? 'dc__required-field' : '') }, { children: label })), jsxRuntime.jsxs("div", __assign({ className: "w-100 flexbox dc__align-items-center" }, { children: [jsxRuntime.jsx("div", __assign({ className: "flex-grow-1" }, { children: jsxRuntime.jsx("input", { "data-testid": "".concat(actionType, "-input-field"), name: actionType, type: "number", step: BUILD_INFRA_INPUT_CONSTRAINTS.STEP, min: BUILD_INFRA_INPUT_CONSTRAINTS.MIN, className: "form__input dc__no-right-border dc__no-right-radius", placeholder: placeholder, value: currentValue, onChange: handleInputChange, required: isRequired, autoComplete: "off", id: "".concat(actionType, "-input") }) })), profileUnitsMap && (jsxRuntime.jsx(ReactSelect, { name: "".concat(actionType, "-unit"), className: "bcn-0 dc__mxw-120", options: unitOptions, value: currentUnit, onChange: handleUnitChange, isSearchable: false, components: {
                             IndicatorSeparator: null,
                             ClearIndicator: null,
                         }, styles: unitSelectorStyles() }))] })), error && (jsxRuntime.jsxs("div", __assign({ className: "form__error" }, { children: [jsxRuntime.jsx(SvgIcWarning, { className: "form__icon form__icon--error" }), error] })))] })));

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "0.0.58-beta-7",
+    "version": "0.0.58-beta-8",
     "description": "Supporting common component library",
     "main": "dist/index.js",
     "scripts": {

package/src/Pages/GlobalConfigurations/BuildInfra/BuildInfraFormAction.tsx

@@ -36,18 +36,20 @@ const BuildInfraFormAction: FunctionComponent<BuildInfraFormActionProps> = ({
         handleProfileInputChange({ action: actionType, data })
     }
 
-    // would also sort the units in order of conversionFactor
-    const { unitOptions, currentUnit } = useMemo(() => {
+    const unitOptions = useMemo(() => {
         const units =
             Object.values(profileUnitsMap)?.map((unit) => ({
                 label: unit.name,
                 value: String(unit.conversionFactor),
             })) ?? []
-
-        const _currentUnit = units.find((unit) => unit.label === currentUnitName)
-        return { unitOptions: units.sort((a, b) => Number(a.value) - Number(b.value)), currentUnit: _currentUnit }
+        return units.sort((a, b) => Number(a.value) - Number(b.value))
     }, [profileUnitsMap])
 
+    const currentUnit = useMemo(
+        () => unitOptions.find((unit) => unit.label === currentUnitName),
+        [unitOptions, currentUnitName],
+    )
+
     return (
         <div className="flexbox-col dc__gap-4 dc__mxw-420 w-100 dc__align-start">
             <label
@@ -59,7 +61,7 @@ const BuildInfraFormAction: FunctionComponent<BuildInfraFormActionProps> = ({
             <div className="w-100 flexbox dc__align-items-center">
                 <div className="flex-grow-1">
                     <input
-                        data-testid={actionType}
+                        data-testid={`${actionType}-input-field`}
                         name={actionType}
                         type="number"
                         step={BUILD_INFRA_INPUT_CONSTRAINTS.STEP}

package/src/Pages/GlobalConfigurations/BuildInfra/services.tsx

@@ -143,7 +143,6 @@ const getBuildInfraProfilePayload = (
 
     const payload: CreateBuildInfraServicePayloadType = {
         name: profileInput.name,
-        id: profileInput.id,
         description: profileInput.description,
         type: profileInput.type,
         configurations,

package/src/Pages/GlobalConfigurations/BuildInfra/types.tsx

@@ -292,7 +292,6 @@ export interface CreateBuildInfraServiceConfigurationType {
 }
 
 export interface CreateBuildInfraServicePayloadType {
-    id: number
     name: string
     description: string
     type: BuildInfraProfileVariants