@devrev/ts-adaas 1.4.1 → 1.4.2

package/dist/workers/worker-adapter.js

@@ -688,9 +688,12 @@ class WorkerAdapter {
      }) {
         var _a, _b;
         if (batchSize <= 0) {
-            const error = new Error(`Invalid attachments batch size: ${batchSize}. Batch size must be greater than 0.`);
-            console.error(error.message);
-            return { error };
+            console.warn(`The specified batch size (${batchSize}) is invalid. Using 1 instead.`);
+            batchSize = 1;
+        }
+        if (batchSize > 50) {
+            console.warn(`The specified batch size (${batchSize}) is too large. Using 50 instead.`);
+            batchSize = 50;
         }
         const repos = [
             {

package/dist/workers/worker-adapter.test.js

@@ -142,44 +142,6 @@ describe('WorkerAdapter', () => {
             expect(result[0]).toHaveLength(1);
             expect(result[1]).toHaveLength(1);
         });
-        it('should handle invalid (0) batch size', async () => {
-            var _a;
-            // Arrange
-            const mockStream = jest.fn();
-            const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
-            // Act
-            const result = await adapter.streamAttachments({
-                stream: mockStream,
-                batchSize: 0,
-            });
-            // Assert
-            expect(consoleErrorSpy).toHaveBeenCalled();
-            expect(result).toEqual({
-                error: expect.any(Error),
-            });
-            expect((_a = result === null || result === void 0 ? void 0 : result.error) === null || _a === void 0 ? void 0 : _a.message).toContain('Invalid attachments batch size');
-            // Restore console.error
-            consoleErrorSpy.mockRestore();
-        });
-        it('should handle invalid (negative) batch size', async () => {
-            var _a;
-            // Arrange
-            const mockStream = jest.fn();
-            const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
-            // Act
-            const result = await adapter.streamAttachments({
-                stream: mockStream,
-                batchSize: -1,
-            });
-            // Assert
-            expect(consoleErrorSpy).toHaveBeenCalled();
-            expect(result).toEqual({
-                error: expect.any(Error),
-            });
-            expect((_a = result === null || result === void 0 ? void 0 : result.error) === null || _a === void 0 ? void 0 : _a.message).toContain('Invalid attachments batch size');
-            // Restore console.error
-            consoleErrorSpy.mockRestore();
-        });
     });
     describe('defaultAttachmentsIterator', () => {
         it('should process all batches of attachments', async () => {
@@ -400,23 +362,84 @@ describe('WorkerAdapter', () => {
             expect(result).toBeUndefined();
         });
         it('should handle invalid batch size', async () => {
-            var _a;
             // Arrange
             const mockStream = jest.fn();
-            const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
+            const consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation();
+            // Set up adapter state with artifact IDs
+            adapter.state.toDevRev = {
+                attachmentsMetadata: {
+                    artifactIds: ['artifact1'],
+                    lastProcessed: 0,
+                    lastProcessedAttachmentsIdsList: [],
+                },
+            };
+            // Mock getting attachments
+            adapter['uploader'].getAttachmentsFromArtifactId = jest.fn().mockResolvedValue({
+                attachments: [
+                    { url: 'http://example.com/file1.pdf', id: 'attachment1', file_name: 'file1.pdf', parent_id: 'parent1' },
+                ],
+            });
+            // Mock the required methods
+            adapter.initializeRepos = jest.fn();
+            const mockReducedAttachments = [['batch1']];
+            adapter['defaultAttachmentsReducer'] = jest.fn().mockReturnValue(mockReducedAttachments);
+            adapter['defaultAttachmentsIterator'] = jest.fn().mockResolvedValue({});
             // Act
             const result = await adapter.streamAttachments({
                 stream: mockStream,
                 batchSize: 0,
             });
             // Assert
-            expect(consoleErrorSpy).toHaveBeenCalled();
-            expect(result).toEqual({
-                error: expect.any(Error),
+            expect(consoleWarnSpy).toHaveBeenCalledWith('The specified batch size (0) is invalid. Using 1 instead.');
+            // Verify that the reducer was called with batchSize 50 (not 100)
+            expect(adapter['defaultAttachmentsReducer']).toHaveBeenCalledWith({
+                attachments: expect.any(Array),
+                adapter: adapter,
+                batchSize: 1,
             });
-            expect((_a = result === null || result === void 0 ? void 0 : result.error) === null || _a === void 0 ? void 0 : _a.message).toContain('Invalid attachments batch size');
-            // Restore console.error
-            consoleErrorSpy.mockRestore();
+            expect(result).toBeUndefined();
+            // Restore console.warn
+            consoleWarnSpy.mockRestore();
+        });
+        it('should cap batch size to 50 when batchSize is greater than 50', async () => {
+            // Arrange
+            const mockStream = jest.fn();
+            const consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation();
+            // Set up adapter state with artifact IDs
+            adapter.state.toDevRev = {
+                attachmentsMetadata: {
+                    artifactIds: ['artifact1'],
+                    lastProcessed: 0,
+                    lastProcessedAttachmentsIdsList: [],
+                },
+            };
+            // Mock getting attachments
+            adapter['uploader'].getAttachmentsFromArtifactId = jest.fn().mockResolvedValue({
+                attachments: [
+                    { url: 'http://example.com/file1.pdf', id: 'attachment1', file_name: 'file1.pdf', parent_id: 'parent1' },
+                ],
+            });
+            // Mock the required methods
+            adapter.initializeRepos = jest.fn();
+            const mockReducedAttachments = [['batch1']];
+            adapter['defaultAttachmentsReducer'] = jest.fn().mockReturnValue(mockReducedAttachments);
+            adapter['defaultAttachmentsIterator'] = jest.fn().mockResolvedValue({});
+            // Act
+            const result = await adapter.streamAttachments({
+                stream: mockStream,
+                batchSize: 100, // Set batch size greater than 50
+            });
+            // Assert
+            expect(consoleWarnSpy).toHaveBeenCalledWith('The specified batch size (100) is too large. Using 50 instead.');
+            // Verify that the reducer was called with batchSize 50 (not 100)
+            expect(adapter['defaultAttachmentsReducer']).toHaveBeenCalledWith({
+                attachments: expect.any(Array),
+                adapter: adapter,
+                batchSize: 50, // Should be capped at 50
+            });
+            expect(result).toBeUndefined();
+            // Restore console.warn
+            consoleWarnSpy.mockRestore();
         });
         it('should handle empty attachments metadata artifact IDs', async () => {
             // Arrange

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devrev/ts-adaas",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "Typescript library containing the ADaaS(AirDrop as a Service) control protocol.",
   "type": "commonjs",
   "main": "./dist/index.js",