@devory/github 0.0.1 → 0.1.0

package/src/test/pr-create.test.ts

@@ -0,0 +1,223 @@
+/**
+ * packages/github/src/test/pr-create.test.ts
+ *
+ * Tests for src/lib/pr-create.ts — gated PR creation helper.
+ * All tests use pure functions; no process spawning.
+ *
+ * Run: tsx --test packages/github/src/test/pr-create.test.ts
+ */
+
+import { test, describe } from "node:test";
+import assert from "node:assert/strict";
+
+import {
+  canCreatePr,
+  prCreateBlockedReason,
+  buildGhCreateArgs,
+  createPr,
+} from "../lib/pr-create.js";
+
+const META = {
+  id: "factory-071",
+  title: "GitHub PR creation (gated automation)",
+  project: "ai-dev-factory",
+  type: "feature" as const,
+  priority: "high" as const,
+  status: "review" as const,
+  repo: ".",
+  branch: "task/factory-071-github-pr-creation",
+};
+
+const BODY = "## Goal\n\nAdd gated PR creation to the factory.";
+
+// ---------------------------------------------------------------------------
+// canCreatePr
+// ---------------------------------------------------------------------------
+
+describe("canCreatePr", () => {
+  test("returns true when GITHUB_TOKEN is set", () => {
+    assert.equal(canCreatePr({ GITHUB_TOKEN: "ghp_test_token" }), true);
+  });
+
+  test("returns false when GITHUB_TOKEN is absent", () => {
+    assert.equal(canCreatePr({}), false);
+  });
+
+  test("returns false when GITHUB_TOKEN is empty string", () => {
+    assert.equal(canCreatePr({ GITHUB_TOKEN: "" }), false);
+  });
+
+  test("returns false when GITHUB_TOKEN is whitespace only", () => {
+    assert.equal(canCreatePr({ GITHUB_TOKEN: "   " }), false);
+  });
+
+  test("returns true for non-empty token with whitespace padding", () => {
+    // Token itself has content — only the full value is checked
+    assert.equal(canCreatePr({ GITHUB_TOKEN: " ghp_abc " }), true);
+  });
+});
+
+// ---------------------------------------------------------------------------
+// prCreateBlockedReason
+// ---------------------------------------------------------------------------
+
+describe("prCreateBlockedReason", () => {
+  const validOptions = {
+    confirm: true,
+    branch: "task/factory-071",
+    env: { GITHUB_TOKEN: "ghp_test" },
+  };
+
+  test("returns null when all guards pass", () => {
+    assert.equal(
+      prCreateBlockedReason(validOptions, { GITHUB_TOKEN: "ghp_test" }),
+      null
+    );
+  });
+
+  test("blocks when confirm is false", () => {
+    const reason = prCreateBlockedReason(
+      { ...validOptions, confirm: false },
+      { GITHUB_TOKEN: "ghp_test" }
+    );
+    assert.ok(reason !== null);
+    assert.ok(reason!.includes("--confirm"));
+  });
+
+  test("blocks when branch is empty string", () => {
+    const reason = prCreateBlockedReason(
+      { ...validOptions, branch: "" },
+      { GITHUB_TOKEN: "ghp_test" }
+    );
+    assert.ok(reason !== null);
+    assert.ok(reason!.includes("branch"));
+  });
+
+  test("blocks when branch is whitespace only", () => {
+    const reason = prCreateBlockedReason(
+      { ...validOptions, branch: "   " },
+      { GITHUB_TOKEN: "ghp_test" }
+    );
+    assert.ok(reason !== null);
+    assert.ok(reason!.includes("branch"));
+  });
+
+  test("blocks when GITHUB_TOKEN is absent", () => {
+    const reason = prCreateBlockedReason(validOptions, {});
+    assert.ok(reason !== null);
+    assert.ok(reason!.includes("GITHUB_TOKEN"));
+  });
+
+  test("confirm guard takes priority over token guard", () => {
+    const reason = prCreateBlockedReason(
+      { ...validOptions, confirm: false },
+      {} // no token
+    );
+    assert.ok(reason !== null);
+    assert.ok(reason!.includes("--confirm"));
+  });
+});
+
+// ---------------------------------------------------------------------------
+// buildGhCreateArgs
+// ---------------------------------------------------------------------------
+
+describe("buildGhCreateArgs", () => {
+  test("includes 'pr create' subcommand", () => {
+    const args = buildGhCreateArgs(META, BODY, { branch: "task/factory-071" });
+    assert.equal(args[0], "pr");
+    assert.equal(args[1], "create");
+  });
+
+  test("includes --title derived from meta", () => {
+    const args = buildGhCreateArgs(META, BODY, { branch: "task/factory-071" });
+    const i = args.indexOf("--title");
+    assert.ok(i >= 0);
+    assert.ok(args[i + 1].includes("GitHub PR creation"));
+  });
+
+  test("includes --body derived from meta + task body", () => {
+    const args = buildGhCreateArgs(META, BODY, { branch: "task/factory-071" });
+    const i = args.indexOf("--body");
+    assert.ok(i >= 0);
+    assert.ok(args[i + 1].includes("factory-071"));
+  });
+
+  test("includes --head with branch name", () => {
+    const args = buildGhCreateArgs(META, BODY, { branch: "task/factory-071" });
+    const i = args.indexOf("--head");
+    assert.ok(i >= 0 && args[i + 1] === "task/factory-071");
+  });
+
+  test("defaults --base to main", () => {
+    const args = buildGhCreateArgs(META, BODY, { branch: "task/factory-071" });
+    const i = args.indexOf("--base");
+    assert.ok(i >= 0 && args[i + 1] === "main");
+  });
+
+  test("uses custom --base when provided", () => {
+    const args = buildGhCreateArgs(META, BODY, { branch: "task/factory-071", base: "develop" });
+    const i = args.indexOf("--base");
+    assert.ok(i >= 0 && args[i + 1] === "develop");
+  });
+
+  test("title follows conventional-commit format", () => {
+    const args = buildGhCreateArgs(META, BODY, { branch: "task/factory-071" });
+    const i = args.indexOf("--title");
+    assert.ok(args[i + 1].startsWith("feat("));
+  });
+
+  test("body contains summary section", () => {
+    const args = buildGhCreateArgs(META, BODY, { branch: "task/factory-071" });
+    const i = args.indexOf("--body");
+    assert.ok(args[i + 1].includes("## Summary"));
+  });
+});
+
+// ---------------------------------------------------------------------------
+// createPr — guard paths (no process spawning)
+// ---------------------------------------------------------------------------
+
+describe("createPr — guard paths", () => {
+  test("returns skipped when confirm is false", () => {
+    const result = createPr(META, BODY, {
+      confirm: false,
+      branch: "task/factory-071",
+      env: { GITHUB_TOKEN: "ghp_test" },
+    });
+    assert.equal(result.ok, false);
+    assert.equal(result.skipped, true);
+    assert.ok(result.error?.includes("--confirm"));
+  });
+
+  test("returns skipped when GITHUB_TOKEN is absent", () => {
+    const result = createPr(META, BODY, {
+      confirm: true,
+      branch: "task/factory-071",
+      env: {},
+    });
+    assert.equal(result.ok, false);
+    assert.equal(result.skipped, true);
+    assert.ok(result.error?.includes("GITHUB_TOKEN"));
+  });
+
+  test("returns skipped when branch is empty", () => {
+    const result = createPr(META, BODY, {
+      confirm: true,
+      branch: "",
+      env: { GITHUB_TOKEN: "ghp_test" },
+    });
+    assert.equal(result.ok, false);
+    assert.equal(result.skipped, true);
+    assert.ok(result.error?.includes("branch"));
+  });
+
+  test("skipped result has no prUrl", () => {
+    const result = createPr(META, BODY, {
+      confirm: false,
+      branch: "task/factory-071",
+      env: { GITHUB_TOKEN: "ghp_test" },
+    });
+    assert.equal(result.prUrl, undefined);
+  });
+});

package/src/test/pr-helpers.test.ts

@@ -0,0 +1,187 @@
+/**
+ * packages/github/src/test/pr-helpers.test.ts
+ *
+ * Tests for src/lib/pr-helpers.ts.
+ * Run: tsx --test packages/github/src/test/pr-helpers.test.ts
+ */
+
+import { test, describe } from "node:test";
+import assert from "node:assert/strict";
+
+import {
+  commitType,
+  taskScope,
+  buildPrTitle,
+  buildPrBody,
+  buildPrMetadata,
+} from "../lib/pr-helpers.js";
+
+// ── commitType ─────────────────────────────────────────────────────────────
+
+describe("commitType", () => {
+  test("feature → feat", () => assert.equal(commitType("feature"), "feat"));
+  test("feat → feat", () => assert.equal(commitType("feat"), "feat"));
+  test("bugfix → fix", () => assert.equal(commitType("bugfix"), "fix"));
+  test("bug → fix", () => assert.equal(commitType("bug"), "fix"));
+  test("refactor → refactor", () => assert.equal(commitType("refactor"), "refactor"));
+  test("chore → chore", () => assert.equal(commitType("chore"), "chore"));
+  test("docs → docs", () => assert.equal(commitType("docs"), "docs"));
+  test("documentation → docs", () => assert.equal(commitType("documentation"), "docs"));
+  test("test → test", () => assert.equal(commitType("test"), "test"));
+  test("perf → perf", () => assert.equal(commitType("perf"), "perf"));
+  test("subtask → feat", () => assert.equal(commitType("subtask"), "feat"));
+  test("unknown → feat", () => assert.equal(commitType("unknown"), "feat"));
+  test("undefined → feat", () => assert.equal(commitType(undefined), "feat"));
+  test("case-insensitive", () => assert.equal(commitType("FEATURE"), "feat"));
+});
+
+// ── taskScope ──────────────────────────────────────────────────────────────
+
+describe("taskScope", () => {
+  test("uses repo_area first", () => {
+    assert.equal(taskScope({ repo_area: "api", lane: "infra", project: "proj" }), "api");
+  });
+
+  test("falls back to lane when no repo_area", () => {
+    assert.equal(taskScope({ lane: "infra", project: "proj" }), "infra");
+  });
+
+  test("falls back to project when no repo_area or lane", () => {
+    assert.equal(taskScope({ project: "ai-dev-factory" }), "ai-dev-factory");
+  });
+
+  test("defaults to 'core' when all empty", () => {
+    assert.equal(taskScope({}), "core");
+  });
+
+  test("trims whitespace", () => {
+    assert.equal(taskScope({ repo_area: "  api  " }), "api");
+  });
+});
+
+// ── buildPrTitle ───────────────────────────────────────────────────────────
+
+describe("buildPrTitle", () => {
+  test("builds conventional-commit title", () => {
+    const title = buildPrTitle({
+      type: "feature",
+      project: "ai-dev-factory",
+      title: "GitHub Integration MVP",
+    });
+    assert.equal(title, "feat(ai-dev-factory): GitHub Integration MVP");
+  });
+
+  test("uses repo_area as scope when present", () => {
+    const title = buildPrTitle({
+      type: "bugfix",
+      repo_area: "api",
+      title: "Fix null pointer",
+    });
+    assert.ok(title.startsWith("fix(api):"));
+  });
+
+  test("truncates to 72 chars with ellipsis", () => {
+    const longTitle = "A".repeat(100);
+    const title = buildPrTitle({ type: "feature", project: "p", title: longTitle });
+    assert.ok(title.length <= 72);
+    assert.ok(title.endsWith("…"));
+  });
+
+  test("does not truncate short titles", () => {
+    const title = buildPrTitle({ type: "chore", project: "proj", title: "short" });
+    assert.ok(title.length < 72);
+    assert.ok(!title.endsWith("…"));
+  });
+
+  test("handles missing type (defaults to feat)", () => {
+    const title = buildPrTitle({ project: "p", title: "My task" });
+    assert.ok(title.startsWith("feat("));
+  });
+
+  test("handles missing title", () => {
+    const title = buildPrTitle({ type: "feature", project: "p" });
+    assert.ok(title.includes("(untitled)"));
+  });
+});
+
+// ── buildPrBody ────────────────────────────────────────────────────────────
+
+describe("buildPrBody", () => {
+  const meta = {
+    id: "factory-066",
+    title: "GitHub Integration MVP",
+    project: "ai-dev-factory",
+    type: "feature",
+    priority: "medium",
+    agent: "fullstack-builder",
+    depends_on: ["factory-054", "factory-063"],
+    verification: ["npm run test", "npm run validate:task -- tasks/backlog/factory-066.md"],
+  };
+
+  test("includes task id in body", () => {
+    const body = buildPrBody(meta, "");
+    assert.ok(body.includes("factory-066"));
+  });
+
+  test("includes task title in body", () => {
+    const body = buildPrBody(meta, "");
+    assert.ok(body.includes("GitHub Integration MVP"));
+  });
+
+  test("includes project in body", () => {
+    const body = buildPrBody(meta, "");
+    assert.ok(body.includes("ai-dev-factory"));
+  });
+
+  test("includes depends_on when present", () => {
+    const body = buildPrBody(meta, "");
+    assert.ok(body.includes("factory-054"));
+    assert.ok(body.includes("factory-063"));
+  });
+
+  test("includes verification commands as checklist items", () => {
+    const body = buildPrBody(meta, "");
+    assert.ok(body.includes("- [ ] `npm run test`"));
+  });
+
+  test("includes task body content when provided", () => {
+    const body = buildPrBody(meta, "## Goal\nDo the thing.");
+    assert.ok(body.includes("Do the thing."));
+  });
+
+  test("omits context section when body is empty", () => {
+    const body = buildPrBody(meta, "");
+    assert.ok(!body.includes("## Context"));
+  });
+
+  test("includes safety footer", () => {
+    const body = buildPrBody(meta, "");
+    assert.ok(body.includes("human review required before merge"));
+  });
+
+  test("includes Summary section header", () => {
+    const body = buildPrBody(meta, "");
+    assert.ok(body.includes("## Summary"));
+  });
+
+  test("omits verification section when verification is empty", () => {
+    const body = buildPrBody({ ...meta, verification: [] }, "");
+    assert.ok(!body.includes("## Verification"));
+  });
+});
+
+// ── buildPrMetadata ────────────────────────────────────────────────────────
+
+describe("buildPrMetadata", () => {
+  test("returns object with title and body", () => {
+    const result = buildPrMetadata({ type: "feature", project: "p", title: "T" }, "");
+    assert.ok(typeof result.title === "string" && result.title.length > 0);
+    assert.ok(typeof result.body === "string" && result.body.length > 0);
+  });
+
+  test("title matches buildPrTitle output", () => {
+    const meta = { type: "bugfix", project: "proj", title: "Fix bug" };
+    const result = buildPrMetadata(meta, "");
+    assert.equal(result.title, buildPrTitle(meta));
+  });
+});

package/index.js

@@ -1 +0,0 @@
-module.exports = {};