@devo-bmad-custom/agent-orchestration 1.0.2 → 1.0.3

package/src/bmb/workflows/agent/steps-v/v-02c-validate-menu.md

@@ -1,127 +1,127 @@
----
-name: 'v-02c-validate-menu'
-description: 'Validate menu structure and append to report'
-
-nextStepFile: './v-02d-validate-structure.md'
-validationReport: '{bmb_creations_output_folder}/validation-report-{agent-name}.md'
-agentMenuPatterns: ../data/agent-menu-patterns.md
-agentFile: '{agent-file-path}'
----
-
-# Validate Step 2c: Validate Menu
-
-## STEP GOAL
-
-Validate the agent's command menu structure against BMAD standards as defined in agentMenuPatterns.md. Append findings to validation report and auto-advance.
-
-## MANDATORY EXECUTION RULES
-
-- 📖 CRITICAL: Read the complete step file before taking any action
-- 🔄 CRITICAL: Read validationReport and agentMenuPatterns first
-- 🔄 CRITICAL: Load the actual agent file to validate menu
-- 🚫 NO MENU - append findings and auto-advance
-- ✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the config `{communication_language}`
-
-### Step-Specific Rules:
-
-- 🎯 Validate menu against agentMenuPatterns.md rules
-- 📊 Append findings to validation report
-- 🚫 FORBIDDEN to present menu
-
-## EXECUTION PROTOCOLS
-
-- 🎯 Load agentMenuPatterns.md reference
-- 🎯 Load the actual agent file for validation
-- 📊 Validate commands and menu
-- 💾 Append findings to validation report
-- ➡️ Auto-advance to next validation step
-
-## MANDATORY SEQUENCE
-
-**CRITICAL:** Follow this sequence exactly. Do not skip, reorder, or improvise unless user explicitly requests a change.
-
-### 1. Load References
-
-Read `{agentMenuPatterns}`, `{validationReport}`, and `{agentFile}`.
-
-### 2. Validate Menu
-
-Perform these checks systematically - validate EVERY rule specified in agentMenuPatterns.md:
-
-1. **Menu Structure**
-   - [ ] Menu section exists and is properly formatted
-   - [ ] At least one menu item defined (unless intentionally tool-less)
-   - [ ] Menu items follow proper YAML structure
-   - [ ] Each item has required fields (trigger, description, action)
-
-2. **Menu Item Requirements**
-   For each menu item:
-   - [ ] trigger: Present, follows `XX or fuzzy match on command` format
-   - [ ] description: Clear and concise, starts with `[XX]` code
-   - [ ] action: Prompt reference (#id) or inline instruction
-
-3. **Trigger Format Validation**
-   - [ ] Format: `XX or fuzzy match on command-name` (XX = 2-letter code)
-   - [ ] Codes are unique within agent
-   - [ ] No reserved codes used: MH, CH, PM, DA
-
-4. **Description Format Validation**
-   - [ ] Descriptions start with `[XX]` code
-   - [ ] Code in description matches trigger code
-   - [ ] Descriptions are clear and descriptive
-
-5. **Action Handler Validation**
-   - [ ] If `action: '#prompt-id'`, corresponding prompt exists
-   - [ ] If `action: 'inline text'`, instruction is complete and clear
-
-6. **Alignment Checks**
-   - [ ] Menu items align with agent's role/purpose
-   - [ ] Menu items are appropriate for target users
-   - [ ] Menu scope is appropriate (not too sparse/overloaded)
-
-7. **Configuration Specific Menu Handler Validation**
-   - [ ] Determine hasSidecar from metadata
-   - [ ] For hasSidecar: true:
-     - [ ] Menu handlers MAY reference sidecar files using correct path format
-     - [ ] Sidecar references use: `{project-root}/_bmad/_memory/{sidecar-folder}/...`
-   - [ ] For hasSidecar: false:
-     - [ ] Menu handlers MUST NOT have sidecar file links
-     - [ ] Menu handlers use only internal references (#) or inline prompts
-
-### 3. Append Findings to Report
-
-Append to `{validationReport}`:
-
-```markdown
-### Menu Validation
-
-**Status:** {✅ PASS / ⚠️ WARNING / ❌ FAIL}
-
-**hasSidecar:** {true|false}
-
-**Checks:**
-- [ ] Triggers follow `XX or fuzzy match on command` format
-- [ ] Descriptions start with `[XX]` code
-- [ ] No reserved codes (MH, CH, PM, DA)
-- [ ] Action handlers valid (#prompt-id or inline)
-- [ ] Configuration appropriate menu links
-
-**Detailed Findings:**
-
-*PASSING:*
-{List of passing checks}
-
-*WARNINGS:*
-{List of non-blocking issues}
-
-*FAILURES:*
-{List of blocking issues that must be fixed}
-```
-
-### 4. Auto-Advance
-
-Load and execute `{nextStepFile}` immediately.
-
----
-
-**Validating YAML structure...**
+---
+name: 'v-02c-validate-menu'
+description: 'Validate menu structure and append to report'
+
+nextStepFile: './v-02d-validate-structure.md'
+validationReport: '{bmb_creations_output_folder}/validation-report-{agent-name}.md'
+agentMenuPatterns: ../data/agent-menu-patterns.md
+agentFile: '{agent-file-path}'
+---
+
+# Validate Step 2c: Validate Menu
+
+## STEP GOAL
+
+Validate the agent's command menu structure against BMAD standards as defined in agentMenuPatterns.md. Append findings to validation report and auto-advance.
+
+## MANDATORY EXECUTION RULES
+
+- 📖 CRITICAL: Read the complete step file before taking any action
+- 🔄 CRITICAL: Read validationReport and agentMenuPatterns first
+- 🔄 CRITICAL: Load the actual agent file to validate menu
+- 🚫 NO MENU - append findings and auto-advance
+- ✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the config `{communication_language}`
+
+### Step-Specific Rules:
+
+- 🎯 Validate menu against agentMenuPatterns.md rules
+- 📊 Append findings to validation report
+- 🚫 FORBIDDEN to present menu
+
+## EXECUTION PROTOCOLS
+
+- 🎯 Load agentMenuPatterns.md reference
+- 🎯 Load the actual agent file for validation
+- 📊 Validate commands and menu
+- 💾 Append findings to validation report
+- ➡️ Auto-advance to next validation step
+
+## MANDATORY SEQUENCE
+
+**CRITICAL:** Follow this sequence exactly. Do not skip, reorder, or improvise unless user explicitly requests a change.
+
+### 1. Load References
+
+Read `{agentMenuPatterns}`, `{validationReport}`, and `{agentFile}`.
+
+### 2. Validate Menu
+
+Perform these checks systematically - validate EVERY rule specified in agentMenuPatterns.md:
+
+1. **Menu Structure**
+   - [ ] Menu section exists and is properly formatted
+   - [ ] At least one menu item defined (unless intentionally tool-less)
+   - [ ] Menu items follow proper YAML structure
+   - [ ] Each item has required fields (trigger, description, action)
+
+2. **Menu Item Requirements**
+   For each menu item:
+   - [ ] trigger: Present, follows `XX or fuzzy match on command` format
+   - [ ] description: Clear and concise, starts with `[XX]` code
+   - [ ] action: Prompt reference (#id) or inline instruction
+
+3. **Trigger Format Validation**
+   - [ ] Format: `XX or fuzzy match on command-name` (XX = 2-letter code)
+   - [ ] Codes are unique within agent
+   - [ ] No reserved codes used: MH, CH, PM, DA
+
+4. **Description Format Validation**
+   - [ ] Descriptions start with `[XX]` code
+   - [ ] Code in description matches trigger code
+   - [ ] Descriptions are clear and descriptive
+
+5. **Action Handler Validation**
+   - [ ] If `action: '#prompt-id'`, corresponding prompt exists
+   - [ ] If `action: 'inline text'`, instruction is complete and clear
+
+6. **Alignment Checks**
+   - [ ] Menu items align with agent's role/purpose
+   - [ ] Menu items are appropriate for target users
+   - [ ] Menu scope is appropriate (not too sparse/overloaded)
+
+7. **Configuration Specific Menu Handler Validation**
+   - [ ] Determine hasSidecar from metadata
+   - [ ] For hasSidecar: true:
+     - [ ] Menu handlers MAY reference sidecar files using correct path format
+     - [ ] Sidecar references use: `{project-root}/_bmad/_memory/{sidecar-folder}/...`
+   - [ ] For hasSidecar: false:
+     - [ ] Menu handlers MUST NOT have sidecar file links
+     - [ ] Menu handlers use only internal references (#) or inline prompts
+
+### 3. Append Findings to Report
+
+Append to `{validationReport}`:
+
+```markdown
+### Menu Validation
+
+**Status:** {✅ PASS / ⚠️ WARNING / ❌ FAIL}
+
+**hasSidecar:** {true|false}
+
+**Checks:**
+- [ ] Triggers follow `XX or fuzzy match on command` format
+- [ ] Descriptions start with `[XX]` code
+- [ ] No reserved codes (MH, CH, PM, DA)
+- [ ] Action handlers valid (#prompt-id or inline)
+- [ ] Configuration appropriate menu links
+
+**Detailed Findings:**
+
+*PASSING:*
+{List of passing checks}
+
+*WARNINGS:*
+{List of non-blocking issues}
+
+*FAILURES:*
+{List of blocking issues that must be fixed}
+```
+
+### 4. Auto-Advance
+
+Load and execute `{nextStepFile}` immediately.
+
+---
+
+**Validating YAML structure...**

package/src/bmb/workflows/agent/steps-v/v-02d-validate-structure.md

@@ -1,134 +1,134 @@
----
-name: 'v-02d-validate-structure'
-description: 'Validate YAML structure and append to report'
-
-nextStepFile: './v-02e-validate-sidecar.md'
-validationReport: '{bmb_creations_output_folder}/validation-report-{agent-name}.md'
-agentValidation: ../data/agent-validation.md
-agentCompilation: ../data/agent-compilation.md
-agentFile: '{agent-file-path}'
----
-
-# Validate Step 2d: Validate Structure
-
-## STEP GOAL
-
-Validate the agent's YAML structure and completeness against BMAD standards as defined in agentCompilation.md. Append findings to validation report and auto-advance.
-
-## MANDATORY EXECUTION RULES
-
-- 📖 CRITICAL: Read the complete step file before taking any action
-- 🔄 CRITICAL: Read validationReport and agentCompilation first
-- 🔄 CRITICAL: Load the actual agent file to validate structure
-- 🚫 NO MENU - append findings and auto-advance
-- ✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the config `{communication_language}`
-
-### Step-Specific Rules:
-
-- 🎯 Validate structure against agentCompilation.md rules
-- 📊 Append findings to validation report
-- 🚫 FORBIDDEN to present menu
-
-## EXECUTION PROTOCOLS
-
-- 🎯 Load agentCompilation.md reference
-- 🎯 Load the actual agent file for validation
-- 📊 Validate YAML structure
-- 💾 Append findings to validation report
-- ➡️ Auto-advance to next validation step
-
-## MANDATORY SEQUENCE
-
-**CRITICAL:** Follow this sequence exactly. Do not skip, reorder, or improvise unless user explicitly requests a change.
-
-### 1. Load References
-
-Read `{agentCompilation}`, `{agentValidation}`, `{validationReport}`, and `{agentFile}`.
-
-### 2. Validate Structure
-
-Perform these checks systematically - validate EVERY rule specified in agentCompilation.md:
-
-#### A. YAML Syntax Validation
-- [ ] Parse YAML without errors
-- [ ] Check indentation consistency (2-space standard)
-- [ ] Validate proper escaping of special characters
-- [ ] Verify no duplicate keys in any section
-
-#### B. Frontmatter Validation
-- [ ] All required fields present (name, description, version, etc.)
-- [ ] Field values are correct type (string, boolean, array)
-- [ ] No empty required fields
-- [ ] Proper array formatting with dashes
-- [ ] Boolean fields are actual booleans (not strings)
-
-#### C. Section Completeness
-- [ ] All required sections present based on hasSidecar value
-- [ ] Sections not empty unless explicitly optional
-- [ ] Proper markdown heading hierarchy (##, ###)
-- [ ] No orphaned content without section headers
-
-#### D. Field-Level Validation
-- [ ] Path references exist and are valid
-- [ ] Array fields properly formatted
-- [ ] No malformed YAML structures
-- [ ] File references use correct path format
-
-#### E. Agent Configuration Specific Checks
-
-**For Agents WITHOUT Sidecar (hasSidecar is false):**
-- [ ] No sidecar requirements
-- [ ] No sidecar-folder path in metadata
-- [ ] If critical_actions present, no sidecar file references
-- [ ] Menu handlers use only internal references (#) or inline prompts
-- [ ] Total size under ~250 lines (unless justified)
-
-**For Agents WITH Sidecar (hasSidecar is true):**
-- [ ] hasSidecar flag set correctly in metadata
-- [ ] Sidecar folder path specified in metadata
-- [ ] critical_actions section present with minimum requirements:
-  - [ ] Loads sidecar memories
-  - [ ] Loads sidecar instructions
-  - [ ] Restricts file access to sidecar folder
-- [ ] All critical_actions reference correct `{project-root}/_bmad/_memory/` paths
-- [ ] Menu handlers that update sidecar use correct path format
-
-### 3. Append Findings to Report
-
-Append to `{validationReport}`:
-
-```markdown
-### Structure Validation
-
-**Status:** {✅ PASS / ⚠️ WARNING / ❌ FAIL}
-
-**Configuration:** Agent {WITH|WITHOUT} sidecar
-
-**hasSidecar:** {true|false}
-
-**Checks:**
-- [ ] Valid YAML syntax
-- [ ] Required fields present (name, description, persona, menu)
-- [ ] Field types correct (arrays, strings, booleans)
-- [ ] Consistent 2-space indentation
-- [ ] Configuration appropriate structure
-
-**Detailed Findings:**
-
-*PASSING:*
-{List of passing checks}
-
-*WARNINGS:*
-{List of non-blocking issues}
-
-*FAILURES:*
-{List of blocking issues that must be fixed}
-```
-
-### 4. Auto-Advance
-
-Load and execute `{nextStepFile}` immediately.
-
----
-
-**Validating sidecar structure...**
+---
+name: 'v-02d-validate-structure'
+description: 'Validate YAML structure and append to report'
+
+nextStepFile: './v-02e-validate-sidecar.md'
+validationReport: '{bmb_creations_output_folder}/validation-report-{agent-name}.md'
+agentValidation: ../data/agent-validation.md
+agentCompilation: ../data/agent-compilation.md
+agentFile: '{agent-file-path}'
+---
+
+# Validate Step 2d: Validate Structure
+
+## STEP GOAL
+
+Validate the agent's YAML structure and completeness against BMAD standards as defined in agentCompilation.md. Append findings to validation report and auto-advance.
+
+## MANDATORY EXECUTION RULES
+
+- 📖 CRITICAL: Read the complete step file before taking any action
+- 🔄 CRITICAL: Read validationReport and agentCompilation first
+- 🔄 CRITICAL: Load the actual agent file to validate structure
+- 🚫 NO MENU - append findings and auto-advance
+- ✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the config `{communication_language}`
+
+### Step-Specific Rules:
+
+- 🎯 Validate structure against agentCompilation.md rules
+- 📊 Append findings to validation report
+- 🚫 FORBIDDEN to present menu
+
+## EXECUTION PROTOCOLS
+
+- 🎯 Load agentCompilation.md reference
+- 🎯 Load the actual agent file for validation
+- 📊 Validate YAML structure
+- 💾 Append findings to validation report
+- ➡️ Auto-advance to next validation step
+
+## MANDATORY SEQUENCE
+
+**CRITICAL:** Follow this sequence exactly. Do not skip, reorder, or improvise unless user explicitly requests a change.
+
+### 1. Load References
+
+Read `{agentCompilation}`, `{agentValidation}`, `{validationReport}`, and `{agentFile}`.
+
+### 2. Validate Structure
+
+Perform these checks systematically - validate EVERY rule specified in agentCompilation.md:
+
+#### A. YAML Syntax Validation
+- [ ] Parse YAML without errors
+- [ ] Check indentation consistency (2-space standard)
+- [ ] Validate proper escaping of special characters
+- [ ] Verify no duplicate keys in any section
+
+#### B. Frontmatter Validation
+- [ ] All required fields present (name, description, version, etc.)
+- [ ] Field values are correct type (string, boolean, array)
+- [ ] No empty required fields
+- [ ] Proper array formatting with dashes
+- [ ] Boolean fields are actual booleans (not strings)
+
+#### C. Section Completeness
+- [ ] All required sections present based on hasSidecar value
+- [ ] Sections not empty unless explicitly optional
+- [ ] Proper markdown heading hierarchy (##, ###)
+- [ ] No orphaned content without section headers
+
+#### D. Field-Level Validation
+- [ ] Path references exist and are valid
+- [ ] Array fields properly formatted
+- [ ] No malformed YAML structures
+- [ ] File references use correct path format
+
+#### E. Agent Configuration Specific Checks
+
+**For Agents WITHOUT Sidecar (hasSidecar is false):**
+- [ ] No sidecar requirements
+- [ ] No sidecar-folder path in metadata
+- [ ] If critical_actions present, no sidecar file references
+- [ ] Menu handlers use only internal references (#) or inline prompts
+- [ ] Total size under ~250 lines (unless justified)
+
+**For Agents WITH Sidecar (hasSidecar is true):**
+- [ ] hasSidecar flag set correctly in metadata
+- [ ] Sidecar folder path specified in metadata
+- [ ] critical_actions section present with minimum requirements:
+  - [ ] Loads sidecar memories
+  - [ ] Loads sidecar instructions
+  - [ ] Restricts file access to sidecar folder
+- [ ] All critical_actions reference correct `{project-root}/_bmad/_memory/` paths
+- [ ] Menu handlers that update sidecar use correct path format
+
+### 3. Append Findings to Report
+
+Append to `{validationReport}`:
+
+```markdown
+### Structure Validation
+
+**Status:** {✅ PASS / ⚠️ WARNING / ❌ FAIL}
+
+**Configuration:** Agent {WITH|WITHOUT} sidecar
+
+**hasSidecar:** {true|false}
+
+**Checks:**
+- [ ] Valid YAML syntax
+- [ ] Required fields present (name, description, persona, menu)
+- [ ] Field types correct (arrays, strings, booleans)
+- [ ] Consistent 2-space indentation
+- [ ] Configuration appropriate structure
+
+**Detailed Findings:**
+
+*PASSING:*
+{List of passing checks}
+
+*WARNINGS:*
+{List of non-blocking issues}
+
+*FAILURES:*
+{List of blocking issues that must be fixed}
+```
+
+### 4. Auto-Advance
+
+Load and execute `{nextStepFile}` immediately.
+
+---
+
+**Validating sidecar structure...**