@devicecloud.dev/dcd 5.2.0-beta.2 → 5.2.0-beta.3

package/dist/commands/cloud.js

@@ -16,7 +16,7 @@ import { TestSubmissionService } from '../services/test-submission.service.js';
 import { VersionService } from '../services/version.service.js';
 import { EAndroidApiLevels, EAndroidDevices, EiOSDevices, EiOSVersions, isIosMatrixConfig, } from '../types/domain/device.types.js';
 import { resolveAuth } from '../utils/auth.js';
-import { matrixIsIos, parseDeviceMatrix } from '../utils/device-matrix.js';
+import { assertMatrixSupported, matrixIsIos, parseDeviceMatrix, } from '../utils/device-matrix.js';
 import { detectCiContext, isCI } from '../utils/ci.js';
 import { CliError, coerceArray, collectRepeatedFlag, getCliVersion, getUpgradeCommand, logger, parseIntFlag, validateEnum, } from '../utils/cli.js';
 import { fetchCompatibilityData, } from '../utils/compatibility.js';
@@ -560,6 +560,10 @@ export const cloudCommand = defineCommand({
             // there is no matrix, and tolerant of older APIs that lack the endpoint.
             if (deviceMatrix.length > 0) {
                 const estimate = await ApiGateway.estimateMatrix(apiUrl, auth, fields);
+                // A null estimate means the API predates the matrix (404/405). It would
+                // silently strip deviceMatrix and run one device — refuse rather than
+                // hand back a green single-device run the user reads as a matrix.
+                assertMatrixSupported(deviceMatrix, estimate);
                 if (estimate) {
                     const osPrefix = matrixIsIos(deviceMatrix) ? 'iOS' : 'API';
                     const rows = ui.fields([

package/dist/utils/device-matrix.d.ts

@@ -1,4 +1,18 @@
 import { DeviceMatrixConfig } from '../types/domain/device.types.js';
+/**
+ * Refuse to submit a device matrix to an API that cannot honour it.
+ *
+ * The estimate endpoint is only called when a matrix was actually requested, so
+ * a null estimate (the gateway maps 404/405 to null) means the API predates the
+ * feature. That API would **silently strip** the unknown `deviceMatrix` field —
+ * its ValidationPipe runs `whitelist: true, forbidNonWhitelisted: false` — and
+ * run every flow on a single default device, exiting 0. The user would believe
+ * they had tested N devices when they tested one: the exact silent
+ * under-testing the device matrix exists to prevent. Fail loudly instead.
+ *
+ * @throws CliError when a matrix was requested but the API does not support it.
+ */
+export declare function assertMatrixSupported(deviceMatrix: DeviceMatrixConfig[], estimate: unknown | null): void;
 /**
  * Parse repeated `--ios-device-matrix <device>:<version>` and
  * `--android-device-matrix <device>:<apiLevel>[:play]` flags into an explicit device

package/dist/utils/device-matrix.js

@@ -1,5 +1,27 @@
 import { isIosMatrixConfig, } from '../types/domain/device.types.js';
 import { CliError } from './cli.js';
+/**
+ * Refuse to submit a device matrix to an API that cannot honour it.
+ *
+ * The estimate endpoint is only called when a matrix was actually requested, so
+ * a null estimate (the gateway maps 404/405 to null) means the API predates the
+ * feature. That API would **silently strip** the unknown `deviceMatrix` field —
+ * its ValidationPipe runs `whitelist: true, forbidNonWhitelisted: false` — and
+ * run every flow on a single default device, exiting 0. The user would believe
+ * they had tested N devices when they tested one: the exact silent
+ * under-testing the device matrix exists to prevent. Fail loudly instead.
+ *
+ * @throws CliError when a matrix was requested but the API does not support it.
+ */
+export function assertMatrixSupported(deviceMatrix, estimate) {
+    if (deviceMatrix.length === 0 || estimate)
+        return;
+    throw new CliError('This DeviceCloud API does not support device matrices, so ' +
+        '--ios-device-matrix / --android-device-matrix cannot be honoured. ' +
+        'Submitting anyway would silently run every flow on a single default ' +
+        'device and report success. Upgrade the API, or drop the matrix flags ' +
+        'and use --ios-device / --android-device for a single-device run.');
+}
 /**
  * Parse repeated `--ios-device-matrix <device>:<version>` and
  * `--android-device-matrix <device>:<apiLevel>[:play]` flags into an explicit device

package/package.json

@@ -60,7 +60,7 @@
     "type": "git",
     "url": "https://devicecloud.dev"
   },
-  "version": "5.2.0-beta.2",
+  "version": "5.2.0-beta.3",
   "bugs": {
     "url": "https://discord.gg/gm3mJwcNw8"
   },