@devflow-tools/memory-engine 0.16.34 → 0.17.1

package/dist/memory-store.js

@@ -12,9 +12,11 @@ import { applyV8ToV9Migration } from './migrations/v8-to-v9.js';
 import { applyV9ToV10Migration } from './migrations/v9-to-v10.js';
 import { applyV10ToV11Migration } from './migrations/v10-to-v11.js';
 import { applyV11ToV12Migration } from './migrations/v11-to-v12.js';
+import { applyV12ToV13Migration } from './migrations/v12-to-v13.js';
 import { observationDedupKey, } from './observation-types.js';
 import { analysesConflict, analyzePreference, analyzePreferenceObservation, } from './preference-conflicts.js';
 import { mergeSemanticEntities, normalizeEntityKey, normalizeSemanticMemory, } from './semantic-memory.js';
+import { emitSemanticControlLog } from '@devflow-tools/telemetry';
 // ── Schema ─────────────────────────────────────────────
 const SCHEMA_V2 = `
 -- ============================================================
@@ -448,10 +450,11 @@ export class MemoryStore {
         applyV9ToV10Migration(this.db);
         applyV10ToV11Migration(this.db);
         applyV11ToV12Migration(this.db, rootPath);
+        applyV12ToV13Migration(this.db);
         this.repairOrphanSessions(rootPath);
-        console.log('[MemoryStore] Schema initialized', {
-            dbPath: this.dbPath,
-            tableCount: this.countTables(),
+        emitSemanticControlLog({
+            event: 'memory.engine.transitioned', identity: { projectRoot: this.defaultProjectRoot }, level: 'debug', timestamp: Date.now(),
+            data: { stage: 'store_initialized', database: 'memories.db', tableCount: this.countTables() },
         });
     }
     setLeaseStore(store) {
@@ -538,10 +541,16 @@ export class MemoryStore {
                    COALESCE(l1_score, 0), COALESCE(dialog_score, 0), user_message
             FROM events
           `);
-                    console.log('[MemoryStore] Migrated', count.c, 'events to session_events');
+                    emitSemanticControlLog({
+                        event: 'memory.write.completed', identity: { projectRoot: this.defaultProjectRoot }, level: 'info', timestamp: Date.now(),
+                        data: { stage: 'event_migration', migrated: count.c },
+                    });
                 }
                 catch (err) {
-                    console.warn('[MemoryStore] Event migration skipped:', err.message);
+                    emitSemanticControlLog({
+                        event: 'memory.write.degraded', identity: { projectRoot: this.defaultProjectRoot }, level: 'warn', timestamp: Date.now(),
+                        data: { stage: 'event_migration', reason: memoryStoreErrorReason(err), fallback: 'existing_schema' },
+                    });
                 }
             }
         }
@@ -625,7 +634,10 @@ export class MemoryStore {
         confidence, strength, scope, session_id, created_at, updated_at)
       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
     `).run(id, memType, title, entry.content, entry.originalText ?? null, entry.source ?? 'auto', entry.status ?? 'active', entry.confidence ?? 0.5, entry.strength ?? 0.5, entry.scope ?? '', entry.sessionId ?? null, now, now);
-        console.log('[MemoryStore] Memory added', { id, type: memType, status: entry.status ?? 'active' });
+        emitSemanticControlLog({
+            event: 'memory.write.completed', identity: { projectRoot: this.defaultProjectRoot, sessionId: entry.sessionId }, level: 'info', timestamp: now,
+            data: { stage: 'memory_add', memoryId: id, type: memType, status: entry.status ?? 'active' },
+        });
         return this.get(id);
     }
     get(id) {
@@ -647,7 +659,10 @@ export class MemoryStore {
             return;
         vals.push(id);
         this.db.prepare(`UPDATE memories SET ${sets.join(', ')} WHERE id = ?`).run(...vals);
-        console.log('[MemoryStore] Memory updated', { id, keys: Object.keys(updates) });
+        emitSemanticControlLog({
+            event: 'memory.write.completed', identity: { projectRoot: this.defaultProjectRoot }, level: 'debug', timestamp: Date.now(),
+            data: { stage: 'memory_update', memoryId: id, fields: Object.keys(updates) },
+        });
     }
     delete(id) {
         this.db.prepare('DELETE FROM memories WHERE id = ?').run(id);
@@ -945,6 +960,9 @@ export class MemoryStore {
           `).run(input.receiptId ?? null, input.reason ?? 'canonical_turn_commit', now, row.turn_event_id, row.observation_id, input.receiptId ?? null).changes;
                     continue;
                 }
+                if (row.status === 'committed' && row.receipt_id && row.receipt_id !== input.receiptId) {
+                    continue;
+                }
                 const hasOtherCommittedLineage = Boolean(this.db.prepare(`
           SELECT 1 FROM turn_observation_lineage
           WHERE observation_id = ? AND turn_event_id <> ? AND status = 'committed'
@@ -1337,13 +1355,19 @@ export class MemoryStore {
         });
         const repaired = repair();
         if (repaired > 0) {
-            console.log('[MemoryStore] Recovered orphan event sessions', { count: repaired });
+            emitSemanticControlLog({
+                event: 'memory.engine.transitioned', identity: { projectRoot: this.defaultProjectRoot }, level: 'warn', timestamp: Date.now(),
+                data: { stage: 'orphan_session_repair', recovered: repaired },
+            });
         }
         return repaired;
     }
     createSession(id, projectRoot, task = '') {
         this.ensureSession(id, projectRoot, task);
-        console.log('[MemoryStore] Session created', { id, project: projectRoot, task });
+        emitSemanticControlLog({
+            event: 'memory.engine.transitioned', identity: { projectRoot, sessionId: id }, level: 'debug', timestamp: Date.now(),
+            data: { from: 'missing', to: 'active', stage: 'session_create' },
+        });
     }
     closeSession(id) {
         this.ensureSession(id, this.defaultProjectRoot, 'Recovered session close');
@@ -1352,7 +1376,10 @@ export class MemoryStore {
       UPDATE sessions SET status = 'closed', closed_at = ?
       WHERE id = ? AND status = 'active'
     `).run(now, id);
-        console.log('[MemoryStore] Session closed', { id });
+        emitSemanticControlLog({
+            event: 'memory.engine.transitioned', identity: { projectRoot: this.defaultProjectRoot, sessionId: id }, level: 'info', timestamp: now,
+            data: { from: 'active', to: 'closed', stage: 'session_close' },
+        });
     }
     getSession(id) {
         return this.db.prepare('SELECT * FROM sessions WHERE id = ?').get(id) ?? null;
@@ -1400,8 +1427,9 @@ export class MemoryStore {
          quality_status, quarantine_reason, quality_details, quarantined_at,
          failure_category, resolution_state, evidence_status, evidence_details,
          semantic_subject, semantic_predicate, semantic_value, semantic_polarity,
-         semantic_key, facet_key, entities, temporal, reinforce_count, last_reinforced_at)
-      VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+         semantic_key, facet_key, entities, temporal, reinforce_count, last_reinforced_at,
+         capsule, projection, extraction_version)
+      VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
     `).run(id, obs.sessionId, obs.project ?? this.defaultProjectRoot, obs.type, obs.title, obs.narrative ?? '', JSON.stringify(obs.facts ?? []), JSON.stringify(obs.files ?? []), JSON.stringify(obs.tools ?? []), JSON.stringify(obs.concepts ?? []), obs.importance ?? 5, obs.confidence ?? 0.5, obs.source ?? 'distill', dedupKey, JSON.stringify(obs.sourceEventIds ?? []), now, now, obs.qualityStatus ?? 'accepted', obs.quarantineReason ?? null, obs.qualityDetails ? JSON.stringify(obs.qualityDetails) : null, obs.qualityStatus === 'quarantined' ? now : null, obs.failureCategory ?? null, obs.resolutionState ?? 'current', obs.evidenceStatus
             ?? (obs.source === 'explicit_intent'
                 ? 'unverified'
@@ -1411,7 +1439,19 @@ export class MemoryStore {
             kind: 'source_event',
             source,
             summary: 'Observation was accepted from an evidence-bound session event.',
-        }))), obs.semantic?.subject ?? '', obs.semantic?.predicate ?? '', obs.semantic?.value ?? '', obs.semantic?.polarity ?? 'neutral', obs.semantic?.semanticKey ?? null, obs.semantic?.facetKey ?? null, JSON.stringify(obs.semantic?.entities ?? []), obs.semantic?.temporal ? JSON.stringify(obs.semantic.temporal) : null, 0, null);
+        }))), obs.semantic?.subject ?? '', obs.semantic?.predicate ?? '', obs.semantic?.value ?? '', obs.semantic?.polarity ?? 'neutral', obs.semantic?.semanticKey ?? null, obs.semantic?.facetKey ?? null, JSON.stringify(obs.semantic?.entities ?? []), obs.semantic?.temporal ? JSON.stringify(obs.semantic.temporal) : null, 0, null, JSON.stringify(obs.capsule ?? {
+            narrative: obs.narrative ?? '',
+            sourceEvidenceIds: obs.sourceEventIds ?? [],
+            entities: obs.semantic?.entities ?? [],
+            temporalStatus: obs.semantic?.temporal?.status ?? 'current',
+            extractionVersion: 'legacy-compatible.v1',
+        }), JSON.stringify(obs.projection ?? {
+            subject: obs.semantic?.subject ?? '',
+            predicate: obs.semantic?.predicate ?? '',
+            value: obs.semantic?.value ?? '',
+            polarity: obs.semantic?.polarity ?? 'neutral',
+            facet: obs.semantic?.facet ?? 'generic',
+        }), obs.capsule?.extractionVersion ?? 'legacy-compatible.v1');
         // Insert concept junction rows
         if (obs.concepts && obs.concepts.length > 0) {
             const insertConcept = this.db.prepare('INSERT OR IGNORE INTO observation_concepts (observation_id, concept) VALUES (?, ?)');
@@ -1421,8 +1461,9 @@ export class MemoryStore {
         }
         this.replaceObservationEntities(id, obs.project ?? this.defaultProjectRoot, obs.semantic?.entities ?? []);
         this.bumpRetrievalRevision();
-        console.log('[MemoryStore] Observation added', {
-            id, sessionId: obs.sessionId, type: obs.type, conceptCount: obs.concepts?.length ?? 0,
+        emitSemanticControlLog({
+            event: 'memory.write.completed', identity: { projectRoot: obs.project ?? this.defaultProjectRoot, sessionId: obs.sessionId }, level: 'info', timestamp: Date.now(),
+            data: { stage: 'observation_add', observationId: id, type: obs.type, conceptCount: obs.concepts?.length ?? 0 },
         });
         return this.getObservation(id);
     }
@@ -1447,10 +1488,14 @@ export class MemoryStore {
                     ...obs.semantic.entities.map(normalizeEntityKey),
                 ]);
                 const entities = mergeSemanticEntities(parseStringArray(exact.entities), obs.semantic.entities);
-                const narrative = semanticRichness(obs.narrative ?? '') > semanticRichness(exact.narrative)
-                    ? obs.narrative ?? ''
-                    : exact.narrative;
-                const title = semanticRichness(obs.title) > semanticRichness(exact.title) ? obs.title : exact.title;
+                const narrative = obs.preferIncomingNarrative
+                    ? obs.narrative ?? exact.narrative
+                    : semanticRichness(obs.narrative ?? '') > semanticRichness(exact.narrative)
+                        ? obs.narrative ?? ''
+                        : exact.narrative;
+                const title = obs.preferIncomingNarrative
+                    ? obs.title
+                    : semanticRichness(obs.title) > semanticRichness(exact.title) ? obs.title : exact.title;
                 const contentChanged = exact.title !== title
                     || exact.narrative !== narrative;
                 this.db.prepare(`
@@ -1592,6 +1637,9 @@ export class MemoryStore {
       VALUES (?, ?, ?, ?)
     `).run(sourceObservationId, targetObservationId, type, createdAt);
     }
+    addSemanticObservationRelation(sourceObservationId, targetObservationId, type, createdAt = Date.now()) {
+        this.addObservationRelation(sourceObservationId, targetObservationId, type, createdAt);
+    }
     supersedeSemanticFacetConflicts(project, winnerId, semantic, now) {
         const conflicts = this.findCurrentObservationsByFacetKey(project, semantic.facetKey)
             .filter(candidate => candidate.id !== winnerId)
@@ -2080,7 +2128,10 @@ export class MemoryStore {
             insert.run(s.id, s.sessionId, s.type, s.strength, JSON.stringify(s.sourceEventIds), JSON.stringify(s.payload), s.timestamp);
         }
         if (signals.length > 0) {
-            console.log('[MemoryStore] Signals recorded', { count: signals.length, sessionId: signals[0].sessionId });
+            emitSemanticControlLog({
+                event: 'memory.write.completed', identity: { projectRoot: this.defaultProjectRoot, sessionId: signals[0].sessionId }, level: 'debug', timestamp: Date.now(),
+                data: { stage: 'signal_write', count: signals.length },
+            });
         }
     }
     getSessionSignals(sessionId) {
@@ -2307,7 +2358,10 @@ export class MemoryStore {
             ? this.db.prepare('DELETE FROM session_events WHERE processed = 1 AND created_at < ?').run(sevenDaysAgo)
             : this.deleteOldProcessedEventsExcept(sevenDaysAgo, pendingEventIds);
         const total = { swept: candidates.length, kept, downgraded, expired: expired + pendingExpired.changes, cleanedEvents: cleanedEvents.changes };
-        console.log('[MemoryStore] Retention sweep complete', total);
+        emitSemanticControlLog({
+            event: 'memory.engine.transitioned', identity: { projectRoot: this.defaultProjectRoot }, level: 'debug', timestamp: Date.now(),
+            data: { stage: 'retention_sweep', ...total },
+        });
         return total;
     }
     deleteOldProcessedEventsExcept(before, excludedIds) {
@@ -2469,6 +2523,9 @@ function semanticFromExplicitEnrichment(enrichment) {
 function camelToSnake(str) {
     return str.replace(/[A-Z]/g, letter => `_${letter.toLowerCase()}`);
 }
+function memoryStoreErrorReason(error) {
+    return (error instanceof Error ? error.message : String(error)).trim().slice(0, 500) || 'memory_store_failed';
+}
 function parseStringArray(value) {
     try {
         const parsed = JSON.parse(value);